120882 2013-09-06 12:36:41 -0700 MediaStream API: Storing the constraints in MediaStreamSource 2013-09-16 10:20:32 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 121101 1 eric.carlson thiago.lacerda commit-queue glenn hta jer.noble tommyw oldest_to_newest 925774 0 eric.carlson 2013-09-06 12:36:41 -0700 Consider merging https://chromium.googlesource.com/chromium/blink/+/04ac7655b54ae98f55774afde3f8e92b6c6302e6 It was requested that the constraints object, if any, should be stored in the source for later referencing. The first user of this is WebAudio but for consistency the video constraints are stored as well. 929308 1 211669 thiago.lacerda 2013-09-14 15:26:38 -0700 Created attachment 211669 Patch 929322 2 211669 eric.carlson 2013-09-14 16:15:41 -0700 Comment on attachment 211669 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211669&action=review > Source/WebCore/ChangeLog:8 > + No new tests needed. Please note the Blink revision this was merged from. > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:150 > + (*iter)->component()->source()->setConstraints(m_audio); > + > + > + MediaStreamTrackVector videoTracks = stream->getVideoTracks(); Nit: you have an extra blank line here. 929690 3 211779 thiago.lacerda 2013-09-16 07:07:02 -0700 Created attachment 211779 Patch 929691 4 thiago.lacerda 2013-09-16 07:08:17 -0700 Removed extra line and removed unnecessary vector creation inside UserMediaRequest::succeed method 929792 5 211779 commit-queue 2013-09-16 10:20:30 -0700 Comment on attachment 211779 Patch Clearing flags on attachment: 211779 Committed r155881: <http://trac.webkit.org/changeset/155881> 929793 6 commit-queue 2013-09-16 10:20:32 -0700 All reviewed patches have been landed. Closing bug. 211669 2013-09-14 15:26:38 -0700 2013-09-16 07:06:56 -0700 Patch bug-120882-20130914192637.patch text/plain 3369 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1Nzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjg0N2EyZGNiYWI4ODM0 ZjAzMGI1Zjk5MDQyYzkzOTc1OWQ5ODI4Yy4uZDdjZGU1YzM0MTIyZWQyMGY3ZDY0NGUzYjc2ZmFl MDdkY2RkZmMxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA5LTE0ICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIE1lZGlhU3RyZWFtIEFQSTogU3RvcmluZyB0aGUgY29uc3RyYWludHMgaW4gTWVkaWFT dHJlYW1Tb3VyY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyMDg4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFt L1VzZXJNZWRpYVJlcXVlc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VXNlck1lZGlhUmVxdWVz dDo6c3VjY2VlZCk6CisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1T b3VyY2UuaDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU3RyZWFtU291cmNlOjpzZXRDb25zdHJh aW50cyk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVN0cmVhbVNvdXJjZTo6Y29uc3RyYWludHMp OgorCiAyMDEzLTA5LTE0ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAg W0NUVEVdIE5vZGUgc3ViY2xhc3NlcyBzaG91bGQgdGFrZSBhIERvY3VtZW50IGJ5IHJlZmVyZW5j ZSBpbiB0aGVpciBjb25zdHJ1Y3RvciAoUGFydCAzKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9Vc2VyTWVkaWFSZXF1ZXN0LmNwcCBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vVXNlck1lZGlhUmVxdWVzdC5jcHAKaW5kZXggNDQ3MDg0 MmM3OTg1Y2QxZTZhMGM5YTkzMWEzNTE3NGY4ZmZhOGRiMS4uYTlkNGY5MjExZDFhYTMwYjhiYWEy ZjVlMDdlMmMwZjlkMjMyNDBhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9t ZWRpYXN0cmVhbS9Vc2VyTWVkaWFSZXF1ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhc3RyZWFtL1VzZXJNZWRpYVJlcXVlc3QuY3BwCkBAIC0xNDEsNiArMTQxLDE2IEBA IHZvaWQgVXNlck1lZGlhUmVxdWVzdDo6c3VjY2VlZChQYXNzUmVmUHRyPE1lZGlhU3RyZWFtRGVz Y3JpcHRvcj4gc3RyZWFtRGVzY3JpcHRvCiAgICAgICAgIHJldHVybjsKIAogICAgIFJlZlB0cjxN ZWRpYVN0cmVhbT4gc3RyZWFtID0gTWVkaWFTdHJlYW06OmNyZWF0ZShtX3NjcmlwdEV4ZWN1dGlv bkNvbnRleHQsIHN0cmVhbURlc2NyaXB0b3IpOworCisgICAgTWVkaWFTdHJlYW1UcmFja1ZlY3Rv ciBhdWRpb1RyYWNrcyA9IHN0cmVhbS0+Z2V0QXVkaW9UcmFja3MoKTsKKyAgICBmb3IgKE1lZGlh U3RyZWFtVHJhY2tWZWN0b3I6Oml0ZXJhdG9yIGl0ZXIgPSBhdWRpb1RyYWNrcy5iZWdpbigpOyBp dGVyICE9IGF1ZGlvVHJhY2tzLmVuZCgpOyArK2l0ZXIpCisgICAgICAgICgqaXRlciktPmNvbXBv bmVudCgpLT5zb3VyY2UoKS0+c2V0Q29uc3RyYWludHMobV9hdWRpbyk7CisKKworICAgIE1lZGlh U3RyZWFtVHJhY2tWZWN0b3IgdmlkZW9UcmFja3MgPSBzdHJlYW0tPmdldFZpZGVvVHJhY2tzKCk7 CisgICAgZm9yIChNZWRpYVN0cmVhbVRyYWNrVmVjdG9yOjppdGVyYXRvciBpdGVyID0gdmlkZW9U cmFja3MuYmVnaW4oKTsgaXRlciAhPSB2aWRlb1RyYWNrcy5lbmQoKTsgKytpdGVyKQorICAgICAg ICAoKml0ZXIpLT5jb21wb25lbnQoKS0+c291cmNlKCktPnNldENvbnN0cmFpbnRzKG1fdmlkZW8p OworCiAgICAgbV9zdWNjZXNzQ2FsbGJhY2stPmhhbmRsZUV2ZW50KHN0cmVhbS5nZXQoKSk7CiB9 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlh U3RyZWFtU291cmNlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRp YVN0cmVhbVNvdXJjZS5oCmluZGV4IGMwMDkyYzIwNTEwZTAwNmE0NzI1YTNhODk2ODk5NGIzZDQz ZTg2Y2EuLjBlZDI2YjFlYmYzMzQ3YjY5OWYyMGFiNDVhZDhjM2I0YzhhYjlmNmEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtU291cmNl LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1T b3VyY2UuaApAQCAtMzUsNiArMzUsNyBAQAogI2lmIEVOQUJMRShNRURJQV9TVFJFQU0pCiAKICNp bmNsdWRlICJBdWRpb0Rlc3RpbmF0aW9uQ29uc3VtZXIuaCIKKyNpbmNsdWRlICJNZWRpYUNvbnN0 cmFpbnRzLmgiCiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4KICNpbmNsdWRlIDx3dGYvVmVj dG9yLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CkBAIC04MCw2ICs4MSw5IEBA IHB1YmxpYzoKICAgICBQYXNzUmVmUHRyPEV4dHJhRGF0YT4gZXh0cmFEYXRhKCkgY29uc3QgeyBy ZXR1cm4gbV9leHRyYURhdGE7IH0KICAgICB2b2lkIHNldEV4dHJhRGF0YShQYXNzUmVmUHRyPEV4 dHJhRGF0YT4gZXh0cmFEYXRhKSB7IG1fZXh0cmFEYXRhID0gZXh0cmFEYXRhOyB9CiAKKyAgICB2 b2lkIHNldENvbnN0cmFpbnRzKFBhc3NSZWZQdHI8TWVkaWFDb25zdHJhaW50cz4gY29uc3RyYWlu dHMpIHsgbV9jb25zdHJhaW50cyA9IGNvbnN0cmFpbnRzOyB9CisgICAgTWVkaWFDb25zdHJhaW50 cyogY29uc3RyYWludHMoKSB7IHJldHVybiBtX2NvbnN0cmFpbnRzLmdldCgpOyB9CisKICAgICBj b25zdCBTdHJpbmcmIGRldmljZUlkKCkgeyByZXR1cm4gbV9kZXZpY2VJZDsgfQogICAgIHZvaWQg c2V0RGV2aWNlSWQoY29uc3QgU3RyaW5nJiBkZXZpY2VJZCkgeyBtX2RldmljZUlkID0gZGV2aWNl SWQ7IH0KIApAQCAtMTA0LDYgKzEwOCw3IEBAIHByaXZhdGU6CiAgICAgTXV0ZXggbV9hdWRpb0Nv bnN1bWVyc0xvY2s7CiAgICAgVmVjdG9yPFJlZlB0cjxBdWRpb0Rlc3RpbmF0aW9uQ29uc3VtZXI+ ID4gbV9hdWRpb0NvbnN1bWVyczsKICAgICBSZWZQdHI8RXh0cmFEYXRhPiBtX2V4dHJhRGF0YTsK KyAgICBSZWZQdHI8TWVkaWFDb25zdHJhaW50cz4gbV9jb25zdHJhaW50czsKIH07CiAKIHR5cGVk ZWYgVmVjdG9yPFJlZlB0cjxNZWRpYVN0cmVhbVNvdXJjZT4gPiBNZWRpYVN0cmVhbVNvdXJjZVZl Y3RvcjsK 211779 2013-09-16 07:07:02 -0700 2013-09-16 10:20:30 -0700 Patch bug-120882-20130916110701.patch text/plain 3415 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1ODUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjgyNzdjNGMxZTNkYmU5 ZmRhNGJhYjNkMGMyYzE0ZTIxMWE1ZDQzMy4uMzVhNWZjYmJkYjc5NWQ4ODBjMzEwMzBkODExYTEz NTY2ZTI0YjM4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA5LTE2ICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIE1lZGlhU3RyZWFtIEFQSTogU3RvcmluZyB0aGUgY29uc3RyYWludHMgaW4gTWVkaWFT dHJlYW1Tb3VyY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyMDg4MgorCisgICAgICAgIGJhc2VkIG9uOiBodHRwczovL2Nocm9taXVtLmdvb2dsZXNv dXJjZS5jb20vY2hyb21pdW0vYmxpbmsvKy8wNGFjNzY1NWI1NGFlOThmNTU3NzRhZmRlM2Y4ZTky YjZjNjMwMmU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0v VXNlck1lZGlhUmVxdWVzdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpVc2VyTWVkaWFSZXF1ZXN0 OjpzdWNjZWVkKToKKyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVNv dXJjZS5oOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFTdHJlYW1Tb3VyY2U6OnNldENvbnN0cmFp bnRzKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU3RyZWFtU291cmNlOjpjb25zdHJhaW50cyk6 CisKIDIwMTMtMDktMTYgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CiAK ICAgICAgICAgW0FUS10gRXh0ZW5kcyBhdGsgdmFsdWUgaW50ZXJmYWNlIHRvIHJldHVybiBwcm9w ZXIgY2hlY2tib3ggc3RhdGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21l ZGlhc3RyZWFtL1VzZXJNZWRpYVJlcXVlc3QuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9t ZWRpYXN0cmVhbS9Vc2VyTWVkaWFSZXF1ZXN0LmNwcAppbmRleCA0NDcwODQyYzc5ODVjZDFlNmEw YzlhOTMxYTM1MTc0ZjhmZmE4ZGIxLi43NDFhZjljOWFmYjM3ZTU1NjAzOGYwMDVkOWZlNWViYThi YmFmYjUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1Vz ZXJNZWRpYVJlcXVlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJl YW0vVXNlck1lZGlhUmVxdWVzdC5jcHAKQEAgLTE0MSw2ICsxNDEsMTUgQEAgdm9pZCBVc2VyTWVk aWFSZXF1ZXN0OjpzdWNjZWVkKFBhc3NSZWZQdHI8TWVkaWFTdHJlYW1EZXNjcmlwdG9yPiBzdHJl YW1EZXNjcmlwdG8KICAgICAgICAgcmV0dXJuOwogCiAgICAgUmVmUHRyPE1lZGlhU3RyZWFtPiBz dHJlYW0gPSBNZWRpYVN0cmVhbTo6Y3JlYXRlKG1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dCwgc3Ry ZWFtRGVzY3JpcHRvcik7CisKKyAgICBNZWRpYVN0cmVhbVRyYWNrVmVjdG9yIHRyYWNrcyA9IHN0 cmVhbS0+Z2V0QXVkaW9UcmFja3MoKTsKKyAgICBmb3IgKE1lZGlhU3RyZWFtVHJhY2tWZWN0b3I6 Oml0ZXJhdG9yIGl0ZXIgPSB0cmFja3MuYmVnaW4oKTsgaXRlciAhPSB0cmFja3MuZW5kKCk7ICsr aXRlcikKKyAgICAgICAgKCppdGVyKS0+Y29tcG9uZW50KCktPnNvdXJjZSgpLT5zZXRDb25zdHJh aW50cyhtX2F1ZGlvKTsKKworICAgIHRyYWNrcyA9IHN0cmVhbS0+Z2V0VmlkZW9UcmFja3MoKTsK KyAgICBmb3IgKE1lZGlhU3RyZWFtVHJhY2tWZWN0b3I6Oml0ZXJhdG9yIGl0ZXIgPSB0cmFja3Mu YmVnaW4oKTsgaXRlciAhPSB0cmFja3MuZW5kKCk7ICsraXRlcikKKyAgICAgICAgKCppdGVyKS0+ Y29tcG9uZW50KCktPnNvdXJjZSgpLT5zZXRDb25zdHJhaW50cyhtX3ZpZGVvKTsKKwogICAgIG1f c3VjY2Vzc0NhbGxiYWNrLT5oYW5kbGVFdmVudChzdHJlYW0uZ2V0KCkpOwogfQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVNvdXJj ZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1Tb3Vy Y2UuaAppbmRleCBjMDA5MmMyMDUxMGUwMDZhNDcyNWEzYTg5Njg5OTRiM2Q0M2U4NmNhLi4wZWQy NmIxZWJmMzM0N2I2OTlmMjBhYjQ1YWQ4YzNiNGM4YWI5ZjZhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVNvdXJjZS5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtU291cmNlLmgKQEAg LTM1LDYgKzM1LDcgQEAKICNpZiBFTkFCTEUoTUVESUFfU1RSRUFNKQogCiAjaW5jbHVkZSAiQXVk aW9EZXN0aW5hdGlvbkNvbnN1bWVyLmgiCisjaW5jbHVkZSAiTWVkaWFDb25zdHJhaW50cy5oIgog I2luY2x1ZGUgPHd0Zi9SZWZDb3VudGVkLmg+CiAjaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgogI2lu Y2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgpAQCAtODAsNiArODEsOSBAQCBwdWJsaWM6CiAg ICAgUGFzc1JlZlB0cjxFeHRyYURhdGE+IGV4dHJhRGF0YSgpIGNvbnN0IHsgcmV0dXJuIG1fZXh0 cmFEYXRhOyB9CiAgICAgdm9pZCBzZXRFeHRyYURhdGEoUGFzc1JlZlB0cjxFeHRyYURhdGE+IGV4 dHJhRGF0YSkgeyBtX2V4dHJhRGF0YSA9IGV4dHJhRGF0YTsgfQogCisgICAgdm9pZCBzZXRDb25z dHJhaW50cyhQYXNzUmVmUHRyPE1lZGlhQ29uc3RyYWludHM+IGNvbnN0cmFpbnRzKSB7IG1fY29u c3RyYWludHMgPSBjb25zdHJhaW50czsgfQorICAgIE1lZGlhQ29uc3RyYWludHMqIGNvbnN0cmFp bnRzKCkgeyByZXR1cm4gbV9jb25zdHJhaW50cy5nZXQoKTsgfQorCiAgICAgY29uc3QgU3RyaW5n JiBkZXZpY2VJZCgpIHsgcmV0dXJuIG1fZGV2aWNlSWQ7IH0KICAgICB2b2lkIHNldERldmljZUlk KGNvbnN0IFN0cmluZyYgZGV2aWNlSWQpIHsgbV9kZXZpY2VJZCA9IGRldmljZUlkOyB9CiAKQEAg LTEwNCw2ICsxMDgsNyBAQCBwcml2YXRlOgogICAgIE11dGV4IG1fYXVkaW9Db25zdW1lcnNMb2Nr OwogICAgIFZlY3RvcjxSZWZQdHI8QXVkaW9EZXN0aW5hdGlvbkNvbnN1bWVyPiA+IG1fYXVkaW9D b25zdW1lcnM7CiAgICAgUmVmUHRyPEV4dHJhRGF0YT4gbV9leHRyYURhdGE7CisgICAgUmVmUHRy PE1lZGlhQ29uc3RyYWludHM+IG1fY29uc3RyYWludHM7CiB9OwogCiB0eXBlZGVmIFZlY3RvcjxS ZWZQdHI8TWVkaWFTdHJlYW1Tb3VyY2U+ID4gTWVkaWFTdHJlYW1Tb3VyY2VWZWN0b3I7Cg==