120832 2013-09-06 01:52:02 -0700 Revalidation header blacklisting should be case-insensitive. 2013-09-06 13:03:49 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mkwst mkwst ap commit-queue darin japhet oldest_to_newest 925449 0 mkwst 2013-09-06 01:52:02 -0700 Headers like 'content-type' should be ignored for 304 responses, even if they are delivered as 'Content-Type', or 'CoNtEnT-TyPe', etc. I broke this behavior in http://trac.webkit.org/changeset/142068 ("Entity-header extension headers honored on 304 responses"). This causes pages like https://learndev.unm.edu/ to break on reload, as they incorrectly send 'Content-Type: text/plain' for 304 responses for resources like CSS and JavaScript. https://code.google.com/p/chromium/issues/detail?id=246875 documents the Blink-side fix. I'll upload a patch shortly to fix the issue in WebKit. 925452 1 210711 mkwst 2013-09-06 02:02:58 -0700 Created attachment 210711 Patch 925453 2 mkwst 2013-09-06 02:04:34 -0700 Hi Alexey! Would you mind taking a look at this followup to the 7-month old http://trac.webkit.org/changeset/142068? Thanks! 925693 3 210711 ap 2013-09-06 09:56:44 -0700 Comment on attachment 210711 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210711&action=review r=me Thank you, this is much appreciated. > LayoutTests/http/tests/cache/resources/stylesheet304-bad-content-type.php:7 > + header("HTTP/1.0 304 Not Modified"); I'd have used HTTP/1.1, because 1.0 should die, but this makes no difference in practice. 925694 4 ap 2013-09-06 09:57:00 -0700 <rdar://problem/14929843> 925697 5 210711 ap 2013-09-06 10:10:09 -0700 Comment on attachment 210711 Patch I'm still not sure how we get away with using WTF::Unicode::foldCase for HTTP headers everywhere, this should break with the letter "i" in Turkish locale. But this should not block landing. 925768 6 ap 2013-09-06 12:17:20 -0700 Committed <http://trac.webkit.org/r155203>. 925777 7 darin 2013-09-06 12:42:41 -0700 Can we add some test coverage for this? 925796 8 ap 2013-09-06 13:03:49 -0700 My bad, I only committed WebCore by accident. Landed the test in r155208. 210711 2013-09-06 02:02:58 -0700 2013-09-06 10:10:09 -0700 Patch bug-120832-20130906110257.patch text/plain 6969 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTdhMGVhNGQxM2I3NmEy NTVmODM4YWIzOTU5MjhjZDllNTUyYzdkNS4uZmNjMDgwM2M4Zjc4NzQ4ZDNhYWJiY2VlNTY0MzNm MTFjNDIxMTk3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDEzLTA5LTA2ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2YWxpZGF0aW9uIGhlYWRl ciBibGFja2xpc3Rpbmcgc2hvdWxkIGJlIGNhc2UtaW5zZW5zaXRpdmUuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA4MzIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIZWFkZXJzIGxpa2UgJ2NvbnRlbnQt dHlwZScgc2hvdWxkIGJlIGlnbm9yZWQgZm9yIDMwNCByZXNwb25zZXMsCisgICAgICAgIGV2ZW4g aWYgdGhleSBhcmUgZGVsaXZlcmVkIGFzICdDb250ZW50LVR5cGUnLCBvciAnQ29OdEVuVC1UeVBl JywgZXRjLgorCisgICAgICAgIEkgYnJva2UgdGhpcyBiZWhhdmlvciBpbiBodHRwOi8vdHJhYy53 ZWJraXQub3JnL2NoYW5nZXNldC8xNDIwNjgKKyAgICAgICAgKCJFbnRpdHktaGVhZGVyIGV4dGVu c2lvbiBoZWFkZXJzIGhvbm9yZWQgb24gMzA0IHJlc3BvbnNlcyIpLiBQYWdlcyBsaWtlCisgICAg ICAgIGh0dHBzOi8vbGVhcm5kZXYudW5tLmVkdS8gY3VycmVudGx5IGJyZWFrIG9uIHJlbG9hZCwg YXMgdGhleSBpbmNvcnJlY3RseQorICAgICAgICBzZW5kICdDb250ZW50LVR5cGU6IHRleHQvcGxh aW4nIGZvciAzMDQgcmVzcG9uc2VzIGZvciByZXNvdXJjZXMgbGlrZQorICAgICAgICBDU1MgYW5k IEphdmFTY3JpcHQuIFRoZSBicm93c2VyIHNob3VsZCBkcm9wIHRoZXNlIGhlYWRlcnMsIGJ1dCBi ZWNhdXNlCisgICAgICAgIHdlJ3JlIGNvbXBhcmluZyBpbiBhIGNhc2Utc2Vuc2l0aXZlIGZhc2hp b24sIHdlIGRvbid0LgorCisgICAgICAgIGh0dHBzOi8vY29kZS5nb29nbGUuY29tL3AvY2hyb21p dW0vaXNzdWVzL2RldGFpbD9pZD0yNDY4NzUgZG9jdW1lbnRzIHRoZQorICAgICAgICBCbGluay1z aWRlIGZpeDsgdGhpcyBwYXRjaCBpcyBhIHBvcnQgb2YgdGhhdCBwYXRjaC4KKworICAgICAgICBU ZXN0OiBodHRwL3Rlc3RzL2NhY2hlL2NvbnRlbnQtdHlwZS1pZ25vcmVkLWR1cmluZy1yZXZhbGlk YXRpb24uaHRtbAorCisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OnNob3VsZFVwZGF0ZUhlYWRlckFmdGVyUmV2YWxpZGF0aW9uKToK KyAgICAgICAgQ29tcGFyZSB0aGUgcHJvdmlkZWQgQXRvbWljU3RyaW5nICdoZWFkZXInIHRvIHRo ZSByZXZhbGlkYXRpb24KKyAgICAgICAgYmxhY2tsaXN0cyBpbiBhIGNhc2UtaW5zZW5zaXRpdmUg ZmFzaGlvbi4KKwogMjAxMy0wOS0wNiAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdh bGlhLmNvbT4KIAogICAgICAgICBbQ1NTIEdyaWQgTGF5b3V0XSBSZXNvbHZlIG5hbWVkIGdyaWQg bGluZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNv dXJjZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuY3Bw CmluZGV4IDRjMGMwMmZjMWI2OGFmYTIyMzU1NWFkZWVmNjdiMzQ2YTkzNTE1YTAuLmYzNjFhZmYz NGUwOTg4YjMzYTlkMzRhMzRhMGQ4ZTAxNTAwMWQ0NTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv bG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcApAQCAtOTAsMTEgKzkwLDExIEBAIGNvbnN0 IGNoYXIqIGNvbnN0IGhlYWRlclByZWZpeGVzVG9JZ25vcmVBZnRlclJldmFsaWRhdGlvbltdID0g ewogc3RhdGljIGlubGluZSBib29sIHNob3VsZFVwZGF0ZUhlYWRlckFmdGVyUmV2YWxpZGF0aW9u KGNvbnN0IEF0b21pY1N0cmluZyYgaGVhZGVyKQogewogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBp IDwgV1RGX0FSUkFZX0xFTkdUSChoZWFkZXJzVG9JZ25vcmVBZnRlclJldmFsaWRhdGlvbik7IGkr KykgewotICAgICAgICBpZiAoaGVhZGVyID09IGhlYWRlcnNUb0lnbm9yZUFmdGVyUmV2YWxpZGF0 aW9uW2ldKQorICAgICAgICBpZiAoZXF1YWxJZ25vcmluZ0Nhc2UoaGVhZGVyLCBoZWFkZXJzVG9J Z25vcmVBZnRlclJldmFsaWRhdGlvbltpXSkpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAg ICAgfQogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgV1RGX0FSUkFZX0xFTkdUSChoZWFkZXJQ cmVmaXhlc1RvSWdub3JlQWZ0ZXJSZXZhbGlkYXRpb24pOyBpKyspIHsKLSAgICAgICAgaWYgKGhl YWRlci5zdGFydHNXaXRoKGhlYWRlclByZWZpeGVzVG9JZ25vcmVBZnRlclJldmFsaWRhdGlvbltp XSkpCisgICAgICAgIGlmIChoZWFkZXIuc3RhcnRzV2l0aChoZWFkZXJQcmVmaXhlc1RvSWdub3Jl QWZ0ZXJSZXZhbGlkYXRpb25baV0sIGZhbHNlKSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsK ICAgICB9CiAgICAgcmV0dXJuIHRydWU7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTU3NjlmMzBhM2EyMzRlNzI1NzEzZTU0 OTY2ZmRiYTY2Nzc4MzA4NS4uMjE3NzQ3YjlmMWU3YTVhODYzOTc4Zjg5OTIwZmQxYTJhMTliNmM4 NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA5LTA2ICBNaWtlIFdlc3QgIDxta3dzdEBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2YWxpZGF0aW9uIGhlYWRlciBibGFja2xpc3Rpbmcg c2hvdWxkIGJlIGNhc2UtaW5zZW5zaXRpdmUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA4MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGRzIGEgbmV3IHRlc3QgdG8gdmVyaWZ5IHRoYXQgYSBDU1Mg ZmlsZSBzZXJ2ZWQgaW5pdGlhbGx5IGFzIHR5cGUKKyAgICAgICAgJ3RleHQvY3NzJyBtYWludGFp bnMgdGhhdCB0eXBlIGV2ZW4gaWYgYSByZXZhbGlkYXRpb24gcmVzcG9uc2Ugc2VuZHMKKyAgICAg ICAgJ3RleHQvcGxhaW4nIGFsb25nIHdpdGggYSAzMDQgcmVzcG9uc2UuCisKKyAgICAgICAgKiBo dHRwL3Rlc3RzL2NhY2hlL2NvbnRlbnQtdHlwZS1pZ25vcmVkLWR1cmluZy1yZXZhbGlkYXRpb24t ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL2NhY2hlL2NvbnRlbnQt dHlwZS1pZ25vcmVkLWR1cmluZy1yZXZhbGlkYXRpb24uaHRtbDogQWRkZWQuCisgICAgICAgICog aHR0cC90ZXN0cy9jYWNoZS9yZXNvdXJjZXMvc3R5bGVzaGVldDMwNC1iYWQtY29udGVudC10eXBl LnBocDogQWRkZWQuCisKIDIwMTMtMDktMDYgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFy QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0NTUyBHcmlkIExheW91dF0gUmVzb2x2ZSBuYW1lZCBn cmlkIGxpbmVzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2NhY2hlL2NvbnRl bnQtdHlwZS1pZ25vcmVkLWR1cmluZy1yZXZhbGlkYXRpb24tZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9jYWNoZS9jb250ZW50LXR5cGUtaWdub3JlZC1kdXJpbmctcmV2YWxp ZGF0aW9uLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5mNDdhOTc0MzA0ZmY5ZjEwZTFjOWUwN2Uw YTRjYmIyY2RiYjVmOGY0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9jYWNoZS9jb250ZW50LXR5cGUtaWdub3JlZC1kdXJpbmctcmV2YWxpZGF0aW9uLWV4cGVjdGVk LnR4dApAQCAtMCwwICsxLDEwIEBACitDZXJ0YWluIGhlYWRlcnMgKHN1Y2ggYXMgJ2NvbnRlbnQt dHlwZScpIG91Z2h0IHRvIGJlIGlnbm9yZWQgd2hlbiByZXNvdXJjZXMgbGlrZSBzdHlsZXNoZWV0 cyBhcmUgcmV2YWxpZGF0ZWQgdmlhIGEgMzA0IHJlc3BvbnNlLgorCitPbiBzdWNjZXNzLCB5b3Ug d2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBD T01QTEVURSIuCisKKworUEFTUyB3aW5kb3cuZ2V0Q29tcHV0ZWRTdHlsZShkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgndGVzdCcpKS5iYWNrZ3JvdW5kQ29sb3IgaXMgInJnYigwLCAyNTUsIDApIgor UEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCitUaGlzIGRp diBzaG91bGQgaGF2ZSBhIGdyZWVuIGJhY2tncm91bmQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL2NhY2hlL2NvbnRlbnQtdHlwZS1pZ25vcmVkLWR1cmluZy1yZXZhbGlkYXRp b24uaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvY2FjaGUvY29udGVudC10eXBlLWlnbm9y ZWQtZHVyaW5nLXJldmFsaWRhdGlvbi5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjQxYTBlZTc0NTY0MTkxZDg1 OGRjNTA1NDA3NmEyMzFkY2M4NjUzODMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL2NhY2hlL2NvbnRlbnQtdHlwZS1pZ25vcmVkLWR1cmluZy1yZXZhbGlkYXRpb24u aHRtbApAQCAtMCwwICsxLDI4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cisg ICAgPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSJyZXNvdXJjZXMvc3R5bGVzaGVldDMwNC1i YWQtY29udGVudC10eXBlLnBocCI+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgICA8ZGl2IGlkPSJ0ZXN0 Ij5UaGlzIGRpdiBzaG91bGQgaGF2ZSBhIGdyZWVuIGJhY2tncm91bmQuPC9kaXY+CisKKyAgICA8 c2NyaXB0IHNyYz0iL2pzLXRlc3QtcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4K KyAgICA8c2NyaXB0PgorICAgICAgICB3aW5kb3cuanNUZXN0SXNBc3luYyA9IHRydWU7CisKKyAg ICAgICAgZGVzY3JpcHRpb24oIkNlcnRhaW4gaGVhZGVycyAoc3VjaCBhcyAnY29udGVudC10eXBl Jykgb3VnaHQgdG8gYmUgaWdub3JlZCB3aGVuIHJlc291cmNlcyBsaWtlIHN0eWxlc2hlZXRzIGFy ZSByZXZhbGlkYXRlZCB2aWEgYSAzMDQgcmVzcG9uc2UuIik7CisKKyAgICAgICAgd2luZG93Lm9u bG9hZCA9IGZ1bmN0aW9uICgpIHsKKyAgICAgICAgICAgIGlmICh3aW5kb3cuc2Vzc2lvblN0b3Jh Z2UucmVsb2FkZWQpIHsKKyAgICAgICAgICAgICAgICB3aW5kb3cuc2Vzc2lvblN0b3JhZ2UucmVt b3ZlSXRlbSgicmVsb2FkZWQiKTsKKyAgICAgICAgICAgICAgICBzaG91bGRCZUVxdWFsVG9TdHJp bmcoIndpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0ZXN0 JykpLmJhY2tncm91bmRDb2xvciIsICJyZ2IoMCwgMjU1LCAwKSIpOyAKKyAgICAgICAgICAgICAg ICBmaW5pc2hKU1Rlc3QoKTsKKyAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAgICAg d2luZG93LnNlc3Npb25TdG9yYWdlLnJlbG9hZGVkID0gMTsKKyAgICAgICAgICAgICAgICB3aW5k b3cubG9jYXRpb24ucmVsb2FkKCk7CisgICAgICAgICAgICB9CisgICAgICAgIH07CisgICAgPC9z Y3JpcHQ+CisgICAgPHNjcmlwdCBzcmM9Ii9qcy10ZXN0LXJlc291cmNlcy9qcy10ZXN0LXBvc3Qu anMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aHR0cC90ZXN0cy9jYWNoZS9yZXNvdXJjZXMvc3R5bGVzaGVldDMwNC1iYWQtY29udGVudC10eXBl LnBocCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvY2FjaGUvcmVzb3VyY2VzL3N0eWxlc2hlZXQz MDQtYmFkLWNvbnRlbnQtdHlwZS5waHAKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMmFkZjZjODI3OWU2NjRlYTFjYjZm MGQwMzFjMGRmZGUyNjIxOWNlZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAv dGVzdHMvY2FjaGUvcmVzb3VyY2VzL3N0eWxlc2hlZXQzMDQtYmFkLWNvbnRlbnQtdHlwZS5waHAK QEAgLTAsMCArMSwyMSBAQAorPD9waHAKK3JlcXVpcmVfb25jZSAnLi4vLi4vcmVzb3VyY2VzL3Bv cnRhYmlsaXR5TGF5ZXIucGhwJzsKKworY2xlYXJzdGF0Y2FjaGUoKTsKKworaWYgKCRfU0VSVkVS WyJIVFRQX0lGX01PRElGSUVEX1NJTkNFIl0pIHsKKyAgICBoZWFkZXIoIkhUVFAvMS4wIDMwNCBO b3QgTW9kaWZpZWQiKTsKKyAgICBoZWFkZXIoIkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbiIpOwor ICAgIGV4aXQoKTsKK30KKyRvbmVfeWVhciA9IDEyICogMzEgKiAyNCAqIDYwICogNjA7CiskbGFz dF9tb2RpZmllZCA9IGdtZGF0ZShEQVRFX1JGQzExMjMsIHRpbWUoKSAtICRvbmVfeWVhcik7Cisk ZXhwaXJlcyA9IGdtZGF0ZShEQVRFX1JGQzExMjMsIHRpbWUoKSArICRvbmVfeWVhcik7CisKK2hl YWRlcignQ2FjaGUtQ29udHJvbDogcHVibGljLCBtYXgtYWdlPScgLiAkb25lX3llYXIpOworaGVh ZGVyKCdFeHBpcmVzOiAnIC4gJGV4cGlyZXMpOworaGVhZGVyKCdDb250ZW50LVR5cGU6IHRleHQv Y3NzJyk7CitoZWFkZXIoJ0V0YWc6IDEyMzQ1Njc4OScpOworaGVhZGVyKCdMYXN0LU1vZGlmaWVk OiAnIC4gJGxhc3RfbW9kaWZpZWQpOworPz4KKyN0ZXN0IHsgYmFja2dyb3VuZC1jb2xvcjogcmdi KDAsIDI1NSwgMCk7IH0K