120812 2013-09-05 17:06:02 -0700 [CMAKE] Add c++0x into CXX_FLAGS as a default 2013-09-10 09:23:37 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi cdumez commit-queue gyuyoung.kim ossy rakuco oldest_to_newest 925293 0 ryuan.choi 2013-09-05 17:06:02 -0700 After Bug 119081, We enabled C++0x for WebKit, WebCore, JSC and WTF. After r155148, we should enable it for all cpp files including gtest and ImageDiff. Because we are already using c++0x in WebCore, I think that we can move all cmake targets. 925297 1 210685 ryuan.choi 2013-09-05 17:10:29 -0700 Created attachment 210685 Patch 925306 2 ryuan.choi 2013-09-05 17:22:32 -0700 Committed r155163: <http://trac.webkit.org/changeset/155163> 925307 3 210685 ryuan.choi 2013-09-05 17:23:22 -0700 Comment on attachment 210685 Patch clearing flags. 927331 4 ossy 2013-09-10 09:23:37 -0700 *** Bug 119402 has been marked as a duplicate of this bug. *** 210685 2013-09-05 17:10:29 -0700 2013-09-05 17:23:22 -0700 Patch bug-120812-20130906091027.patch text/plain 6674 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggY2NmN2UwN2Ez MmY1NThmYzMzMDI3ODQwOGE3ZjhmODUwMjc4MTg0My4uNjUxNTg2MWUzYjJiZDA2YTQ1YTE3NGMw MWJiNzZmMmNkYzFmN2Y4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEz LTA5LTA1ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBb Q01BS0VdIEFkZCBjKysweCBpbnRvIENYWF9GTEFHUyBhcyBhIGRlZmF1bHQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDgxMgorCisgICAgICAgIFVu cmV2aWV3ZWQgYnVpbGQgZml4IGZvciBFRkwgcG9ydHMuCisKKyAgICAgICAgKiB0ZXN0cy9Vbml0 VGVzdFV0aWxzL0VXS1Rlc3RDb25maWcuaDogQWRkIHNwYWNlIGJldHdlZW4gc3RyaW5ncy4KKwog MjAxMy0wOC0yOCAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAgICAg ICAgW0VGTF0gTGV0IFBhZ2UgY3JlYXRlIHRoZSBtYWluIEZyYW1lCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTBm Y2YxODZkZDc0N2Y5OWVkZTcwYTI5NjllNWU4OTM5MzNiMWQ3Ny4uM2Q4MmY0OTA2MTE4MjQ5YjE4 NjM3YzRhYjczYmI2ZDRlNWIxYjdlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEz LTA5LTA1ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBb Q01BS0VdIEFkZCBjKysweCBpbnRvIENYWF9GTEFHUyBhcyBhIGRlZmF1bHQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDgxMgorCisgICAgICAgIFVu cmV2aWV3ZWQgYnVpbGQgZml4IGZvciBFRkwgcG9ydHMuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXSzJVbml0VGVzdEJhc2UuaDogQWRkZWQgY29u c3RleHByIGZvciBpbi1jbGFzcyBpbml0aWFsaXphdGlvbi4KKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXSzJVbml0VGVzdEVudmlyb25tZW50LmNwcDog QWRkZWQgc3BhY2UgYmV0d2VlbiBzdHJpbmdzLgorICAgICAgICAoRVdLMlVuaXRUZXN0OjpFV0sy VW5pdFRlc3RFbnZpcm9ubWVudDo6ZGVmYXVsdFRlc3RQYWdlVXJsKToKKyAgICAgICAgKEVXSzJV bml0VGVzdDo6RVdLMlVuaXRUZXN0RW52aXJvbm1lbnQ6OmRlZmF1bHRUaGVtZSk6CisgICAgICAg IChFV0syVW5pdFRlc3Q6OkVXSzJVbml0VGVzdEVudmlyb25tZW50Ojp1cmxGb3JSZXNvdXJjZSk6 CisKIDIwMTMtMDktMDUgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAg ICAgICAgV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlciBleHRlbmRzIGxpZmV0aW1lIG9mIFdL VmlldywgZGVsZXRpbmcgaXQgYXQgYSB3cm9uZyB0aW1lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXS1Rlc3RDb25maWcuaCBiL1NvdXJjZS9XZWJL aXQvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdLVGVzdENvbmZpZy5oCmluZGV4IGExY2Y2ZWE4 MzkxZGFhZjM5ZjVlMDljMWM4YzA3MTZjNjk4MGQwOWUuLmZmNDRhZWVhNTBlNzRiZjQ4MzBlNmY5 YTI0MTE1Y2JjMWYyNWZjYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL3Rlc3RzL1Vu aXRUZXN0VXRpbHMvRVdLVGVzdENvbmZpZy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL3Rlc3Rz L1VuaXRUZXN0VXRpbHMvRVdLVGVzdENvbmZpZy5oCkBAIC0yMyw4ICsyMyw4IEBAIG5hbWVzcGFj ZSBFV0tVbml0VGVzdHMgewogbmFtZXNwYWNlIENvbmZpZyB7CiBzdGF0aWMgY29uc3QgaW50IGRl ZmF1bHRWaWV3V2lkdGggPSA2MDA7CiBzdGF0aWMgY29uc3QgaW50IGRlZmF1bHRWaWV3SGVpZ2h0 ID0gODAwOwotc3RhdGljIGNvbnN0IGNoYXIqIGNvbnN0IGRlZmF1bHRUaGVtZVBhdGggPSBERUZB VUxUX1RIRU1FX1BBVEgiL2RlZmF1bHQuZWRqIjsKLXN0YXRpYyBjb25zdCBjaGFyKiBjb25zdCBk ZWZhdWx0VGVzdFBhZ2UgPSAiZmlsZTovLyJERUZBVUxUX1RFU1RfUEFHRV9ESVIiL2RlZmF1bHRf dGVzdF9wYWdlLmh0bWwiOworc3RhdGljIGNvbnN0IGNoYXIqIGNvbnN0IGRlZmF1bHRUaGVtZVBh dGggPSBERUZBVUxUX1RIRU1FX1BBVEggIi9kZWZhdWx0LmVkaiI7CitzdGF0aWMgY29uc3QgY2hh ciogY29uc3QgZGVmYXVsdFRlc3RQYWdlID0gImZpbGU6Ly8iIERFRkFVTFRfVEVTVF9QQUdFX0RJ UiAiL2RlZmF1bHRfdGVzdF9wYWdlLmh0bWwiOwogfQogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXSzJVbml0VGVz dEJhc2UuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL1VuaXRUZXN0 VXRpbHMvRVdLMlVuaXRUZXN0QmFzZS5oCmluZGV4IDEzZWZhOGJlZWY2N2I2MTZiOTRiNWVhMTlh YjA5ZTAxM2QzZjIxNjYuLjEyMDQ3ZGEzNjBjMzNkM2U1NTcwNDM4ZjVmYzQ2OGE5NmVkNDc5YTQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL1VuaXRU ZXN0VXRpbHMvRVdLMlVuaXRUZXN0QmFzZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdLMlVuaXRUZXN0QmFzZS5oCkBAIC00NCw3 ICs0NCw3IEBAIHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIHZvaWQgU2V0VXAoKTsKICAgICB2aXJ0 dWFsIHZvaWQgVGVhckRvd24oKTsKIAotICAgIHN0YXRpYyBjb25zdCBkb3VibGUgZGVmYXVsdFRp bWVvdXRTZWNvbmRzID0gMTAuMDsKKyAgICBzdGF0aWMgY29uc3RleHByIGRvdWJsZSBkZWZhdWx0 VGltZW91dFNlY29uZHMgPSAxMC4wOwogCiAgICAgYm9vbCBsb2FkVXJsU3luYyhjb25zdCBjaGFy KiB1cmwsIGRvdWJsZSB0aW1lb3V0U2Vjb25kcyA9IGRlZmF1bHRUaW1lb3V0U2Vjb25kcyk7CiAg ICAgYm9vbCB3YWl0VW50aWxMb2FkRmluaXNoZWQoZG91YmxlIHRpbWVvdXRTZWNvbmRzID0gZGVm YXVsdFRpbWVvdXRTZWNvbmRzKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdLMlVuaXRUZXN0RW52aXJvbm1lbnQuY3Bw IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9F V0syVW5pdFRlc3RFbnZpcm9ubWVudC5jcHAKaW5kZXggZTYyNmVlNzQ1NTM2MzU5NjdiY2MxZDEx ODA0YWNkZmJkYTU3NGY2Mi4uMDA2MThlMjNjMDRjOTQxYjQ1YjdmOWU1ZjZmMTMwYmE2OTJiYWY5 MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5p dFRlc3RVdGlscy9FV0syVW5pdFRlc3RFbnZpcm9ubWVudC5jcHAKKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0syVW5pdFRlc3RFbnZp cm9ubWVudC5jcHAKQEAgLTM0LDEyICszNCwxMiBAQCBFV0syVW5pdFRlc3RFbnZpcm9ubWVudDo6 RVdLMlVuaXRUZXN0RW52aXJvbm1lbnQoKQogCiBjb25zdCBjaGFyKiBFV0syVW5pdFRlc3RFbnZp cm9ubWVudDo6ZGVmYXVsdFRlc3RQYWdlVXJsKCkgY29uc3QKIHsKLSAgICByZXR1cm4gImZpbGU6 Ly8iVEVTVF9SRVNPVVJDRVNfRElSIi9kZWZhdWx0X3Rlc3RfcGFnZS5odG1sIjsKKyAgICByZXR1 cm4gImZpbGU6Ly8iIFRFU1RfUkVTT1VSQ0VTX0RJUiAiL2RlZmF1bHRfdGVzdF9wYWdlLmh0bWwi OwogfQogCiBjb25zdCBjaGFyKiBFV0syVW5pdFRlc3RFbnZpcm9ubWVudDo6ZGVmYXVsdFRoZW1l KCkgY29uc3QKIHsKLSAgICByZXR1cm4gVEVTVF9USEVNRV9ESVIiL2RlZmF1bHQuZWRqIjsKKyAg ICByZXR1cm4gVEVTVF9USEVNRV9ESVIgIi9kZWZhdWx0LmVkaiI7CiB9CiAKIGNvbnN0IGNoYXIq IEVXSzJVbml0VGVzdEVudmlyb25tZW50OjppbmplY3RlZEJ1bmRsZVNhbXBsZSgpIGNvbnN0CkBA IC00OSw3ICs0OSw3IEBAIGNvbnN0IGNoYXIqIEVXSzJVbml0VGVzdEVudmlyb25tZW50Ojppbmpl Y3RlZEJ1bmRsZVNhbXBsZSgpIGNvbnN0CiAKIENTdHJpbmcgRVdLMlVuaXRUZXN0RW52aXJvbm1l bnQ6OnVybEZvclJlc291cmNlKGNvbnN0IGNoYXIqIHJlc291cmNlKQogewotICAgIHJldHVybiBt YWtlU3RyaW5nKCJmaWxlOi8vIlRFU1RfUkVTT1VSQ0VTX0RJUiIvIiwgcmVzb3VyY2UpLnV0Zjgo KTsKKyAgICByZXR1cm4gbWFrZVN0cmluZygiZmlsZTovLyIgVEVTVF9SRVNPVVJDRVNfRElSICIv IiwgcmVzb3VyY2UpLnV0ZjgoKTsKIH0KIAogQ1N0cmluZyBFV0syVW5pdFRlc3RFbnZpcm9ubWVu dDo6cGF0aEZvclJlc291cmNlKGNvbnN0IGNoYXIqIHJlc291cmNlKQpkaWZmIC0tZ2l0IGEvU291 cmNlL2NtYWtlL09wdGlvbnNDb21tb24uY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1v bi5jbWFrZQppbmRleCBlZTNjZTdhNDliYjlkMzAzNzNiMDU3NTg2NDBlY2JjYzRhZGY2MGQ0Li4w ZmU4N2RlYmEzMmJiYWI4ZTVmOTE3N2JlYTk2OWEwMTA0MGUyMjY4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0Nv bW1vbi5jbWFrZQpAQCAtMjQsNiArMjQsMTAgQEAgZW5kaWYgKCkKIAogc2V0X3Byb3BlcnR5KEdM T0JBTCBQUk9QRVJUWSBVU0VfRk9MREVSUyBPTikKIAoraWYgKENNQUtFX0NPTVBJTEVSX0lTX0dO VUNYWCBPUiAiJHtDTUFLRV9DWFhfQ09NUElMRVJfSUR9IiBTVFJFUVVBTCAiQ2xhbmciKQorICAg IHNldChDTUFLRV9DWFhfRkxBR1MgIiR7Q01BS0VfQ1hYX0ZMQUdTfSAtc3RkPWdudSsrMHgiKQor ZW5kaWYgKCkKKwogc3RyaW5nKFRPTE9XRVIgJHtDTUFLRV9IT1NUX1NZU1RFTV9QUk9DRVNTT1J9 IExPV0VSQ0FTRV9DTUFLRV9IT1NUX1NZU1RFTV9QUk9DRVNTT1IpCiBpZiAoIiR7Q01BS0VfQ1hY X0NPTVBJTEVSX0lEfSIgU1RSRVFVQUwgIkdOVSIgQU5EICIke0xPV0VSQ0FTRV9DTUFLRV9IT1NU X1NZU1RFTV9QUk9DRVNTT1J9IiBNQVRDSEVTICIoaVszLTZdODZ8eDg2KSIpCiAgICAgIyBUbyBh dm9pZCBvdXQgb2YgbWVtb3J5IHdoZW4gYnVpbGRpbmcgd2l0aCBkZWJ1ZyBvcHRpb24gaW4gMzJi aXQgc3lzdGVtLgpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2Ug Yi9Tb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZQppbmRleCA0YzEzMGU5MGEwNjQ4OWY1 MjJiZjNkODkwYzA0YjBkZmM5MTkzODQ5Li4xZTUxZWJjYzBjNzhmMmRjMDcxOTJmZDljMTQwOTY2 YjQ4YjQ2MWI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZQor KysgYi9Tb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZQpAQCAtNTEsOCArNTEsNiBAQCBt YWNybyhXRUJLSVRfU0VUX0VYVFJBX0NPTVBJTEVSX0ZMQUdTIF90YXJnZXQpCiAgICAgICAgICAg ICBzZXQoT0xEX0NPTVBJTEVfRkxBR1MgIiR7T0xEX0NPTVBJTEVfRkxBR1N9IC1Xbm8tYysrMHgt Y29tcGF0IikKICAgICAgICAgZW5kaWYgKCkKIAotICAgICAgICBzZXQoT0xEX0NPTVBJTEVfRkxB R1MgIiR7T0xEX0NPTVBJTEVfRkxBR1N9IC1zdGQ9Z251KysweCIpCi0KICAgICAgICAgc2V0X3Rh cmdldF9wcm9wZXJ0aWVzKCR7X3RhcmdldH0gUFJPUEVSVElFUwogICAgICAgICAgICAgQ09NUElM RV9GTEFHUyAiJHtPTERfQ09NUElMRV9GTEFHU30iKQogCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cg Yi9DaGFuZ2VMb2cKaW5kZXggOGE2Nzg1NTA5YTQzMjg2ZGJkN2Q1MjZjMWQ0OTJlZjg3OWIzNjYw Ny4uNDQ1MTUxZTIzNWM5ZjY2OGRkOTdlMjYyOTU1YzczNjBhOWMwZDFjYyAxMDA2NDQKLS0tIGEv Q2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA5LTA1ICBS eXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbQ01BS0VdIEFk ZCBjKysweCBpbnRvIENYWF9GTEFHUyBhcyBhIGRlZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDgxMgorCisgICAgICAgIFVucmV2aWV3ZWQg YnVpbGQgZml4IGZvciBFRkwgcG9ydHMuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9u c0NvbW1vbi5jbWFrZTogTW92ZWQgYysrMHggb3B0aW9uIGhlcmUgZnJvbSBXZWJLaXRIZWxwZXJz LgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlOgorCiAyMDEzLTA5 LTA0ICBNaWNoYWVsIEJyw7xuaW5nICA8bWljaGFlbC5icnVuaW5nQGRpZ2lhLmNvbT4KIAogICAg ICAgICBbUXRdIFVzZSBjb3JyZWN0IGxpYnJhcnkgcGF0aHMgZm9yIHByZWZpeCBidWlsZHMgb24g TWFjLgo=