120804 2013-09-05 15:37:25 -0700 Web Inspector: Edit Breakpoint popover sometimes appears misplaced in top left 2013-09-05 17:54:44 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 925248 0 joepeck 2013-09-05 15:37:25 -0700 Occasionally the Edit Breakpoint popover is poorly sized and misplaced in the top left. This looks really bad! * STEPS TO REPRODUCE 1. Inspect <http://bogojoker.com/shell/> 2. Set a breakpoint on easySlider.min.js:3 3. Edit Breakpoint + set autoContinue 4. Close and reopen inspector (to save changes) 5. Reload page (⌘R) 6. Select breakpoint in sidebar 7. Choose Edit Breakpoint either in the Sidebar or Gutter NOTE: Repeat steps 5-7 as needed till you reproduce => misplaced popover 925249 1 joepeck 2013-09-05 15:37:50 -0700 After some debugging, this appears to happen when the element that is the contextmenu event's targetElement is no longer in the DOM by the time we call getBoundingClientRect. So we can grab the bounding client rect earlier, and not carry the element around. 925250 2 webkit-bug-importer 2013-09-05 15:37:52 -0700 <rdar://problem/14923517> 925253 3 210672 joepeck 2013-09-05 15:40:59 -0700 Created attachment 210672 [PATCH] Proposed Fix 925327 4 210672 commit-queue 2013-09-05 17:54:42 -0700 Comment on attachment 210672 [PATCH] Proposed Fix Clearing flags on attachment: 210672 Committed r155165: <http://trac.webkit.org/changeset/155165> 925328 5 commit-queue 2013-09-05 17:54:44 -0700 All reviewed patches have been landed. Closing bug. 210672 2013-09-05 15:40:59 -0700 2013-09-05 17:54:42 -0700 [PATCH] Proposed Fix popover-position.patch text/plain 2541 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGYyZDEzZGIuLmI2N2E0MDEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEzLTA5LTA1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRWRpdCBC cmVha3BvaW50IHBvcG92ZXIgc29tZXRpbWVzIGFwcGVhcnMgbWlzcGxhY2VkIGluIHRvcCBsZWZ0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA4MDQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHcmFiIHRo ZSBib3VuZGluZyByZWN0IGltbWVkaWF0ZWx5LCBpbnN0ZWFkIG9mIGdyYWJiaW5nIGl0IGZyb20g dGhlIGVsZW1lbnQKKyAgICAgICAgYWZ0ZXIgdGhlIHVzZXIgaGFzIHNlbGVjdGVkIHRoZSAiRWRp dCBCcmVha3BvaW50IiBjb250ZXh0IG1lbnUgaXRlbS4gV2hlbgorICAgICAgICB0aGUgcG9wb3Zl ciB3YXMgbWlzcGxhY2VkIGl0IHdhcyB3aGVuIHVzaW5nIGFuIGVsZW1lbnQgaGFkIGJlZW4gcmVt b3ZlZCBvcgorICAgICAgICByZXBsYWNlZCBpbiB0aGUgRE9NLCBhbmQgY2F1c2VkIGEgYm9ndXMg Ym91bmRpbmcgY2xpZW50IHJlY3QuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0JyZWFrcG9p bnQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQnJlYWtwb2ludC5wcm90b3R5cGUuZWRpdEJy ZWFrcG9pbnQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkJyZWFrcG9pbnQucHJvdG90eXBlLl9z aG93RWRpdEJyZWFrcG9pbnRQb3BvdmVyKToKKworMjAxMy0wOS0wNSAgSm9zZXBoIFBlY29yYXJv ICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEJyZWFrcG9p bnQgQWN0aW9ucwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTIwNTc2CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0JyZWFrcG9pbnQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9C cmVha3BvaW50LmpzCmluZGV4IDQyYTQyZTguLjFlZmY2YzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0JyZWFrcG9pbnQuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQnJlYWtwb2ludC5qcwpAQCAtMTk5LDkgKzE5OSwx MyBAQCBXZWJJbnNwZWN0b3IuQnJlYWtwb2ludC5wcm90b3R5cGUgPSB7CiAKICAgICBhcHBlbmRD b250ZXh0TWVudUl0ZW1zOiBmdW5jdGlvbihjb250ZXh0TWVudSwgYnJlYWtwb2ludERpc3BsYXlF bGVtZW50KQogICAgIHsKKyAgICAgICAgY29uc29sZS5hc3NlcnQoZG9jdW1lbnQuYm9keS5jb250 YWlucyhicmVha3BvaW50RGlzcGxheUVsZW1lbnQpLCAiYnJlYWtwb2ludCBwb3BvdmVyIGRpc3Bs YXkgZWxlbWVudCBtdXN0IGJlIGluIHRoZSBET00iKTsKKworICAgICAgICB2YXIgYm91bmRpbmdD bGllbnRSZWN0ID0gYnJlYWtwb2ludERpc3BsYXlFbGVtZW50LmdldEJvdW5kaW5nQ2xpZW50UmVj dCgpOworCiAgICAgICAgIGZ1bmN0aW9uIGVkaXRCcmVha3BvaW50KCkKICAgICAgICAgewotICAg ICAgICAgICAgdGhpcy5fc2hvd0VkaXRCcmVha3BvaW50UG9wb3ZlcihicmVha3BvaW50RGlzcGxh eUVsZW1lbnQpOworICAgICAgICAgICAgdGhpcy5fc2hvd0VkaXRCcmVha3BvaW50UG9wb3Zlcihi b3VuZGluZ0NsaWVudFJlY3QpOwogICAgICAgICB9CiAKICAgICAgICAgZnVuY3Rpb24gcmVtb3Zl QnJlYWtwb2ludCgpCkBAIC00NzQsMTAgKzQ3OCwxMSBAQCBXZWJJbnNwZWN0b3IuQnJlYWtwb2lu dC5wcm90b3R5cGUgPSB7CiAgICAgICAgIGRlbGV0ZSB0aGlzLl9wb3BvdmVyOwogICAgIH0sCiAK LSAgICBfc2hvd0VkaXRCcmVha3BvaW50UG9wb3ZlcjogZnVuY3Rpb24oZWxlbWVudCkKKyAgICBf c2hvd0VkaXRCcmVha3BvaW50UG9wb3ZlcjogZnVuY3Rpb24oYm91bmRpbmdDbGllbnRSZWN0KQog ICAgIHsKICAgICAgICAgY29uc3QgcGFkZGluZyA9IDI7Ci0gICAgICAgIHZhciBib3VuZHMgPSBX ZWJJbnNwZWN0b3IuUmVjdC5yZWN0RnJvbUNsaWVudFJlY3QoZWxlbWVudC5nZXRCb3VuZGluZ0Ns aWVudFJlY3QoKSk7CisgICAgICAgIHZhciBib3VuZHMgPSBXZWJJbnNwZWN0b3IuUmVjdC5yZWN0 RnJvbUNsaWVudFJlY3QoYm91bmRpbmdDbGllbnRSZWN0KTsKKwogICAgICAgICBib3VuZHMub3Jp Z2luLnggLT0gMTsgLy8gTW92ZSB0aGUgYW5jaG9yIGxlZnQgb25lIHBpeGVsIHNvIGl0IGxvb2tz IG1vcmUgY2VudGVyZWQuCiAgICAgICAgIGJvdW5kcy5vcmlnaW4ueCAtPSBwYWRkaW5nOwogICAg ICAgICBib3VuZHMub3JpZ2luLnkgLT0gcGFkZGluZzsK