120793 2013-09-05 13:57:43 -0700 [GTK] GlibUtilities: getCurrentExecutablePath() does not compile on GNU/Hurd 2013-09-06 09:47:49 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto webkit-unassigned benjamin cmarcelo commit-queue gustavo pochu27 oldest_to_newest 925197 0 berto 2013-09-05 13:57:43 -0700 That's because PATH_MAX is not defined there. Reported in Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=669059 925198 1 210658 berto 2013-09-05 13:59:49 -0700 Created attachment 210658 Patch 925201 2 commit-queue 2013-09-05 14:00:52 -0700 Attachment 210658 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/gobject/GlibUtilities.cpp']" exit_code: 1 Source/WTF/wtf/gobject/GlibUtilities.cpp:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 925202 3 210660 berto 2013-09-05 14:01:25 -0700 Created attachment 210660 Patch The previous patch needed style fixes, here's the updated one. 925443 4 210660 svillar 2013-09-06 01:15:08 -0700 Comment on attachment 210660 Patch I see how this could help with the build, but IMO the patch should actually fix the underlying issue. I believe there should be a way in GNU/Hurd to retrieve the current executable path even if PATH_MAX is not defined. 925493 5 pochu27 2013-09-06 03:41:53 -0700 There's currently no way to get the executable path on GNU/Hurd (there is /proc/self but there's no /proc/self/exe), but the catch-all case in findWebKitProcess() which just uses LIBEXECDIR should work fine there. If you want we can keep a downstream patch with a dummy getCurrentExecutablePath() until there's a way to get the executable path on the Hurd. 925629 6 210660 gustavo 2013-09-06 09:38:47 -0700 Comment on attachment 210660 Patch No point in waiting, I think, let's just do it and we can revisit if it is made possible in the future. 925689 7 berto 2013-09-06 09:47:49 -0700 Committed r155193: <http://trac.webkit.org/changeset/155193> 210658 2013-09-05 13:59:49 -0700 2013-09-05 14:01:25 -0700 Patch 120793.diff text/plain 1280 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggNjcyMWJiNi4uNTNlZWJmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMy0wOS0wNSAg QWxiZXJ0byBHYXJjaWEgIDxiZXJ0b0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEdsaWJV dGlsaXRpZXM6IGdldEN1cnJlbnRFeGVjdXRhYmxlUGF0aCgpIGRvZXMgbm90IGNvbXBpbGUgb24g R05VL0h1cmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyMDc5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE9yaWdpbmFsIHBhdGNoIGJ5IFN2YW50ZSBTaWduZWxsIDxzdmFudGUuc2lnbmVsbEB0ZWxpYS5j b20+LgorCisgICAgICAgIFBBVEhfTUFYIGlzIG5vdCBkZWZpbmVkIGluIEdOVS9IdXJkLCB0aGlz IHBhdGNoIGFkZHMgYSBkdW1teQorICAgICAgICBpbXBsZW1lbnRhdGlvbiB0byBtYWtlIGl0IGNv bXBpbGUuCisKKyAgICAgICAgKiB3dGYvZ29iamVjdC9HbGliVXRpbGl0aWVzLmNwcDoKKyAgICAg ICAgKGdldEN1cnJlbnRFeGVjdXRhYmxlUGF0aCk6CisKIDIwMTMtMDktMDUgIEFuZGVycyBDYXJs c3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBDaGFuZ2UgU3RyaW5nQnVmZmVy IGJhY2sgdG8gbm90IHVzZSBhbiBPd25QdHIgaW4gYW4gYXR0ZW1wdCB0byBmaXggcG9ydHMuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9nb2JqZWN0L0dsaWJVdGlsaXRpZXMuY3BwIGIvU291 cmNlL1dURi93dGYvZ29iamVjdC9HbGliVXRpbGl0aWVzLmNwcAppbmRleCAxYTJhOGIxLi42YjVm NjZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9nb2JqZWN0L0dsaWJVdGlsaXRpZXMuY3Bw CisrKyBiL1NvdXJjZS9XVEYvd3RmL2dvYmplY3QvR2xpYlV0aWxpdGllcy5jcHAKQEAgLTM3LDYg KzM3LDExIEBAIENTdHJpbmcgZ2V0Q3VycmVudEV4ZWN1dGFibGVQYXRoKCkKICAgICAgICAgcmV0 dXJuIENTdHJpbmcoKTsKICAgICByZXR1cm4gQ1N0cmluZyhyZWFkTGlua0J1ZmZlciwgcmVzdWx0 KTsKIH0KKyNlbGlmIE9TKEhVUkQpCitDU3RyaW5nIGdldEN1cnJlbnRFeGVjdXRhYmxlUGF0aCgp Cit7CisgIHJldHVybiBDU3RyaW5nKCk7Cit9CiAjZWxpZiBPUyhVTklYKQogQ1N0cmluZyBnZXRD dXJyZW50RXhlY3V0YWJsZVBhdGgoKQogewo= 210660 2013-09-05 14:01:25 -0700 2013-09-06 09:38:47 -0700 Patch 120793.diff text/plain 1282 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggNjcyMWJiNi4uNTNlZWJmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMy0wOS0wNSAg QWxiZXJ0byBHYXJjaWEgIDxiZXJ0b0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEdsaWJV dGlsaXRpZXM6IGdldEN1cnJlbnRFeGVjdXRhYmxlUGF0aCgpIGRvZXMgbm90IGNvbXBpbGUgb24g R05VL0h1cmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyMDc5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE9yaWdpbmFsIHBhdGNoIGJ5IFN2YW50ZSBTaWduZWxsIDxzdmFudGUuc2lnbmVsbEB0ZWxpYS5j b20+LgorCisgICAgICAgIFBBVEhfTUFYIGlzIG5vdCBkZWZpbmVkIGluIEdOVS9IdXJkLCB0aGlz IHBhdGNoIGFkZHMgYSBkdW1teQorICAgICAgICBpbXBsZW1lbnRhdGlvbiB0byBtYWtlIGl0IGNv bXBpbGUuCisKKyAgICAgICAgKiB3dGYvZ29iamVjdC9HbGliVXRpbGl0aWVzLmNwcDoKKyAgICAg ICAgKGdldEN1cnJlbnRFeGVjdXRhYmxlUGF0aCk6CisKIDIwMTMtMDktMDUgIEFuZGVycyBDYXJs c3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBDaGFuZ2UgU3RyaW5nQnVmZmVy IGJhY2sgdG8gbm90IHVzZSBhbiBPd25QdHIgaW4gYW4gYXR0ZW1wdCB0byBmaXggcG9ydHMuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9nb2JqZWN0L0dsaWJVdGlsaXRpZXMuY3BwIGIvU291 cmNlL1dURi93dGYvZ29iamVjdC9HbGliVXRpbGl0aWVzLmNwcAppbmRleCAxYTJhOGIxLi5mMDhl MzMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9nb2JqZWN0L0dsaWJVdGlsaXRpZXMuY3Bw CisrKyBiL1NvdXJjZS9XVEYvd3RmL2dvYmplY3QvR2xpYlV0aWxpdGllcy5jcHAKQEAgLTM3LDYg KzM3LDExIEBAIENTdHJpbmcgZ2V0Q3VycmVudEV4ZWN1dGFibGVQYXRoKCkKICAgICAgICAgcmV0 dXJuIENTdHJpbmcoKTsKICAgICByZXR1cm4gQ1N0cmluZyhyZWFkTGlua0J1ZmZlciwgcmVzdWx0 KTsKIH0KKyNlbGlmIE9TKEhVUkQpCitDU3RyaW5nIGdldEN1cnJlbnRFeGVjdXRhYmxlUGF0aCgp Cit7CisgICAgcmV0dXJuIENTdHJpbmcoKTsKK30KICNlbGlmIE9TKFVOSVgpCiBDU3RyaW5nIGdl dEN1cnJlbnRFeGVjdXRhYmxlUGF0aCgpCiB7Cg==