120790 2013-09-05 13:17:24 -0700 Clean up wtf/Compiler.h 2013-09-05 14:00:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cmarcelo commit-queue oldest_to_newest 925185 0 andersca 2013-09-05 13:17:24 -0700 Clean up wtf/Compiler.h 925187 1 210653 andersca 2013-09-05 13:22:26 -0700 Created attachment 210653 Patch 925191 2 210653 kling 2013-09-05 13:27:54 -0700 Comment on attachment 210653 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210653&action=review > Source/WTF/ChangeLog:12 > + - Replace WTF_COMPILER_SUPPORTS_CXX_FINAL_CONTROL with a compiler quirk for versions of clang > + that have a buggy final implementation and fix a bug in the macro where final would be disabled > + for versions of clang where __clang_minor__ is less than 2, regardless of the major version. Whoops! > Source/WTF/wtf/Compiler.h:57 > +// Disable final on versions of Apple clang earlier than 4.2 to avoid bugs like http://webkit.org/b/119165 */ /* I think this file might need to be C compatible. */ 925199 3 andersca 2013-09-05 14:00:34 -0700 Committed r155146: <http://trac.webkit.org/changeset/155146> 210653 2013-09-05 13:22:26 -0700 2013-09-05 13:27:54 -0700 Patch bug-120790-20130905132226.patch text/plain 5386 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDY3MjFiYjY0NmZhZjA1NjU4N2Q2NWY0 ZmI1MDczZDcyNmIwYTRiMmUuLjA0OGQzODllZDIxZDQ2ZmU2ZjMyZmU4NDg1OWI1Y2YzZWFjMzZl ODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAKIDIwMTMtMDktMDUgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KIAorICAgICAgICBDbGVhbiB1cCB3dGYvQ29tcGlsZXIuaAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwNzkwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgLSBHZXQgcmlkIG9m IHRoZSBDTEFOR19QUkFHTUEgZGVmaW5lLCBpdCdzIG5vdCB1c2VkIGFueXdoZXJlLgorICAgICAg ICAtIFJlbW92ZSBhIHdvcmthcm91bmQgZm9yIGEgYnVnIGluIHRoZSB2ZXJzaW9uIG9mIGNsYW5n IHRoYXQgY2FtZSB3aXRoIFhjb2RlIDQuMi4KKyAgICAgICAgLSBSZXBsYWNlIFdURl9DT01QSUxF Ul9TVVBQT1JUU19DWFhfRklOQUxfQ09OVFJPTCB3aXRoIGEgY29tcGlsZXIgcXVpcmsgZm9yIHZl cnNpb25zIG9mIGNsYW5nCisgICAgICAgICAgdGhhdCBoYXZlIGEgYnVnZ3kgZmluYWwgaW1wbGVt ZW50YXRpb24gYW5kIGZpeCBhIGJ1ZyBpbiB0aGUgbWFjcm8gd2hlcmUgZmluYWwgd291bGQgYmUg ZGlzYWJsZWQKKyAgICAgICAgICBmb3IgdmVyc2lvbnMgb2YgY2xhbmcgd2hlcmUgX19jbGFuZ19t aW5vcl9fIGlzIGxlc3MgdGhhbiAyLCByZWdhcmRsZXNzIG9mIHRoZSBtYWpvciB2ZXJzaW9uLgor ICAgICAgICAtIEZhaWwgaWYgc29tZW9uZSB0cmllcyB0byBjb21waWxlIHRoZSBXZWJLaXQgc3Rh Y2sgd2l0aCBhIGNvbXBpbGVyIHRoYXQgZG9lc24ndCBzdXBwb3J0IHJ2YWx1ZQorICAgICAgICAg IHJlZmVyZW5jZXMgb3Igc3RhdGljX2Fzc2VydC4KKworICAgICAgICAqIHd0Zi9Db21waWxlci5o OgorCisyMDEzLTA5LTA1ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisK ICAgICAgICAgQ2hhbmdlIFN0cmluZ0J1ZmZlciBiYWNrIHRvIG5vdCB1c2UgYW4gT3duUHRyIGlu IGFuIGF0dGVtcHQgdG8gZml4IHBvcnRzLgogICAgICAgICAKICAgICAgICAgKiB3dGYvdGV4dC9T dHJpbmdCdWZmZXIuaDoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0NvbXBpbGVyLmggYi9T b3VyY2UvV1RGL3d0Zi9Db21waWxlci5oCmluZGV4IDhjYTY5ODMxZGQ5ZmU3MDc5YTUyZjNkMzI5 YzUxMzgzMjQzYTRhOGUuLjMxNWNlZjE1NWQ0MDU5ZjZmZjUwYWQ5NDNkMjYxZmVjNzJlYTU1YWIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0NvbXBpbGVyLmgKKysrIGIvU291cmNlL1dURi93 dGYvQ29tcGlsZXIuaApAQCAtNDEsMTYgKzQxLDkgQEAKICNpZiBkZWZpbmVkKF9fY2xhbmdfXykK ICNkZWZpbmUgV1RGX0NPTVBJTEVSX0NMQU5HIDEKIAotI2RlZmluZSBDTEFOR19QUkFHTUEoUFJB R01BKSBfUHJhZ21hKFBSQUdNQSkKLQogLyogU3BlY2lmaWMgY29tcGlsZXIgZmVhdHVyZXMgKi8K ICNkZWZpbmUgV1RGX0NPTVBJTEVSX1NVUFBPUlRTX0NYWF9WQVJJQURJQ19URU1QTEFURVMgX19o YXNfZmVhdHVyZShjeHhfdmFyaWFkaWNfdGVtcGxhdGVzKQotCi0vKiBUaGVyZSBpcyBhIGJ1ZyBp biBjbGFuZyB0aGF0IGNvbWVzIHdpdGggWGNvZGUgNC4yIHdoZXJlIEF0b21pY1N0cmluZ3MgY2Fu J3QgYmUgaW1wbGljaXRseSBjb252ZXJ0ZWQgdG8gU3RyaW5ncwotICAgaW4gdGhlIHByZXNlbmNl IG9mIG1vdmUgY29uc3RydWN0b3JzIGFuZC9vciBtb3ZlIGFzc2lnbm1lbnQgb3BlcmF0b3JzLiBU aGlzIGJ1ZyBoYXMgYmVlbiBmaXhlZCBpbiBYY29kZSA0LjMgY2xhbmcsIHNvIHdlCi0gICBjaGVj ayBmb3IgYm90aCBjeHhfcnZhbHVlX3JlZmVyZW5jZXMgYXMgd2VsbCBhcyB0aGUgdW5yZWxhdGVk IGN4eF9ub25zdGF0aWNfbWVtYmVyX2luaXQgZmVhdHVyZSB3aGljaCB3ZSBrbm93IHdhcyBhZGRl ZCBpbiA0LjMgKi8KLSNkZWZpbmUgV1RGX0NPTVBJTEVSX1NVUFBPUlRTX0NYWF9SVkFMVUVfUkVG RVJFTkNFUyBfX2hhc19mZWF0dXJlKGN4eF9ydmFsdWVfcmVmZXJlbmNlcykgJiYgX19oYXNfZmVh dHVyZShjeHhfbm9uc3RhdGljX21lbWJlcl9pbml0KQotCisjZGVmaW5lIFdURl9DT01QSUxFUl9T VVBQT1JUU19DWFhfUlZBTFVFX1JFRkVSRU5DRVMgX19oYXNfZmVhdHVyZShjeHhfcnZhbHVlX3Jl ZmVyZW5jZXMpCiAjZGVmaW5lIFdURl9DT01QSUxFUl9TVVBQT1JUU19DWFhfREVMRVRFRF9GVU5D VElPTlMgX19oYXNfZmVhdHVyZShjeHhfZGVsZXRlZF9mdW5jdGlvbnMpCiAjZGVmaW5lIFdURl9D T01QSUxFUl9TVVBQT1JUU19DWFhfTlVMTFBUUiBfX2hhc19mZWF0dXJlKGN4eF9udWxscHRyKQog I2RlZmluZSBXVEZfQ09NUElMRVJfU1VQUE9SVFNfQ1hYX0VYUExJQ0lUX0NPTlZFUlNJT05TIF9f aGFzX2ZlYXR1cmUoY3h4X2V4cGxpY2l0X2NvbnZlcnNpb25zKQpAQCAtNTgsMjMgKzUxLDE0IEBA CiAjZGVmaW5lIFdURl9DT01QSUxFUl9TVVBQT1JUU19DX1NUQVRJQ19BU1NFUlQgX19oYXNfZmVh dHVyZShjX3N0YXRpY19hc3NlcnQpCiAjZGVmaW5lIFdURl9DT01QSUxFUl9TVVBQT1JUU19DWFhf U1RBVElDX0FTU0VSVCBfX2hhc19mZWF0dXJlKGN4eF9zdGF0aWNfYXNzZXJ0KQogI2RlZmluZSBX VEZfQ09NUElMRVJfU1VQUE9SVFNfQ1hYX09WRVJSSURFX0NPTlRST0wgX19oYXNfZmVhdHVyZShj eHhfb3ZlcnJpZGVfY29udHJvbCkKLQotI2lmZGVmIF9fQVBQTEVfXwotLyogRW5hYmxlIGZpbmFs IG9ubHkgb24gY2xhbmcgNC4yIGFuZCBsYXRlciB0byBhdm9pZCBidWdzIGxpa2UgaHR0cDovL3dl YmtpdC5vcmcvYi8xMTkxNjUgKi8KLSNkZWZpbmUgQVBQTEVfQ0xBTkdfVkVSU0lPTl9BVF9MRUFT VChtYWpvciwgbWlub3IpIChkZWZpbmVkKF9fY2xhbmdfbWFqb3JfXykgJiYgX19jbGFuZ19tYWpv cl9fID49IG1ham9yICYmIF9fY2xhbmdfbWlub3JfXyA+PSBtaW5vcikKLSNkZWZpbmUgV1RGX0NP TVBJTEVSX1NVUFBPUlRTX0NYWF9GSU5BTF9DT05UUk9MIFdURl9DT01QSUxFUl9TVVBQT1JUU19D WFhfT1ZFUlJJREVfQ09OVFJPTCAmJiBBUFBMRV9DTEFOR19WRVJTSU9OX0FUX0xFQVNUKDQsIDIp Ci0jZWxzZQotLyogV2UgZG9uJ3Qga25vdyB3aGljaCB2ZXJzaW9ucyBvZiBjbGFuZyBoYXMgdGhl IGJ1ZyBtZW50aW9uZWQgYWJvdmUgc2luY2UgX19jbGFuZ19tYWpvcl9fIGFuZCBfX2NsYW5nX21p bm9yX18gYXJlIHZlbmRvciBkZXBlbmRlbnQgKi8KLSNkZWZpbmUgV1RGX0NPTVBJTEVSX1NVUFBP UlRTX0NYWF9GSU5BTF9DT05UUk9MIFdURl9DT01QSUxFUl9TVVBQT1JUU19DWFhfT1ZFUlJJREVf Q09OVFJPTAotI2VuZGlmCi0KLSNkZWZpbmUgV1RGX0NPTVBJTEVSX1NVUFBPUlRTX0hBU19UUklW SUFMX0RFU1RSVUNUT1IgX19oYXNfZmVhdHVyZShoYXNfdHJpdmlhbF9kZXN0cnVjdG9yKQogI2Rl ZmluZSBXVEZfQ09NUElMRVJfU1VQUE9SVFNfQ1hYX1NUUk9OR19FTlVNUyBfX2hhc19mZWF0dXJl KGN4eF9zdHJvbmdfZW51bXMpCiAjZGVmaW5lIFdURl9DT01QSUxFUl9TVVBQT1JUU19DWFhfUkVG RVJFTkNFX1FVQUxJRklFRF9GVU5DVElPTlMgX19oYXNfZmVhdHVyZShjeHhfcmVmZXJlbmNlX3F1 YWxpZmllZF9mdW5jdGlvbnMpCisKKy8vIERpc2FibGUgZmluYWwgb24gdmVyc2lvbnMgb2YgQXBw bGUgY2xhbmcgZWFybGllciB0aGFuIDQuMiB0byBhdm9pZCBidWdzIGxpa2UgaHR0cDovL3dlYmtp dC5vcmcvYi8xMTkxNjUgKi8KKyNpZiBkZWZpbmVkKF9fQVBQTEVfXykgJiYgKF9fY2xhbmdfbWFq b3JfXyA8IDQgfHwgKF9fY2xhbmdfbWFqb3JfXyA9PSA0ICYmIF9fY2xhbmdfbWlub3JfXyA8IDIp KQorI2RlZmluZSBXVEZfQ09NUElMRVJfUVVJUktfRklOQUxfSVNfQlVHR1kKICNlbmRpZgogCi0j aWZuZGVmIENMQU5HX1BSQUdNQQotI2RlZmluZSBDTEFOR19QUkFHTUEoUFJBR01BKQogI2VuZGlm CiAKIC8qIENPTVBJTEVSKE1TVkMpIC0gTWljcm9zb2Z0IFZpc3VhbCBDKysgKi8KQEAgLTkyLDcg Kzc2LDYgQEAKIAogI2lmICFDT01QSUxFUihDTEFORykKICNkZWZpbmUgV1RGX0NPTVBJTEVSX1NV UFBPUlRTX0NYWF9PVkVSUklERV9DT05UUk9MIDEKLSNkZWZpbmUgV1RGX0NPTVBJTEVSX1NVUFBP UlRTX0NYWF9GSU5BTF9DT05UUk9MIDEKICNkZWZpbmUgV1RGX0NPTVBJTEVSX1FVSVJLX0ZJTkFM X0lTX0NBTExFRF9TRUFMRUQgMQogI2VuZGlmCiAKQEAgLTE2MSw3ICsxNDQsNiBAQAogI2VuZGlm CiAjaWYgR0NDX1ZFUlNJT05fQVRfTEVBU1QoNCwgNywgMCkKICNkZWZpbmUgV1RGX0NPTVBJTEVS X1NVUFBPUlRTX0NYWF9PVkVSUklERV9DT05UUk9MIDEKLSNkZWZpbmUgV1RGX0NPTVBJTEVSX1NV UFBPUlRTX0NYWF9GSU5BTF9DT05UUk9MIDEKICNlbmRpZgogI2VuZGlmIC8qIGRlZmluZWQoX19H WFhfRVhQRVJJTUVOVEFMX0NYWDBYX18pIHx8IChkZWZpbmVkKF9fY3BsdXNwbHVzKSAmJiBfX2Nw bHVzcGx1cyA+PSAyMDExMDNMKSAqLwogI2VuZGlmIC8qIENPTVBJTEVSKEdDQykgKi8KQEAgLTE5 Myw2ICsxNzUsMTcgQEAKIAogLyogPT09PSBDb21waWxlciBmZWF0dXJlcyA9PT09ICovCiAKKy8q IFJlcXVpcmVkIEMrKzExIGZlYXR1cmVzLiBXZSBjYW4gcmVtb3ZlIHRoZXNlIG9uY2UgdGhleSd2 ZSBiZWVuIHJlcXVpcmVkIGZvciBzb21lIHRpbWUgKi8KKworI2lmZGVmIF9fY3BsdXNwbHVzCisj aWYgIUNPTVBJTEVSX1NVUFBPUlRTKENYWF9SVkFMVUVfUkVGRVJFTkNFUykKKyNlcnJvciAiUGxl YXNlIHVzZSBhIGNvbXBpbGVyIHRoYXQgc3VwcG9ydHMgQysrMTEgcnZhbHVlIHJlZmVyZW5jZXMu IgorI2VuZGlmCisjaWYgIUNPTVBJTEVSX1NVUFBPUlRTKENYWF9TVEFUSUNfQVNTRVJUKQorI2Vy cm9yICJQbGVhc2UgdXNlIGEgY29tcGlsZXIgdGhhdCBzdXBwb3J0cyBDKysxMSBzdGF0aWNfYXNz ZXJ0LiIKKyNlbmRpZgorI2VuZGlmCisKIC8qIEFMV0FZU19JTkxJTkUgKi8KIAogI2lmbmRlZiBB TFdBWVNfSU5MSU5FCkBAIC0yODIsNyArMjc1LDcgQEAKICNkZWZpbmUgT1ZFUlJJREUKICNlbmRp ZgogCi0jaWYgQ09NUElMRVJfU1VQUE9SVFMoQ1hYX0ZJTkFMX0NPTlRST0wpCisjaWYgQ09NUElM RVJfU1VQUE9SVFMoQ1hYX09WRVJSSURFX0NPTlRST0wpICYmICFDT01QSUxFUl9RVUlSSyhGSU5B TF9JU19CVUdHWSkKICNpZiBDT01QSUxFUl9RVUlSSyhGSU5BTF9JU19DQUxMRURfU0VBTEVEKQog I2RlZmluZSBGSU5BTCBzZWFsZWQKICNlbHNlCg==