120788 2013-09-05 12:43:11 -0700 [Qt][BlackBerry] Text track localized string functions are named wrong 2013-09-06 09:11:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 b.long webkit-unassigned b.long commit-queue pnormand oldest_to_newest 925168 0 b.long 2013-09-05 12:43:11 -0700 [Qt][BlackBerry] Text track localized string functions are named wrong 925169 1 210648 b.long 2013-09-05 12:44:51 -0700 Created attachment 210648 Patch This fixes the QtWebKitBuild with --video-track. I noticed BlackBerry had the same problem, so I fixed it there too. I'm going to look into building with --video-track by default and disabling it at runtime, since this comes up a lot. This specific case appears to have been caused by r155048. 925399 2 210648 pnormand 2013-09-05 22:21:28 -0700 Comment on attachment 210648 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210648&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). cq won't like this, please remove it. Also if no details are given about the specific changes please remove the lines below. 925603 3 210760 b.long 2013-09-06 08:54:51 -0700 Created attachment 210760 Fix ChangeLog 925616 4 210760 commit-queue 2013-09-06 09:11:33 -0700 Comment on attachment 210760 Fix ChangeLog Clearing flags on attachment: 210760 Committed r155190: <http://trac.webkit.org/changeset/155190> 925617 5 commit-queue 2013-09-06 09:11:35 -0700 All reviewed patches have been landed. Closing bug. 210648 2013-09-05 12:44:51 -0700 2013-09-06 08:54:48 -0700 Patch bug-120788-20130905134450.patch text/plain 2224 b.long U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTAxNzNkMWRmYTk3NDZh OGRkZTljMjg5YzEzN2I1M2ExYzUyMzU5Yi4uYTVhNjU2ODllYjM1OTQxNjE5MjdjY2MyYTcyZWJk Yzc1YTE3ODA0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA5LTA1ICBCcmVu ZGFuIExvbmcgIDxiLmxvbmdAY2FibGVsYWJzLmNvbT4KKworICAgICAgICBbUXRdW0JsYWNrQmVy cnldIFRleHQgdHJhY2sgbG9jYWxpemVkIHN0cmluZyBmdW5jdGlvbnMgYXJlIG5hbWVkIHdyb25n CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA3ODgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2JsYWNrYmVycnkvTG9jYWxpemVk U3RyaW5nc0JsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6dGV4dFRyYWNrT2ZmTWVu dUl0ZW1UZXh0KToKKyAgICAgICAgKFdlYkNvcmU6OnRleHRUcmFja0F1dG9tYXRpY01lbnVJdGVt VGV4dCk6CisgICAgICAgICogcGxhdGZvcm0vcXQvTG9jYWxpemVkU3RyaW5nc1F0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OnRleHRUcmFja09mZk1lbnVJdGVtVGV4dCk6CisgICAgICAgIChXZWJD b3JlOjp0ZXh0VHJhY2tBdXRvbWF0aWNNZW51SXRlbVRleHQpOgorCiAyMDEzLTA5LTA0ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgVmVjdG9yOjpyZWxl YXNlQnVmZmVyIHNob3VsZCByZXR1cm4gYW4gT3duUHRyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0xvY2FsaXplZFN0cmluZ3NCbGFja0JlcnJ5LmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvTG9jYWxpemVkU3RyaW5nc0JsYWNr QmVycnkuY3BwCmluZGV4IGEwYjIwZDA1ZTAzYTg1OTJmOWI5NzJlMDdiNTcyMTQyOTUxODJlMDQu LjQ4NWU0NjAwOGQxN2JmMjYzNzM2ZDA0NjAyODgyOGE2YzJhMzA3Y2IgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvTG9jYWxpemVkU3RyaW5nc0JsYWNrQmVy cnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvTG9jYWxpemVk U3RyaW5nc0JsYWNrQmVycnkuY3BwCkBAIC0zOTMsNyArMzkzLDEzIEBAIFN0cmluZyB0ZXh0VHJh Y2tTdWJ0aXRsZXNUZXh0KCkKICAgICByZXR1cm4gU3RyaW5nKCk7CiB9CiAKLVN0cmluZyB0ZXh0 VHJhY2tPZmZUZXh0KCkKK1N0cmluZyB0ZXh0VHJhY2tPZmZNZW51SXRlbVRleHQoKQoreworICAg IG5vdEltcGxlbWVudGVkKCk7CisgICAgcmV0dXJuIFN0cmluZygpOworfQorCitTdHJpbmcgdGV4 dFRyYWNrQXV0b21hdGljTWVudUl0ZW1UZXh0KCkKIHsKICAgICBub3RJbXBsZW1lbnRlZCgpOwog ICAgIHJldHVybiBTdHJpbmcoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L3F0L0xvY2FsaXplZFN0cmluZ3NRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9M b2NhbGl6ZWRTdHJpbmdzUXQuY3BwCmluZGV4IDViMGRlZmUyOWEwM2U1NDM2NGI0ZWJmMzg2MDAz YTBlMmZjNjkyYjMuLjMxZmVlMjA2MGU0YzdiOGRkZGM3NTMwZTljOWY4OGYwNjBkZmViOTggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L0xvY2FsaXplZFN0cmluZ3NRdC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvTG9jYWxpemVkU3RyaW5nc1F0LmNw cApAQCAtNzYyLDcgKzc2MiwxMyBAQCBTdHJpbmcgdGV4dFRyYWNrU3VidGl0bGVzVGV4dCgpCiAg ICAgcmV0dXJuIFN0cmluZygpOwogfQogCi1TdHJpbmcgdGV4dFRyYWNrT2ZmVGV4dCgpCitTdHJp bmcgdGV4dFRyYWNrT2ZmTWVudUl0ZW1UZXh0KCkKK3sKKyAgICBub3RJbXBsZW1lbnRlZCgpOwor ICAgIHJldHVybiBTdHJpbmcoKTsKK30KKworU3RyaW5nIHRleHRUcmFja0F1dG9tYXRpY01lbnVJ dGVtVGV4dCgpCiB7CiAgICAgbm90SW1wbGVtZW50ZWQoKTsKICAgICByZXR1cm4gU3RyaW5nKCk7 Cg== 210760 2013-09-06 08:54:51 -0700 2013-09-06 09:11:33 -0700 Fix ChangeLog bug-120788-20130906095450.patch text/plain 2207 b.long U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTBhOThmNzNhYzMxZmM3 MDQ2MDU5Y2RiNmY0ZjY4MzI3M2RiYzYzMi4uYjMxOWM2MjlhNWQ0NzQ0Mjk0ZDcyNTA3MWM0N2Ez NDM5M2ZiOTE1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA5LTA1ICBCcmVu ZGFuIExvbmcgIDxiLmxvbmdAY2FibGVsYWJzLmNvbT4KKworICAgICAgICBbUXRdW0JsYWNrQmVy cnldIFRleHQgdHJhY2sgbG9jYWxpemVkIHN0cmluZyBmdW5jdGlvbnMgYXJlIG5hbWVkIHdyb25n CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA3ODgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHJl bmFtZXMgdGV4dFRyYWNrT2ZmVGV4dCgpIHRvIHRleHRUcmFja09mZk1lbnVJdGVtVGV4dCgpLCBh bmQKKyAgICAgICAgYWRkcyB0ZXh0VHJhY2tBdXRvbWF0aWNNZW51SXRlbVRleHQoKSwgdG8gbWFr ZSB0aGVtIG1hdGNoIHRoZQorICAgICAgICBkZWZpbml0aW9ucyBpbiBMb2NhbGl6ZWRTdHJpbmdz LmguCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ibGFja2JlcnJ5L0xvY2FsaXplZFN0cmluZ3NCbGFj a0JlcnJ5LmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Mb2NhbGl6ZWRTdHJpbmdzUXQuY3Bw OgorCiAyMDEzLTA5LTA2ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGln aWEuY29tPgogCiAgICAgICAgIFtRdF1bV0syXSBDYWNoZWQgY3JlZGVudGlhbHMgbm90IGNsZWFy ZWQgYmV0d2VlbiB0ZXN0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxh Y2tiZXJyeS9Mb2NhbGl6ZWRTdHJpbmdzQmxhY2tCZXJyeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ibGFja2JlcnJ5L0xvY2FsaXplZFN0cmluZ3NCbGFja0JlcnJ5LmNwcAppbmRleCBh MGIyMGQwNWUwM2E4NTkyZjliOTcyZTA3YjU3MjE0Mjk1MTgyZTA0Li40ODVlNDYwMDhkMTdiZjI2 MzczNmQwNDYwMjg4MjhhNmMyYTMwN2NiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ibGFja2JlcnJ5L0xvY2FsaXplZFN0cmluZ3NCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0xvY2FsaXplZFN0cmluZ3NCbGFja0JlcnJ5 LmNwcApAQCAtMzkzLDcgKzM5MywxMyBAQCBTdHJpbmcgdGV4dFRyYWNrU3VidGl0bGVzVGV4dCgp CiAgICAgcmV0dXJuIFN0cmluZygpOwogfQogCi1TdHJpbmcgdGV4dFRyYWNrT2ZmVGV4dCgpCitT dHJpbmcgdGV4dFRyYWNrT2ZmTWVudUl0ZW1UZXh0KCkKK3sKKyAgICBub3RJbXBsZW1lbnRlZCgp OworICAgIHJldHVybiBTdHJpbmcoKTsKK30KKworU3RyaW5nIHRleHRUcmFja0F1dG9tYXRpY01l bnVJdGVtVGV4dCgpCiB7CiAgICAgbm90SW1wbGVtZW50ZWQoKTsKICAgICByZXR1cm4gU3RyaW5n KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9Mb2NhbGl6ZWRTdHJp bmdzUXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvTG9jYWxpemVkU3RyaW5nc1F0 LmNwcAppbmRleCA1YjBkZWZlMjlhMDNlNTQzNjRiNGViZjM4NjAwM2EwZTJmYzY5MmIzLi4zMWZl ZTIwNjBlNGM3YjhkZGRjNzUzMGU5YzlmODhmMDYwZGZlYjk4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9xdC9Mb2NhbGl6ZWRTdHJpbmdzUXQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3F0L0xvY2FsaXplZFN0cmluZ3NRdC5jcHAKQEAgLTc2Miw3ICs3NjIs MTMgQEAgU3RyaW5nIHRleHRUcmFja1N1YnRpdGxlc1RleHQoKQogICAgIHJldHVybiBTdHJpbmco KTsKIH0KIAotU3RyaW5nIHRleHRUcmFja09mZlRleHQoKQorU3RyaW5nIHRleHRUcmFja09mZk1l bnVJdGVtVGV4dCgpCit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICByZXR1cm4gU3RyaW5n KCk7Cit9CisKK1N0cmluZyB0ZXh0VHJhY2tBdXRvbWF0aWNNZW51SXRlbVRleHQoKQogewogICAg IG5vdEltcGxlbWVudGVkKCk7CiAgICAgcmV0dXJuIFN0cmluZygpOwo=