120787 2013-09-05 12:37:14 -0700 Make RenderBlock have a protected constructor. 2013-09-06 13:55:46 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt bdakin commit-queue esprehn+autocc glenn kondapallykalyan ossy oldest_to_newest 925161 0 hyatt 2013-09-05 12:37:14 -0700 Make RenderBlock have a protected constructor so that it cannot be instantiated directly. 925166 1 210647 hyatt 2013-09-05 12:41:57 -0700 Created attachment 210647 Patch 925172 2 hyatt 2013-09-05 12:46:44 -0700 Landed in r155141. 925313 3 bdakin 2013-09-05 17:29:38 -0700 I had to roll this out with http://trac.webkit.org/changeset/155162 because of the failing tests. 925384 4 ossy 2013-09-05 21:20:57 -0700 (In reply to comment #3) > I had to roll this out with http://trac.webkit.org/changeset/155162 because of the failing tests. Reopen, since it was rolled out. 925841 5 hyatt 2013-09-06 13:55:46 -0700 Re-landed this in r155211.. 210647 2013-09-05 12:41:57 -0700 2013-09-05 12:43:55 -0700 Patch patch.txt text/plain 4485 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NTE0MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEzLTA5LTA1ICBEYXZpZCBI eWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIFJlbmRlckJsb2NrIGhhdmUg YSBwcm90ZWN0ZWQgY29uc3RydWN0b3IuLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTIwNzg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIG5vYm9keSBjYW4gY3JlYXRlIGEgUmVuZGVyQmxv Y2sgZGlyZWN0bHkuIE1ha2Ugc3VyZSBSZW5kZXJCbG9ja0Zsb3dzCisgICAgICAgIGdldCBtYWRl IHdoZW4gYSBkaXNwbGF5OmJsb2NrL2lubGluZS1ibG9jay9jb21wYWN0L3J1bi1pbiBpcyBzZWVu LgorCisgICAgICAgICogaHRtbC9IVE1MRGV0YWlsc0VsZW1lbnQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SFRNTERldGFpbHNFbGVtZW50OjpjcmVhdGVSZW5kZXJlcik6CisgICAgICAgICogaHRt bC9IVE1MU3VtbWFyeUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFN1bW1hcnlF bGVtZW50OjpjcmVhdGVSZW5kZXJlcik6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2Nr LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpjcmVhdGVBbm9ueW1vdXMpOgor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5oOgorICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyT2JqZWN0OjpjcmVhdGVP YmplY3QpOgorCiAyMDEzLTA5LTA1ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAog ICAgICAgICBBZGQgbmV3IFJlbmRlckJsb2NrRmxvdyBjbGFzcwpJbmRleDogU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MRGV0YWlsc0VsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTERldGFpbHNFbGVtZW50LmNwcAkocmV2aXNpb24gMTU1MTM4KQorKysgU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MRGV0YWlsc0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yNyw3ICsyNyw3IEBACiAjaW5jbHVkZSAiSFRNTFN1bW1hcnlFbGVtZW50LmgiCiAjaW5jbHVk ZSAiTG9jYWxpemVkU3RyaW5ncy5oIgogI2luY2x1ZGUgIk1vdXNlRXZlbnQuaCIKLSNpbmNsdWRl ICJSZW5kZXJCbG9jay5oIgorI2luY2x1ZGUgIlJlbmRlckJsb2NrRmxvdy5oIgogI2luY2x1ZGUg IlNoYWRvd1Jvb3QuaCIKICNpbmNsdWRlICJUZXh0LmgiCiAKQEAgLTExMyw3ICsxMTMsNyBAQCBI VE1MRGV0YWlsc0VsZW1lbnQ6OkhUTUxEZXRhaWxzRWxlbWVudChjCiAKIFJlbmRlck9iamVjdCog SFRNTERldGFpbHNFbGVtZW50OjpjcmVhdGVSZW5kZXJlcihSZW5kZXJBcmVuYSogYXJlbmEsIFJl bmRlclN0eWxlKikKIHsKLSAgICByZXR1cm4gbmV3IChhcmVuYSkgUmVuZGVyQmxvY2sodGhpcyk7 CisgICAgcmV0dXJuIG5ldyAoYXJlbmEpIFJlbmRlckJsb2NrRmxvdyh0aGlzKTsKIH0KIAogdm9p ZCBIVE1MRGV0YWlsc0VsZW1lbnQ6OmRpZEFkZFVzZXJBZ2VudFNoYWRvd1Jvb3QoU2hhZG93Um9v dCogcm9vdCkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFN1bW1hcnlFbGVtZW50LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTdW1tYXJ5RWxlbWVudC5j cHAJKHJldmlzaW9uIDE1NTEzOCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFN1bW1hcnlF bGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzAsNyArMzAsNyBAQAogI2luY2x1ZGUgIk1v dXNlRXZlbnQuaCIKICNpbmNsdWRlICJOb2RlUmVuZGVyaW5nVHJhdmVyc2FsLmgiCiAjaW5jbHVk ZSAiUGxhdGZvcm1Nb3VzZUV2ZW50LmgiCi0jaW5jbHVkZSAiUmVuZGVyQmxvY2suaCIKKyNpbmNs dWRlICJSZW5kZXJCbG9ja0Zsb3cuaCIKICNpbmNsdWRlICJTaGFkb3dSb290LmgiCiAKIG5hbWVz cGFjZSBXZWJDb3JlIHsKQEAgLTY4LDcgKzY4LDcgQEAgSFRNTFN1bW1hcnlFbGVtZW50OjpIVE1M U3VtbWFyeUVsZW1lbnQoYwogCiBSZW5kZXJPYmplY3QqIEhUTUxTdW1tYXJ5RWxlbWVudDo6Y3Jl YXRlUmVuZGVyZXIoUmVuZGVyQXJlbmEqIGFyZW5hLCBSZW5kZXJTdHlsZSopCiB7Ci0gICAgcmV0 dXJuIG5ldyAoYXJlbmEpIFJlbmRlckJsb2NrKHRoaXMpOworICAgIHJldHVybiBuZXcgKGFyZW5h KSBSZW5kZXJCbG9ja0Zsb3codGhpcyk7CiB9CiAKIGJvb2wgSFRNTFN1bW1hcnlFbGVtZW50Ojpj aGlsZFNob3VsZENyZWF0ZVJlbmRlcmVyKGNvbnN0IE5vZGUqIGNoaWxkKSBjb25zdApJbmRleDog U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCShyZXZpc2lvbiAxNTUxMzkp CisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yMzcsNyArMjM3LDcgQEAgUmVuZGVyQmxvY2s6On5SZW5kZXJCbG9jaygpCiAKIFJl bmRlckJsb2NrKiBSZW5kZXJCbG9jazo6Y3JlYXRlQW5vbnltb3VzKERvY3VtZW50KiBkb2N1bWVu dCkKIHsKLSAgICBSZW5kZXJCbG9jayogcmVuZGVyZXIgPSBuZXcgKGRvY3VtZW50LT5yZW5kZXJB cmVuYSgpKSBSZW5kZXJCbG9jaygwKTsKKyAgICBSZW5kZXJCbG9jayogcmVuZGVyZXIgPSBuZXcg KGRvY3VtZW50LT5yZW5kZXJBcmVuYSgpKSBSZW5kZXJCbG9ja0Zsb3coMCk7CiAgICAgcmVuZGVy ZXItPnNldERvY3VtZW50Rm9yQW5vbnltb3VzKGRvY3VtZW50KTsKICAgICByZXR1cm4gcmVuZGVy ZXI7CiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaAkocmV2aXNp b24gMTU1MTM5KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgJKHdv cmtpbmcgY29weSkKQEAgLTg5LDkgKzg5LDExIEBAIHB1YmxpYzoKICAgICB0ZW1wbGF0ZSA8Y2xh c3M+IGZyaWVuZCBzdHJ1Y3QgVmFsdWVUb1N0cmluZzsKICNlbmRpZgogCitwcm90ZWN0ZWQ6CiAg ICAgZXhwbGljaXQgUmVuZGVyQmxvY2soQ29udGFpbmVyTm9kZSopOwogICAgIHZpcnR1YWwgflJl bmRlckJsb2NrKCk7CiAKK3B1YmxpYzoKICAgICBzdGF0aWMgUmVuZGVyQmxvY2sqIGNyZWF0ZUFu b255bW91cyhEb2N1bWVudCopOwogCiAgICAgUmVuZGVyT2JqZWN0KiBmaXJzdENoaWxkKCkgY29u c3QgeyBBU1NFUlQoY2hpbGRyZW4oKSA9PSB2aXJ0dWFsQ2hpbGRyZW4oKSk7IHJldHVybiBjaGls ZHJlbigpLT5maXJzdENoaWxkKCk7IH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJPYmplY3QuY3BwCShyZXZpc2lvbiAxNTUxMzkpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjA3LDcgKzIwNyw3IEBA IFJlbmRlck9iamVjdCogUmVuZGVyT2JqZWN0OjpjcmVhdGVPYmplY3QKICAgICBjYXNlIENPTVBB Q1Q6CiAgICAgICAgIGlmICgoIXN0eWxlLT5oYXNBdXRvQ29sdW1uQ291bnQoKSB8fCAhc3R5bGUt Pmhhc0F1dG9Db2x1bW5XaWR0aCgpKSAmJiBkb2N1bWVudC5yZWdpb25CYXNlZENvbHVtbnNFbmFi bGVkKCkpCiAgICAgICAgICAgICByZXR1cm4gbmV3IChhcmVuYSkgUmVuZGVyTXVsdGlDb2x1bW5C bG9jayhlbGVtZW50KTsKLSAgICAgICAgcmV0dXJuIG5ldyAoYXJlbmEpIFJlbmRlckJsb2NrKGVs ZW1lbnQpOworICAgICAgICByZXR1cm4gbmV3IChhcmVuYSkgUmVuZGVyQmxvY2tGbG93KGVsZW1l bnQpOwogICAgIGNhc2UgTElTVF9JVEVNOgogICAgICAgICByZXR1cm4gbmV3IChhcmVuYSkgUmVu ZGVyTGlzdEl0ZW0oZWxlbWVudCk7CiAgICAgY2FzZSBUQUJMRToK