120775 2013-09-05 08:31:24 -0700 [Qt][WK2] Cached credentials not cleared between tests 2013-09-06 03:10:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 118232 1 allan.jensen allan.jensen abecsi cmarcelo commit-queue jturcotte kadam menard oldest_to_newest 925044 0 allan.jensen 2013-09-05 08:31:24 -0700 Some xmlhttprequests tests are flaky because they end up reusing credentials from earlier tests. The underlying problem is that QNetworkAccessManager has an internal cache of credentials that is never cleared between tests. 925048 1 210618 allan.jensen 2013-09-05 08:32:38 -0700 Created attachment 210618 Patch Patch moved from bug 118232 925057 2 210618 allan.jensen 2013-09-05 08:42:13 -0700 Comment on attachment 210618 Patch Unsetting review. Based on the output from http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release%20-%20Qt5.1%20-%20WebKit2/builds/1286 this patch appears to cause 200-300ms slower tests on all tests outside the fast directory. 925064 3 210624 allan.jensen 2013-09-05 09:06:10 -0700 Created attachment 210624 Patch 925463 4 210624 jturcotte 2013-09-06 02:42:03 -0700 Comment on attachment 210624 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210624&action=review r=me I don't like starting to pollute this file with platform code, but I can't think of a better place to do this. > Source/WebCore/testing/Internals.cpp:282 > + QNetworkAccessManager* qnam = context->networkAccessManager(); > + if (qnam) > + qnam->clearAccessCache(); Nit: Could be shrunk to "if (QNetworkAccessManager* qnam = context->networkAccessManager())". 925479 5 allan.jensen 2013-09-06 03:10:34 -0700 Committed r155183: <http://trac.webkit.org/changeset/155183> 210618 2013-09-05 08:32:38 -0700 2013-09-05 09:06:02 -0700 Patch bug-118232-20130904182026.patch text/plain 3869 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MDQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmQ3MGM2OTFjNmFiMTRh MjYyMTcyZTU5MzFiMDhmODQ3OWExODYwZS4uOWJhZTAzMDJiM2FmYTAzZTA4NGQwNWJmMDJkNDY3 NTk4ZGJhYWI5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA5LTA0ICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtR dF1bV2syXSBNYW55IHRlc3RzIGFyZSBmYWlsaW5nIHdpdGggZmxha3kgb24gUXQgNS4xLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MjMyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVtZW50IHBs YXRmb3JtQ2xlYXJSZXNvdXJjZUNhY2hlcywgc28gd2UgY2FuIGNsZWFyIHRoZSBjcmVkZW50aWFs cyBhbmQgcmVzb3VyY2VzCisgICAgICAgIGNhY2hlZCBpbiBRTmV0d29ya0FjY2Vzc01hbmFnZXIg d2hlbiBXZWJLaXRUZXN0UnVubmVyIHJlcXVlc3RzIGl0LgorCisgICAgICAgICogV2ViUHJvY2Vz cy9xdC9XZWJQcm9jZXNzUXQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzOjpwbGF0 Zm9ybUNsZWFyUmVzb3VyY2VDYWNoZXMpOgorCiAyMDEzLTA5LTA0ICBaYW4gRG9iZXJzZWsgIDx6 ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBBZGQgc3VwcG9ydCBmb3IgdGhl IFdheWxhbmQgYnVpbGQgdGFyZ2V0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL3F0L1dlYlByb2Nlc3NRdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1dl YlByb2Nlc3NRdC5jcHAKaW5kZXggMGRjYWY5ZDE3M2NjODc1YjI4MWI3NDA2OTNiMTcwNDBlZTI0 ZTc4YS4uOTkwMTFmYTg5ZWNhNmQyNmEzZTI0NTE1NDNhYzFiNDYyNDJlYjI3YSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzUXQuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQvV2ViUHJvY2Vzc1F0LmNwcApAQCAtOTIsOCArOTIs MTQgQEAgdm9pZCBXZWJQcm9jZXNzOjpwbGF0Zm9ybVNldENhY2hlTW9kZWwoQ2FjaGVNb2RlbCBj YWNoZU1vZGVsKQogICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQgaHlicmlkIGluLW1lbW9yeS0gYW5k IGRpc2stY2FjaGluZyBhcyBlLmcuIHRoZSBNYWMgcG9ydCBkb2VzLgogfQogCi12b2lkIFdlYlBy b2Nlc3M6OnBsYXRmb3JtQ2xlYXJSZXNvdXJjZUNhY2hlcyhSZXNvdXJjZUNhY2hlc1RvQ2xlYXIp Cit2b2lkIFdlYlByb2Nlc3M6OnBsYXRmb3JtQ2xlYXJSZXNvdXJjZUNhY2hlcyhSZXNvdXJjZUNh Y2hlc1RvQ2xlYXIgcmVzb3VyY2VzVG9DbGVhcikKIHsKKyAgICBtX25ldHdvcmtBY2Nlc3NNYW5h Z2VyLT5jbGVhckFjY2Vzc0NhY2hlKCk7CisgICAgaWYgKHJlc291cmNlc1RvQ2xlYXIgPT0gSW5N ZW1vcnlSZXNvdXJjZUNhY2hlc09ubHkpCisgICAgICAgIHJldHVybjsKKworICAgIGlmIChRQWJz dHJhY3ROZXR3b3JrQ2FjaGUqIGNhY2hlID0gbV9uZXR3b3JrQWNjZXNzTWFuYWdlci0+Y2FjaGUo KSkKKyAgICAgICAgY2FjaGUtPmNsZWFyKCk7CiB9CiAKICNpZiBkZWZpbmVkKFFfT1NfTUFDWCkK ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzNzE4 MGM1NjQ0MWI0MTYzMjAyM2ExZmZjNjc0ZmNhYWVmMDA1OWI1Li4wZWRhN2RhNjdkNTA5ZGMyMWRh Yjc3M2I4NTA2YmU4Y2Y1NGViMDAyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDktMDQgIEFsbGFuIFNhbmRm ZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CisKKyAgICAgICAgW1F0XVtXazJd IE1hbnkgdGVzdHMgYXJlIGZhaWxpbmcgd2l0aCBmbGFreSBvbiBRdCA1LjEuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTgyMzIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHN1cmUgd2UgZXhwbGlj aXRseSBjbGVhciB0aGUgbWVtb3J5IGNhY2hlIGJldHdlZW4gdGVzdHMuCisKKyAgICAgICAgKiBX ZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdUUjo6VGVzdENv bnRyb2xsZXI6OnJlc2V0U3RhdGVUb0NvbnNpc3RlbnRWYWx1ZXMpOgorCiAyMDEzLTA5LTA0ICBL cnp5c3p0b2YgQ3plY2ggIDxrLmN6ZWNoQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtBVEtdIEFk ZHMgYW4gYWNjZXNzaWJpbGl0eSBzdXBwb3J0IHRvIGFjY2VzcyBhIHZhbHVlIG9mIHRoZSBjb2xv ciBjb250cm9sIGVsZW1lbnQKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVz dENvbnRyb2xsZXIuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5j cHAKaW5kZXggZDY5MWFjZDA1MjI2NGI5ODk5MGM5ZTRlZjgxZWQ0OGViY2FhNjkyMS4uZWQ1YTM5 MGY3ODk3Y2Y3YTNlYzY4N2NmYWE0MTAwNjI0ZWRiYzdiZCAxMDA2NDQKLS0tIGEvVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci9UZXN0Q29udHJvbGxlci5jcHAKQEAgLTQyLDYgKzQyLDcgQEAKICNpbmNsdWRlIDxXZWJL aXQyL1dLUGFnZUdyb3VwLmg+CiAjaW5jbHVkZSA8V2ViS2l0Mi9XS1BhZ2VQcml2YXRlLmg+CiAj aW5jbHVkZSA8V2ViS2l0Mi9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5oPgorI2luY2x1ZGUgPFdlYktp dDIvV0tSZXNvdXJjZUNhY2hlTWFuYWdlci5oPgogI2luY2x1ZGUgPFdlYktpdDIvV0tSZXRhaW5Q dHIuaD4KICNpbmNsdWRlIDxhbGdvcml0aG0+CiAjaW5jbHVkZSA8Y3N0ZGlvPgpAQCAtNTM5LDYg KzU0MCwxMiBAQCBib29sIFRlc3RDb250cm9sbGVyOjpyZXNldFN0YXRlVG9Db25zaXN0ZW50VmFs dWVzKCkKICAgICBXS0NvbnRleHRTZXRTaG91bGRVc2VGb250U21vb3RoaW5nKFRlc3RDb250cm9s bGVyOjpzaGFyZWQoKS5jb250ZXh0KCksIGZhbHNlKTsKIAogICAgIFdLQ29udGV4dFNldENhY2hl TW9kZWwoVGVzdENvbnRyb2xsZXI6OnNoYXJlZCgpLmNvbnRleHQoKSwga1dLQ2FjaGVNb2RlbERv Y3VtZW50QnJvd3Nlcik7CisjaWYgUExBVEZPUk0oUVQpCisgICAgLy8gU2V0Q2FjaGVNb2RlbCBv bmx5IGNhdXNlcyBhIGNsZWFyaW5nIG9mIGNhY2hlIGlmIHRoZSBjYWNoZU1vZGVsIGFjdHVhbGx5 IGNoYW5nZXMsIGFuZCBmb3IgUXQgd2UgbmVlZCB0aGUKKyAgICAvLyBtZW1vcnkgY2FjaGUgY2xl YXJlZCAgYmV0d2VlbiB0ZXN0cyB0byBnZXQgcmlkIG9mIGNhY2hlZCBjcmVkZW50aWFscyBpbiBR TmV0d29ya0FjY2Vzc01hbmFnZXIuCisgICAgV0tSZXNvdXJjZUNhY2hlTWFuYWdlclJlZiBjYWNo ZU1hbmFnZXIgPSBXS0NvbnRleHRHZXRSZXNvdXJjZUNhY2hlTWFuYWdlcihUZXN0Q29udHJvbGxl cjo6c2hhcmVkKCkuY29udGV4dCgpKTsKKyAgICBXS1Jlc291cmNlQ2FjaGVNYW5hZ2VyQ2xlYXJD YWNoZUZvckFsbE9yaWdpbnMoY2FjaGVNYW5hZ2VyLCBXS1Jlc291cmNlQ2FjaGVzVG9DbGVhcklu TWVtb3J5T25seSk7CisjZW5kaWYKIAogICAgIC8vIEZJWE1FOiBUaGlzIGZ1bmN0aW9uIHNob3Vs ZCBhbHNvIGVuc3VyZSB0aGF0IHRoZXJlIGlzIG9ubHkgb25lIHBhZ2Ugb3Blbi4KIAo= 210624 2013-09-05 09:06:10 -0700 2013-09-06 02:42:02 -0700 Patch bug-120775-20130905180609.patch text/plain 1857 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MDQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzFiZDgyOTUwNDIzMDgz NmFlOTYyNzYyMTYyYTY1ZjU5OTAwNTNmNC4uMTY0MWZjY2ZlZTFjYWVkNDFjODE2Yjg1ZjEwNWRj YWQwZGQ0MDdhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA5LTA1ICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtR dF1bV0syXSBDYWNoZWQgY3JlZGVudGlhbHMgbm90IGNsZWFyZWQgYmV0d2VlbiB0ZXN0cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwNzc1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2xlYXIgdGhlIGFj Y2VzcyBjcmVkZW50aWFscyB3aGVuIHJlc2V0dGluZyB0aGUgc3RhdGUgb2YgYSBwYWdlIGZvciB0 ZXN0aW5nLgorCisgICAgICAgICogdGVzdGluZy9JbnRlcm5hbHMuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SW50ZXJuYWxzOjpyZXNldFRvQ29uc2lzdGVudFN0YXRlKToKKwogMjAxMy0wOS0wNCAg S3J6eXN6dG9mIEN6ZWNoICA8ay5jemVjaEBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbQVRLXSBB ZGRzIGFuIGFjY2Vzc2liaWxpdHkgc3VwcG9ydCB0byBhY2Nlc3MgYSB2YWx1ZSBvZiB0aGUgY29s b3IgY29udHJvbCBlbGVtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0lu dGVybmFscy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKaW5kZXgg YWQ4YWRjZDgyMzZkMTcyN2EwMWUwZDg1ZmNhYTM3YTgwNTlmZThmZC4uM2RjZDgwMDM4Mjg2Y2Vi ZjI0NDg3M2VlYWM4ZGFmNGYxNWE3YTQ3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVz dGluZy9JbnRlcm5hbHMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxz LmNwcApAQCAtMTQ4LDYgKzE0OCwxMSBAQAogI2luY2x1ZGUgIlZpYnJhdGlvbi5oIgogI2VuZGlm CiAKKyNpZiBQTEFURk9STShRVCkKKyNpbmNsdWRlICJOZXR3b3JraW5nQ29udGV4dC5oIgorI2lu Y2x1ZGUgPFFOZXR3b3JrQWNjZXNzTWFuYWdlcj4KKyNlbmRpZgorCiBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAKIHVzaW5nIG5hbWVzcGFjZSBIVE1MTmFtZXM7CkBAIC0yNjksNiArMjc0LDE0IEBAIHZv aWQgSW50ZXJuYWxzOjpyZXNldFRvQ29uc2lzdGVudFN0YXRlKFBhZ2UqIHBhZ2UpCiAgICAgICAg IHBhZ2UtPm1haW5GcmFtZSgpLmVkaXRvcigpLnRvZ2dsZUNvbnRpbnVvdXNTcGVsbENoZWNraW5n KCk7CiAgICAgaWYgKHBhZ2UtPm1haW5GcmFtZSgpLmVkaXRvcigpLmlzT3ZlcndyaXRlTW9kZUVu YWJsZWQoKSkKICAgICAgICAgcGFnZS0+bWFpbkZyYW1lKCkuZWRpdG9yKCkudG9nZ2xlT3Zlcndy aXRlTW9kZUVuYWJsZWQoKTsKKworI2lmIFBMQVRGT1JNKFFUKQorICAgIGlmIChOZXR3b3JraW5n Q29udGV4dCogY29udGV4dCA9IHBhZ2UtPm1haW5GcmFtZSgpLmxvYWRlcigpLm5ldHdvcmtpbmdD b250ZXh0KCkpIHsKKyAgICAgICAgUU5ldHdvcmtBY2Nlc3NNYW5hZ2VyKiBxbmFtID0gY29udGV4 dC0+bmV0d29ya0FjY2Vzc01hbmFnZXIoKTsKKyAgICAgICAgaWYgKHFuYW0pCisgICAgICAgICAg ICBxbmFtLT5jbGVhckFjY2Vzc0NhY2hlKCk7CisgICAgfQorI2VuZGlmCiB9CiAKIEludGVybmFs czo6SW50ZXJuYWxzKERvY3VtZW50KiBkb2N1bWVudCkK