120767 2013-09-05 05:24:24 -0700 Remove String(RefPtr<StringImpl>) constructor 2013-09-05 07:30:33 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov andersca benjamin cmarcelo commit-queue kling oldest_to_newest 924973 0 mikhail.pozdnyakov 2013-09-05 05:24:24 -0700 The String(RefPtr<StringImpl>) constructor should be removed for the following reasons: 1) It almost does not have clients, so it is unneeded. 2) RefPtr should never be passed by value 924974 1 210604 mikhail.pozdnyakov 2013-09-05 05:28:15 -0700 Created attachment 210604 patch 925008 2 210604 andersca 2013-09-05 07:03:59 -0700 Comment on attachment 210604 patch Nice! Of course, when we start dabbling with move semantics we'll probably end up changing the constructor that takes a PassRefPtr back into a RefPtr constructor ;) 925022 3 210604 commit-queue 2013-09-05 07:30:31 -0700 Comment on attachment 210604 patch Clearing flags on attachment: 210604 Committed r155115: <http://trac.webkit.org/changeset/155115> 925023 4 commit-queue 2013-09-05 07:30:33 -0700 All reviewed patches have been landed. Closing bug. 210604 2013-09-05 05:28:15 -0700 2013-09-05 07:30:31 -0700 patch bug120767 text/plain 2017 mikhail.pozdnyakov Y29tbWl0IGE2ZjVkYWUwYmNjOTJiMWExNGU2NTdkNDY0YmVhYzI5ZjUzMzJlZDcKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg VGh1IFNlcCA1IDE1OjI3OjEyIDIwMTMgKzAzMDAKCiAgICBidWcxMjA3NjcKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDhkMGI1 Y2UuLmI2MzljOGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTMtMDktMDUgIE1pa2hhaWwgUG96 ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CisKKyAgICAgICAgUmVtb3Zl IFN0cmluZyhSZWZQdHI8U3RyaW5nSW1wbD4pIGNvbnN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA3NjcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgU3RyaW5nKFJlZlB0cjxTdHJpbmdJ bXBsPikgY29uc3RydWN0b3Igc2hvdWxkIGJlIHJlbW92ZWQgZm9yIHRoZSBmb2xsb3dpbmcgcmVh c29uczoKKyAgICAgICAgLSBJdCBhbG1vc3QgZG9lcyBub3QgaGF2ZSBjbGllbnRzLCBzbyBpdCBp cyB1bm5lZWRlZC4KKyAgICAgICAgLSBSZWZQdHIgc2hvdWxkIG5ldmVyIGJlIHBhc3NlZCBieSB2 YWx1ZQorCisgICAgICAgICogd3RmL3RleHQvU3RyaW5nQnVpbGRlci5jcHA6CisgICAgICAgIChX VEY6OlN0cmluZ0J1aWxkZXI6OnNocmlua1RvRml0KToKKyAgICAgICAgKiB3dGYvdGV4dC9XVEZT dHJpbmcuaDoKKwogMjAxMy0wOS0wMyAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgog CiAgICAgICAgIENvZGVCbG9jayBtZW1vcnkgY29zdCByZXBvcnRpbmcgc2hvdWxkIGJlIHJhdGlv bmFsaXplZApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmNw cCBiL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nQnVpbGRlci5jcHAKaW5kZXggODFlNWQyNy4u NzQ1YmNhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmNw cAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuY3BwCkBAIC0zNDEsOCAr MzQxLDcgQEAgdm9pZCBTdHJpbmdCdWlsZGVyOjpzaHJpbmtUb0ZpdCgpCiAgICAgICAgICAgICBy ZWFsbG9jYXRlQnVmZmVyPExDaGFyPihtX2xlbmd0aCk7CiAgICAgICAgIGVsc2UKICAgICAgICAg ICAgIHJlYWxsb2NhdGVCdWZmZXI8VUNoYXI+KG1fbGVuZ3RoKTsKLSAgICAgICAgbV9zdHJpbmcg PSBtX2J1ZmZlcjsKLSAgICAgICAgbV9idWZmZXIgPSAwOworICAgICAgICBtX3N0cmluZyA9IG1f YnVmZmVyLnJlbGVhc2UoKTsKICAgICB9CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3Rm L3RleHQvV1RGU3RyaW5nLmggYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmluZy5oCmluZGV4 IDAzZmI3MjcuLmM4Mzk3Y2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvV1RGU3Ry aW5nLmgKKysrIGIvU291cmNlL1dURi93dGYvdGV4dC9XVEZTdHJpbmcuaApAQCAtMTI4LDcgKzEy OCw2IEBAIHB1YmxpYzoKICAgICAvLyBDb25zdHJ1Y3QgYSBzdHJpbmcgcmVmZXJlbmNpbmcgYW4g ZXhpc3RpbmcgU3RyaW5nSW1wbC4KICAgICBTdHJpbmcoU3RyaW5nSW1wbCogaW1wbCkgOiBtX2lt cGwoaW1wbCkgeyB9CiAgICAgU3RyaW5nKFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gaW1wbCkgOiBt X2ltcGwoaW1wbCkgeyB9Ci0gICAgU3RyaW5nKFJlZlB0cjxTdHJpbmdJbXBsPiBpbXBsKSA6IG1f aW1wbChpbXBsKSB7IH0KIAogICAgIC8vIENvbnN0cnVjdCBhIHN0cmluZyBmcm9tIGEgY29uc3Rh bnQgc3RyaW5nIGxpdGVyYWwuCiAgICAgV1RGX0VYUE9SVF9TVFJJTkdfQVBJIFN0cmluZyhBU0NJ SUxpdGVyYWwgY2hhcmFjdGVycyk7Cg==