120764 2013-09-05 03:58:05 -0700 [Win][WebGL] Crash on exit 2013-10-04 09:51:13 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC Unspecified RESOLVED FIXED http://media.tojicode.com/q3bsp/ PlatformOnly P2 Normal --- 0 peavo webkit-unassigned achristensen bfulgham commit-queue mrobinson oldest_to_newest 924959 0 peavo 2013-09-05 03:58:05 -0700 Everytime I have visited a page with WebGL content, I get a crash on exit (NULL pointer access violation). I believe the reason for the crash is that the libGLESv2.dll is detached from the process at exit, and releases relevant memory, and then the atexit cleanup routine is called afterwards, accessing the released memory. This is the stacktrace I'm getting: libGLESv2.dll!0588787f() [Frames below may be incorrect and/or missing, no symbols loaded for libGLESv2.dll] libGLESv2.dll!05893fdc() WebKit.dll!WebCore::GLContextEGL::~GLContextEGL() Line 236 C++ WebKit.dll!WebCore::GLContextEGL::`scalar deleting destructor'() + 0xb bytes C++ WebKit.dll!WebCore::GLContext::cleanupActiveContextsAtExit() Line 140 C++ WebKit.dll!_CRT_INIT(void * hDllHandle, unsigned long dwReason, void * lpreserved) Line 415 C WebKit.dll!__DllMainCRTStartup(void * hDllHandle, unsigned long dwReason, void * lpreserved) Line 526 + 0x8 bytes C WebKit.dll!_DllMainCRTStartup(void * hDllHandle, unsigned long dwReason, void * lpreserved) Line 476 + 0xe bytes C 924960 1 210598 peavo 2013-09-05 04:09:08 -0700 Created attachment 210598 Patch 935972 2 mrobinson 2013-10-03 14:14:02 -0700 Nice catch. This can probably be surrounded by PLATFORM(X11) actually. Looks like the activeContextList is unused otherwise? That can go into the #ifdef as well, i guess. 936174 3 213356 peavo 2013-10-04 06:13:33 -0700 Created attachment 213356 Patch 936175 4 peavo 2013-10-04 06:14:55 -0700 (In reply to comment #2) > Nice catch. This can probably be surrounded by PLATFORM(X11) actually. Looks like the activeContextList is unused otherwise? That can go into the #ifdef as well, i guess. Thanks for looking into this, I have updated the patch accordingly :) This should also reduce code size for other platforms. 936210 5 213356 mrobinson 2013-10-04 09:10:44 -0700 Comment on attachment 213356 Patch Thanks! 936215 6 213356 commit-queue 2013-10-04 09:14:14 -0700 Comment on attachment 213356 Patch Clearing flags on attachment: 213356 Committed r156893: <http://trac.webkit.org/changeset/156893> 936216 7 commit-queue 2013-10-04 09:14:16 -0700 All reviewed patches have been landed. Closing bug. 936219 8 peavo 2013-10-04 09:51:13 -0700 (In reply to comment #5) > (From update of attachment 213356 [details]) > Thanks! Thanks for reviewing ;) 210598 2013-09-05 04:09:08 -0700 2013-10-04 06:13:26 -0700 Patch bug-120764-20130905130855.patch text/plain 1619 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NTEwOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA5LTA1ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5dW1dlYkdMXSBD cmFzaCBvbiBleGl0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjA3NjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBPbiBleGl0LCBsaWJHTEVTdjIuZGxsIGlzIGRldGFjaGVkIGZyb20gdGhlIHByb2Nlc3Mg YW5kIHJlbGV2YW50IG1lbW9yeSBpcyByZWxlYXNlZAorICAgICAgICBiZWZvcmUgdGhlIGF0ZXhp dCBjbGVhbnVwIGhhbmRsZXIgaXMgY2FsbGVkLCBjYXVzaW5nIGEgTlVMTCBwb2ludGVyIGNyYXNo LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR0xDb250ZXh0LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkdMQ29udGV4dDo6YWRkQWN0aXZlQ29udGV4dCk6IERvbid0IGFkZCB0aGUgYXRl eGl0IGNsZWFudXAgaGFuZGxlciBvbiBXaW5kb3dzLgorCiAyMDEzLTA5LTA1ICBNaWhuZWEgT3Zp ZGVuaWUgIDxtaWhuZWFAYWRvYmUuY29tPgogCiAgICAgICAgIFJlcGxhY2Ugbm9kZSgpIGNhbGxz IHdpdGggZ2VuZXJhdGluZ05vZGUoKSBmb3IgUmVuZGVyUmVnaW9uIGNvZGUKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dMQ29udGV4dC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR0xDb250ZXh0LmNwcAkocmV2aXNpb24g MTU1MDk4KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR0xDb250ZXh0LmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTA5LDExICsxMDksMTUgQEAgc3RhdGljIEFjdGl2ZUNvbnRl eHRMaXN0JiBhY3RpdmVDb250ZXh0TAogCiB2b2lkIEdMQ29udGV4dDo6YWRkQWN0aXZlQ29udGV4 dChHTENvbnRleHQqIGNvbnRleHQpCiB7CisvLyBDYXVzZXMgY3Jhc2ggb24gZXhpdCBvbiBXaW5k b3dzIGJlY2F1c2UgbGliR0xFU3YyLmRsbCBpcyBkZXRhY2hlZCwKKy8vIGFuZCByZWxldmFudCBt ZW1vcnkgaXMgcmVsZWFzZWQgYmVmb3JlIHRoZSBhdGV4aXQgaGFuZGxlciBpcyBjYWxsZWQuCisj aWYgIVBMQVRGT1JNKFdJTikKICAgICBzdGF0aWMgYm9vbCBhZGRlZEF0RXhpdEhhbmRsZXIgPSBm YWxzZTsKICAgICBpZiAoIWFkZGVkQXRFeGl0SGFuZGxlcikgewogICAgICAgICBhdGV4aXQoJkdM Q29udGV4dDo6Y2xlYW51cEFjdGl2ZUNvbnRleHRzQXRFeGl0KTsKICAgICAgICAgYWRkZWRBdEV4 aXRIYW5kbGVyID0gdHJ1ZTsKICAgICB9CisjZW5kaWYKICAgICBhY3RpdmVDb250ZXh0TGlzdCgp LmFwcGVuZChjb250ZXh0KTsKIH0KIAo= 213356 2013-10-04 06:13:33 -0700 2013-10-04 09:14:14 -0700 Patch bug-120764-20131004151322.patch text/plain 2606 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1Njg4NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTEwLTA0ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5dW1dlYkdMXSBD cmFzaCBvbiBleGl0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjA3NjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBPbiBleGl0LCBsaWJHTEVTdjIuZGxsIGlzIGRldGFjaGVkIGZyb20gdGhlIHByb2Nlc3Mg YW5kIHJlbGV2YW50IG1lbW9yeSBpcyByZWxlYXNlZAorICAgICAgICBiZWZvcmUgdGhlIGF0ZXhp dCBHTCBjb250ZXh0IGNsZWFudXAgaGFuZGxlciBpcyBjYWxsZWQsIGNhdXNpbmcgYSBOVUxMIHBv aW50ZXIgY3Jhc2guCisgICAgICAgIFRoZSBHTCBjb250ZXh0IGNsZWFudXAgY29kZSB3YXMgb3Jp Z2luYWxseSB3cml0dGVuIHRvIGF2b2lkIGEgWCBzZXJ2ZXIgY3Jhc2ggb24gZXhpdCwKKyAgICAg ICAgc28gaXQncyBvbmx5IG5lZWRlZCBmb3IgUExBVEZPUk0oWDExKS4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL0dMQ29udGV4dC5jcHA6IE9ubHkgY2xlYW4gdXAgYWN0aXZlIEdMIGNv bnRleHRzIG9uIGV4aXQgZm9yIFBMQVRGT1JNKFgxMSkuCisgICAgICAgIChXZWJDb3JlOjpHTENv bnRleHQ6OmNsZWFudXBTaGFyZWRYMTFEaXNwbGF5KToKKyAgICAgICAgKFdlYkNvcmU6OkdMQ29u dGV4dDo6Y2xlYW51cEFjdGl2ZUNvbnRleHRzQXRFeGl0KToKKyAgICAgICAgKFdlYkNvcmU6OkdM Q29udGV4dDo6R0xDb250ZXh0KToKKyAgICAgICAgKFdlYkNvcmU6OkdMQ29udGV4dDo6fkdMQ29u dGV4dCk6CisKIDIwMTMtMTAtMDQgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29t PgogCiAgICAgICAgIFtXZWJJRExdIEFubm90YXRlIElETCBpbnRlcmZhY2VzIHVuZGVyIFNvdXJj ZS9XZWJDb3JlL2Nzcy8gd2l0aCB0aGUgT3BlcmF0aW9uc05vdERlbGV0YWJsZSBhdHRyaWJ1dGUK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dMQ29udGV4dC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR0xDb250ZXh0LmNw cAkocmV2aXNpb24gMTU2ODgwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv R0xDb250ZXh0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTMsNyArOTMsNiBAQCB2b2lkIEdMQ29u dGV4dDo6Y2xlYW51cFNoYXJlZFgxMURpc3BsYXkoCiAgICAgWENsb3NlRGlzcGxheShnU2hhcmVk WDExRGlzcGxheSk7CiAgICAgZ1NoYXJlZFgxMURpc3BsYXkgPSAwOwogfQotI2VuZGlmIC8vIFBM QVRGT1JNKFgxMSkKIAogLy8gQmVjYXVzZSBvZiBkcml2ZXIgYnVncywgZXhpdGluZyB0aGUgcHJv Z3JhbSB3aGVuIHRoZXJlIGFyZSBhY3RpdmUgcGJ1ZmZlcnMKIC8vIGNhbiBjcmFzaCB0aGUgWCBz ZXJ2ZXIgKHRoaXMgaGFzIGJlZW4gb2JzZXJ2ZWQgd2l0aCB0aGUgb2ZmaWNpYWwgTnZpZGlhIGRy aXZlcnMpLgpAQCAtMTQwLDExICsxMzksOSBAQCB2b2lkIEdMQ29udGV4dDo6Y2xlYW51cEFjdGl2 ZUNvbnRleHRzQXRFCiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBjb250ZXh0TGlzdC5zaXpl KCk7ICsraSkKICAgICAgICAgZGVsZXRlIGNvbnRleHRMaXN0W2ldOwogCi0jaWYgUExBVEZPUk0o WDExKQogICAgIGNsZWFudXBTaGFyZWRYMTFEaXNwbGF5KCk7Ci0jZW5kaWYKIH0KLQorI2VuZGlm IC8vIFBMQVRGT1JNKFgxMSkKIAogCiBQYXNzT3duUHRyPEdMQ29udGV4dD4gR0xDb250ZXh0Ojpj cmVhdGVDb250ZXh0Rm9yV2luZG93KEdMTmF0aXZlV2luZG93VHlwZSB3aW5kb3dIYW5kbGUsIEdM Q29udGV4dCogc2hhcmluZ0NvbnRleHQpCkBAIC0xNzQsNyArMTcxLDkgQEAgUGFzc093blB0cjxH TENvbnRleHQ+IEdMQ29udGV4dDo6Y3JlYXRlQwogCiBHTENvbnRleHQ6OkdMQ29udGV4dCgpCiB7 CisjaWYgUExBVEZPUk0oWDExKQogICAgIGFkZEFjdGl2ZUNvbnRleHQodGhpcyk7CisjZW5kaWYK IH0KIAogUGFzc093blB0cjxHTENvbnRleHQ+IEdMQ29udGV4dDo6Y3JlYXRlT2Zmc2NyZWVuQ29u dGV4dChHTENvbnRleHQqIHNoYXJpbmdDb250ZXh0KQpAQCAtMTg2LDcgKzE4NSw5IEBAIEdMQ29u dGV4dDo6fkdMQ29udGV4dCgpCiB7CiAgICAgaWYgKHRoaXMgPT0gY3VycmVudENvbnRleHQoKS0+ Y29udGV4dCgpKQogICAgICAgICBjdXJyZW50Q29udGV4dCgpLT5zZXRDb250ZXh0KDApOworI2lm IFBMQVRGT1JNKFgxMSkKICAgICByZW1vdmVBY3RpdmVDb250ZXh0KHRoaXMpOworI2VuZGlmCiB9 CiAKIGJvb2wgR0xDb250ZXh0OjptYWtlQ29udGV4dEN1cnJlbnQoKQo=