120757 2013-09-04 23:58:16 -0700 [CSSRegions] RenderRegion::generatingElement should return a reference 2013-09-11 09:47:04 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 57312 1 mihnea mmaerean commit-queue esprehn+autocc glenn hyatt kangil.han kondapallykalyan macpherson menard WebkitBugTracker oldest_to_newest 924882 0 mihnea 2013-09-04 23:58:16 -0700 As a follow up from https://bugs.webkit.org/show_bug.cgi?id=120397, make RenderRegion::generatingElement() return a reference instead of pointer since for regions, generatingNode cannot return 0. 926602 1 mmaerean 2013-09-09 02:04:04 -0700 RenderRegionSet derives from RenderRegion. Is generatingElement() always not NULL for RenderRegionSet as well? I'm thinking not. 926654 2 211030 mmaerean 2013-09-09 04:52:13 -0700 Created attachment 211030 patch 927825 3 mihnea 2013-09-11 09:46:03 -0700 (In reply to comment #1) > RenderRegionSet derives from RenderRegion. > Is generatingElement() always not NULL for RenderRegionSet as well? I'm thinking not. At this moment, RenderMultiColumnSet -> RenderRegionSet -> RenderRegion and RenderMultiColumnSet is created as an anonymous block. Therefore, for this type of region, generatingElement() can return NULL. Closing this bug as invalid. 211030 2013-09-09 04:52:13 -0700 2013-09-11 09:46:47 -0700 patch patch120757generatingElementReference.diff text/plain 6917 mmaerean ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5ZTM2YmE0Li4wOWY3MGQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTMtMDktMDkgIE1paGFpIE1hZXJlYW4gIDxtbWFlcmVhbkBhZG9iZS5jb20+CisKKyAg ICAgICAgW0NTU1JlZ2lvbnNdIFJlbmRlclJlZ2lvbjo6Z2VuZXJhdGluZ0VsZW1lbnQgc2hvdWxk IHJldHVybiBhIHJlZmVyZW5jZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTIwNzU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBjc3MvRWxlbWVudFJ1bGVDb2xsZWN0b3IuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RWxlbWVudFJ1bGVDb2xsZWN0b3I6OmNvbGxlY3RNYXRjaGluZ1J1bGVzRm9yUmVnaW9u KToKKyAgICAgICAgKiBkb20vV2ViS2l0TmFtZWRGbG93LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OldlYktpdE5hbWVkRmxvdzo6Z2V0UmVnaW9uc0J5Q29udGVudCk6CisgICAgICAgIChXZWJDb3Jl OjpXZWJLaXROYW1lZEZsb3c6OmdldFJlZ2lvbnMpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJSZWdpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyUmVnaW9uOjpyZWdpb25PdmVy c2V0U3RhdGUpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyUmVnaW9uOjpzZXRSZWdpb25PdmVy c2V0U3RhdGUpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyUmVnaW9uOjpjaGVja1JlZ2lvblN0 eWxlKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyUmVnaW9uLmg6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJSZWdpb246OmdlbmVyYXRpbmdFbGVtZW50KToKKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVyVHJlZUFzVGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjp3cml0ZVJlbmRlclJl Z2lvbkxpc3QpOgorCiAyMDEzLTA5LTA4ICBTYW50b3NoIE1haHRvICA8c2FudG9zaC5tYUBzYW1z dW5nLmNvbT4KIAogICAgICAgICBIVE1MRG9jdW1lbnQuaCA6IFJlbW92aW5nIHVubmVjZXNzYXJ5 IGZvcndhcmQgZGVjbGFyYXRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvRWxl bWVudFJ1bGVDb2xsZWN0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0VsZW1lbnRSdWxlQ29s bGVjdG9yLmNwcAppbmRleCBmMjZmNGQ2Li5mNjI2NjRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvRWxlbWVudFJ1bGVDb2xsZWN0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nz cy9FbGVtZW50UnVsZUNvbGxlY3Rvci5jcHAKQEAgLTE4Myw3ICsxODMsNyBAQCB2b2lkIEVsZW1l bnRSdWxlQ29sbGVjdG9yOjpjb2xsZWN0TWF0Y2hpbmdSdWxlc0ZvclJlZ2lvbihjb25zdCBNYXRj aFJlcXVlc3QmIG1hdAogICAgIHVuc2lnbmVkIHNpemUgPSBtYXRjaFJlcXVlc3QucnVsZVNldC0+ cmVnaW9uU2VsZWN0b3JzQW5kUnVsZVNldHMoKS5zaXplKCk7CiAgICAgZm9yICh1bnNpZ25lZCBp ID0gMDsgaSA8IHNpemU7ICsraSkgewogICAgICAgICBjb25zdCBDU1NTZWxlY3RvciogcmVnaW9u U2VsZWN0b3IgPSBtYXRjaFJlcXVlc3QucnVsZVNldC0+cmVnaW9uU2VsZWN0b3JzQW5kUnVsZVNl dHMoKS5hdChpKS5zZWxlY3RvcjsKLSAgICAgICAgaWYgKGNoZWNrUmVnaW9uU2VsZWN0b3IocmVn aW9uU2VsZWN0b3IsIG1fcmVnaW9uRm9yU3R5bGluZy0+Z2VuZXJhdGluZ0VsZW1lbnQoKSkpIHsK KyAgICAgICAgaWYgKGNoZWNrUmVnaW9uU2VsZWN0b3IocmVnaW9uU2VsZWN0b3IsICZtX3JlZ2lv bkZvclN0eWxpbmctPmdlbmVyYXRpbmdFbGVtZW50KCkpKSB7CiAgICAgICAgICAgICBSdWxlU2V0 KiByZWdpb25SdWxlcyA9IG1hdGNoUmVxdWVzdC5ydWxlU2V0LT5yZWdpb25TZWxlY3RvcnNBbmRS dWxlU2V0cygpLmF0KGkpLnJ1bGVTZXQuZ2V0KCk7CiAgICAgICAgICAgICBBU1NFUlQocmVnaW9u UnVsZXMpOwogICAgICAgICAgICAgY29sbGVjdE1hdGNoaW5nUnVsZXMoTWF0Y2hSZXF1ZXN0KHJl Z2lvblJ1bGVzLCBtYXRjaFJlcXVlc3QuaW5jbHVkZUVtcHR5UnVsZXMsIG1hdGNoUmVxdWVzdC5z Y29wZSksIHJ1bGVSYW5nZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vV2ViS2l0 TmFtZWRGbG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9XZWJLaXROYW1lZEZsb3cuY3BwCmlu ZGV4IGYyODkyYmEuLmU5MDk1ZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9XZWJL aXROYW1lZEZsb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9XZWJLaXROYW1lZEZsb3cu Y3BwCkBAIC0xNDAsNyArMTQwLDcgQEAgUGFzc1JlZlB0cjxOb2RlTGlzdD4gV2ViS2l0TmFtZWRG bG93OjpnZXRSZWdpb25zQnlDb250ZW50KE5vZGUqIGNvbnRlbnROb2RlKQogICAgICAgICAgICAg aWYgKHJlbmRlclJlZ2lvbi0+aXNQc2V1ZG9FbGVtZW50KCkpCiAgICAgICAgICAgICAgICAgY29u dGludWU7CiAgICAgICAgICAgICBpZiAobV9wYXJlbnRGbG93VGhyZWFkLT5vYmplY3RJbkZsb3dS ZWdpb24oY29udGVudE5vZGUtPnJlbmRlcmVyKCksIHJlbmRlclJlZ2lvbikpCi0gICAgICAgICAg ICAgICAgcmVnaW9uTm9kZXMuYXBwZW5kKHJlbmRlclJlZ2lvbi0+Z2VuZXJhdGluZ0VsZW1lbnQo KSk7CisgICAgICAgICAgICAgICAgcmVnaW9uTm9kZXMuYXBwZW5kKCZyZW5kZXJSZWdpb24tPmdl bmVyYXRpbmdFbGVtZW50KCkpOwogICAgICAgICB9CiAgICAgfQogCkBAIC0xNjcsNyArMTY3LDcg QEAgUGFzc1JlZlB0cjxOb2RlTGlzdD4gV2ViS2l0TmFtZWRGbG93OjpnZXRSZWdpb25zKCkKICAg ICAgICAgLy8gaHR0cDovL2Rldi53My5vcmcvY3Nzd2cvY3NzLXJlZ2lvbnMvI3RoZS1yZWdpb24t aW50ZXJmYWNlCiAgICAgICAgIGlmIChyZW5kZXJSZWdpb24tPmlzUHNldWRvRWxlbWVudCgpKQog ICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgIHJlZ2lvbk5vZGVzLmFwcGVuZChyZW5kZXJS ZWdpb24tPmdlbmVyYXRpbmdFbGVtZW50KCkpOworICAgICAgICByZWdpb25Ob2Rlcy5hcHBlbmQo JnJlbmRlclJlZ2lvbi0+Z2VuZXJhdGluZ0VsZW1lbnQoKSk7CiAgICAgfQogCiAgICAgcmV0dXJu IFN0YXRpY05vZGVMaXN0OjphZG9wdChyZWdpb25Ob2Rlcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUmVnaW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJSZWdpb24uY3BwCmluZGV4IDU0NDQ3NjMuLjE5ODgzZmMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZWdpb24uY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZWdpb24uY3BwCkBAIC0xMzksMTkgKzEzOSwxNSBAQCBM YXlvdXRSZWN0IFJlbmRlclJlZ2lvbjo6b3ZlcmZsb3dSZWN0Rm9yRmxvd1RocmVhZFBvcnRpb24o Y29uc3QgTGF5b3V0UmVjdCYgZmxvdwogCiBSZWdpb25PdmVyc2V0U3RhdGUgUmVuZGVyUmVnaW9u OjpyZWdpb25PdmVyc2V0U3RhdGUoKSBjb25zdAogewotICAgIEFTU0VSVChnZW5lcmF0aW5nRWxl bWVudCgpKTsKLQogICAgIGlmICghaXNWYWxpZCgpKQogICAgICAgICByZXR1cm4gUmVnaW9uVW5k ZWZpbmVkOwogCi0gICAgcmV0dXJuIGdlbmVyYXRpbmdFbGVtZW50KCktPnJlZ2lvbk92ZXJzZXRT dGF0ZSgpOworICAgIHJldHVybiBnZW5lcmF0aW5nRWxlbWVudCgpLnJlZ2lvbk92ZXJzZXRTdGF0 ZSgpOwogfQogCiB2b2lkIFJlbmRlclJlZ2lvbjo6c2V0UmVnaW9uT3ZlcnNldFN0YXRlKFJlZ2lv bk92ZXJzZXRTdGF0ZSBzdGF0ZSkKIHsKLSAgICBBU1NFUlQoZ2VuZXJhdGluZ0VsZW1lbnQoKSk7 Ci0KLSAgICBnZW5lcmF0aW5nRWxlbWVudCgpLT5zZXRSZWdpb25PdmVyc2V0U3RhdGUoc3RhdGUp OworICAgIGdlbmVyYXRpbmdFbGVtZW50KCkuc2V0UmVnaW9uT3ZlcnNldFN0YXRlKHN0YXRlKTsK IH0KIAogTGF5b3V0VW5pdCBSZW5kZXJSZWdpb246OnBhZ2VMb2dpY2FsVG9wRm9yT2Zmc2V0KExh eW91dFVuaXQgLyogb2Zmc2V0ICovKSBjb25zdApAQCAtMjI4LDcgKzIyNCw3IEBAIHZvaWQgUmVu ZGVyUmVnaW9uOjpjaGVja1JlZ2lvblN0eWxlKCkKIAogICAgIC8vIEZJWE1FOiBSZWdpb24gc3R5 bGluZyBkb2Vzbid0IHdvcmsgZm9yIHBzZXVkbyBlbGVtZW50cy4KICAgICBpZiAoIWlzUHNldWRv RWxlbWVudCgpKQotICAgICAgICBjdXN0b21SZWdpb25TdHlsZSA9IHZpZXcoKS5kb2N1bWVudCgp LmVuc3VyZVN0eWxlUmVzb2x2ZXIoKS5jaGVja1JlZ2lvblN0eWxlKGdlbmVyYXRpbmdFbGVtZW50 KCkpOworICAgICAgICBjdXN0b21SZWdpb25TdHlsZSA9IHZpZXcoKS5kb2N1bWVudCgpLmVuc3Vy ZVN0eWxlUmVzb2x2ZXIoKS5jaGVja1JlZ2lvblN0eWxlKCZnZW5lcmF0aW5nRWxlbWVudCgpKTsK ICAgICBzZXRIYXNDdXN0b21SZWdpb25TdHlsZShjdXN0b21SZWdpb25TdHlsZSk7CiAgICAgbV9m bG93VGhyZWFkLT5jaGVja1JlZ2lvbnNXaXRoU3R5bGluZygpOwogfQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5oIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclJlZ2lvbi5oCmluZGV4IGU3OWMzOWYuLjdiMmNmNGEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZWdpb24uaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyUmVnaW9uLmgKQEAgLTE1Myw3ICsxNTMsNyBAQCBwdWJsaWM6 CiAKICAgICBMYXlvdXRSZWN0IHJlY3RGbG93UG9ydGlvbkZvckJveChjb25zdCBSZW5kZXJCb3gq LCBjb25zdCBMYXlvdXRSZWN0JikgY29uc3Q7CiAKLSAgICBFbGVtZW50KiBnZW5lcmF0aW5nRWxl bWVudCgpIGNvbnN0IHsgcmV0dXJuIHRvRWxlbWVudChSZW5kZXJPYmplY3Q6OmdlbmVyYXRpbmdO b2RlKCkpOyB9CisgICAgRWxlbWVudCYgZ2VuZXJhdGluZ0VsZW1lbnQoKSBjb25zdCB7IHJldHVy biAqdG9FbGVtZW50KFJlbmRlck9iamVjdDo6Z2VuZXJhdGluZ05vZGUoKSk7IH0KIAogcHJvdGVj dGVkOgogICAgIFJlbmRlck92ZXJmbG93KiBlbnN1cmVPdmVyZmxvd0ZvckJveChjb25zdCBSZW5k ZXJCb3gqKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUcmVl QXNUZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUcmVlQXNUZXh0LmNw cAppbmRleCAwN2FhNmQ4Li4xZGM3ZWVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVHJlZUFzVGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclRyZWVBc1RleHQuY3BwCkBAIC02NjksMTkgKzY2OSwxNyBAQCBzdGF0aWMgdm9pZCB3 cml0ZVJlbmRlclJlZ2lvbkxpc3QoY29uc3QgUmVuZGVyUmVnaW9uTGlzdCYgZmxvd1RocmVhZFJl Z2lvbkxpc3QsCiAgICAgICAgIFJlbmRlclJlZ2lvbiogcmVuZGVyUmVnaW9uID0gKml0UlI7CiAg ICAgICAgIHdyaXRlSW5kZW50KHRzLCBpbmRlbnQgKyAyKTsKICAgICAgICAgdHMgPDwgIlJlbmRl clJlZ2lvbiI7Ci0gICAgICAgIGlmIChyZW5kZXJSZWdpb24tPmdlbmVyYXRpbmdFbGVtZW50KCkp IHsKLSAgICAgICAgICAgIFN0cmluZyB0YWdOYW1lID0gZ2V0VGFnTmFtZShyZW5kZXJSZWdpb24t Pm5vZGUoKSk7Ci0gICAgICAgICAgICBpZiAoIXRhZ05hbWUuaXNFbXB0eSgpKQotICAgICAgICAg ICAgICAgIHRzIDw8ICIgeyIgPDwgdGFnTmFtZSA8PCAifSI7Ci0gICAgICAgICAgICBpZiAocmVu ZGVyUmVnaW9uLT5nZW5lcmF0aW5nRWxlbWVudCgpLT5oYXNJRCgpKQotICAgICAgICAgICAgICAg IHRzIDw8ICIgIyIgPDwgcmVuZGVyUmVnaW9uLT5nZW5lcmF0aW5nRWxlbWVudCgpLT5pZEZvclN0 eWxlUmVzb2x1dGlvbigpOwotICAgICAgICAgICAgaWYgKHJlbmRlclJlZ2lvbi0+aGFzTGF5ZXIo KSkKLSAgICAgICAgICAgICAgICB0cyA8PCAiIGhhc0xheWVyIjsKLSAgICAgICAgICAgIGlmIChy ZW5kZXJSZWdpb24tPmhhc0N1c3RvbVJlZ2lvblN0eWxlKCkpCi0gICAgICAgICAgICAgICAgdHMg PDwgIiByZWdpb24gc3R5bGU6IDEiOwotICAgICAgICAgICAgaWYgKHJlbmRlclJlZ2lvbi0+aGFz QXV0b0xvZ2ljYWxIZWlnaHQoKSkKLSAgICAgICAgICAgICAgICB0cyA8PCAiIGhhc0F1dG9Mb2dp Y2FsSGVpZ2h0IjsKLSAgICAgICAgfQorICAgICAgICBTdHJpbmcgdGFnTmFtZSA9IGdldFRhZ05h bWUocmVuZGVyUmVnaW9uLT5ub2RlKCkpOworICAgICAgICBpZiAoIXRhZ05hbWUuaXNFbXB0eSgp KQorICAgICAgICAgICAgdHMgPDwgIiB7IiA8PCB0YWdOYW1lIDw8ICJ9IjsKKyAgICAgICAgaWYg KHJlbmRlclJlZ2lvbi0+Z2VuZXJhdGluZ0VsZW1lbnQoKS5oYXNJRCgpKQorICAgICAgICAgICAg dHMgPDwgIiAjIiA8PCByZW5kZXJSZWdpb24tPmdlbmVyYXRpbmdFbGVtZW50KCkuaWRGb3JTdHls ZVJlc29sdXRpb24oKTsKKyAgICAgICAgaWYgKHJlbmRlclJlZ2lvbi0+aGFzTGF5ZXIoKSkKKyAg ICAgICAgICAgIHRzIDw8ICIgaGFzTGF5ZXIiOworICAgICAgICBpZiAocmVuZGVyUmVnaW9uLT5o YXNDdXN0b21SZWdpb25TdHlsZSgpKQorICAgICAgICAgICAgdHMgPDwgIiByZWdpb24gc3R5bGU6 IDEiOworICAgICAgICBpZiAocmVuZGVyUmVnaW9uLT5oYXNBdXRvTG9naWNhbEhlaWdodCgpKQor ICAgICAgICAgICAgdHMgPDwgIiBoYXNBdXRvTG9naWNhbEhlaWdodCI7CiAgICAgICAgIGlmICgh cmVuZGVyUmVnaW9uLT5pc1ZhbGlkKCkpCiAgICAgICAgICAgICB0cyA8PCAiIGludmFsaWQiOwog ICAgICAgICB0cyA8PCAiXG4iOwo=