120703 2013-09-04 15:04:12 -0700 [GTK] MediaControlsGtk: fix warning in constructor due to incorrect order of attributes 2013-09-05 00:21:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto berto commit-queue eric.carlson esprehn+autocc glenn jer.noble mrobinson oldest_to_newest 924628 0 berto 2013-09-04 15:04:12 -0700 CXX Source/WebCore/rendering/libWebCore_la-RenderTextFragment.lo In file included from ../../Source/WebCore/html/shadow/MediaControlsGtk.cpp:32:0: ../../Source/WebCore/html/shadow/MediaControlsGtk.h: In constructor 'WebCore::MediaControlsGtk::MediaControlsGtk(WebCore::Document*)': ../../Source/WebCore/html/shadow/MediaControlsGtk.h:76:43: warning: 'WebCore::MediaControlsGtk::m_eventListener' will be initialized after [-Wreorder] ../../Source/WebCore/html/shadow/MediaControlsGtk.h:73:49: warning: 'WebCore::MediaControlClosedCaptionsTrackListElement* WebCore::MediaControlsGtk::m_closedCaptionsTrackList' [-Wreorder] ../../Source/WebCore/html/shadow/MediaControlsGtk.cpp:63:1: warning: when initialized here [-Wreorder] In this case it's harmless since all those elements are initialized to 0. 924630 1 210500 berto 2013-09-04 15:06:22 -0700 Created attachment 210500 Patch 924899 2 berto 2013-09-05 00:21:05 -0700 Committed r155102: <http://trac.webkit.org/changeset/155102> 210500 2013-09-04 15:06:22 -0700 2013-09-04 23:52:03 -0700 Patch 120703.diff text/plain 1272 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5NjJjYTQ4Li5kNGFlM2ZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMDktMDQgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KKworICAg ICAgICBbR1RLXSBNZWRpYUNvbnRyb2xzR3RrOiBmaXggd2FybmluZyBpbiBjb25zdHJ1Y3RvciBk dWUgdG8gaW5jb3JyZWN0IG9yZGVyIG9mIGF0dHJpYnV0ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDcwMworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBtZW1iZXIgaW5pdGlhbGl6YXRpb24gc28g aXQgbWF0Y2hlcyB0aGVpciBkZWNsYXJhdGlvbiBbLVdyZW9yZGVyXS4KKworICAgICAgICAqIGh0 bWwvc2hhZG93L01lZGlhQ29udHJvbHNHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFD b250cm9sc0d0azo6TWVkaWFDb250cm9sc0d0ayk6CisKIDIwMTMtMDktMDQgIEJlbSBKb25lcy1C ZXkgIDxiam9uZXNiZUBhZG9iZS5jb20+CiAKICAgICAgICAgRmxvYXRpbmdPYmplY3RzIHNob3Vs ZCBtYW5hZ2UgY2xlYW5pbmcgaXQncyBsaW5lIGJveCB0cmVlIHBvaW50ZXJzIGl0c2VsZgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sc0d0ay5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xzR3RrLmNwcAppbmRleCAy ZGVlMDRiLi41M2RhMGVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9N ZWRpYUNvbnRyb2xzR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRp YUNvbnRyb2xzR3RrLmNwcApAQCAtNjQsOSArNjQsOSBAQCBNZWRpYUNvbnRyb2xzR3RrOjpNZWRp YUNvbnRyb2xzR3RrKERvY3VtZW50KiBkb2N1bWVudCkKICAgICA6IE1lZGlhQ29udHJvbHMoZG9j dW1lbnQpCiAgICAgLCBtX2R1cmF0aW9uRGlzcGxheSgwKQogICAgICwgbV9lbmNsb3N1cmUoMCkK LSAgICAsIG1fZXZlbnRMaXN0ZW5lcigwKQogICAgICwgbV9jbG9zZWRDYXB0aW9uc1RyYWNrTGlz dCgwKQogICAgICwgbV9jbG9zZWRDYXB0aW9uc0NvbnRhaW5lcigwKQorICAgICwgbV9ldmVudExp c3RlbmVyKDApCiB7CiB9CiAK