120692 2013-09-04 12:25:47 -0700 FloatingObjects should manage cleaning its line box tree pointers itself 2013-09-04 14:34:55 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bjonesbe bjonesbe commit-queue darin esprehn+autocc glenn gtk-ews kondapallykalyan xan.lopez oldest_to_newest 924556 0 bjonesbe 2013-09-04 12:25:47 -0700 FloatingObjects should manage cleaning it's line box tree pointers itself 924558 1 210485 bjonesbe 2013-09-04 12:31:39 -0700 Created attachment 210485 Patch Ported from Blink 924588 2 210485 hyatt 2013-09-04 13:54:22 -0700 Comment on attachment 210485 Patch r=me 924596 3 210485 gtk-ews 2013-09-04 13:59:49 -0700 Comment on attachment 210485 Patch Attachment 210485 did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1684731 924604 4 210485 bjonesbe 2013-09-04 14:09:37 -0700 Comment on attachment 210485 Patch One more try, maybe I'll get a working gtk bot this time. 924617 5 210485 commit-queue 2013-09-04 14:34:53 -0700 Comment on attachment 210485 Patch Clearing flags on attachment: 210485 Committed r155065: <http://trac.webkit.org/changeset/155065> 924618 6 commit-queue 2013-09-04 14:34:55 -0700 All reviewed patches have been landed. Closing bug. 210485 2013-09-04 12:31:39 -0700 2013-09-04 14:34:53 -0700 Patch bug-120692-20130904123139.patch text/plain 6345 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGIxMzE3NDNlMjI4YjRm YjYxN2U5NjVkZDYwYmMwZTc3OTMwMjkyZS4uMGRhYjcxZWIxNTNiZGNkN2VkNzFjM2I4ZDMwMjZm ODBiODMyMDk3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM3IEBACiAyMDEzLTA5LTA0ICBCZW0g Sm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgogCisgICAgICAgIEZsb2F0aW5nT2JqZWN0 cyBzaG91bGQgbWFuYWdlIGNsZWFuaW5nIGl0J3MgbGluZSBib3ggdHJlZSBwb2ludGVycyBpdHNl bGYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDY5 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg aXMgYW5vdGhlciBzdGVwIGluIHByb3Blcmx5IGVuY2Fwc3VsYXRpbmcgRmxvYXRpbmdPYmplY3Rz LgorICAgICAgICBJbnN0ZWFkIG9mIGhhdmluZyBSZW5kZXJCbG9jayB3YWxrIGFuZCBjbGVhciB0 aGUgbGluZSBib3ggdHJlZQorICAgICAgICBwb2ludGVycywgY3JlYXRlIGEgbWV0aG9kIGZvciB0 aGUgYmVoYXZpb3IsIGFuZCBoYXZlIFJlbmRlckJsb2NrIGNhbGwKKyAgICAgICAgdGhhdC4KKwor ICAgICAgICBJbiBhZGR0aW9uLCBhZGQgYSBwcm9wZXIgZGVzdHJ1Y3RvciB0byBGbG9hdGluZ09i amVjdHMsIHNvIHRoYXQKKyAgICAgICAgUmVuZGVyQmxvY2sgZG9lcyBub3QgaGF2ZSB0byBleHBs aWNpdGx5IGRlbGV0ZSB0aGUgc2V0IGluCisgICAgICAgIEZsb2F0aW5nT2JqZWN0cy4KKworICAg ICAgICBBbmQgYXMgYSBib251cywgZml4IHRoZSBvcmRlcmluZyBvZiBhbiBpZiB0byBhdm9pZCB0 aGUgZXhwZW5zaXZlCisgICAgICAgIGRlc2NlbmRhbnRDaGlsZCBjaGVjay4KKworICAgICAgICBU aGlzIGlzIGEgcG9ydCBvZiBhIEJsaW5rIHBhdGNoIGJ5IEVyaWMgU2VpZGVsLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjp+UmVuZGVy QmxvY2spOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmRlbGV0ZUxpbmVCb3hUcmVl KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpyZXBhaW50T3ZlcmhhbmdpbmdGbG9h dHMpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OkZsb2F0aW5nT2JqZWN0czo6fkZs b2F0aW5nT2JqZWN0cyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6RmxvYXRpbmdP YmplY3RzOjpjbGVhckxpbmVCb3hUcmVlUG9pbnRlcnMpOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyQmxvY2s6OkZsb2F0aW5nT2JqZWN0czo6Y2xlYXIpOgorICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJCbG9jay5oOgorCisyMDEzLTA5LTA0ICBCZW0gSm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRv YmUuY29tPgorCiAgICAgICAgIE1vdmUgbG9naWNhbCBkaW1lbnNpb24gZ2V0dGVycy9zZXR0ZXJz IHRvIEZsb2F0aW5nT2JqZWN0IGZyb20gUmVuZGVyQmxvY2sKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDY4NgogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJsb2NrLmNwcAppbmRleCA0ZGE2OGFmMDJiYWZmYjM4ODE2MTNmYWYzZjk2MTE0 MDNhNjY2YzNiLi4zODliMjlmOWQzOGUzMDlmYTVkYzJkN2U0MTM3MDAyNzQzOTFmZTdiIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKQEAgLTIyNywxMiArMjI3LDgg QEAgc3RhdGljIHZvaWQgcmVtb3ZlQmxvY2tGcm9tRGVzY2VuZGFudEFuZENvbnRhaW5lck1hcHMo UmVuZGVyQmxvY2sqIGJsb2NrLCBUcmFja2UKIAogUmVuZGVyQmxvY2s6On5SZW5kZXJCbG9jaygp CiB7Ci0gICAgaWYgKG1fZmxvYXRpbmdPYmplY3RzKQotICAgICAgICBkZWxldGVBbGxWYWx1ZXMo bV9mbG9hdGluZ09iamVjdHMtPnNldCgpKTsKLSAgICAKICAgICBpZiAoaGFzQ29sdW1ucygpKQog ICAgICAgICBnQ29sdW1uSW5mb01hcC0+dGFrZSh0aGlzKTsKLQogICAgIGlmIChnUGVyY2VudEhl aWdodERlc2NlbmRhbnRzTWFwKQogICAgICAgICByZW1vdmVCbG9ja0Zyb21EZXNjZW5kYW50QW5k Q29udGFpbmVyTWFwcyh0aGlzLCBnUGVyY2VudEhlaWdodERlc2NlbmRhbnRzTWFwLCBnUGVyY2Vu dEhlaWdodENvbnRhaW5lck1hcCk7CiAgICAgaWYgKGdQb3NpdGlvbmVkRGVzY2VuZGFudHNNYXAp CkBAIC05ODgsMTUgKzk4NCw4IEBAIHN0YXRpYyB2b2lkIGdldElubGluZVJ1bihSZW5kZXJPYmpl Y3QqIHN0YXJ0LCBSZW5kZXJPYmplY3QqIGJvdW5kYXJ5LAogCiB2b2lkIFJlbmRlckJsb2NrOjpk ZWxldGVMaW5lQm94VHJlZSgpCiB7Ci0gICAgaWYgKGNvbnRhaW5zRmxvYXRzKCkpIHsKLSAgICAg ICAgLy8gQ2xlYXIgcmVmZXJlbmNlcyB0byBvcmlnaW5hdGluZyBsaW5lcywgc2luY2UgdGhlIGxp bmVzIGFyZSBiZWluZyBkZWxldGVkCi0gICAgICAgIGNvbnN0IEZsb2F0aW5nT2JqZWN0U2V0JiBm bG9hdGluZ09iamVjdFNldCA9IG1fZmxvYXRpbmdPYmplY3RzLT5zZXQoKTsKLSAgICAgICAgRmxv YXRpbmdPYmplY3RTZXRJdGVyYXRvciBlbmQgPSBmbG9hdGluZ09iamVjdFNldC5lbmQoKTsKLSAg ICAgICAgZm9yIChGbG9hdGluZ09iamVjdFNldEl0ZXJhdG9yIGl0ID0gZmxvYXRpbmdPYmplY3RT ZXQuYmVnaW4oKTsgaXQgIT0gZW5kOyArK2l0KSB7Ci0gICAgICAgICAgICBBU1NFUlQoISgoKml0 KS0+b3JpZ2luYXRpbmdMaW5lKCkpIHx8ICYoKml0KS0+b3JpZ2luYXRpbmdMaW5lKCktPnJlbmRl cmVyKCkgPT0gdGhpcyk7Ci0gICAgICAgICAgICAoKml0KS0+c2V0T3JpZ2luYXRpbmdMaW5lKDAp OwotICAgICAgICB9Ci0gICAgfQorICAgIGlmIChjb250YWluc0Zsb2F0cygpKQorICAgICAgICBt X2Zsb2F0aW5nT2JqZWN0cy0+Y2xlYXJMaW5lQm94VHJlZVBvaW50ZXJzKCk7CiAgICAgbV9saW5l Qm94ZXMuZGVsZXRlTGluZUJveFRyZWUocmVuZGVyQXJlbmEoKSk7CiAKICAgICBpZiAoQVhPYmpl Y3RDYWNoZSogY2FjaGUgPSBkb2N1bWVudCgpLmV4aXN0aW5nQVhPYmplY3RDYWNoZSgpKQpAQCAt MzA0Miw3ICszMDMxLDkgQEAgdm9pZCBSZW5kZXJCbG9jazo6cmVwYWludE92ZXJoYW5naW5nRmxv YXRzKGJvb2wgcGFpbnRBbGxEZXNjZW5kYW50cykKICAgICAgICAgLy8gT25seSByZXBhaW50IHRo ZSBvYmplY3QgaWYgaXQgaXMgb3ZlcmhhbmdpbmcsIGlzIG5vdCBpbiBpdHMgb3duIGxheWVyLCBh bmQKICAgICAgICAgLy8gaXMgb3VyIHJlc3BvbnNpYmlsaXR5IHRvIHBhaW50IChtX3Nob3VsZFBh aW50IGlzIHNldCkuIFdoZW4gcGFpbnRBbGxEZXNjZW5kYW50cyBpcyB0cnVlLCB0aGUgbGF0dGVy CiAgICAgICAgIC8vIGNvbmRpdGlvbiBpcyByZXBsYWNlZCB3aXRoIGJlaW5nIGEgZGVzY2VuZGFu dCBvZiB1cy4KLSAgICAgICAgaWYgKHItPmxvZ2ljYWxCb3R0b20oaXNIb3Jpem9udGFsV3JpdGlu Z01vZGUoKSkgPiBsb2dpY2FsSGVpZ2h0KCkgJiYgKChwYWludEFsbERlc2NlbmRhbnRzICYmIHIt PnJlbmRlcmVyKCktPmlzRGVzY2VuZGFudE9mKHRoaXMpKSB8fCByLT5zaG91bGRQYWludCgpKSAm JiAhci0+cmVuZGVyZXIoKS0+aGFzU2VsZlBhaW50aW5nTGF5ZXIoKSkgeworICAgICAgICBpZiAo ci0+bG9naWNhbEJvdHRvbShpc0hvcml6b250YWxXcml0aW5nTW9kZSgpKSA+IGxvZ2ljYWxIZWln aHQoKQorICAgICAgICAgICAgJiYgIXItPnJlbmRlcmVyKCktPmhhc1NlbGZQYWludGluZ0xheWVy KCkKKyAgICAgICAgICAgICYmIChyLT5zaG91bGRQYWludCgpIHx8IChwYWludEFsbERlc2NlbmRh bnRzICYmIHItPnJlbmRlcmVyKCktPmlzRGVzY2VuZGFudE9mKHRoaXMpKSkpIHsKICAgICAgICAg ICAgIHItPnJlbmRlcmVyKCktPnJlcGFpbnQoKTsKICAgICAgICAgICAgIHItPnJlbmRlcmVyKCkt PnJlcGFpbnRPdmVyaGFuZ2luZ0Zsb2F0cyhmYWxzZSk7CiAgICAgICAgIH0KQEAgLTgyMzcsNiAr ODIyOCwyMiBAQCBpbmxpbmUgUmVuZGVyQmxvY2s6OkZsb2F0aW5nT2JqZWN0czo6RmxvYXRpbmdP YmplY3RzKGNvbnN0IFJlbmRlckJsb2NrKiByZW5kZXJlcgogewogfQogCitSZW5kZXJCbG9jazo6 RmxvYXRpbmdPYmplY3RzOjp+RmxvYXRpbmdPYmplY3RzKCkKK3sKKyAgICAvLyBGSVhNRTogbV9z ZXQgc2hvdWxkIHVzZSBPd25QdHIgaW5zdGVhZC4KKyAgICBkZWxldGVBbGxWYWx1ZXMobV9zZXQp OworfQorCit2b2lkIFJlbmRlckJsb2NrOjpGbG9hdGluZ09iamVjdHM6OmNsZWFyTGluZUJveFRy ZWVQb2ludGVycygpCit7CisgICAgLy8gQ2xlYXIgcmVmZXJlbmNlcyB0byBvcmlnaW5hdGluZyBs aW5lcywgc2luY2UgdGhlIGxpbmVzIGFyZSBiZWluZyBkZWxldGVkCisgICAgRmxvYXRpbmdPYmpl Y3RTZXRJdGVyYXRvciBlbmQgPSBtX3NldC5lbmQoKTsKKyAgICBmb3IgKEZsb2F0aW5nT2JqZWN0 U2V0SXRlcmF0b3IgaXQgPSBtX3NldC5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQpIHsKKyAgICAg ICAgQVNTRVJUKCEoKCppdCktPm9yaWdpbmF0aW5nTGluZSgpKSB8fCAmKCgqaXQpLT5vcmlnaW5h dGluZ0xpbmUoKS0+cmVuZGVyZXIoKSkgPT0gbV9yZW5kZXJlcik7CisgICAgICAgICgqaXQpLT5z ZXRPcmlnaW5hdGluZ0xpbmUoMCk7CisgICAgfQorfQorCiB2b2lkIFJlbmRlckJsb2NrOjpjcmVh dGVGbG9hdGluZ09iamVjdHMoKQogewogICAgIG1fZmxvYXRpbmdPYmplY3RzID0gYWRvcHRQdHIo bmV3IEZsb2F0aW5nT2JqZWN0cyh0aGlzLCBpc0hvcml6b250YWxXcml0aW5nTW9kZSgpKSk7CkBA IC04MjQ0LDYgKzgyNTEsOSBAQCB2b2lkIFJlbmRlckJsb2NrOjpjcmVhdGVGbG9hdGluZ09iamVj dHMoKQogCiBpbmxpbmUgdm9pZCBSZW5kZXJCbG9jazo6RmxvYXRpbmdPYmplY3RzOjpjbGVhcigp CiB7CisgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIGNhbGwgZGVsZXRlQWxsVmFsdWVzLCBleGNl cHQgUmVuZGVyQmxvY2s6OmNsZWFyRmxvYXRzCisgICAgLy8gbGlrZSB0byBwbGF5IGZhc3QgYW5k IGxvb3NlIHdpdGggb3duZXJzaGlwIG9mIHRoZXNlIHBvaW50ZXJzLgorICAgIC8vIElmIHdlIG1v dmUgdG8gT3duUHRyIHRoYXQgd2lsbCBmaXggdGhpcyBvd25lcnNoaXAgb2RkbmVzcy4KICAgICBt X3NldC5jbGVhcigpOwogICAgIG1fcGxhY2VkRmxvYXRzVHJlZS5jbGVhcigpOwogICAgIG1fbGVm dE9iamVjdHNDb3VudCA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQmxvY2suaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5oCmlu ZGV4IGYzODY1MjMwNzVkNzZkY2E4ODU1ZTcwNjhkMTU0NGMzNjAzNTM0YmEuLmZlZmQzODYyNWM5 YzgzN2UxYThiMjcyYWRiMDNhZmQ4NzVhYWE3YWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCbG9jay5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9jay5oCkBAIC0xMjUxLDYgKzEyNTEsOCBAQCBwdWJsaWM6CiAgICAgY2xhc3MgRmxv YXRpbmdPYmplY3RzIHsKICAgICAgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoRmxvYXRpbmdPYmpl Y3RzKTsgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CiAgICAgcHVibGljOgorICAgICAgICB+Rmxv YXRpbmdPYmplY3RzKCk7CisKICAgICAgICAgdm9pZCBjbGVhcigpOwogICAgICAgICB2b2lkIGFk ZChGbG9hdGluZ09iamVjdCopOwogICAgICAgICB2b2lkIHJlbW92ZShGbG9hdGluZ09iamVjdCop OwpAQCAtMTI2Niw2ICsxMjY4LDcgQEAgcHVibGljOgogICAgICAgICAgICAgY29tcHV0ZVBsYWNl ZEZsb2F0c1RyZWVJZk5lZWRlZCgpOwogICAgICAgICAgICAgcmV0dXJuIG1fcGxhY2VkRmxvYXRz VHJlZTsgCiAgICAgICAgIH0KKyAgICAgICAgdm9pZCBjbGVhckxpbmVCb3hUcmVlUG9pbnRlcnMo KTsKICAgICBwcml2YXRlOgogICAgICAgICBGbG9hdGluZ09iamVjdHMoY29uc3QgUmVuZGVyQmxv Y2sqLCBib29sIGhvcml6b250YWxXcml0aW5nTW9kZSk7CiAgICAgICAgIHZvaWQgY29tcHV0ZVBs YWNlZEZsb2F0c1RyZWUoKTsK