120675 2013-09-04 04:15:21 -0700 [GTK] ghost cursor when mouse hovers over an image file in a tab 2013-09-09 00:30:43 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 0 sindhus csaavedra cgarcia commit-queue csaavedra mrobinson zan oldest_to_newest 924353 0 sindhus 2013-09-04 04:15:21 -0700 I have epiphany built from git master today. There is an odd cursor appearing when mouse pointer is on an image that is opened inside epiphany. If I take a screenshot, in the screenshot the normal mouse pointer appears. Epiphany maintainer confirms that this is reproducible on GtkLauncher and MiniBrowser 924356 1 csaavedra 2013-09-04 04:19:42 -0700 Both the zoom-in and the zoom-out cursors seem to be corrupted somehow. I haven't checked the other custom cursos, though. 925213 2 csaavedra 2013-09-05 14:23:39 -0700 After the patch in bug 118905 landed there is no "ghost" cursor anymore, but no cursor either. 925523 3 210725 csaavedra 2013-09-06 06:01:34 -0700 Created attachment 210725 Test case. I wrote this small test case from the code in CursorGtk.cpp, it shows that the cursor is always corrupted. Something has changed that is rendering the code useless. 925613 4 csaavedra 2013-09-06 09:05:11 -0700 So it was a GTK+ bug. I fixed it in GTK+ master already. However there is a method we should be using here to make this simpler. gdk_cursor_new_from_surface(). I'll cook a patch. 925615 5 mrobinson 2013-09-06 09:10:39 -0700 Is gdk_cursor_new_from_surface in GDK 3.6? 925620 6 csaavedra 2013-09-06 09:13:01 -0700 No, only 3.9. But I think we want to use it for hires display support. 925622 7 csaavedra 2013-09-06 09:22:20 -0700 If we're not going to bump to 3.9 for this, then I guess we can close this already. 926175 8 cgarcia 2013-09-07 03:44:14 -0700 (In reply to comment #7) > If we're not going to bump to 3.9 for this, then I guess we can close this already. Why? We can use the new code when GTK version is >= 3.9, no? 926242 9 mrobinson 2013-09-07 12:00:49 -0700 (In reply to comment #8) > (In reply to comment #7) > > If we're not going to bump to 3.9 for this, then I guess we can close this already. > > Why? We can use the new code when GTK version is >= 3.9, no? If we are interested in keeping backward compatibility, we can just write a version that targets <= 3.6 and use it conditionally. It's just a question of whether or not we think it's useful / makes the code nicer. 926583 10 211011 csaavedra 2013-09-08 23:53:33 -0700 Created attachment 211011 Patch 926590 11 211011 commit-queue 2013-09-09 00:30:41 -0700 Comment on attachment 211011 Patch Clearing flags on attachment: 211011 Committed r155329: <http://trac.webkit.org/changeset/155329> 926591 12 commit-queue 2013-09-09 00:30:43 -0700 All reviewed patches have been landed. Closing bug. 210725 2013-09-06 06:01:34 -0700 2013-09-06 06:02:33 -0700 Test case. cursor-test.c text/plain 3126 csaavedra I2luY2x1ZGUgPGd0ay9ndGsuaD4KI2luY2x1ZGUgPGNhaXJvL2NhaXJvLmg+CiNpbmNsdWRlIDxn ZGstcGl4YnVmL2dkay1waXhidWYuaD4KCi8qIE1PWl9DVVJTT1JfWk9PTV9JTiAqLwpzdGF0aWMg Y29uc3QgdW5zaWduZWQgY2hhciBtb3pfem9vbV9pbl9iaXRzW10gPSB7CiAgMHhmMCwgMHgwMCwg MHgwMCwgMHgwMCwgMHgwYywgMHgwMywgMHgwMCwgMHgwMCwgMHgwMiwgMHgwNCwgMHgwMCwgMHgw MCwKICAweDYyLCAweDA0LCAweDAwLCAweDAwLCAweDYxLCAweDA4LCAweDAwLCAweDAwLCAweGY5 LCAweDA5LCAweDAwLCAweDAwLAogIDB4ZjksIDB4MDksIDB4MDAsIDB4MDAsIDB4NjEsIDB4MDgs IDB4MDAsIDB4MDAsIDB4NjIsIDB4MDQsIDB4MDAsIDB4MDAsCiAgMHgwMiwgMHgwNCwgMHgwMCwg MHgwMCwgMHgwYywgMHgwZiwgMHgwMCwgMHgwMCwgMHhmMCwgMHgxYywgMHgwMCwgMHgwMCwKICAw eDAwLCAweDM4LCAweDAwLCAweDAwLCAweDAwLCAweDcwLCAweDAwLCAweDAwLCAweDAwLCAweGUw LCAweDAwLCAweDAwLAogIDB4MDAsIDB4NDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAs IDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsCiAgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwg MHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwKICAweDAwLCAw eDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAw LCAweDAwLAogIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAs IDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsCiAgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwg MHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwKICAweDAwLCAweDAwLCAw eDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwIH07CgpzdGF0aWMgY29uc3QgdW5zaWdu ZWQgY2hhciBtb3pfem9vbV9pbl9tYXNrX2JpdHNbXSA9IHsKICAweGYwLCAweDAwLCAweDAwLCAw eDAwLCAweGZjLCAweDAzLCAweDAwLCAweDAwLCAweGZlLCAweDA3LCAweDAwLCAweDAwLAogIDB4 ZmUsIDB4MDcsIDB4MDAsIDB4MDAsIDB4ZmYsIDB4MGYsIDB4MDAsIDB4MDAsIDB4ZmYsIDB4MGYs IDB4MDAsIDB4MDAsCiAgMHhmZiwgMHgwZiwgMHgwMCwgMHgwMCwgMHhmZiwgMHgwZiwgMHgwMCwg MHgwMCwgMHhmZSwgMHgwNywgMHgwMCwgMHgwMCwKICAweGZlLCAweDA3LCAweDAwLCAweDAwLCAw eGZjLCAweDBmLCAweDAwLCAweDAwLCAweGYwLCAweDFjLCAweDAwLCAweDAwLAogIDB4MDAsIDB4 MzgsIDB4MDAsIDB4MDAsIDB4MDAsIDB4NzAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4ZTAsIDB4MDAs IDB4MDAsCiAgMHgwMCwgMHg0MCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwg MHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwKICAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAw eDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLAogIDB4MDAsIDB4MDAsIDB4 MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAs CiAgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwgMHgwMCwg MHgwMCwgMHgwMCwgMHgwMCwKICAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAw eDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLCAweDAwLAogIDB4MDAsIDB4MDAsIDB4MDAsIDB4 MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAgfTsKCnR5cGVkZWYgc3RydWN0IHsKICAgIGNvbnN0 IGNoYXIqIG5hbWU7CiAgICBjb25zdCB1bnNpZ25lZCBjaGFyKiBiaXRzOwogICAgY29uc3QgdW5z aWduZWQgY2hhciogbWFza19iaXRzOwogICAgaW50IGhvdF94OwogICAgaW50IGhvdF95Owp9IEN1 c3RvbUN1cnNvcjsKCi8vIGNyZWF0ZSBjdXN0b20gcGl4bWFwIGN1cnNvciBmcm9tIGN1cnNvcnMg aW4gbnNHVEtDdXJzb3JEYXRhLmgKc3RhdGljIGNvbnN0IEN1c3RvbUN1cnNvciBDdXN0b21DdXJz b3JzW10gPSB7CiAgICB7ICJ6b29tLWluIiwgbW96X3pvb21faW5fYml0cywgbW96X3pvb21faW5f bWFza19iaXRzLCA2LCA2IH0sCn07CgppbnQKbWFpbiAoKQp7CglndGtfaW5pdChOVUxMLCBOVUxM KTsKCglDdXN0b21DdXJzb3IgY3Vyc29yID0gQ3VzdG9tQ3Vyc29yc1swXTsKCUdka0N1cnNvciog ZGVmYXVsdF9jdXJzb3IgPSBnZGtfY3Vyc29yX25ld19mb3JfZGlzcGxheSAoZ2RrX2Rpc3BsYXlf Z2V0X2RlZmF1bHQoKSwgR0RLX0FSUk9XKTsKCWNhaXJvX3N1cmZhY2VfdCogc291cmNlID0gY2Fp cm9faW1hZ2Vfc3VyZmFjZV9jcmVhdGVfZm9yX2RhdGEoKHVuc2lnbmVkIGNoYXIqKWN1cnNvci5i aXRzLCBDQUlST19GT1JNQVRfQTEsIDMyLCAzMiwgNCk7CgljYWlyb19zdXJmYWNlX3QqIG1hc2sg PSBjYWlyb19pbWFnZV9zdXJmYWNlX2NyZWF0ZV9mb3JfZGF0YSgodW5zaWduZWQgY2hhciopY3Vy c29yLm1hc2tfYml0cywgQ0FJUk9fRk9STUFUX0ExLCAzMiwgMzIsIDQpOwoJY2Fpcm9fc3VyZmFj ZV90KiBzdXJmYWNlID0gY2Fpcm9faW1hZ2Vfc3VyZmFjZV9jcmVhdGUoQ0FJUk9fRk9STUFUX0Ex LCAzMiwgMzIpOwoJY2Fpcm9fdCogY3IgPSBjYWlyb19jcmVhdGUoc3VyZmFjZSk7CgoJY2Fpcm9f c2V0X3NvdXJjZV9zdXJmYWNlKGNyLCBzb3VyY2UsIDAsIDApOwoJY2Fpcm9fbWFza19zdXJmYWNl KGNyLCBtYXNrLCAwLCAwKTsKCglHZGtQaXhidWYqIHBpeGJ1ZiA9IGdka19waXhidWZfZ2V0X2Zy b21fc3VyZmFjZShzdXJmYWNlLCAwLCAwLCAzMiwgMzIpOwoJR2RrQ3Vyc29yICpnZGtfY3Vyc29y ID0gZ2RrX2N1cnNvcl9uZXdfZnJvbV9waXhidWYoZ2RrX2Rpc3BsYXlfZ2V0X2RlZmF1bHQoKSwg cGl4YnVmLCBjdXJzb3IuaG90X3gsIGN1cnNvci5ob3RfeSk7CgoJLyogVXNlIGRlZmF1bHRfY3Vy c29yIHRvIHJldHVybiBzYW5pdHkgdG8geW91ciBjdXJzb3IuICovCglnZGtfd2luZG93X3NldF9j dXJzb3IoZ2RrX3NjcmVlbl9nZXRfcm9vdF93aW5kb3cgKGdka19zY3JlZW5fZ2V0X2RlZmF1bHQo KSksIGRlZmF1bHRfY3Vyc29yKTsKCglndGtfbWFpbigpOwoJcmV0dXJuIDA7Cn0K 211011 2013-09-08 23:53:33 -0700 2013-09-09 00:30:41 -0700 Patch bug-120675-20130909095331.patch text/plain 1842 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDkzOTJlMDVjMmMzYmQ3 OTY5YzAyN2I5ODkyOTc4Mjc3MzM5MTFiZC4uM2RlOGJmMzA2MDFkNTBkMjU1MDE5OGNmZDFiZDdm ODQwY2ZkM2E0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA5LTA4ICBDbGF1 ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gIGdo b3N0IGN1cnNvciB3aGVuIG1vdXNlIGhvdmVycyBvdmVyIGFuIGltYWdlIGZpbGUgaW4gYSB0YWIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDY3NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cywgY292ZXJlZCBieSBleGlzdGluZy4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9DdXJz b3JHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlTmFtZWRDdXJzb3IpOiBVc2UgbmV3 IGdka19jdXJzb3JfbmV3X2Zyb21fc3VyZmFjZSgpCisgICAgICAgIHdoZW4gY29tcGlsaW5nIGFn YWluc3QgR1RLKyAzLjkuMTIgb3IgbmV3ZXIuCisKIDIwMTMtMDktMDUgIEVucmlxdWUgT2Nhw7Fh IEdvbnrDoWxleiAgPGVvY2FuaGFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBBc3NlcnRp b24gZmFpbHMgd2hlbiB0aGUgbW91c2UgcG9pbnRlciBpcyBzdHlsZWQgd2l0aCBhIGN1c3RvbSBj dXJzb3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9DdXJzb3JHdGsu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0N1cnNvckd0ay5jcHAKaW5kZXggZTY2 ODdhZmY5OTBjZTkzOWE5MmZiOTE5MzZiZDc5NTMyNDZiNGUyYS4uZDQ1ODYwZDQ4MWNiOThhZGVk NTRlOTVhMzAwMjg5YTgzYTM1YjZiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3RrL0N1cnNvckd0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0N1 cnNvckd0ay5jcHAKQEAgLTU0LDggKzU0LDEyIEBAIHN0YXRpYyBHUmVmUHRyPEdka0N1cnNvcj4g Y3JlYXRlTmFtZWRDdXJzb3IoQ3VzdG9tQ3Vyc29yVHlwZSBjdXJzb3JUeXBlKQogICAgIGNhaXJv X3NldF9zb3VyY2Vfc3VyZmFjZShjci5nZXQoKSwgc291cmNlLmdldCgpLCAwLCAwKTsKICAgICBj YWlyb19tYXNrX3N1cmZhY2UoY3IuZ2V0KCksIG1hc2suZ2V0KCksIDAsIDApOwogCisjaWYgR1RL X0NIRUNLX1ZFUlNJT04oMywgOSwgMTIpCisgICAgcmV0dXJuIGFkb3B0R1JlZihnZGtfY3Vyc29y X25ld19mcm9tX3N1cmZhY2UoZ2RrX2Rpc3BsYXlfZ2V0X2RlZmF1bHQoKSwgc3VyZmFjZS5nZXQo KSwgY3Vyc29yLmhvdF94LCBjdXJzb3IuaG90X3kpKTsKKyNlbHNlCiAgICAgR1JlZlB0cjxHZGtQ aXhidWY+IHBpeGJ1ZiA9IGFkb3B0R1JlZihnZGtfcGl4YnVmX2dldF9mcm9tX3N1cmZhY2Uoc3Vy ZmFjZS5nZXQoKSwgMCwgMCwgMzIsIDMyKSk7CiAgICAgcmV0dXJuIGFkb3B0R1JlZihnZGtfY3Vy c29yX25ld19mcm9tX3BpeGJ1ZihnZGtfZGlzcGxheV9nZXRfZGVmYXVsdCgpLCBwaXhidWYuZ2V0 KCksIGN1cnNvci5ob3RfeCwgY3Vyc29yLmhvdF95KSk7CisjZW5kaWYKIH0KIAogc3RhdGljIEdS ZWZQdHI8R2RrQ3Vyc29yPiBjcmVhdGVDdXN0b21DdXJzb3IoSW1hZ2UqIGltYWdlLCBjb25zdCBJ bnRQb2ludCYgaG90U3BvdCkK