120658 2013-09-03 18:39:30 -0700 Fix uninitialized build warning in make_names.pl 2013-09-03 20:33:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue esprehn+autocc kangil.han kling oldest_to_newest 924235 0 gyuyoung.kim 2013-09-03 18:39:30 -0700 There is build warning from r154965. Use of uninitialized value in numeric ne (!=) at /home/gyuyoung/webkit/WebKit/Source/WebCore/dom/make_names.pl line 625. 924236 1 210420 gyuyoung.kim 2013-09-03 18:42:35 -0700 Created attachment 210420 Patch 924244 2 210420 darin 2013-09-03 19:12:56 -0700 Comment on attachment 210420 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210420&action=review > Source/WebCore/dom/make_names.pl:625 > + if (!($parsedTags{$name}{generateTypeChecks})) { Is there a need for those parentheses? 924248 3 210422 gyuyoung.kim 2013-09-03 19:36:00 -0700 Created attachment 210422 Patch for landing 924249 4 gyuyoung.kim 2013-09-03 19:37:38 -0700 (In reply to comment #2) > (From update of attachment 210420 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=210420&action=review > > > Source/WebCore/dom/make_names.pl:625 > > + if (!($parsedTags{$name}{generateTypeChecks})) { > > Is there a need for those parentheses? I don't think there is a need in this case. Fixed. 924263 5 210422 commit-queue 2013-09-03 20:33:09 -0700 Comment on attachment 210422 Patch for landing Clearing flags on attachment: 210422 Committed r155016: <http://trac.webkit.org/changeset/155016> 924264 6 commit-queue 2013-09-03 20:33:13 -0700 All reviewed patches have been landed. Closing bug. 210420 2013-09-03 18:42:35 -0700 2013-09-03 19:35:52 -0700 Patch bug-120658-20130904104233.patch text/plain 1242 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTlmZDE0MGVhNjdlMjU0 MzUxY2JkMmRmZWEyZmRhMGQyOTc4NTNkNy4uMDVkM2ZiYjUzNmU0ZGU0NDQ2NWQ0MTRlNDgyYWU1 ODE1MjdmMTBkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA5LTAzICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IHVuaW5p dGlhbGl6ZWQgYnVpbGQgd2FybmluZyBpbiBtYWtlX25hbWVzLnBsCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA2NTgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9y IGNoYW5nZS4KKworICAgICAgICAqIGRvbS9tYWtlX25hbWVzLnBsOgorICAgICAgICAocHJpbnRU eXBlQ2hlY2tzKTogRml4ZWQgYSBidWlsZCB3YXJuaW5nIHNpbmNlIHIxNTQ5NjUuCisKIDIwMTMt MDktMDMgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBDYW4n dCBzZWxlY3QgS2F0YWthbmEgd29yZCBieSBkb3VibGUtY2xpY2tpbmcuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9kb20vbWFrZV9uYW1lcy5wbCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9tYWtl X25hbWVzLnBsCmluZGV4IGY5NjZmZmJhNDc2ZTM1N2UxOGJiMDQ4YjVmMDJiYzBlM2ZiOGEwNDcu LjJhYzkyMDJjMmU1MDJhNmQ0MzBjM2QwMzBlZDE0MjBhMTk1ZWE4ZDYgMTAwNzU1Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9tYWtlX25hbWVzLnBsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9t YWtlX25hbWVzLnBsCkBAIC02MjIsNyArNjIyLDcgQEAgc3ViIHByaW50VHlwZUNoZWNrcwogICAg IG15ICVuYW1lcyA9ICUkbmFtZXNSZWY7CiAKICAgICBmb3IgbXkgJG5hbWUgKHNvcnQga2V5cyAl bmFtZXMpIHsKLSAgICAgICAgaWYgKCRwYXJzZWRUYWdzeyRuYW1lfXtnZW5lcmF0ZVR5cGVDaGVj a3N9ICE9IDEpIHsKKyAgICAgICAgaWYgKCEoJHBhcnNlZFRhZ3N7JG5hbWV9e2dlbmVyYXRlVHlw ZUNoZWNrc30pKSB7CiAgICAgICAgICAgICBuZXh0OwogICAgICAgICB9CiAK 210422 2013-09-03 19:36:00 -0700 2013-09-03 20:33:09 -0700 Patch for landing bug-120658-20130904113558.patch text/plain 1239 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTlmZDE0MGVhNjdlMjU0 MzUxY2JkMmRmZWEyZmRhMGQyOTc4NTNkNy4uODY2M2VkNTc3ZDkyNWJlOTg2ZmY0MDZmYTc1YjA0 YjM0ZGI3Yjk2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA5LTAzICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IHVuaW5p dGlhbGl6ZWQgYnVpbGQgd2FybmluZyBpbiBtYWtlX25hbWVzLnBsCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA2NTgKKworICAgICAgICBSZXZpZXdl ZCBieSBBbmRyZWFzIEtsaW5nLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3Ig Y2hhbmdlLgorCisgICAgICAgICogZG9tL21ha2VfbmFtZXMucGw6CisgICAgICAgIChwcmludFR5 cGVDaGVja3MpOiBGaXhlZCBhIGJ1aWxkIHdhcm5pbmcgc2luY2UgcjE1NDk2NS4KKwogMjAxMy0w OS0wMyAgRW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIENhbid0 IHNlbGVjdCBLYXRha2FuYSB3b3JkIGJ5IGRvdWJsZS1jbGlja2luZy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9tYWtlX25hbWVzLnBsIGIvU291cmNlL1dlYkNvcmUvZG9tL21ha2Vf bmFtZXMucGwKaW5kZXggZjk2NmZmYmE0NzZlMzU3ZTE4YmIwNDhiNWYwMmJjMGUzZmI4YTA0Ny4u ZDQzYWNmZjQzMzNhYWMzODExZjZmMTRkNWE3OGFjODA0ZmE0MDQ3YSAxMDA3NTUKLS0tIGEvU291 cmNlL1dlYkNvcmUvZG9tL21ha2VfbmFtZXMucGwKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL21h a2VfbmFtZXMucGwKQEAgLTYyMiw3ICs2MjIsNyBAQCBzdWIgcHJpbnRUeXBlQ2hlY2tzCiAgICAg bXkgJW5hbWVzID0gJSRuYW1lc1JlZjsKIAogICAgIGZvciBteSAkbmFtZSAoc29ydCBrZXlzICVu YW1lcykgewotICAgICAgICBpZiAoJHBhcnNlZFRhZ3N7JG5hbWV9e2dlbmVyYXRlVHlwZUNoZWNr c30gIT0gMSkgeworICAgICAgICBpZiAoISRwYXJzZWRUYWdzeyRuYW1lfXtnZW5lcmF0ZVR5cGVD aGVja3N9KSB7CiAgICAgICAgICAgICBuZXh0OwogICAgICAgICB9CiAK