120655 2013-09-03 16:21:30 -0700 The test inspector/geolocation-success.html is unreliable 2013-09-03 16:56:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 924206 0 benjamin 2013-09-03 16:21:30 -0700 The test inspector/geolocation-success.html is unreliable 924208 1 210417 benjamin 2013-09-03 16:24:18 -0700 Created attachment 210417 Patch 924209 2 210417 ap 2013-09-03 16:29:53 -0700 Comment on attachment 210417 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210417&action=review > LayoutTests/inspector/geolocation-success.html:35 > + testRunner.evaluateInWebInspector(callID, webInspectorCallbackString); > + ++callID; Can 0 be passed as call id? It doesn't look like it's used for anything, unless that is really well hidden. 924214 3 benjamin 2013-09-03 16:56:48 -0700 Committed r155009: <http://trac.webkit.org/changeset/155009> 210417 2013-09-03 16:24:18 -0700 2013-09-03 16:29:52 -0700 Patch bug-120655-20130903162418.patch text/plain 3153 benjamin SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE1NTAwOCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA5LTAzICBCZW5qYW1pbiBQb3VsYWlu ICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBUaGUgdGVzdCBpbnNwZWN0b3IvZ2Vv bG9jYXRpb24tc3VjY2Vzcy5odG1sIGlzIHVucmVsaWFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDY1NQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2dlb2xvY2F0aW9uLXN1Y2Nl c3MtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGluc3BlY3Rvci9nZW9sb2NhdGlvbi1zdWNjZXNz Lmh0bWw6CisgICAgICAgIFRoZSB0ZXN0IHdhcyBleHBlY3RpbmcgZXZlcnl0aGluZyB3b3VsZCBi ZSBkb25lIGluIHRoZSBwYWdlIGNvbnRleHQKKyAgICAgICAgd2hlbiBJbnNwZWN0b3JUZXN0LmV2 YWx1YXRlSW5QYWdlIGludm9rZSB0aGUgY2FsbGJhY2suCisKKyAgICAgICAgVGhpcyBpcyBub3Qg dGhlIGNhc2UsIGdlb2xvY2F0aW9uIEFQSXMgYXJlIGFzeW5jaHJvbm91cy4KKyAgICAgICAgVGhl IGNhbGxiYWNrcyBwcmludExvY2F0aW9uKCkgYW5kIHByaW50RXJyb3IoKSBtYXkgb3IgbWF5IG5v dCBiZSBleGVjdXRlZC4KKworICAgICAgICBUbyBmaXggdGhpcywgdGhlIGV4ZWN1dGlvbiBvZiBl YWNoIHN0ZXAgaXMgY2hhbmdlZCB0byBkZXBlbmRzIG9uIHRoZSBjb21wbGV0aW9uCisgICAgICAg IG9mIHRoZSBnZW9sb2NhdGlvbiBjYWxsYmFjay4KKwogMjAxMy0wOS0wMyAgT2xpdmVyIEh1bnQg IDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFN1cHBvcnQgc3RydWN0dXJlZCBjbG9uZSBv ZiBNYXAgYW5kIFNldApJbmRleDogTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2dlb2xvY2F0aW9uLXN1 Y2Nlc3MtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2luc3BlY3Rvci9n ZW9sb2NhdGlvbi1zdWNjZXNzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMTU0OTk4KQorKysgTGF5 b3V0VGVzdHMvaW5zcGVjdG9yL2dlb2xvY2F0aW9uLXN1Y2Nlc3MtZXhwZWN0ZWQudHh0CSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMyBAQAotQ09OU09MRSBNRVNTQUdFOiBsaW5lIDIyOiBsYXQ6 IDQzLjQ3NjA5MywgbG9uZzogLTgwLjU0MDI5OQotQ09OU09MRSBNRVNTQUdFOiBsaW5lIDIyOiBs YXQ6IDUxLjQ3OCwgbG9uZzogLTAuMTY2CitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMjQ6IGxhdDog NDMuNDc2MDkzLCBsb25nOiAtODAuNTQwMjk5CitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMjQ6IGxh dDogNTEuNDc4LCBsb25nOiAtMC4xNjYKIApJbmRleDogTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2dl b2xvY2F0aW9uLXN1Y2Nlc3MuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9pbnNwZWN0 b3IvZ2VvbG9jYXRpb24tc3VjY2Vzcy5odG1sCShyZXZpc2lvbiAxNTQ5OTgpCisrKyBMYXlvdXRU ZXN0cy9pbnNwZWN0b3IvZ2VvbG9jYXRpb24tc3VjY2Vzcy5odG1sCSh3b3JraW5nIGNvcHkpCkBA IC0xNSwzMiArMTUsMzggQEAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CiB9IGVsc2UKICAgICBk ZWJ1ZygnVGhpcyB0ZXN0IGNhbiBub3QgYmUgcnVuIHdpdGhvdXQgdGhlIExheW91dFRlc3RDb250 cm9sbGVyJyk7CiAKLWZ1bmN0aW9uIGdldEdlb2xvY2F0aW9uKCkKK3ZhciBjYWxsSUQgPSAwOwor CitmdW5jdGlvbiBnZXRHZW9sb2NhdGlvbih3ZWJJbnNwZWN0b3JDYWxsYmFja1N0cmluZykKIHsK ICAgICBmdW5jdGlvbiBwcmludExvY2F0aW9uKHBvcykKICAgICB7CiAgICAgICAgIGNvbnNvbGUu bG9nKCdsYXQ6ICcgKyBwb3MuY29vcmRzLmxhdGl0dWRlICsgJywgbG9uZzogJyArIHBvcy5jb29y ZHMubG9uZ2l0dWRlKTsKKyAgICAgICAgZmluaXNoVGVzdCgpOwogICAgIH0KICAgICBmdW5jdGlv biBwcmludEVycm9yKGVycikKICAgICB7CiAgICAgICAgIGNvbnNvbGUubG9nKCdFcnJvcjogJyAr IGVyci5jb2RlKTsKKyAgICAgICAgZmluaXNoVGVzdCgpOworICAgIH0KKyAgICBmdW5jdGlvbiBm aW5pc2hUZXN0KCkKKyAgICB7CisgICAgICAgIHRlc3RSdW5uZXIuZXZhbHVhdGVJbldlYkluc3Bl Y3RvcihjYWxsSUQsIHdlYkluc3BlY3RvckNhbGxiYWNrU3RyaW5nKTsKKyAgICAgICAgKytjYWxs SUQ7CiAgICAgfQogICAgIG5hdmlnYXRvci5nZW9sb2NhdGlvbi5nZXRDdXJyZW50UG9zaXRpb24o cHJpbnRMb2NhdGlvbiwgcHJpbnRFcnJvciwgW10pCiB9CiAKIGZ1bmN0aW9uIHRlc3QoKQogewot ICAgIGZ1bmN0aW9uIGNhbGxiYWNrQ29tcGxldGUoKQotICAgIHsKLSAgICAgICAgSW5zcGVjdG9y VGVzdC5jb21wbGV0ZVRlc3QoKTsKLSAgICB9Ci0gICAgZnVuY3Rpb24gY2FsbGJhY2soKQorICAg IHdpbmRvdy50ZXN0U3RlcDIgPSBmdW5jdGlvbigpCiAgICAgewogICAgICAgICBQYWdlQWdlbnQu Y2xlYXJHZW9sb2NhdGlvbk92ZXJyaWRlKCk7Ci0gICAgICAgIEluc3BlY3RvclRlc3QuZXZhbHVh dGVJblBhZ2UoImdldEdlb2xvY2F0aW9uKCkiLCBjYWxsYmFja0NvbXBsZXRlKTsKKyAgICAgICAg SW5zcGVjdG9yVGVzdC5ldmFsdWF0ZUluUGFnZSgiZ2V0R2VvbG9jYXRpb24oJ0luc3BlY3RvclRl c3QuY29tcGxldGVUZXN0KCknKSIpOwogICAgIH0KKwogICAgIFBhZ2VBZ2VudC5zZXRHZW9sb2Nh dGlvbk92ZXJyaWRlKDQzLjQ3NjA5MywgLTgwLjU0MDI5OSwgMTUwKTsKLSAgICBJbnNwZWN0b3JU ZXN0LmV2YWx1YXRlSW5QYWdlKCJnZXRHZW9sb2NhdGlvbigpIiwgY2FsbGJhY2spOworICAgIElu c3BlY3RvclRlc3QuZXZhbHVhdGVJblBhZ2UoImdldEdlb2xvY2F0aW9uKCd3aW5kb3cudGVzdFN0 ZXAyKCknKSIpOwogfQogCiAK