120639 2013-09-03 10:27:52 -0700 ASSERT in MarkedAllocator::allocateSlowCase is wrong 2013-09-04 14:01:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg benjamin commit-queue oldest_to_newest 924074 0 mhahnenberg 2013-09-03 10:27:52 -0700 ASSERT(!m_heap->shouldCollect()) is no longer true due to our use of the GC deferral mechanism. We could technically be beyond our byte allocation limit, but still not try to collect due to deferral. We should either amend shouldCollect to account for GC deferral or remove this ASSERT. 924081 1 210385 mhahnenberg 2013-09-03 10:39:43 -0700 Created attachment 210385 Patch 924539 2 mhahnenberg 2013-09-04 11:43:38 -0700 <rdar://problem/14858879> 924547 3 210385 commit-queue 2013-09-04 12:05:27 -0700 Comment on attachment 210385 Patch Clearing flags on attachment: 210385 Committed r155056: <http://trac.webkit.org/changeset/155056> 924548 4 commit-queue 2013-09-04 12:05:29 -0700 All reviewed patches have been landed. Closing bug. 924597 5 benjamin 2013-09-04 14:01:35 -0700 The debug bots started crashing. E.g.: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r155055%20(12191)/results.html It looks related to this change. Can you please have a look? 210385 2013-09-03 10:39:43 -0700 2013-09-04 12:05:27 -0700 Patch bug-120639-20130903103948.patch text/plain 1564 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU0OTkwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEzLTA5LTAzICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgQVNTRVJUIGluIE1hcmtlZEFsbG9jYXRvcjo6YWxsb2NhdGVTbG93Q2FzZSBpcyB3 cm9uZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIw NjM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQVNT RVJUKCFtX2hlYXAtPnNob3VsZENvbGxlY3QoKSkgaXMgbm8gbG9uZ2VyIHRydWUgZHVlIHRvIG91 ciB1c2Ugb2YgdGhlIEdDIAorICAgICAgICBkZWZlcnJhbCBtZWNoYW5pc20uIFdlIGNvdWxkIHRl Y2huaWNhbGx5IGJlIGJleW9uZCBvdXIgYnl0ZSBhbGxvY2F0aW9uIGxpbWl0LCAKKyAgICAgICAg YnV0IHN0aWxsIG5vdCB0cnkgdG8gY29sbGVjdCBkdWUgdG8gZGVmZXJyYWwuIFRoaXMgcGF0Y2gg YW1lbmRzIHNob3VsZENvbGxlY3QoKSAKKyAgICAgICAgdG8gcmV0dXJuIGZhbHNlIGlmIEdDIGlz IGN1cnJlbnRseSBkZWZlcnJlZC4KKworICAgICAgICAqIGhlYXAvSGVhcC5oOgorICAgICAgICAo SlNDOjpIZWFwOjpzaG91bGRDb2xsZWN0KToKKwogMjAxMy0wOS0wMiAgRmlsaXAgUGl6bG8gIDxm cGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIENvZGVCbG9jazo6amV0dGlzb24oKSBzaG91bGQg YmUgaW1wbGljaXQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmgJKHJldmlzaW9uIDE1 NDk4OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuaAkod29ya2luZyBjb3B5 KQpAQCAtMzA1LDYgKzMwNSw4IEBAIG5hbWVzcGFjZSBKU0MgewogCiAgICAgaW5saW5lIGJvb2wg SGVhcDo6c2hvdWxkQ29sbGVjdCgpCiAgICAgeworICAgICAgICBpZiAoaXNEZWZlcnJlZCgpKQor ICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICBpZiAoT3B0aW9uczo6Z2NNYXhIZWFw U2l6ZSgpKQogICAgICAgICAgICAgcmV0dXJuIG1fYnl0ZXNBbGxvY2F0ZWQgPiBPcHRpb25zOjpn Y01heEhlYXBTaXplKCkgJiYgbV9pc1NhZmVUb0NvbGxlY3QgJiYgbV9vcGVyYXRpb25JblByb2dy ZXNzID09IE5vT3BlcmF0aW9uOwogICAgICAgICByZXR1cm4gbV9ieXRlc0FsbG9jYXRlZCA+IG1f Ynl0ZXNBbGxvY2F0ZWRMaW1pdCAmJiBtX2lzU2FmZVRvQ29sbGVjdCAmJiBtX29wZXJhdGlvbklu UHJvZ3Jlc3MgPT0gTm9PcGVyYXRpb247Cg==