120632 2013-09-03 05:40:27 -0700 [Qt] Images scaled poorly in canvas 2013-09-03 08:31:08 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen commit-queue jturcotte michael.bruning noam oldest_to_newest 923963 0 allan.jensen 2013-09-03 05:40:27 -0700 The WebKit canvas code assumes that antialiasing and average image quality is enabled by default. The Qt ImageBuffer implementation does not however set any default render-hints causing the defaults in the GraphicsContext to be antialiasing and smooth scaling disabled. Ideally these default should follow the render-hints set on the webview, but I don't see how that is possible currently, so let us default the defaults to the default. 923964 1 allan.jensen 2013-09-03 05:40:54 -0700 Btw, this is Issue 2 from https://bugreports.qt-project.org/browse/QTBUG-33081. 923965 2 210360 allan.jensen 2013-09-03 05:42:46 -0700 Created attachment 210360 Patch 924009 3 210372 allan.jensen 2013-09-03 07:44:25 -0700 Created attachment 210372 Patch Moved the fix to better defining image-interpolation quality in TextureMapper since that is where the problem is. 924022 4 allan.jensen 2013-09-03 08:31:08 -0700 Committed r154985: <http://trac.webkit.org/changeset/154985> 210360 2013-09-03 05:42:46 -0700 2013-09-03 07:44:20 -0700 Patch bug-120632-20130903144244.patch text/plain 1626 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0OTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODllN2MyZTA4M2VkMTlk NjFkOTNhZTVmYTYxNjAyMzk4Yjg5ZjQwYy4uYmY3NzU0MDQ1M2EwMzc2NjBmYjkyMTE1Zjk4NjQ3 ZWIxNzVlNTA0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEzLTA5LTAzICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgogCisgICAgICAgIFtR dF0gSW1hZ2VzIHNjYWxlZCBwb29ybHkgaW4gY2FudmFzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA2MzIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGUgc21vb3RoLXNjYWxpbmcgYW5kIGFudGlh bGlhc2luZyBieSBkZWZhdWx0IG9uIHRoZSBRUGFpbnRlciwKKyAgICAgICAgdG8gbWFrZSB0aGVt IGRlZmF1bHQgaW4gdGhlIEdyYXBoaWNzQ29udGV4dC4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL3F0L0ltYWdlQnVmZmVyUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VCdWZm ZXJEYXRhOjpJbWFnZUJ1ZmZlckRhdGEpOgorCisyMDEzLTA5LTAzICBBbGxhbiBTYW5kZmVsZCBK ZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCiAgICAgICAgIFtRdF0gUmVtb3ZlIGRl YWQgY29kZSBmb3IgUXRYbWxQYXR0ZXJucwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTIwNjI0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlQnVmZmVyUXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VCdWZmZXJRdC5jcHAKaW5kZXggNmIxM2EyNjY0MmFkNWQ1 MzYyZjM5ZTVhNTg4ZGEzNzdmYjJiOTAxOC4uMTY0MTljNjc1YzJiMzc4N2IyMDNiODcwMTU2ZmJi YWFjZmNlY2MwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv cXQvSW1hZ2VCdWZmZXJRdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvcXQvSW1hZ2VCdWZmZXJRdC5jcHAKQEAgLTc1LDcgKzc1LDkgQEAgSW1hZ2VCdWZmZXJEYXRh OjpJbWFnZUJ1ZmZlckRhdGEoY29uc3QgSW50U2l6ZSYgc2l6ZSkKICAgICBicnVzaC5zZXRDb2xv cihRdDo6YmxhY2spOwogICAgIHBhaW50ZXItPnNldEJydXNoKGJydXNoKTsKICAgICBwYWludGVy LT5zZXRDb21wb3NpdGlvbk1vZGUoUVBhaW50ZXI6OkNvbXBvc2l0aW9uTW9kZV9Tb3VyY2VPdmVy KTsKLSAgICAKKyAgICBwYWludGVyLT5zZXRSZW5kZXJIaW50KFFQYWludGVyOjpBbnRpYWxpYXNp bmcsIHRydWUpOworICAgIHBhaW50ZXItPnNldFJlbmRlckhpbnQoUVBhaW50ZXI6OlNtb290aFBp eG1hcFRyYW5zZm9ybSwgdHJ1ZSk7CisKICAgICBtX2ltYWdlID0gU3RpbGxJbWFnZTo6Y3JlYXRl Rm9yUmVuZGVyaW5nKCZtX3BpeG1hcCk7CiB9CiAK 210372 2013-09-03 07:44:25 -0700 2013-09-03 07:47:25 -0700 Patch bug-120632-20130903164423.patch text/plain 2280 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0OTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDM4NzRmNDVhNDc5 ZTc5MWEyZGUyZTY4OGYxOGNmZTY0MTc5ODBmMDcuLjU0ZWUwNjdjMTU2ZTg0ZTlhYzBhODBlZDZi YTFjZDYyNDYyZGI5ZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTMtMDkt MDMgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CiAKKyAg ICAgICAgW1F0XSBJbWFnZXMgc2NhbGVkIHBvb3JseSBpbiBjYW52YXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDYzMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4cGxpY2l0bHkgc2V0IGEgaW1hZ2VJ bnRlcnBvbGF0aW9uUXVhbGl0eSBvbiB0aGUgVGV4dHVyZU1hcHBlciwgYmVjYXVzZQorICAgICAg ICBJbnRlcnBvbGF0aW9uRGVmYXVsdCBtYXkgYmUgaW50ZXJwcmV0ZWQgZGlmZmVyZW50bHkgYnkg bmVzdGVkIEdyYXBoaWNzQ29udGV4dHMuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9UZXh0 dXJlTWFwcGVyTGF5ZXJDbGllbnRRdC5jcHA6CisgICAgICAgIChUZXh0dXJlTWFwcGVyTGF5ZXJD bGllbnRRdDo6cmVuZGVyQ29tcG9zaXRlZExheWVycyk6CisKKzIwMTMtMDktMDMgIEFsbGFuIFNh bmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CisKICAgICAgICAgW1F0XVtX SzFdIFBhZ2VWaXNpYmlsaXR5IHRlc3RzIGFyZSBmbGFreQogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwNDE4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvVGV4dHVyZU1hcHBlckxheWVyQ2xpZW50UXQuY3BwIGIv U291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9UZXh0dXJlTWFwcGVyTGF5ZXJDbGllbnRR dC5jcHAKaW5kZXggMDFkYWNmMGI1MzI1MjhiY2M4ODUwMmNiM2FhMzc5OGEzNDI3MDlkOC4uNDY1 ODU3ZmFmMDI2MWNhMGI3NmNkNTQyNzMwMDJkOGQyMGRlOGU2NiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9UZXh0dXJlTWFwcGVyTGF5ZXJDbGllbnRRdC5jcHAK KysrIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9UZXh0dXJlTWFwcGVyTGF5ZXJD bGllbnRRdC5jcHAKQEAgLTEwNCw3ICsxMDQsMTQgQEAgdm9pZCBUZXh0dXJlTWFwcGVyTGF5ZXJD bGllbnRRdDo6cmVuZGVyQ29tcG9zaXRlZExheWVycyhHcmFwaGljc0NvbnRleHQqIGNvbnRleHQK ICAgICAgICAgcmV0dXJuOwogCiAgICAgbV90ZXh0dXJlTWFwcGVyLT5zZXRHcmFwaGljc0NvbnRl eHQoY29udGV4dCk7Ci0gICAgbV90ZXh0dXJlTWFwcGVyLT5zZXRJbWFnZUludGVycG9sYXRpb25R dWFsaXR5KGNvbnRleHQtPmltYWdlSW50ZXJwb2xhdGlvblF1YWxpdHkoKSk7CisgICAgLy8gR3Jh cGhpY3NDb250ZXh0OjppbWFnZUludGVycG9sYXRpb25RdWFsaXR5IGlzIGFsd2F5cyBJbnRlcnBv bGF0aW9uRGVmYXVsdCBoZXJlLAorICAgIC8vIGJ1dCAnZGVmYXVsdCcgbWF5IGJlIGludGVycHJl dGVkIGRpZmZlcmVudGx5IGR1ZSB0byBhIGRpZmZlcmVudCBiYWNrZW5kIFFQYWludGVyLAorICAg IC8vIHNvIHdlIG5lZWQgdG8gc2V0IGFuIGV4cGxpY2l0IGltYWdlSW50ZXJwb2xhdGlvblF1YWxp dHkuCisgICAgaWYgKGNvbnRleHQtPnBsYXRmb3JtQ29udGV4dCgpLT5yZW5kZXJIaW50cygpICYg UVBhaW50ZXI6OlNtb290aFBpeG1hcFRyYW5zZm9ybSkKKyAgICAgICAgbV90ZXh0dXJlTWFwcGVy LT5zZXRJbWFnZUludGVycG9sYXRpb25RdWFsaXR5KFdlYkNvcmU6OkludGVycG9sYXRpb25NZWRp dW0pOworICAgIGVsc2UKKyAgICAgICAgbV90ZXh0dXJlTWFwcGVyLT5zZXRJbWFnZUludGVycG9s YXRpb25RdWFsaXR5KFdlYkNvcmU6OkludGVycG9sYXRpb25Ob25lKTsKKwogICAgIG1fdGV4dHVy ZU1hcHBlci0+c2V0VGV4dERyYXdpbmdNb2RlKGNvbnRleHQtPnRleHREcmF3aW5nTW9kZSgpKTsK ICAgICBRUGFpbnRlciogcGFpbnRlciA9IGNvbnRleHQtPnBsYXRmb3JtQ29udGV4dCgpOwogICAg IGNvbnN0IFFUcmFuc2Zvcm0gdHJhbnNmb3JtID0gcGFpbnRlci0+d29ybGRUcmFuc2Zvcm0oKTsK