120617 2013-09-02 23:47:12 -0700 Change type of Document::doctype back to a raw pointer 2019-02-06 09:03:03 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin cdumez commit-queue esprehn+autocc kangil.han kling oldest_to_newest 923860 0 darin 2013-09-02 23:47:12 -0700 Change type of Document::doctype back to a raw pointer 923861 1 210327 darin 2013-09-02 23:49:13 -0700 Created attachment 210327 Patch 923862 2 darin 2013-09-02 23:49:44 -0700 Kling, did you have a good reason to change this to a RefPtr? 923989 3 210327 kling 2013-09-03 06:53:25 -0700 Comment on attachment 210327 Patch Sure. r=me You should change documentTypeString() in markup.cpp back as well. 924003 4 kling 2013-09-03 07:37:17 -0700 (In reply to comment #2) > Kling, did you have a good reason to change this to a RefPtr? Not a great one. I felt that since this function is not performance-critical and its primary purpose is providing web API, we might as well tailor it to that use case. If that makes it a little more awkward to use it internally, all the better. BUT now that I look closer, it appears that JSC bindings don't actually handle PassRefPtr return values so well, and we end up with an extra ref/deref pair! :( 924055 5 darin 2013-09-03 10:03:15 -0700 (In reply to comment #4) > I felt that since this function is not performance-critical and its primary purpose is providing web API, we might as well tailor it to that use case. If that makes it a little more awkward to use it internally, all the better. It seems OK to me to put the ref into the bindings rather than into the function in the DOM itself. In my opinion, functions should not return a PassRefPtr if it they don’t need to. For one thing, if there's already a wrapper there is no need to ref the pointer. > BUT now that I look closer, it appears that JSC bindings don't actually handle PassRefPtr return values so well, and we end up with an extra ref/deref pair! :( Oh, we should fix that. 924278 6 darin 2013-09-03 21:52:18 -0700 Committed r155019: <http://trac.webkit.org/changeset/155019> 1502894 7 lforschler 2019-02-06 09:03:03 -0800 Mass moving XML DOM bugs to the "DOM" Component. 210327 2013-09-02 23:49:13 -0700 2013-09-03 06:53:24 -0700 Patch bug-120617-20130902234913.patch text/plain 3171 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0OTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2E5ZDkyYmM1MGJiNWI3 YTIwNDYyOGU2YTI3YjA2OWI0ZjBlOThiNi4uN2JkNTNlZTc5ODRjZDNhNGVkMTY5N2Q2OTNlMGRh M2QwMWQzYTE5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEzLTA5LTAyICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAorICAgICAgICBDaGFuZ2UgdHlwZSBvZiBEb2N1 bWVudDo6ZG9jdHlwZSBiYWNrIHRvIGEgcmF3IHBvaW50ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDYxNworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkRvY3VtZW50Ojpkb2N0eXBlKTogUmV0dXJuIGEgcmF3IHBvaW50ZXIuCisgICAg ICAgIChXZWJDb3JlOjpEb2N1bWVudDo6Y2hpbGRyZW5DaGFuZ2VkKTogVXNlIHRoZSByYXcgcG9p bnRlci4KKyAgICAgICAgQWxzbyBhZGRlZCBhIEZJWE1FIGFib3V0IHRoaXMgY29kZSB0aGF0IGlz IHByb2JhYmx5IGluIHRoZSB3cm9uZyBwbGFjZS4KKyAgICAgICAgKiBkb20vRG9jdW1lbnQuaDog TW9yZSBvZiB0aGUgc2FtZS4KKworMjAxMy0wOS0wMiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBs ZS5jb20+CisKICAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yUHJvZmlsZXJBZ2VudC5jcHA6 CiAgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JQcm9maWxlckFnZW50OjpyZW1vdmVQcm9maWxl KTogRml4IGJyYWNlcyBoZXJlOyBhIHJldmlldwogICAgICAgICBjb21tZW50IEkgZm9yZ290IHRv IGFkZHJlc3MgaW4gbXkgbGFzdCBjaGVjay1pbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4 IDM1NGUxNzliZDYwY2U3YTEyYzgxZjY0YjQ1NmI2ODcwYWY1NTNiODIuLjI1MTJjNzI2NjIxOWI0 Y2IyYjMyNWJjYmFmM2IzMzllNGNmNDRjYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAt NzU2LDcgKzc1Niw3IEBAIGJvb2wgRG9jdW1lbnQ6Omhhc01hbmlmZXN0KCkgY29uc3QKICAgICBy ZXR1cm4gZG9jdW1lbnRFbGVtZW50KCkgJiYgZG9jdW1lbnRFbGVtZW50KCktPmhhc1RhZ05hbWUo aHRtbFRhZykgJiYgZG9jdW1lbnRFbGVtZW50KCktPmhhc0F0dHJpYnV0ZShtYW5pZmVzdEF0dHIp OwogfQogCi1QYXNzUmVmUHRyPERvY3VtZW50VHlwZT4gRG9jdW1lbnQ6OmRvY3R5cGUoKSBjb25z dAorRG9jdW1lbnRUeXBlKiBEb2N1bWVudDo6ZG9jdHlwZSgpIGNvbnN0CiB7CiAgICAgZm9yIChO b2RlKiBub2RlID0gZmlyc3RDaGlsZCgpOyBub2RlOyBub2RlID0gbm9kZS0+bmV4dFNpYmxpbmco KSkgewogICAgICAgICBpZiAobm9kZS0+aXNEb2N1bWVudFR5cGVOb2RlKCkpCkBAIC03NzIsNyAr NzcyLDExIEBAIHZvaWQgRG9jdW1lbnQ6OmNoaWxkcmVuQ2hhbmdlZChjb25zdCBDaGlsZENoYW5n ZSYgY2hhbmdlKQogICAgIC8vIE5PVEU6IFBlciBET00sIGR5bmFtaWNhbGx5IGluc2VydGluZy9y ZW1vdmluZyBkb2N0eXBlIG5vZGVzIGRvZXNuJ3QgYWZmZWN0IGNvbXBhdGliaWxpdHkgbW9kZS4K IAogI2lmIEVOQUJMRShMRUdBQ1lfVklFV1BPUlRfQURBUFRJT04pCi0gICAgaWYgKFJlZlB0cjxE b2N1bWVudFR5cGU+IGRvY3VtZW50VHlwZSA9IGRvY3R5cGUoKSkgeworICAgIC8vIEZJWE1FOiBJ dCdzIGEgbGl0dGxlIHN0cmFuZ2UgdG8gYWRkIHRoZXNlIHJ1bGVzIHdoZW4gYSBEb2N1bWVudFR5 cGUgd2l0aCB0aGlzIHByZWZpeCBpcyBhZGRlZCwKKyAgICAvLyBidXQgbm90IHJlbW92ZSB0aGVz ZSBydWxlcyB3aGVuIGEgRG9jdW1lbnRUeXBlIHdpdGggdGhpcyBwcmVmaXggaXMgcmVtb3ZlZC4g SXQgc2VlbXMgdGhpcyBzaG91bGQKKyAgICAvLyBiZSBoYW5kbGVkIG1vcmUgdGhlIHdheSB0aGUg Y29tcGF0aWJpbGl0eSBtb2RlIGlzLCBieSBmZXRjaGluZyB0aGUgZG9jdHlwZSBhdCB0aGUgYXBw cm9wcmlhdGUgdGltZSwKKyAgICAvLyByYXRoZXIgdGhhbiBieSByZXNwb25kaW5nIHdoZW4gYSBk b2N1bWVudCB0eXBlIG5vZGUgaXMgaW5zZXJ0ZWQuCisgICAgaWYgKERvY3VtZW50VHlwZSogZG9j dW1lbnRUeXBlID0gZG9jdHlwZSgpKSB7CiAgICAgICAgIGlmIChkb2N1bWVudFR5cGUtPnB1Ymxp Y0lkKCkuc3RhcnRzV2l0aCgiLS8vd2FwZm9ydW0vL2R0ZCB4aHRtbCBtb2JpbGUgMS4iLCAvKiBj YXNlU2Vuc2l0aXZlICovIGZhbHNlKSkKICAgICAgICAgICAgIHByb2Nlc3NWaWV3cG9ydCgid2lk dGg9ZGV2aWNlLXdpZHRoLCBoZWlnaHQ9ZGV2aWNlLWhlaWdodCIsIFZpZXdwb3J0QXJndW1lbnRz OjpYSFRNTE1vYmlsZVByb2ZpbGUpOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2RvbS9Eb2N1bWVudC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKaW5kZXggYjlj OTk2Njc4NmY0NjgxMDJiNmUxYzE1NmQwOGNkODJmM2FmM2E1Yy4uZjI2ZTMwOGY0ZTUxN2VmM2M1 MmNkYzgzODc0YzQ3NTY0OTE1NjdiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0Rv Y3VtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKQEAgLTMyNyw3ICsz MjcsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRSZWZlcnJlclBvbGljeShSZWZlcnJlclBvbGlj eSByZWZlcnJlclBvbGljeSkgeyBtX3JlZmVycmVyUG9saWN5ID0gcmVmZXJyZXJQb2xpY3k7IH0K ICAgICBSZWZlcnJlclBvbGljeSByZWZlcnJlclBvbGljeSgpIGNvbnN0IHsgcmV0dXJuIG1fcmVm ZXJyZXJQb2xpY3k7IH0KIAotICAgIFBhc3NSZWZQdHI8RG9jdW1lbnRUeXBlPiBkb2N0eXBlKCkg Y29uc3Q7CisgICAgRG9jdW1lbnRUeXBlKiBkb2N0eXBlKCkgY29uc3Q7CiAKICAgICBET01JbXBs ZW1lbnRhdGlvbiogaW1wbGVtZW50YXRpb24oKTsKICAgICAK