120614 2013-09-02 21:21:19 -0700 enable filter-build-webkit for logs on build.webkit.org 2013-09-12 16:02:21 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lforschler lforschler commit-queue rniwa oldest_to_newest 923836 0 lforschler 2013-09-02 21:21:19 -0700 Enable Opensource/Tools/Scripts/filter-build-webkit on the log files 923838 1 lforschler 2013-09-02 21:32:03 -0700 Sadly, build-webkit output's to stdio, not to a file. So, doing this on the client in a follow-up step won't work, as there is no log on disk to operate on. However, I think we could probably do this server-side by using some stdio filtering. The createSummary function should work here. 928443 2 211459 lforschler 2013-09-12 12:55:29 -0700 Created attachment 211459 Add a summary to the current stdio which captures errors and warnings 928445 3 lforschler 2013-09-12 12:56:46 -0700 This patch will filter out warnings and errors. It does not use filter-build-webkit. I've tested this on my own master/slave test setup on MacOS. as long as the build.webkit.org machine has StringIO, it should be fine there. 928530 4 211483 lforschler 2013-09-12 15:31:01 -0700 Created attachment 211483 Updated patch to filter logs. Make it platform mac only. use cStringIO instead of StringIO for performance. Enable this only for the mac platform. 928545 5 211483 commit-queue 2013-09-12 16:02:18 -0700 Comment on attachment 211483 Updated patch to filter logs. Make it platform mac only. Clearing flags on attachment: 211483 Committed r155656: <http://trac.webkit.org/changeset/155656> 928546 6 commit-queue 2013-09-12 16:02:21 -0700 All reviewed patches have been landed. Closing bug. 211459 2013-09-12 12:55:29 -0700 2013-09-12 15:31:01 -0700 Add a summary to the current stdio which captures errors and warnings shortlog.patch text/plain 1960 lforschler SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1NTY0MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEzLTA5LTEyICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxl LmNvbT4KKworICAgICAgICBDcmVhdGUgc2hvcnQgYnVpbGQgbG9ncyBmb3IgZXJyb3JzIGFuZCB3 YXJuaW5ncy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyMDYxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZzoK KyAgICAgICAgICAgIC1pbmNsdWRlIFN0cmluZ0lPIAorICAgICAgICAoQ29tcGlsZVdlYktpdC5j cmVhdGVTdW1tYXJ5KToKKyAgICAgICAgICAgIC1hZGQgYSBjcmVhdGVTdW1tYXJ5IGZ1bmN0aW9u IHdoaWNoIHdpbGwgcGFyc2Ugb3V0IGVycm9ycyBhbmQgd2FybmluZ3MgaW50byBhIGNvbmNpc2Ug bG9nIGZpbGUgZm9yIHF1aWNrIHZpZXdpbmcKKwogMjAxMy0wOS0xMiAgQW5kZXJzIENhcmxzc29u ICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBydWRpbWVudGFyeSBzdXBwb3J0 IGZvciBtb3ZlLW9ubHkgdHlwZXMgYXMgdmFsdWVzIGluIEhhc2hNYXAKSW5kZXg6IFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcv bWFzdGVyLmNmZwkocmV2aXNpb24gMTU1NjQxKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZwkod29ya2luZyBjb3B5KQpAQCAtMTgs NiArMTgsNyBAQCBpbXBvcnQgb3MKIGltcG9ydCByZQogaW1wb3J0IGpzb24KIGltcG9ydCBvcGVy YXRvcgoraW1wb3J0IFN0cmluZ0lPCiBpbXBvcnQgdXJsbGliCiAKIGZyb20gY29tbWl0dGVyX2F1 dGggaW1wb3J0IENvbW1pdHRlckF1dGgKQEAgLTE4Nyw2ICsxODgsMjAgQEAgY2xhc3MgQ29tcGls ZVdlYktpdChzaGVsbC5Db21waWxlKToKIAogICAgICAgICByZXR1cm4gc2hlbGwuQ29tcGlsZS5z dGFydChzZWxmKQogCisgICAgZGVmIGNyZWF0ZVN1bW1hcnkoc2VsZiwgbG9nKToKKyAgICAgICAg d2FybmluZ3MgPSBbXQorICAgICAgICBlcnJvcnMgPSBbXQorICAgICAgICBzaW8gPSBTdHJpbmdJ Ty5TdHJpbmdJTyhsb2cuZ2V0VGV4dCgpKQorICAgICAgICBmb3IgbGluZSBpbiBzaW8ucmVhZGxp bmVzKCk6CisgICAgICAgICAgICBpZiAiYXJuaW5nOiIgaW4gbGluZToKKyAgICAgICAgICAgICAg ICB3YXJuaW5ncy5hcHBlbmQobGluZSkKKyAgICAgICAgICAgIGlmICJycm9yOiIgaW4gbGluZToK KyAgICAgICAgICAgICAgICBlcnJvcnMuYXBwZW5kKGxpbmUpCisgICAgICAgIGlmIHdhcm5pbmdz OgorICAgICAgICAgICAgc2VsZi5hZGRDb21wbGV0ZUxvZygnd2FybmluZ3MnLCAiIi5qb2luKHdh cm5pbmdzKSkKKyAgICAgICAgaWYgZXJyb3JzOgorICAgICAgICAgICAgc2VsZi5hZGRDb21wbGV0 ZUxvZygnZXJyb3JzJywgIiIuam9pbihlcnJvcnMpKQorICAgIAogCiBjbGFzcyBDb21waWxlV2Vi S2l0MU9ubHkoQ29tcGlsZVdlYktpdCk6CiAgICAgY29tbWFuZCA9IFsicGVybCIsICIuL1Rvb2xz L1NjcmlwdHMvYnVpbGQtd2Via2l0IiwgIi0tbm8td2Via2l0MiIsIFdpdGhQcm9wZXJ0aWVzKCIt LSUoY29uZmlndXJhdGlvbilzIildCg== 211483 2013-09-12 15:31:01 -0700 2013-09-12 16:02:18 -0700 Updated patch to filter logs. Make it platform mac only. shortlog.patch text/plain 2099 lforschler SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1NTY0MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEzLTA5LTEyICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxl LmNvbT4KKworICAgICAgICBDcmVhdGUgc2hvcnQgYnVpbGQgbG9ncyBmb3IgZXJyb3JzIGFuZCB3 YXJuaW5ncy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyMDYxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZzoK KyAgICAgICAgICAgIC1pbmNsdWRlIFN0cmluZ0lPIAorICAgICAgICAoQ29tcGlsZVdlYktpdC5j cmVhdGVTdW1tYXJ5KToKKyAgICAgICAgICAgIC1hZGQgYSBjcmVhdGVTdW1tYXJ5IGZ1bmN0aW9u IHdoaWNoIHdpbGwgcGFyc2Ugb3V0IGVycm9ycyBhbmQgd2FybmluZ3MgaW50byBhIGNvbmNpc2Ug bG9nIGZpbGUgZm9yIHF1aWNrIHZpZXdpbmcKKwogMjAxMy0wOS0xMiAgQW5kZXJzIENhcmxzc29u ICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBydWRpbWVudGFyeSBzdXBwb3J0 IGZvciBtb3ZlLW9ubHkgdHlwZXMgYXMgdmFsdWVzIGluIEhhc2hNYXAKSW5kZXg6IFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcv bWFzdGVyLmNmZwkocmV2aXNpb24gMTU1NjQxKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZwkod29ya2luZyBjb3B5KQpAQCAtMTgs NiArMTgsNyBAQCBpbXBvcnQgb3MKIGltcG9ydCByZQogaW1wb3J0IGpzb24KIGltcG9ydCBvcGVy YXRvcgoraW1wb3J0IGNTdHJpbmdJTwogaW1wb3J0IHVybGxpYgogCiBmcm9tIGNvbW1pdHRlcl9h dXRoIGltcG9ydCBDb21taXR0ZXJBdXRoCkBAIC0xODcsNiArMTg4LDIyIEBAIGNsYXNzIENvbXBp bGVXZWJLaXQoc2hlbGwuQ29tcGlsZSk6CiAKICAgICAgICAgcmV0dXJuIHNoZWxsLkNvbXBpbGUu c3RhcnQoc2VsZikKIAorICAgIGRlZiBjcmVhdGVTdW1tYXJ5KHNlbGYsIGxvZyk6CisgICAgICAg IHBsYXRmb3JtID0gc2VsZi5nZXRQcm9wZXJ0eSgncGxhdGZvcm0nKQorICAgICAgICBpZiBwbGF0 Zm9ybS5zdGFydHN3aXRoKCdtYWMnKTogICAgCisgICAgICAgICAgICB3YXJuaW5ncyA9IFtdCisg ICAgICAgICAgICBlcnJvcnMgPSBbXQorICAgICAgICAgICAgc2lvID0gY1N0cmluZ0lPLlN0cmlu Z0lPKGxvZy5nZXRUZXh0KCkpCisgICAgICAgICAgICBmb3IgbGluZSBpbiBzaW8ucmVhZGxpbmVz KCk6CisgICAgICAgICAgICAgICAgaWYgImFybmluZzoiIGluIGxpbmU6CisgICAgICAgICAgICAg ICAgICAgIHdhcm5pbmdzLmFwcGVuZChsaW5lKQorICAgICAgICAgICAgICAgIGlmICJycm9yOiIg aW4gbGluZToKKyAgICAgICAgICAgICAgICAgICAgZXJyb3JzLmFwcGVuZChsaW5lKQorICAgICAg ICAgICAgaWYgd2FybmluZ3M6CisgICAgICAgICAgICAgICAgc2VsZi5hZGRDb21wbGV0ZUxvZygn d2FybmluZ3MnLCAiIi5qb2luKHdhcm5pbmdzKSkKKyAgICAgICAgICAgIGlmIGVycm9yczoKKyAg ICAgICAgICAgICAgICBzZWxmLmFkZENvbXBsZXRlTG9nKCdlcnJvcnMnLCAiIi5qb2luKGVycm9y cykpCisKIAogY2xhc3MgQ29tcGlsZVdlYktpdDFPbmx5KENvbXBpbGVXZWJLaXQpOgogICAgIGNv bW1hbmQgPSBbInBlcmwiLCAiLi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCIsICItLW5vLXdl YmtpdDIiLCBXaXRoUHJvcGVydGllcygiLS0lKGNvbmZpZ3VyYXRpb24pcyIpXQo=