<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>120612</bug_id>
          
          <creation_ts>2013-09-02 16:38:55 -0700</creation_ts>
          <short_desc>WebKit crashes when trying to send a msg via &apos;today&apos;s birthdays&apos; dialogue box on Facebook</short_desc>
          <delta_ts>2013-09-10 18:15:52 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac (Intel)</rep_platform>
          <op_sys>OS X 10.8</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://facebook.com</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P1</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter>vomitols</reporter>
          <assigned_to name="Chris Curtis">chris_curtis</assigned_to>
          <cc>ap</cc>
    
    <cc>chris_curtis</cc>
    
    <cc>commit-queue</cc>
    
    <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>923816</commentid>
    <comment_count>0</comment_count>
    <who name="">vomitols</who>
    <bug_when>2013-09-02 16:38:55 -0700</bug_when>
    <thetext>Process:         WebProcess [257]
Path:            /Applications/WebKit.app/Contents/Frameworks/10.8/WebKit2.framework/WebProcess.app/Contents/MacOS/WebProcess
Identifier:      com.apple.WebProcess
Version:         538+ (538.1+)
Code Type:       X86-64 (Native)
Parent Process:  ??? [255]
User ID:         501

Date/Time:       2013-09-02 19:29:22.095 -0400
OS Version:      Mac OS X 10.8.4 (12E3067)
Report Version:  10

Interval Since Last Report:          581443 sec
Crashes Since Last Report:           9
Per-App Interval Since Last Report:  220852 sec
Per-App Crashes Since Last Report:   9
Anonymous UUID:                      DCE721A9-E6D2-843E-8602-282ED14B7DF9

Crashed Thread:  0  Dispatch queue: com.apple.main-thread

Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVALID_ADDRESS at 0xfffffffffffffff8

VM Regions Near 0xfffffffffffffff8:
--&gt; shared memory          00007ffffff55000-00007ffffff56000 [    4K] r-x/r-x SM=SHM  
    

Application Specific Information:
Bundle controller class:
BrowserBundleController
 

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.JavaScriptCore      	0x000000010179927a JSC::VM::throwException(JSC::ExecState*, JSC::JSValue) + 1370
1   com.apple.JavaScriptCore      	0x0000000101799a09 JSC::VM::throwException(JSC::ExecState*, JSC::JSObject*) + 9
2   com.apple.JavaScriptCore      	0x0000000101667504 JSC::JSValue::toObjectSlowCase(JSC::ExecState*, JSC::JSGlobalObject*) const + 132
3   com.apple.JavaScriptCore      	0x00000001016b0813 JSValueToObject + 195
4   com.apple.Safari.framework    	0x00007fff8a12db73 Safari::controlObject(Safari::WK::BundleFrame const&amp;, Safari::WK::Double const&amp;, Safari::WK::String const&amp;) + 230
5   com.apple.Safari.framework    	0x00007fff8a12d7bc Safari::FrameMetadata::computeMetadata() + 538
6   com.apple.Safari.framework    	0x00007fff8a12dbc1 Safari::FrameMetadata::metadataForAllForms() + 21
7   com.apple.Safari.framework    	0x00007fff8a12e71f Safari::FormMetadataController::frameMetadata(Safari::WK::BundleFrame const&amp;) + 95
8   com.apple.Safari.framework    	0x00007fff8a12e90d Safari::FormMetadataController::metadataForForm(Safari::WK::BundleFrame const&amp;, Safari::WK::BundleNodeHandle const&amp;) + 109
9   com.apple.Safari.framework    	0x00007fff8a000272 Safari::BrowserBundlePageFormClient::willSendSubmitEvent(Safari::WK::BundlePage const&amp;, Safari::WK::BundleNodeHandle const&amp;, Safari::WK::BundleFrame const&amp;, Safari::WK::BundleFrame const&amp;, Safari::WK::Dictionary const&amp;) + 102
10  com.apple.Safari.framework    	0x00007fff8a07ed0a Safari::WK::willSendSubmitEvent(OpaqueWKBundlePage const*, OpaqueWKBundleNodeHandle const*, OpaqueWKBundleFrame const*, OpaqueWKBundleFrame const*, OpaqueWKDictionary const*, void const*) + 151
11  com.apple.WebKit2             	0x000000010109ece1 WebKit::InjectedBundlePageFormClient::willSendSubmitEvent(WebKit::WebPage*, WebCore::HTMLFormElement*, WebKit::WebFrame*, WebKit::WebFrame*, WTF::Vector&lt;std::__1::pair&lt;WTF::String, WTF::String&gt;, 0ul, WTF::CrashOnOverflow&gt; const&amp;) + 277
12  com.apple.WebKit2             	0x000000010113e905 WebKit::WebFrameLoaderClient::dispatchWillSendSubmitEvent(WTF::PassRefPtr&lt;WebCore::FormState&gt;) + 123
13  com.apple.WebCore             	0x0000000101d6f816 WebCore::HTMLFormElement::prepareForSubmission(WebCore::Event*) + 294
14  com.apple.WebCore             	0x0000000102472ada WebCore::SubmitInputType::handleDOMActivateEvent(WebCore::Event*) + 74
15  com.apple.WebCore             	0x0000000101d7ab1b WebCore::HTMLInputElement::defaultEventHandler(WebCore::Event*) + 619
16  com.apple.WebCore             	0x0000000101c60289 WebCore::EventDispatcher::dispatchEventPostProcess(void*) + 313
17  com.apple.WebCore             	0x0000000101c5ffcc WebCore::EventDispatcher::dispatch() + 764
18  com.apple.WebCore             	0x0000000101c606ac WebCore::EventDispatchMediator::dispatchEvent(WebCore::EventDispatcher*) const + 12
19  com.apple.WebCore             	0x0000000101c5f3cc WebCore::EventDispatcher::dispatchEvent(WebCore::Node*, WTF::PassRefPtr&lt;WebCore::EventDispatchMediator&gt;) + 124
20  com.apple.WebCore             	0x00000001023c06ef WebCore::ScopedEventQueue::enqueueEventDispatchMediator(WTF::PassRefPtr&lt;WebCore::EventDispatchMediator&gt;) + 175
21  com.apple.WebCore             	0x0000000101c5f597 WebCore::EventDispatcher::dispatchScopedEvent(WebCore::Node*, WTF::PassRefPtr&lt;WebCore::EventDispatchMediator&gt;) + 247
22  com.apple.WebCore             	0x00000001021e0d73 WebCore::Node::dispatchScopedEvent(WTF::PassRefPtr&lt;WebCore::Event&gt;) + 67
23  com.apple.WebCore             	0x00000001021e123e WebCore::Node::dispatchDOMActivateEvent(int, WTF::PassRefPtr&lt;WebCore::Event&gt;) + 302
24  com.apple.WebCore             	0x00000001021e1a14 WebCore::Node::defaultEventHandler(WebCore::Event*) + 404
25  com.apple.WebCore             	0x0000000101d7adbe WebCore::HTMLInputElement::defaultEventHandler(WebCore::Event*) + 1294
26  com.apple.WebCore             	0x0000000101c60289 WebCore::EventDispatcher::dispatchEventPostProcess(void*) + 313
27  com.apple.WebCore             	0x0000000101c5ffcc WebCore::EventDispatcher::dispatch() + 764
28  com.apple.WebCore             	0x0000000101c5fbf7 WebCore::EventDispatcher::dispatchSimulatedClick(WebCore::Element*, WebCore::Event*, WebCore::SimulatedClickMouseEventOptions, WebCore::SimulatedClickVisualOptions) + 1575
29  com.apple.WebCore             	0x0000000101fbb2e1 WebCore::jsHTMLElementPrototypeFunctionClick(JSC::ExecState*) + 97
30  ???                           	0x0000587845001045 0 + 97273576951877
31  com.apple.JavaScriptCore      	0x0000000101629601 JSC::JITCode::execute(JSC::JSStack*, JSC::ExecState*, JSC::VM*) + 49
32  com.apple.JavaScriptCore      	0x000000010160ff4d JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&amp;, JSC::JSValue, JSC::ArgList const&amp;) + 573
33  com.apple.JavaScriptCore      	0x00000001014e64e5 JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&amp;, JSC::JSValue, JSC::ArgList const&amp;) + 69
34  com.apple.JavaScriptCore      	0x000000010165f59e JSC::boundFunctionCall(JSC::ExecState*) + 526
35  ???                           	0x0000587845001045 0 + 97273576951877
36  com.apple.JavaScriptCore      	0x0000000101629601 JSC::JITCode::execute(JSC::JSStack*, JSC::ExecState*, JSC::VM*) + 49
37  com.apple.JavaScriptCore      	0x000000010160ff4d JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&amp;, JSC::JSValue, JSC::ArgList const&amp;) + 573
38  com.apple.JavaScriptCore      	0x00000001014e64e5 JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&amp;, JSC::JSValue, JSC::ArgList const&amp;) + 69
39  com.apple.WebCore             	0x0000000101f8f78c WebCore::JSEventListener::handleEvent(WebCore::ScriptExecutionContext*, WebCore::Event*) + 908
40  com.apple.WebCore             	0x0000000101c77bec WebCore::EventTarget::fireEventListeners(WebCore::Event*, WebCore::EventTargetData*, WTF::Vector&lt;WebCore::RegisteredEventListener, 1ul, WTF::CrashOnOverflow&gt;&amp;) + 364
41  com.apple.WebCore             	0x0000000101c77895 WebCore::EventTarget::fireEventListeners(WebCore::Event*) + 469
42  com.apple.WebCore             	0x00000001021e0d23 WebCore::Node::handleLocalEvents(WebCore::Event*) + 67
43  com.apple.WebCore             	0x0000000101c5f1b7 WebCore::EventContext::handleLocalEvents(WebCore::Event*) const + 87
44  com.apple.WebCore             	0x0000000101c600d8 WebCore::EventDispatcher::dispatchEventAtBubbling(WebCore::WindowEventContext&amp;) + 56
45  com.apple.WebCore             	0x0000000101c5ffc1 WebCore::EventDispatcher::dispatch() + 753
46  com.apple.WebCore             	0x0000000101c606ac WebCore::EventDispatchMediator::dispatchEvent(WebCore::EventDispatcher*) const + 12
47  com.apple.WebCore             	0x0000000101c5f3cc WebCore::EventDispatcher::dispatchEvent(WebCore::Node*, WTF::PassRefPtr&lt;WebCore::EventDispatchMediator&gt;) + 124
48  com.apple.WebCore             	0x00000001021e0f2a WebCore::Node::dispatchEvent(WTF::PassRefPtr&lt;WebCore::Event&gt;) + 234
49  com.apple.WebCore             	0x0000000101c77610 WebCore::EventTarget::dispatchEvent(WTF::PassRefPtr&lt;WebCore::Event&gt;, int&amp;) + 112
50  com.apple.WebCore             	0x0000000101c6b8f9 WebCore::EventHandler::keyEvent(WebCore::PlatformKeyboardEvent const&amp;) + 1097
51  com.apple.WebKit2             	0x000000010115f839 WebKit::handleKeyEvent(WebKit::WebKeyboardEvent const&amp;, WebCore::Page*) + 244
52  com.apple.WebKit2             	0x000000010115f6fe WebKit::WebPage::keyEvent(WebKit::WebKeyboardEvent const&amp;) + 42
53  com.apple.WebKit2             	0x00000001011722a7 void CoreIPC::handleMessage&lt;Messages::WebPage::KeyEvent, WebKit::WebPage, void (WebKit::WebPage::*)(WebKit::WebKeyboardEvent const&amp;)&gt;(CoreIPC::MessageDecoder&amp;, WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::WebKeyboardEvent const&amp;)) + 107
54  com.apple.WebKit2             	0x00000001010a7963 CoreIPC::MessageReceiverMap::dispatchMessage(CoreIPC::Connection*, CoreIPC::MessageDecoder&amp;) + 137
55  com.apple.WebKit2             	0x00000001011ad59e WebKit::WebProcess::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageDecoder&amp;) + 34
56  com.apple.WebKit2             	0x000000010107cfc5 CoreIPC::Connection::dispatchMessage(WTF::PassOwnPtr&lt;CoreIPC::MessageDecoder&gt;) + 105
57  com.apple.WebKit2             	0x000000010107eb2e CoreIPC::Connection::dispatchOneMessage() + 106
58  com.apple.WebCore             	0x00000001023b9e91 WebCore::RunLoop::performWork() + 129
59  com.apple.WebCore             	0x00000001023ba452 WebCore::RunLoop::performWork(void*) + 34
60  com.apple.CoreFoundation      	0x00007fff8fd53b31 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
61  com.apple.CoreFoundation      	0x00007fff8fd53455 __CFRunLoopDoSources0 + 245
62  com.apple.CoreFoundation      	0x00007fff8fd767f5 __CFRunLoopRun + 789
63  com.apple.CoreFoundation      	0x00007fff8fd760e2 CFRunLoopRunSpecific + 290
64  com.apple.HIToolbox           	0x00007fff88d21eb4 RunCurrentEventLoopInMode + 209
65  com.apple.HIToolbox           	0x00007fff88d21c52 ReceiveNextEventCommon + 356
66  com.apple.HIToolbox           	0x00007fff88d21ae3 BlockUntilNextEventMatchingListInMode + 62
67  com.apple.AppKit              	0x00007fff8bc7f533 _DPSNextEvent + 685
68  com.apple.AppKit              	0x00007fff8bc7edf2 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 128
69  com.apple.AppKit              	0x00007fff8bc761a3 -[NSApplication run] + 517
70  com.apple.WebCore             	0x00000001023baad2 WebCore::RunLoop::run() + 82
71  com.apple.WebKit2             	0x000000010111d26a int WebKit::ChildProcessMain&lt;WebKit::WebProcess, WebKit::WebContentProcessMainDelegate&gt;(int, char**) + 422
72  com.apple.WebProcess          	0x0000000101033e23 main + 337
73  libdyld.dylib                 	0x00007fff8e1117e1 start + 1

Thread 1:: Dispatch queue: com.apple.libdispatch-manager
0   libsystem_kernel.dylib        	0x00007fff864a1d16 kevent + 10
1   libdispatch.dylib             	0x00007fff8da12dea _dispatch_mgr_invoke + 883
2   libdispatch.dylib             	0x00007fff8da129ee _dispatch_mgr_thread + 54

Thread 2:: JavaScriptCore::BlockFree
0   libsystem_kernel.dylib        	0x00007fff864a10fa __psynch_cvwait + 10
1   libsystem_c.dylib             	0x00007fff8ad9bb99 _pthread_cond_wait + 869
2   com.apple.JavaScriptCore      	0x00000001014cc8c8 JSC::BlockAllocator::blockFreeingThreadMain() + 296
3   com.apple.JavaScriptCore      	0x00000001017f0f3f WTF::wtfThreadEntryPoint(void*) + 15
4   libsystem_c.dylib             	0x00007fff8ad97352 _pthread_start + 327
5   libsystem_c.dylib             	0x00007fff8ad83d81 thread_start + 13

Thread 3:: JavaScriptCore::Marking
0   libsystem_kernel.dylib        	0x00007fff864a10fa __psynch_cvwait + 10
1   libsystem_c.dylib             	0x00007fff8ad9bb99 _pthread_cond_wait + 869
2   com.apple.JavaScriptCore      	0x00000001016020eb JSC::GCThread::waitForNextPhase() + 123
3   com.apple.JavaScriptCore      	0x00000001016021af JSC::GCThread::gcThreadMain() + 143
4   com.apple.JavaScriptCore      	0x00000001017f0f3f WTF::wtfThreadEntryPoint(void*) + 15
5   libsystem_c.dylib             	0x00007fff8ad97352 _pthread_start + 327
6   libsystem_c.dylib             	0x00007fff8ad83d81 thread_start + 13

Thread 4:: JavaScriptCore::Marking
0   libsystem_kernel.dylib        	0x00007fff864a10fa __psynch_cvwait + 10
1   libsystem_c.dylib             	0x00007fff8ad9bb99 _pthread_cond_wait + 869
2   com.apple.JavaScriptCore      	0x00000001016020eb JSC::GCThread::waitForNextPhase() + 123
3   com.apple.JavaScriptCore      	0x00000001016021af JSC::GCThread::gcThreadMain() + 143
4   com.apple.JavaScriptCore      	0x00000001017f0f3f WTF::wtfThreadEntryPoint(void*) + 15
5   libsystem_c.dylib             	0x00007fff8ad97352 _pthread_start + 327
6   libsystem_c.dylib             	0x00007fff8ad83d81 thread_start + 13

Thread 5:: JavaScriptCore::Marking
0   libsystem_kernel.dylib        	0x00007fff864a10fa __psynch_cvwait + 10
1   libsystem_c.dylib             	0x00007fff8ad9bb99 _pthread_cond_wait + 869
2   com.apple.JavaScriptCore      	0x00000001016020eb JSC::GCThread::waitForNextPhase() + 123
3   com.apple.JavaScriptCore      	0x00000001016021af JSC::GCThread::gcThreadMain() + 143
4   com.apple.JavaScriptCore      	0x00000001017f0f3f WTF::wtfThreadEntryPoint(void*) + 15
5   libsystem_c.dylib             	0x00007fff8ad97352 _pthread_start + 327
6   libsystem_c.dylib             	0x00007fff8ad83d81 thread_start + 13

Thread 6:: WebCore: Scrolling
0   libsystem_kernel.dylib        	0x00007fff8649f686 mach_msg_trap + 10
1   libsystem_kernel.dylib        	0x00007fff8649ec42 mach_msg + 70
2   com.apple.CoreFoundation      	0x00007fff8fd71233 __CFRunLoopServiceMachPort + 195
3   com.apple.CoreFoundation      	0x00007fff8fd76916 __CFRunLoopRun + 1078
4   com.apple.CoreFoundation      	0x00007fff8fd760e2 CFRunLoopRunSpecific + 290
5   com.apple.CoreFoundation      	0x00007fff8fd84dd1 CFRunLoopRun + 97
6   com.apple.WebCore             	0x00000001023e5a4e WebCore::ScrollingThread::initializeRunLoop() + 254
7   com.apple.JavaScriptCore      	0x00000001017f0f3f WTF::wtfThreadEntryPoint(void*) + 15
8   libsystem_c.dylib             	0x00007fff8ad97352 _pthread_start + 327
9   libsystem_c.dylib             	0x00007fff8ad83d81 thread_start + 13

Thread 7:: com.apple.NSURLConnectionLoader
0   libsystem_kernel.dylib        	0x00007fff8649f686 mach_msg_trap + 10
1   libsystem_kernel.dylib        	0x00007fff8649ec42 mach_msg + 70
2   com.apple.CoreFoundation      	0x00007fff8fd71233 __CFRunLoopServiceMachPort + 195
3   com.apple.CoreFoundation      	0x00007fff8fd76916 __CFRunLoopRun + 1078
4   com.apple.CoreFoundation      	0x00007fff8fd760e2 CFRunLoopRunSpecific + 290
5   com.apple.Foundation          	0x00007fff8837d546 +[NSURLConnection(Loader) _resourceLoadLoop:] + 356
6   com.apple.Foundation          	0x00007fff883db562 __NSThread__main__ + 1345
7   libsystem_c.dylib             	0x00007fff8ad97352 _pthread_start + 327
8   libsystem_c.dylib             	0x00007fff8ad83d81 thread_start + 13

Thread 8:: com.apple.CFSocket.private
0   libsystem_kernel.dylib        	0x00007fff864a1322 __select + 10
1   com.apple.CoreFoundation      	0x00007fff8fdb5f46 __CFSocketManager + 1302
2   libsystem_c.dylib             	0x00007fff8ad97352 _pthread_start + 327
3   libsystem_c.dylib             	0x00007fff8ad83d81 thread_start + 13

Thread 9:: JSC Compilation Thread
0   libsystem_kernel.dylib        	0x00007fff864a10fa __psynch_cvwait + 10
1   libsystem_c.dylib             	0x00007fff8ad9bb99 _pthread_cond_wait + 869
2   com.apple.JavaScriptCore      	0x00000001015f679b JSC::DFG::Worklist::runThread() + 763
3   com.apple.JavaScriptCore      	0x00000001017f0f3f WTF::wtfThreadEntryPoint(void*) + 15
4   libsystem_c.dylib             	0x00007fff8ad97352 _pthread_start + 327
5   libsystem_c.dylib             	0x00007fff8ad83d81 thread_start + 13

Thread 10:
0   libsystem_kernel.dylib        	0x00007fff864a16d6 __workq_kernreturn + 10
1   libsystem_c.dylib             	0x00007fff8ad99afc _pthread_workq_return + 25
2   libsystem_c.dylib             	0x00007fff8ad998c3 _pthread_wqthread + 412
3   libsystem_c.dylib             	0x00007fff8ad83d71 start_wqthread + 13

Thread 11:
0   libsystem_kernel.dylib        	0x00007fff864a16d6 __workq_kernreturn + 10
1   libsystem_c.dylib             	0x00007fff8ad99afc _pthread_workq_return + 25
2   libsystem_c.dylib             	0x00007fff8ad998c3 _pthread_wqthread + 412
3   libsystem_c.dylib             	0x00007fff8ad83d71 start_wqthread + 13

Thread 0 crashed with X86 Thread State (64-bit):
  rax: 0x00007fff5ebc94e8  rbx: 0x0000000106d7e420  rcx: 0x000000010726a170  rdx: 0x00007fff5ebc9420
  rdi: 0x00000001064cb780  rsi: 0x00000000000000e1  rbp: 0x00007fff5ebc9650  rsp: 0x00007fff5ebc9470
   r8: 0xffff000000000002   r9: 0x000000010726a170  r10: 0x0000000111bb6780  r11: 0x0000000000000003
  r12: 0x0000000000000000  r13: 0x0000000000000000  r14: 0x000000012512dd60  r15: 0x0000000106d7e420
  rip: 0x000000010179927a  rfl: 0x0000000000010213  cr2: 0xfffffffffffffff8</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>924117</commentid>
    <comment_count>1</comment_count>
    <who name="Chris Curtis">chris_curtis</who>
    <bug_when>2013-09-03 11:32:30 -0700</bug_when>
    <thetext>Inside throwException, if appendSourceToMessage flag is set, the codeBlock is used to get the developers source code for the error message. In this case though, the codeBlock is never found.

By checking to make sure that the codeBlock is valid we can fix the error, But because appendSourceToMessage was set there should have been a valid codeBlock. I am looking into why the codeBlock is not being found.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>924157</commentid>
    <comment_count>2</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2013-09-03 12:35:47 -0700</bug_when>
    <thetext>JSValueToObject was almost certainly passed a &quot;globalExec&quot;, which doesn&apos;t contain any CodeBlock. So, the bug here is the assumption that there will be a CodeBlock.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>924175</commentid>
    <comment_count>3</comment_count>
      <attachid>210409</attachid>
    <who name="Chris Curtis">chris_curtis</who>
    <bug_when>2013-09-03 14:07:43 -0700</bug_when>
    <thetext>Created attachment 210409
patch

Initial review, This patch still needs a regression test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>925624</commentid>
    <comment_count>4</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2013-09-06 09:27:38 -0700</bug_when>
    <thetext>*** Bug 120825 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>927344</commentid>
    <comment_count>5</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2013-09-10 09:48:52 -0700</bug_when>
    <thetext>What is the status of this bug, did making a regression prove challenging?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>927346</commentid>
    <comment_count>6</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2013-09-10 09:49:52 -0700</bug_when>
    <thetext>*** Bug 120509 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>927353</commentid>
    <comment_count>7</comment_count>
    <who name="Chris Curtis">chris_curtis</who>
    <bug_when>2013-09-10 09:56:47 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; What is the status of this bug, did making a regression prove challenging?

A regression test can not be made to be run through DumpRenderTree, so I am making one in the testapi.c file. I was slightly distracted by a different patch, which is why it is not done. I will do it right now</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>927576</commentid>
    <comment_count>8</comment_count>
      <attachid>211261</attachid>
    <who name="Chris Curtis">chris_curtis</who>
    <bug_when>2013-09-10 16:21:29 -0700</bug_when>
    <thetext>Created attachment 211261
patch with test</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>927577</commentid>
    <comment_count>9</comment_count>
      <attachid>211262</attachid>
    <who name="Chris Curtis">chris_curtis</who>
    <bug_when>2013-09-10 16:23:26 -0700</bug_when>
    <thetext>Created attachment 211262
removed extra whitespace line</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>927598</commentid>
    <comment_count>10</comment_count>
      <attachid>211262</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2013-09-10 17:27:30 -0700</bug_when>
    <thetext>Comment on attachment 211262
removed extra whitespace line 

View in context: https://bugs.webkit.org/attachment.cgi?id=211262&amp;action=review

Looks good, but please fix these details.

&gt; Source/JavaScriptCore/API/tests/testapi.c:1064
&gt; +    JSClassRef globalObjectClass = JSClassCreate(&amp;globalObjectClassDefinition);

This needs a corresponding JSClassRelease.

&gt; Source/JavaScriptCore/API/tests/testapi.c:1065
&gt; +    context = JSGlobalContextCreateInGroup(NULL, globalObjectClass);

This needs a corresponding JSContextRelease. Is it OK that we&apos;re overwriting the global here? Maybe this should be a local.

&gt; Source/JavaScriptCore/API/tests/testapi.c:1066
&gt; +    JSContextGetGlobalObject(context);

You can remove this line.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>927601</commentid>
    <comment_count>11</comment_count>
      <attachid>211268</attachid>
    <who name="Chris Curtis">chris_curtis</who>
    <bug_when>2013-09-10 17:41:10 -0700</bug_when>
    <thetext>Created attachment 211268
patch 4</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>927602</commentid>
    <comment_count>12</comment_count>
      <attachid>211269</attachid>
    <who name="Chris Curtis">chris_curtis</who>
    <bug_when>2013-09-10 17:44:22 -0700</bug_when>
    <thetext>Created attachment 211269
name change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>927603</commentid>
    <comment_count>13</comment_count>
      <attachid>211269</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2013-09-10 17:46:11 -0700</bug_when>
    <thetext>Comment on attachment 211269
name change.

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>927613</commentid>
    <comment_count>14</comment_count>
      <attachid>211269</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-09-10 18:15:49 -0700</bug_when>
    <thetext>Comment on attachment 211269
name change.

Clearing flags on attachment: 211269

Committed r155495: &lt;http://trac.webkit.org/changeset/155495&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>927614</commentid>
    <comment_count>15</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-09-10 18:15:52 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>210409</attachid>
            <date>2013-09-03 14:07:43 -0700</date>
            <delta_ts>2013-09-10 16:21:29 -0700</delta_ts>
            <desc>patch</desc>
            <filename>ro.diff</filename>
            <type>text/plain</type>
            <size>1930</size>
            <attacher name="Chris Curtis">chris_curtis</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU0OTk4KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA
CisyMDEzLTA5LTAzICBDaHJpcyBDdXJ0aXMgIDxjaHJpc19jdXJ0aXNAYXBwbGUuY29tPgorCisg
ICAgICAgIFdlYktpdCBjcmFzaGVzIHdoZW4gdHJ5aW5nIHRvIHNlbmQgYSBtc2cgdmlhICd0b2Rh
eSdzIGJpcnRoZGF5cycgZGlhbG9ndWUgYm94IG9uIEZhY2Vib29rCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA2MTIjYWRkX2NvbW1lbnQKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRoZSBj
b2RlQmxvY2sgd2FzIGFzc3VtZWQgdG8gZXhpc3Qgd2hlbiBhcHBlbmRTb3VyY2VUb01lc3NhZ2Ug
d2FzIHNldC4gCisgICAgICAgIFRoaXMgd2FzIGFuIGludmFsaWQgYXNzdW1wdGlvbi4gSSBhZGRl
ZCBhIGNoZWNrIHRvIGVuc3VyZSB0aGF0IHRoZXJlIGlzIGEKKyAgICAgICAgdmFsaWQgY29kZUJs
b2NrIGJlZm9yZSBhY2Nlc3NpbmcgaXQuCisKKyAgICAgICAgKiBydW50aW1lL1ZNLmNwcDoKKyAg
ICAgICAgKEpTQzo6Vk06OnRocm93RXhjZXB0aW9uKToKKwogMjAxMy0wOS0wMiAgUnlvc3VrZSBO
aXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBTdXBwb3J0IHRoZSAianNvbiIgcmVz
cG9uc2VUeXBlIGFuZCBKU09OIHJlc3BvbnNlIGVudGl0eSBpbiBYSFIKSW5kZXg6IFNvdXJjZS9K
YXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj
cmlwdENvcmUvcnVudGltZS9WTS5jcHAJKHJldmlzaW9uIDE1NDk4NikKKysrIFNvdXJjZS9KYXZh
U2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjU4LDkgKzY1OCwx
MiBAQCBKU1ZhbHVlIFZNOjp0aHJvd0V4Y2VwdGlvbihFeGVjU3RhdGUqIGV4CiAgICAgICAgIENh
bGxGcmFtZSogY2FsbEZyYW1lOwogICAgICAgICBmb3IgKGNhbGxGcmFtZSA9IGV4ZWM7IGNhbGxG
cmFtZSAmJiAhY2FsbEZyYW1lLT5jb2RlQmxvY2soKTsgY2FsbEZyYW1lID0gY2FsbEZyYW1lLT5j
YWxsZXJGcmFtZSgpLT5yZW1vdmVIb3N0Q2FsbEZyYW1lRmxhZygpKQogICAgICAgICAgICAgc3Rh
Y2tJbmRleCsrOwotICAgICAgICBzdGFja0ZyYW1lID0gc3RhY2tUcmFjZS5hdChzdGFja0luZGV4
KTsKLSAgICAgICAgYnl0ZWNvZGVPZmZzZXQgPSBzdGFja0ZyYW1lLmJ5dGVjb2RlT2Zmc2V0Owot
ICAgICAgICBhcHBlbmRTb3VyY2VUb0Vycm9yKGNhbGxGcmFtZSwgc3RhdGljX2Nhc3Q8RXJyb3JJ
bnN0YW5jZSo+KGV4Y2VwdGlvbiksIGJ5dGVjb2RlT2Zmc2V0KTsKKworICAgICAgICBpZiAoY2Fs
bEZyYW1lICYmIGNhbGxGcmFtZS0+Y29kZUJsb2NrKCkpIHsKKyAgICAgICAgICAgIHN0YWNrRnJh
bWUgPSBzdGFja1RyYWNlLmF0KHN0YWNrSW5kZXgpOworICAgICAgICAgICAgYnl0ZWNvZGVPZmZz
ZXQgPSBzdGFja0ZyYW1lLmJ5dGVjb2RlT2Zmc2V0OworICAgICAgICAgICAgYXBwZW5kU291cmNl
VG9FcnJvcihjYWxsRnJhbWUsIHN0YXRpY19jYXN0PEVycm9ySW5zdGFuY2UqPihleGNlcHRpb24p
LCBieXRlY29kZU9mZnNldCk7CisgICAgICAgIH0KICAgICB9CiAKICAgICBpZiAoZXhjZXB0aW9u
LT5oYXNQcm9wZXJ0eShleGVjLCB0aGlzLT5wcm9wZXJ0eU5hbWVzLT5zdGFjaykpCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>211261</attachid>
            <date>2013-09-10 16:21:29 -0700</date>
            <delta_ts>2013-09-10 16:23:26 -0700</delta_ts>
            <desc>patch with test</desc>
            <filename>ro.diff</filename>
            <type>text/plain</type>
            <size>4594</size>
            <attacher name="Chris Curtis">chris_curtis</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU1NDg5KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA
CisyMDEzLTA5LTEwICBDaHJpcyBDdXJ0aXMgIDxjaHJpc19jdXJ0aXNAYXBwbGUuY29tPgorCisg
ICAgICAgIFdlYktpdCBjcmFzaGVzIHdoZW4gdHJ5aW5nIHRvIHNlbmQgYSBtc2cgdmlhICd0b2Rh
eSdzIGJpcnRoZGF5cycgZGlhbG9ndWUgYm94IG9uIEZhY2Vib29rCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA2MTIjYWRkX2NvbW1lbnQKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNvZGVCbG9jayB3
YXMgYXNzdW1lZCB0byBleGlzdCB3aGVuIGFwcGVuZFNvdXJjZVRvTWVzc2FnZSB3YXMgc2V0Lgor
ICAgICAgICBUaGlzIHdhcyBhbiBpbnZhbGlkIGFzc3VtcHRpb24uIEkgYWRkZWQgYSBjaGVjayB0
byBlbnN1cmUgdGhhdCB0aGVyZSBpcyBhCisgICAgICAgIHZhbGlkIGNvZGVCbG9jayBiZWZvcmUg
YWNjZXNzaW5nIGl0LgorCisgICAgICAgICogQVBJL3Rlc3RzL3Rlc3RhcGkuYzoKKyAgICAgICAg
KHZhbHVlVG9PYmplY3RFeGNlcHRpb25DYWxsQXNGdW5jdGlvbik6CisgICAgICAgICh2YWx1ZVRv
T2JqZWN0RXhjZXB0aW9uVGVzdCk6CisgICAgICAgIChtYWluKToKKyAgICAgICAgKiBydW50aW1l
L1ZNLmNwcDoKKyAgICAgICAgKEpTQzo6Vk06OnRocm93RXhjZXB0aW9uKToKKwogMjAxMy0wOS0x
MCAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIE1h
cERhdGEgaGFzIHNvbWUgaXNzdWVzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rl
c3RzL3Rlc3RhcGkuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rl
c3RzL3Rlc3RhcGkuYwkocmV2aXNpb24gMTU1NDg4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl
L0FQSS90ZXN0cy90ZXN0YXBpLmMJKHdvcmtpbmcgY29weSkKQEAgLTEwNDMsNiArMTA0Myw0MSBA
QCBzdGF0aWMgYm9vbCBjaGVja0ZvckN5Y2xlSW5Qcm90b3R5cGVDaGFpCiAgICAgcmV0dXJuIHJl
c3VsdDsKIH0KIAorc3RhdGljIEpTVmFsdWVSZWYgdmFsdWVUb09iamVjdEV4Y2VwdGlvbkNhbGxB
c0Z1bmN0aW9uKEpTQ29udGV4dFJlZiBjdHgsIEpTT2JqZWN0UmVmIGZ1bmN0aW9uLCBKU09iamVj
dFJlZiB0aGlzT2JqZWN0LCBzaXplX3QgYXJndW1lbnRDb3VudCwgY29uc3QgSlNWYWx1ZVJlZiBh
cmd1bWVudHNbXSwgSlNWYWx1ZVJlZiogZXhjZXB0aW9uKQoreworCisgICAgVU5VU0VEX1BBUkFN
KGZ1bmN0aW9uKTsKKyAgICBVTlVTRURfUEFSQU0odGhpc09iamVjdCk7CisgICAgVU5VU0VEX1BB
UkFNKGFyZ3VtZW50Q291bnQpOworICAgIFVOVVNFRF9QQVJBTShhcmd1bWVudHMpOworICAgIEpT
VmFsdWVSZWYganNVbmRlZmluZWQgPSBKU1ZhbHVlTWFrZVVuZGVmaW5lZChKU0NvbnRleHRHZXRH
bG9iYWxDb250ZXh0KGN0eCkpOworICAgIEpTVmFsdWVUb09iamVjdChKU0NvbnRleHRHZXRHbG9i
YWxDb250ZXh0KGN0eCksIGpzVW5kZWZpbmVkLCBleGNlcHRpb24pOworICAgIAorICAgIHJldHVy
biBKU1ZhbHVlTWFrZVVuZGVmaW5lZChjdHgpOworfQorc3RhdGljIGJvb2wgdmFsdWVUb09iamVj
dEV4Y2VwdGlvblRlc3QoKQoreworICAgIEpTQ2xhc3NEZWZpbml0aW9uIGdsb2JhbE9iamVjdENs
YXNzRGVmaW5pdGlvbiA9IGtKU0NsYXNzRGVmaW5pdGlvbkVtcHR5OworICAgIGdsb2JhbE9iamVj
dENsYXNzRGVmaW5pdGlvbi5pbml0aWFsaXplID0gZ2xvYmFsT2JqZWN0X2luaXRpYWxpemU7Cisg
ICAgZ2xvYmFsT2JqZWN0Q2xhc3NEZWZpbml0aW9uLnN0YXRpY1ZhbHVlcyA9IGdsb2JhbE9iamVj
dF9zdGF0aWNWYWx1ZXM7CisgICAgZ2xvYmFsT2JqZWN0Q2xhc3NEZWZpbml0aW9uLnN0YXRpY0Z1
bmN0aW9ucyA9IGdsb2JhbE9iamVjdF9zdGF0aWNGdW5jdGlvbnM7CisgICAgZ2xvYmFsT2JqZWN0
Q2xhc3NEZWZpbml0aW9uLmF0dHJpYnV0ZXMgPSBrSlNDbGFzc0F0dHJpYnV0ZU5vQXV0b21hdGlj
UHJvdG90eXBlOworICAgIEpTQ2xhc3NSZWYgZ2xvYmFsT2JqZWN0Q2xhc3MgPSBKU0NsYXNzQ3Jl
YXRlKCZnbG9iYWxPYmplY3RDbGFzc0RlZmluaXRpb24pOworICAgIGNvbnRleHQgPSBKU0dsb2Jh
bENvbnRleHRDcmVhdGVJbkdyb3VwKE5VTEwsIGdsb2JhbE9iamVjdENsYXNzKTsKKyAgICBKU0Nv
bnRleHRHZXRHbG9iYWxPYmplY3QoY29udGV4dCk7CisgICAgSlNPYmplY3RSZWYgZ2xvYmFsT2Jq
ZWN0ID0gSlNDb250ZXh0R2V0R2xvYmFsT2JqZWN0KGNvbnRleHQpOworCisgICAgSlNTdHJpbmdS
ZWYgdmFsdWVUb09iamVjdCA9IEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJ2YWx1ZVRv
T2JqZWN0Iik7CisgICAgSlNPYmplY3RSZWYgdmFsdWVUb09iamVjdEZ1bmN0aW9uID0gSlNPYmpl
Y3RNYWtlRnVuY3Rpb25XaXRoQ2FsbGJhY2soY29udGV4dCwgdmFsdWVUb09iamVjdCwgdmFsdWVU
b09iamVjdEV4Y2VwdGlvbkNhbGxBc0Z1bmN0aW9uKTsKKyAgICBKU09iamVjdFNldFByb3BlcnR5
KGNvbnRleHQsIGdsb2JhbE9iamVjdCwgdmFsdWVUb09iamVjdCwgdmFsdWVUb09iamVjdEZ1bmN0
aW9uLCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZU5vbmUsIE5VTEwpOworICAgIEpTU3RyaW5nUmVsZWFz
ZSh2YWx1ZVRvT2JqZWN0KTsKKworICAgIEpTU3RyaW5nUmVmIHRlc3QgPSBKU1N0cmluZ0NyZWF0
ZVdpdGhVVEY4Q1N0cmluZygidmFsdWVUb09iamVjdCgpOyIpOworICAgIEpTRXZhbHVhdGVTY3Jp
cHQoY29udGV4dCwgdGVzdCwgTlVMTCwgTlVMTCwgMSwgTlVMTCk7CisKKyAgICByZXR1cm4gdHJ1
ZTsKK30KKwogc3RhdGljIHZvaWQgY2hlY2tDb25zdG5lc3NJbkpTT2JqZWN0TmFtZXMoKQogewog
ICAgIEpTU3RhdGljRnVuY3Rpb24gZnVuOwpAQCAtMTk3NSw2ICsyMDEwLDggQEAgaW50IG1haW4o
aW50IGFyZ2MsIGNoYXIqIGFyZ3ZbXSkKICAgICAgICAgcHJpbnRmKCJGQUlMOiBBIGN5Y2xlIGlu
IGEgcHJvdG90eXBlIGNoYWluIGNhbiBiZSBjcmVhdGVkLlxuIik7CiAgICAgICAgIGZhaWxlZCA9
IHRydWU7CiAgICAgfQorICAgIGlmICh2YWx1ZVRvT2JqZWN0RXhjZXB0aW9uVGVzdCgpKQorICAg
ICAgICBwcmludGYoIlBBU1M6IHRocm93RXhjZXB0aW9uIGRpZCBub3QgY3Jhc2ggd2hlbiBoYW5k
bGluZyBhbiBlcnJvciB3aXRoIGFwcGVuZE1lc3NhZ2VUb0Vycm9yIHNldCBhbmQgbm8gY29kZUJs
b2NrIGF2YWlsYWJsZS4iKTsKIAogICAgIGlmIChmYWlsZWQpIHsKICAgICAgICAgcHJpbnRmKCJG
QUlMOiBTb21lIHRlc3RzIGZhaWxlZC5cbiIpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl
L3J1bnRpbWUvVk0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50
aW1lL1ZNLmNwcAkocmV2aXNpb24gMTU1NDg4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1
bnRpbWUvVk0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MzUsOSArNjM1LDExIEBAIEpTVmFsdWUg
Vk06OnRocm93RXhjZXB0aW9uKEV4ZWNTdGF0ZSogZXgKICAgICAgICAgQ2FsbEZyYW1lKiBjYWxs
RnJhbWU7CiAgICAgICAgIGZvciAoY2FsbEZyYW1lID0gZXhlYzsgY2FsbEZyYW1lICYmICFjYWxs
RnJhbWUtPmNvZGVCbG9jaygpOyBjYWxsRnJhbWUgPSBjYWxsRnJhbWUtPmNhbGxlckZyYW1lKCkt
PnJlbW92ZUhvc3RDYWxsRnJhbWVGbGFnKCkpCiAgICAgICAgICAgICBzdGFja0luZGV4Kys7Ci0g
ICAgICAgIHN0YWNrRnJhbWUgPSBzdGFja1RyYWNlLmF0KHN0YWNrSW5kZXgpOwotICAgICAgICBi
eXRlY29kZU9mZnNldCA9IHN0YWNrRnJhbWUuYnl0ZWNvZGVPZmZzZXQ7Ci0gICAgICAgIGFwcGVu
ZFNvdXJjZVRvRXJyb3IoY2FsbEZyYW1lLCBzdGF0aWNfY2FzdDxFcnJvckluc3RhbmNlKj4oZXhj
ZXB0aW9uKSwgYnl0ZWNvZGVPZmZzZXQpOworICAgICAgICBpZiAoY2FsbEZyYW1lICYmIGNhbGxG
cmFtZS0+Y29kZUJsb2NrKCkpIHsKKyAgICAgICAgICAgIHN0YWNrRnJhbWUgPSBzdGFja1RyYWNl
LmF0KHN0YWNrSW5kZXgpOworICAgICAgICAgICAgYnl0ZWNvZGVPZmZzZXQgPSBzdGFja0ZyYW1l
LmJ5dGVjb2RlT2Zmc2V0OworICAgICAgICAgICAgYXBwZW5kU291cmNlVG9FcnJvcihjYWxsRnJh
bWUsIHN0YXRpY19jYXN0PEVycm9ySW5zdGFuY2UqPihleGNlcHRpb24pLCBieXRlY29kZU9mZnNl
dCk7CisgICAgICAgIH0KICAgICB9CiAKICAgICBpZiAoZXhjZXB0aW9uLT5oYXNQcm9wZXJ0eShl
eGVjLCB0aGlzLT5wcm9wZXJ0eU5hbWVzLT5zdGFjaykpCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>211262</attachid>
            <date>2013-09-10 16:23:26 -0700</date>
            <delta_ts>2013-09-10 17:41:10 -0700</delta_ts>
            <desc>removed extra whitespace line </desc>
            <filename>ro.diff</filename>
            <type>text/plain</type>
            <size>4592</size>
            <attacher name="Chris Curtis">chris_curtis</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU1NDg5KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA
CisyMDEzLTA5LTEwICBDaHJpcyBDdXJ0aXMgIDxjaHJpc19jdXJ0aXNAYXBwbGUuY29tPgorCisg
ICAgICAgIFdlYktpdCBjcmFzaGVzIHdoZW4gdHJ5aW5nIHRvIHNlbmQgYSBtc2cgdmlhICd0b2Rh
eSdzIGJpcnRoZGF5cycgZGlhbG9ndWUgYm94IG9uIEZhY2Vib29rCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA2MTIjYWRkX2NvbW1lbnQKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNvZGVCbG9jayB3
YXMgYXNzdW1lZCB0byBleGlzdCB3aGVuIGFwcGVuZFNvdXJjZVRvTWVzc2FnZSB3YXMgc2V0Lgor
ICAgICAgICBUaGlzIHdhcyBhbiBpbnZhbGlkIGFzc3VtcHRpb24uIEkgYWRkZWQgYSBjaGVjayB0
byBlbnN1cmUgdGhhdCB0aGVyZSBpcyBhCisgICAgICAgIHZhbGlkIGNvZGVCbG9jayBiZWZvcmUg
YWNjZXNzaW5nIGl0LgorCisgICAgICAgICogQVBJL3Rlc3RzL3Rlc3RhcGkuYzoKKyAgICAgICAg
KHZhbHVlVG9PYmplY3RFeGNlcHRpb25DYWxsQXNGdW5jdGlvbik6CisgICAgICAgICh2YWx1ZVRv
T2JqZWN0RXhjZXB0aW9uVGVzdCk6CisgICAgICAgIChtYWluKToKKyAgICAgICAgKiBydW50aW1l
L1ZNLmNwcDoKKyAgICAgICAgKEpTQzo6Vk06OnRocm93RXhjZXB0aW9uKToKKwogMjAxMy0wOS0x
MCAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIE1h
cERhdGEgaGFzIHNvbWUgaXNzdWVzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rl
c3RzL3Rlc3RhcGkuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rl
c3RzL3Rlc3RhcGkuYwkocmV2aXNpb24gMTU1NDg4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl
L0FQSS90ZXN0cy90ZXN0YXBpLmMJKHdvcmtpbmcgY29weSkKQEAgLTEwNDMsNiArMTA0Myw0MCBA
QCBzdGF0aWMgYm9vbCBjaGVja0ZvckN5Y2xlSW5Qcm90b3R5cGVDaGFpCiAgICAgcmV0dXJuIHJl
c3VsdDsKIH0KIAorc3RhdGljIEpTVmFsdWVSZWYgdmFsdWVUb09iamVjdEV4Y2VwdGlvbkNhbGxB
c0Z1bmN0aW9uKEpTQ29udGV4dFJlZiBjdHgsIEpTT2JqZWN0UmVmIGZ1bmN0aW9uLCBKU09iamVj
dFJlZiB0aGlzT2JqZWN0LCBzaXplX3QgYXJndW1lbnRDb3VudCwgY29uc3QgSlNWYWx1ZVJlZiBh
cmd1bWVudHNbXSwgSlNWYWx1ZVJlZiogZXhjZXB0aW9uKQoreworICAgIFVOVVNFRF9QQVJBTShm
dW5jdGlvbik7CisgICAgVU5VU0VEX1BBUkFNKHRoaXNPYmplY3QpOworICAgIFVOVVNFRF9QQVJB
TShhcmd1bWVudENvdW50KTsKKyAgICBVTlVTRURfUEFSQU0oYXJndW1lbnRzKTsKKyAgICBKU1Zh
bHVlUmVmIGpzVW5kZWZpbmVkID0gSlNWYWx1ZU1ha2VVbmRlZmluZWQoSlNDb250ZXh0R2V0R2xv
YmFsQ29udGV4dChjdHgpKTsKKyAgICBKU1ZhbHVlVG9PYmplY3QoSlNDb250ZXh0R2V0R2xvYmFs
Q29udGV4dChjdHgpLCBqc1VuZGVmaW5lZCwgZXhjZXB0aW9uKTsKKyAgICAKKyAgICByZXR1cm4g
SlNWYWx1ZU1ha2VVbmRlZmluZWQoY3R4KTsKK30KK3N0YXRpYyBib29sIHZhbHVlVG9PYmplY3RF
eGNlcHRpb25UZXN0KCkKK3sKKyAgICBKU0NsYXNzRGVmaW5pdGlvbiBnbG9iYWxPYmplY3RDbGFz
c0RlZmluaXRpb24gPSBrSlNDbGFzc0RlZmluaXRpb25FbXB0eTsKKyAgICBnbG9iYWxPYmplY3RD
bGFzc0RlZmluaXRpb24uaW5pdGlhbGl6ZSA9IGdsb2JhbE9iamVjdF9pbml0aWFsaXplOworICAg
IGdsb2JhbE9iamVjdENsYXNzRGVmaW5pdGlvbi5zdGF0aWNWYWx1ZXMgPSBnbG9iYWxPYmplY3Rf
c3RhdGljVmFsdWVzOworICAgIGdsb2JhbE9iamVjdENsYXNzRGVmaW5pdGlvbi5zdGF0aWNGdW5j
dGlvbnMgPSBnbG9iYWxPYmplY3Rfc3RhdGljRnVuY3Rpb25zOworICAgIGdsb2JhbE9iamVjdENs
YXNzRGVmaW5pdGlvbi5hdHRyaWJ1dGVzID0ga0pTQ2xhc3NBdHRyaWJ1dGVOb0F1dG9tYXRpY1By
b3RvdHlwZTsKKyAgICBKU0NsYXNzUmVmIGdsb2JhbE9iamVjdENsYXNzID0gSlNDbGFzc0NyZWF0
ZSgmZ2xvYmFsT2JqZWN0Q2xhc3NEZWZpbml0aW9uKTsKKyAgICBjb250ZXh0ID0gSlNHbG9iYWxD
b250ZXh0Q3JlYXRlSW5Hcm91cChOVUxMLCBnbG9iYWxPYmplY3RDbGFzcyk7CisgICAgSlNDb250
ZXh0R2V0R2xvYmFsT2JqZWN0KGNvbnRleHQpOworICAgIEpTT2JqZWN0UmVmIGdsb2JhbE9iamVj
dCA9IEpTQ29udGV4dEdldEdsb2JhbE9iamVjdChjb250ZXh0KTsKKworICAgIEpTU3RyaW5nUmVm
IHZhbHVlVG9PYmplY3QgPSBKU1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZygidmFsdWVUb09i
amVjdCIpOworICAgIEpTT2JqZWN0UmVmIHZhbHVlVG9PYmplY3RGdW5jdGlvbiA9IEpTT2JqZWN0
TWFrZUZ1bmN0aW9uV2l0aENhbGxiYWNrKGNvbnRleHQsIHZhbHVlVG9PYmplY3QsIHZhbHVlVG9P
YmplY3RFeGNlcHRpb25DYWxsQXNGdW5jdGlvbik7CisgICAgSlNPYmplY3RTZXRQcm9wZXJ0eShj
b250ZXh0LCBnbG9iYWxPYmplY3QsIHZhbHVlVG9PYmplY3QsIHZhbHVlVG9PYmplY3RGdW5jdGlv
biwga0pTUHJvcGVydHlBdHRyaWJ1dGVOb25lLCBOVUxMKTsKKyAgICBKU1N0cmluZ1JlbGVhc2Uo
dmFsdWVUb09iamVjdCk7CisKKyAgICBKU1N0cmluZ1JlZiB0ZXN0ID0gSlNTdHJpbmdDcmVhdGVX
aXRoVVRGOENTdHJpbmcoInZhbHVlVG9PYmplY3QoKTsiKTsKKyAgICBKU0V2YWx1YXRlU2NyaXB0
KGNvbnRleHQsIHRlc3QsIE5VTEwsIE5VTEwsIDEsIE5VTEwpOworCisgICAgcmV0dXJuIHRydWU7
Cit9CisKIHN0YXRpYyB2b2lkIGNoZWNrQ29uc3RuZXNzSW5KU09iamVjdE5hbWVzKCkKIHsKICAg
ICBKU1N0YXRpY0Z1bmN0aW9uIGZ1bjsKQEAgLTE5NzUsNiArMjAwOSw4IEBAIGludCBtYWluKGlu
dCBhcmdjLCBjaGFyKiBhcmd2W10pCiAgICAgICAgIHByaW50ZigiRkFJTDogQSBjeWNsZSBpbiBh
IHByb3RvdHlwZSBjaGFpbiBjYW4gYmUgY3JlYXRlZC5cbiIpOwogICAgICAgICBmYWlsZWQgPSB0
cnVlOwogICAgIH0KKyAgICBpZiAodmFsdWVUb09iamVjdEV4Y2VwdGlvblRlc3QoKSkKKyAgICAg
ICAgcHJpbnRmKCJQQVNTOiB0aHJvd0V4Y2VwdGlvbiBkaWQgbm90IGNyYXNoIHdoZW4gaGFuZGxp
bmcgYW4gZXJyb3Igd2l0aCBhcHBlbmRNZXNzYWdlVG9FcnJvciBzZXQgYW5kIG5vIGNvZGVCbG9j
ayBhdmFpbGFibGUuIik7CiAKICAgICBpZiAoZmFpbGVkKSB7CiAgICAgICAgIHByaW50ZigiRkFJ
TDogU29tZSB0ZXN0cyBmYWlsZWQuXG4iKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y
dW50aW1lL1ZNLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt
ZS9WTS5jcHAJKHJldmlzaW9uIDE1NTQ4OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50
aW1lL1ZNLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjM1LDkgKzYzNSwxMSBAQCBKU1ZhbHVlIFZN
Ojp0aHJvd0V4Y2VwdGlvbihFeGVjU3RhdGUqIGV4CiAgICAgICAgIENhbGxGcmFtZSogY2FsbEZy
YW1lOwogICAgICAgICBmb3IgKGNhbGxGcmFtZSA9IGV4ZWM7IGNhbGxGcmFtZSAmJiAhY2FsbEZy
YW1lLT5jb2RlQmxvY2soKTsgY2FsbEZyYW1lID0gY2FsbEZyYW1lLT5jYWxsZXJGcmFtZSgpLT5y
ZW1vdmVIb3N0Q2FsbEZyYW1lRmxhZygpKQogICAgICAgICAgICAgc3RhY2tJbmRleCsrOwotICAg
ICAgICBzdGFja0ZyYW1lID0gc3RhY2tUcmFjZS5hdChzdGFja0luZGV4KTsKLSAgICAgICAgYnl0
ZWNvZGVPZmZzZXQgPSBzdGFja0ZyYW1lLmJ5dGVjb2RlT2Zmc2V0OwotICAgICAgICBhcHBlbmRT
b3VyY2VUb0Vycm9yKGNhbGxGcmFtZSwgc3RhdGljX2Nhc3Q8RXJyb3JJbnN0YW5jZSo+KGV4Y2Vw
dGlvbiksIGJ5dGVjb2RlT2Zmc2V0KTsKKyAgICAgICAgaWYgKGNhbGxGcmFtZSAmJiBjYWxsRnJh
bWUtPmNvZGVCbG9jaygpKSB7CisgICAgICAgICAgICBzdGFja0ZyYW1lID0gc3RhY2tUcmFjZS5h
dChzdGFja0luZGV4KTsKKyAgICAgICAgICAgIGJ5dGVjb2RlT2Zmc2V0ID0gc3RhY2tGcmFtZS5i
eXRlY29kZU9mZnNldDsKKyAgICAgICAgICAgIGFwcGVuZFNvdXJjZVRvRXJyb3IoY2FsbEZyYW1l
LCBzdGF0aWNfY2FzdDxFcnJvckluc3RhbmNlKj4oZXhjZXB0aW9uKSwgYnl0ZWNvZGVPZmZzZXQp
OworICAgICAgICB9CiAgICAgfQogCiAgICAgaWYgKGV4Y2VwdGlvbi0+aGFzUHJvcGVydHkoZXhl
YywgdGhpcy0+cHJvcGVydHlOYW1lcy0+c3RhY2spKQo=
</data>
<flag name="review"
          id="233326"
          type_id="1"
          status="-"
          setter="ggaren"
    />
    <flag name="commit-queue"
          id="233327"
          type_id="3"
          status="-"
          setter="ggaren"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>211268</attachid>
            <date>2013-09-10 17:41:10 -0700</date>
            <delta_ts>2013-09-10 17:44:22 -0700</delta_ts>
            <desc>patch 4</desc>
            <filename>ro.diff</filename>
            <type>text/plain</type>
            <size>4717</size>
            <attacher name="Chris Curtis">chris_curtis</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU1NDg5KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA
CisyMDEzLTA5LTEwICBDaHJpcyBDdXJ0aXMgIDxjaHJpc19jdXJ0aXNAYXBwbGUuY29tPgorCisg
ICAgICAgIFdlYktpdCBjcmFzaGVzIHdoZW4gdHJ5aW5nIHRvIHNlbmQgYSBtc2cgdmlhICd0b2Rh
eSdzIGJpcnRoZGF5cycgZGlhbG9ndWUgYm94IG9uIEZhY2Vib29rCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA2MTIjYWRkX2NvbW1lbnQKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNvZGVCbG9jayB3
YXMgYXNzdW1lZCB0byBleGlzdCB3aGVuIGFwcGVuZFNvdXJjZVRvTWVzc2FnZSB3YXMgc2V0Lgor
ICAgICAgICBUaGlzIHdhcyBhbiBpbnZhbGlkIGFzc3VtcHRpb24uIEkgYWRkZWQgYSBjaGVjayB0
byBlbnN1cmUgdGhhdCB0aGVyZSBpcyBhCisgICAgICAgIHZhbGlkIGNvZGVCbG9jayBiZWZvcmUg
YWNjZXNzaW5nIGl0LgorCisgICAgICAgICogQVBJL3Rlc3RzL3Rlc3RhcGkuYzoKKyAgICAgICAg
KHZhbHVlVG9PYmplY3RFeGNlcHRpb25DYWxsQXNGdW5jdGlvbik6CisgICAgICAgICh2YWx1ZVRv
T2JqZWN0RXhjZXB0aW9uVGVzdCk6CisgICAgICAgIChtYWluKToKKyAgICAgICAgKiBydW50aW1l
L1ZNLmNwcDoKKyAgICAgICAgKEpTQzo6Vk06OnRocm93RXhjZXB0aW9uKToKKwogMjAxMy0wOS0x
MCAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIE1h
cERhdGEgaGFzIHNvbWUgaXNzdWVzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rl
c3RzL3Rlc3RhcGkuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rl
c3RzL3Rlc3RhcGkuYwkocmV2aXNpb24gMTU1NDg4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl
L0FQSS90ZXN0cy90ZXN0YXBpLmMJKHdvcmtpbmcgY29weSkKQEAgLTEwNDMsNiArMTA0Myw0NCBA
QCBzdGF0aWMgYm9vbCBjaGVja0ZvckN5Y2xlSW5Qcm90b3R5cGVDaGFpCiAgICAgcmV0dXJuIHJl
c3VsdDsKIH0KIAorc3RhdGljIEpTVmFsdWVSZWYgdmFsdWVUb09iamVjdEV4Y2VwdGlvbkNhbGxB
c0Z1bmN0aW9uKEpTQ29udGV4dFJlZiBjdHgsIEpTT2JqZWN0UmVmIGZ1bmN0aW9uLCBKU09iamVj
dFJlZiB0aGlzT2JqZWN0LCBzaXplX3QgYXJndW1lbnRDb3VudCwgY29uc3QgSlNWYWx1ZVJlZiBh
cmd1bWVudHNbXSwgSlNWYWx1ZVJlZiogZXhjZXB0aW9uKQoreworICAgIFVOVVNFRF9QQVJBTShm
dW5jdGlvbik7CisgICAgVU5VU0VEX1BBUkFNKHRoaXNPYmplY3QpOworICAgIFVOVVNFRF9QQVJB
TShhcmd1bWVudENvdW50KTsKKyAgICBVTlVTRURfUEFSQU0oYXJndW1lbnRzKTsKKyAgICBKU1Zh
bHVlUmVmIGpzVW5kZWZpbmVkID0gSlNWYWx1ZU1ha2VVbmRlZmluZWQoSlNDb250ZXh0R2V0R2xv
YmFsQ29udGV4dChjdHgpKTsKKyAgICBKU1ZhbHVlVG9PYmplY3QoSlNDb250ZXh0R2V0R2xvYmFs
Q29udGV4dChjdHgpLCBqc1VuZGVmaW5lZCwgZXhjZXB0aW9uKTsKKyAgICAKKyAgICByZXR1cm4g
SlNWYWx1ZU1ha2VVbmRlZmluZWQoY3R4KTsKK30KK3N0YXRpYyBib29sIHZhbHVlVG9PYmplY3RF
eGNlcHRpb25UZXN0KCkKK3sKKyAgICBKU0dsb2JhbENvbnRleHRSZWYgSlNDb250ZXh0OworICAg
IEpTQ2xhc3NEZWZpbml0aW9uIGdsb2JhbE9iamVjdENsYXNzRGVmaW5pdGlvbiA9IGtKU0NsYXNz
RGVmaW5pdGlvbkVtcHR5OworICAgIGdsb2JhbE9iamVjdENsYXNzRGVmaW5pdGlvbi5pbml0aWFs
aXplID0gZ2xvYmFsT2JqZWN0X2luaXRpYWxpemU7CisgICAgZ2xvYmFsT2JqZWN0Q2xhc3NEZWZp
bml0aW9uLnN0YXRpY1ZhbHVlcyA9IGdsb2JhbE9iamVjdF9zdGF0aWNWYWx1ZXM7CisgICAgZ2xv
YmFsT2JqZWN0Q2xhc3NEZWZpbml0aW9uLnN0YXRpY0Z1bmN0aW9ucyA9IGdsb2JhbE9iamVjdF9z
dGF0aWNGdW5jdGlvbnM7CisgICAgZ2xvYmFsT2JqZWN0Q2xhc3NEZWZpbml0aW9uLmF0dHJpYnV0
ZXMgPSBrSlNDbGFzc0F0dHJpYnV0ZU5vQXV0b21hdGljUHJvdG90eXBlOworICAgIEpTQ2xhc3NS
ZWYgZ2xvYmFsT2JqZWN0Q2xhc3MgPSBKU0NsYXNzQ3JlYXRlKCZnbG9iYWxPYmplY3RDbGFzc0Rl
ZmluaXRpb24pOworICAgIEpTQ29udGV4dCA9IEpTR2xvYmFsQ29udGV4dENyZWF0ZUluR3JvdXAo
TlVMTCwgZ2xvYmFsT2JqZWN0Q2xhc3MpOworICAgIEpTT2JqZWN0UmVmIGdsb2JhbE9iamVjdCA9
IEpTQ29udGV4dEdldEdsb2JhbE9iamVjdChKU0NvbnRleHQpOworCisgICAgSlNTdHJpbmdSZWYg
dmFsdWVUb09iamVjdCA9IEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJ2YWx1ZVRvT2Jq
ZWN0Iik7CisgICAgSlNPYmplY3RSZWYgdmFsdWVUb09iamVjdEZ1bmN0aW9uID0gSlNPYmplY3RN
YWtlRnVuY3Rpb25XaXRoQ2FsbGJhY2soSlNDb250ZXh0LCB2YWx1ZVRvT2JqZWN0LCB2YWx1ZVRv
T2JqZWN0RXhjZXB0aW9uQ2FsbEFzRnVuY3Rpb24pOworICAgIEpTT2JqZWN0U2V0UHJvcGVydHko
SlNDb250ZXh0LCBnbG9iYWxPYmplY3QsIHZhbHVlVG9PYmplY3QsIHZhbHVlVG9PYmplY3RGdW5j
dGlvbiwga0pTUHJvcGVydHlBdHRyaWJ1dGVOb25lLCBOVUxMKTsKKyAgICBKU1N0cmluZ1JlbGVh
c2UodmFsdWVUb09iamVjdCk7CisKKyAgICBKU1N0cmluZ1JlZiB0ZXN0ID0gSlNTdHJpbmdDcmVh
dGVXaXRoVVRGOENTdHJpbmcoInZhbHVlVG9PYmplY3QoKTsiKTsKKyAgICBKU0V2YWx1YXRlU2Ny
aXB0KEpTQ29udGV4dCwgdGVzdCwgTlVMTCwgTlVMTCwgMSwgTlVMTCk7CisgICAgCisgICAgSlNT
dHJpbmdSZWxlYXNlKHRlc3QpOworICAgIEpTQ2xhc3NSZWxlYXNlKGdsb2JhbE9iamVjdENsYXNz
KTsKKyAgICBKU0dsb2JhbENvbnRleHRSZWxlYXNlKEpTQ29udGV4dCk7CisgICAgCisgICAgcmV0
dXJuIHRydWU7Cit9CisKIHN0YXRpYyB2b2lkIGNoZWNrQ29uc3RuZXNzSW5KU09iamVjdE5hbWVz
KCkKIHsKICAgICBKU1N0YXRpY0Z1bmN0aW9uIGZ1bjsKQEAgLTE5NzUsNiArMjAxMyw4IEBAIGlu
dCBtYWluKGludCBhcmdjLCBjaGFyKiBhcmd2W10pCiAgICAgICAgIHByaW50ZigiRkFJTDogQSBj
eWNsZSBpbiBhIHByb3RvdHlwZSBjaGFpbiBjYW4gYmUgY3JlYXRlZC5cbiIpOwogICAgICAgICBm
YWlsZWQgPSB0cnVlOwogICAgIH0KKyAgICBpZiAodmFsdWVUb09iamVjdEV4Y2VwdGlvblRlc3Qo
KSkKKyAgICAgICAgcHJpbnRmKCJQQVNTOiB0aHJvd0V4Y2VwdGlvbiBkaWQgbm90IGNyYXNoIHdo
ZW4gaGFuZGxpbmcgYW4gZXJyb3Igd2l0aCBhcHBlbmRNZXNzYWdlVG9FcnJvciBzZXQgYW5kIG5v
IGNvZGVCbG9jayBhdmFpbGFibGUuXG4iKTsKIAogICAgIGlmIChmYWlsZWQpIHsKICAgICAgICAg
cHJpbnRmKCJGQUlMOiBTb21lIHRlc3RzIGZhaWxlZC5cbiIpOwpJbmRleDogU291cmNlL0phdmFT
Y3JpcHRDb3JlL3J1bnRpbWUvVk0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0
Q29yZS9ydW50aW1lL1ZNLmNwcAkocmV2aXNpb24gMTU1NDg4KQorKysgU291cmNlL0phdmFTY3Jp
cHRDb3JlL3J1bnRpbWUvVk0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MzUsOSArNjM1LDExIEBA
IEpTVmFsdWUgVk06OnRocm93RXhjZXB0aW9uKEV4ZWNTdGF0ZSogZXgKICAgICAgICAgQ2FsbEZy
YW1lKiBjYWxsRnJhbWU7CiAgICAgICAgIGZvciAoY2FsbEZyYW1lID0gZXhlYzsgY2FsbEZyYW1l
ICYmICFjYWxsRnJhbWUtPmNvZGVCbG9jaygpOyBjYWxsRnJhbWUgPSBjYWxsRnJhbWUtPmNhbGxl
ckZyYW1lKCktPnJlbW92ZUhvc3RDYWxsRnJhbWVGbGFnKCkpCiAgICAgICAgICAgICBzdGFja0lu
ZGV4Kys7Ci0gICAgICAgIHN0YWNrRnJhbWUgPSBzdGFja1RyYWNlLmF0KHN0YWNrSW5kZXgpOwot
ICAgICAgICBieXRlY29kZU9mZnNldCA9IHN0YWNrRnJhbWUuYnl0ZWNvZGVPZmZzZXQ7Ci0gICAg
ICAgIGFwcGVuZFNvdXJjZVRvRXJyb3IoY2FsbEZyYW1lLCBzdGF0aWNfY2FzdDxFcnJvckluc3Rh
bmNlKj4oZXhjZXB0aW9uKSwgYnl0ZWNvZGVPZmZzZXQpOworICAgICAgICBpZiAoY2FsbEZyYW1l
ICYmIGNhbGxGcmFtZS0+Y29kZUJsb2NrKCkpIHsKKyAgICAgICAgICAgIHN0YWNrRnJhbWUgPSBz
dGFja1RyYWNlLmF0KHN0YWNrSW5kZXgpOworICAgICAgICAgICAgYnl0ZWNvZGVPZmZzZXQgPSBz
dGFja0ZyYW1lLmJ5dGVjb2RlT2Zmc2V0OworICAgICAgICAgICAgYXBwZW5kU291cmNlVG9FcnJv
cihjYWxsRnJhbWUsIHN0YXRpY19jYXN0PEVycm9ySW5zdGFuY2UqPihleGNlcHRpb24pLCBieXRl
Y29kZU9mZnNldCk7CisgICAgICAgIH0KICAgICB9CiAKICAgICBpZiAoZXhjZXB0aW9uLT5oYXNQ
cm9wZXJ0eShleGVjLCB0aGlzLT5wcm9wZXJ0eU5hbWVzLT5zdGFjaykpCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>211269</attachid>
            <date>2013-09-10 17:44:22 -0700</date>
            <delta_ts>2013-09-10 18:15:49 -0700</delta_ts>
            <desc>name change.</desc>
            <filename>ro.diff</filename>
            <type>text/plain</type>
            <size>4731</size>
            <attacher name="Chris Curtis">chris_curtis</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU1NDg5KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA
CisyMDEzLTA5LTEwICBDaHJpcyBDdXJ0aXMgIDxjaHJpc19jdXJ0aXNAYXBwbGUuY29tPgorCisg
ICAgICAgIFdlYktpdCBjcmFzaGVzIHdoZW4gdHJ5aW5nIHRvIHNlbmQgYSBtc2cgdmlhICd0b2Rh
eSdzIGJpcnRoZGF5cycgZGlhbG9ndWUgYm94IG9uIEZhY2Vib29rCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA2MTIjYWRkX2NvbW1lbnQKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNvZGVCbG9jayB3
YXMgYXNzdW1lZCB0byBleGlzdCB3aGVuIGFwcGVuZFNvdXJjZVRvTWVzc2FnZSB3YXMgc2V0Lgor
ICAgICAgICBUaGlzIHdhcyBhbiBpbnZhbGlkIGFzc3VtcHRpb24uIEkgYWRkZWQgYSBjaGVjayB0
byBlbnN1cmUgdGhhdCB0aGVyZSBpcyBhCisgICAgICAgIHZhbGlkIGNvZGVCbG9jayBiZWZvcmUg
YWNjZXNzaW5nIGl0LgorCisgICAgICAgICogQVBJL3Rlc3RzL3Rlc3RhcGkuYzoKKyAgICAgICAg
KHZhbHVlVG9PYmplY3RFeGNlcHRpb25DYWxsQXNGdW5jdGlvbik6CisgICAgICAgICh2YWx1ZVRv
T2JqZWN0RXhjZXB0aW9uVGVzdCk6CisgICAgICAgIChtYWluKToKKyAgICAgICAgKiBydW50aW1l
L1ZNLmNwcDoKKyAgICAgICAgKEpTQzo6Vk06OnRocm93RXhjZXB0aW9uKToKKwogMjAxMy0wOS0x
MCAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIE1h
cERhdGEgaGFzIHNvbWUgaXNzdWVzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rl
c3RzL3Rlc3RhcGkuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rl
c3RzL3Rlc3RhcGkuYwkocmV2aXNpb24gMTU1NDg4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl
L0FQSS90ZXN0cy90ZXN0YXBpLmMJKHdvcmtpbmcgY29weSkKQEAgLTEwNDMsNiArMTA0Myw0NCBA
QCBzdGF0aWMgYm9vbCBjaGVja0ZvckN5Y2xlSW5Qcm90b3R5cGVDaGFpCiAgICAgcmV0dXJuIHJl
c3VsdDsKIH0KIAorc3RhdGljIEpTVmFsdWVSZWYgdmFsdWVUb09iamVjdEV4Y2VwdGlvbkNhbGxB
c0Z1bmN0aW9uKEpTQ29udGV4dFJlZiBjdHgsIEpTT2JqZWN0UmVmIGZ1bmN0aW9uLCBKU09iamVj
dFJlZiB0aGlzT2JqZWN0LCBzaXplX3QgYXJndW1lbnRDb3VudCwgY29uc3QgSlNWYWx1ZVJlZiBh
cmd1bWVudHNbXSwgSlNWYWx1ZVJlZiogZXhjZXB0aW9uKQoreworICAgIFVOVVNFRF9QQVJBTShm
dW5jdGlvbik7CisgICAgVU5VU0VEX1BBUkFNKHRoaXNPYmplY3QpOworICAgIFVOVVNFRF9QQVJB
TShhcmd1bWVudENvdW50KTsKKyAgICBVTlVTRURfUEFSQU0oYXJndW1lbnRzKTsKKyAgICBKU1Zh
bHVlUmVmIGpzVW5kZWZpbmVkID0gSlNWYWx1ZU1ha2VVbmRlZmluZWQoSlNDb250ZXh0R2V0R2xv
YmFsQ29udGV4dChjdHgpKTsKKyAgICBKU1ZhbHVlVG9PYmplY3QoSlNDb250ZXh0R2V0R2xvYmFs
Q29udGV4dChjdHgpLCBqc1VuZGVmaW5lZCwgZXhjZXB0aW9uKTsKKyAgICAKKyAgICByZXR1cm4g
SlNWYWx1ZU1ha2VVbmRlZmluZWQoY3R4KTsKK30KK3N0YXRpYyBib29sIHZhbHVlVG9PYmplY3RF
eGNlcHRpb25UZXN0KCkKK3sKKyAgICBKU0dsb2JhbENvbnRleHRSZWYgdGVzdENvbnRleHQ7Cisg
ICAgSlNDbGFzc0RlZmluaXRpb24gZ2xvYmFsT2JqZWN0Q2xhc3NEZWZpbml0aW9uID0ga0pTQ2xh
c3NEZWZpbml0aW9uRW1wdHk7CisgICAgZ2xvYmFsT2JqZWN0Q2xhc3NEZWZpbml0aW9uLmluaXRp
YWxpemUgPSBnbG9iYWxPYmplY3RfaW5pdGlhbGl6ZTsKKyAgICBnbG9iYWxPYmplY3RDbGFzc0Rl
ZmluaXRpb24uc3RhdGljVmFsdWVzID0gZ2xvYmFsT2JqZWN0X3N0YXRpY1ZhbHVlczsKKyAgICBn
bG9iYWxPYmplY3RDbGFzc0RlZmluaXRpb24uc3RhdGljRnVuY3Rpb25zID0gZ2xvYmFsT2JqZWN0
X3N0YXRpY0Z1bmN0aW9uczsKKyAgICBnbG9iYWxPYmplY3RDbGFzc0RlZmluaXRpb24uYXR0cmli
dXRlcyA9IGtKU0NsYXNzQXR0cmlidXRlTm9BdXRvbWF0aWNQcm90b3R5cGU7CisgICAgSlNDbGFz
c1JlZiBnbG9iYWxPYmplY3RDbGFzcyA9IEpTQ2xhc3NDcmVhdGUoJmdsb2JhbE9iamVjdENsYXNz
RGVmaW5pdGlvbik7CisgICAgdGVzdENvbnRleHQgPSBKU0dsb2JhbENvbnRleHRDcmVhdGVJbkdy
b3VwKE5VTEwsIGdsb2JhbE9iamVjdENsYXNzKTsKKyAgICBKU09iamVjdFJlZiBnbG9iYWxPYmpl
Y3QgPSBKU0NvbnRleHRHZXRHbG9iYWxPYmplY3QodGVzdENvbnRleHQpOworCisgICAgSlNTdHJp
bmdSZWYgdmFsdWVUb09iamVjdCA9IEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJ2YWx1
ZVRvT2JqZWN0Iik7CisgICAgSlNPYmplY3RSZWYgdmFsdWVUb09iamVjdEZ1bmN0aW9uID0gSlNP
YmplY3RNYWtlRnVuY3Rpb25XaXRoQ2FsbGJhY2sodGVzdENvbnRleHQsIHZhbHVlVG9PYmplY3Qs
IHZhbHVlVG9PYmplY3RFeGNlcHRpb25DYWxsQXNGdW5jdGlvbik7CisgICAgSlNPYmplY3RTZXRQ
cm9wZXJ0eSh0ZXN0Q29udGV4dCwgZ2xvYmFsT2JqZWN0LCB2YWx1ZVRvT2JqZWN0LCB2YWx1ZVRv
T2JqZWN0RnVuY3Rpb24sIGtKU1Byb3BlcnR5QXR0cmlidXRlTm9uZSwgTlVMTCk7CisgICAgSlNT
dHJpbmdSZWxlYXNlKHZhbHVlVG9PYmplY3QpOworCisgICAgSlNTdHJpbmdSZWYgdGVzdCA9IEpT
U3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJ2YWx1ZVRvT2JqZWN0KCk7Iik7CisgICAgSlNF
dmFsdWF0ZVNjcmlwdCh0ZXN0Q29udGV4dCwgdGVzdCwgTlVMTCwgTlVMTCwgMSwgTlVMTCk7Cisg
ICAgCisgICAgSlNTdHJpbmdSZWxlYXNlKHRlc3QpOworICAgIEpTQ2xhc3NSZWxlYXNlKGdsb2Jh
bE9iamVjdENsYXNzKTsKKyAgICBKU0dsb2JhbENvbnRleHRSZWxlYXNlKHRlc3RDb250ZXh0KTsK
KyAgICAKKyAgICByZXR1cm4gdHJ1ZTsKK30KKwogc3RhdGljIHZvaWQgY2hlY2tDb25zdG5lc3NJ
bkpTT2JqZWN0TmFtZXMoKQogewogICAgIEpTU3RhdGljRnVuY3Rpb24gZnVuOwpAQCAtMTk3NSw2
ICsyMDEzLDggQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqIGFyZ3ZbXSkKICAgICAgICAgcHJp
bnRmKCJGQUlMOiBBIGN5Y2xlIGluIGEgcHJvdG90eXBlIGNoYWluIGNhbiBiZSBjcmVhdGVkLlxu
Iik7CiAgICAgICAgIGZhaWxlZCA9IHRydWU7CiAgICAgfQorICAgIGlmICh2YWx1ZVRvT2JqZWN0
RXhjZXB0aW9uVGVzdCgpKQorICAgICAgICBwcmludGYoIlBBU1M6IHRocm93RXhjZXB0aW9uIGRp
ZCBub3QgY3Jhc2ggd2hlbiBoYW5kbGluZyBhbiBlcnJvciB3aXRoIGFwcGVuZE1lc3NhZ2VUb0Vy
cm9yIHNldCBhbmQgbm8gY29kZUJsb2NrIGF2YWlsYWJsZS5cbiIpOwogCiAgICAgaWYgKGZhaWxl
ZCkgewogICAgICAgICBwcmludGYoIkZBSUw6IFNvbWUgdGVzdHMgZmFpbGVkLlxuIik7CkluZGV4
OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uY3BwCShyZXZpc2lvbiAxNTU0ODgpCisrKyBT
b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYz
NSw5ICs2MzUsMTEgQEAgSlNWYWx1ZSBWTTo6dGhyb3dFeGNlcHRpb24oRXhlY1N0YXRlKiBleAog
ICAgICAgICBDYWxsRnJhbWUqIGNhbGxGcmFtZTsKICAgICAgICAgZm9yIChjYWxsRnJhbWUgPSBl
eGVjOyBjYWxsRnJhbWUgJiYgIWNhbGxGcmFtZS0+Y29kZUJsb2NrKCk7IGNhbGxGcmFtZSA9IGNh
bGxGcmFtZS0+Y2FsbGVyRnJhbWUoKS0+cmVtb3ZlSG9zdENhbGxGcmFtZUZsYWcoKSkKICAgICAg
ICAgICAgIHN0YWNrSW5kZXgrKzsKLSAgICAgICAgc3RhY2tGcmFtZSA9IHN0YWNrVHJhY2UuYXQo
c3RhY2tJbmRleCk7Ci0gICAgICAgIGJ5dGVjb2RlT2Zmc2V0ID0gc3RhY2tGcmFtZS5ieXRlY29k
ZU9mZnNldDsKLSAgICAgICAgYXBwZW5kU291cmNlVG9FcnJvcihjYWxsRnJhbWUsIHN0YXRpY19j
YXN0PEVycm9ySW5zdGFuY2UqPihleGNlcHRpb24pLCBieXRlY29kZU9mZnNldCk7CisgICAgICAg
IGlmIChjYWxsRnJhbWUgJiYgY2FsbEZyYW1lLT5jb2RlQmxvY2soKSkgeworICAgICAgICAgICAg
c3RhY2tGcmFtZSA9IHN0YWNrVHJhY2UuYXQoc3RhY2tJbmRleCk7CisgICAgICAgICAgICBieXRl
Y29kZU9mZnNldCA9IHN0YWNrRnJhbWUuYnl0ZWNvZGVPZmZzZXQ7CisgICAgICAgICAgICBhcHBl
bmRTb3VyY2VUb0Vycm9yKGNhbGxGcmFtZSwgc3RhdGljX2Nhc3Q8RXJyb3JJbnN0YW5jZSo+KGV4
Y2VwdGlvbiksIGJ5dGVjb2RlT2Zmc2V0KTsKKyAgICAgICAgfQogICAgIH0KIAogICAgIGlmIChl
eGNlcHRpb24tPmhhc1Byb3BlcnR5KGV4ZWMsIHRoaXMtPnByb3BlcnR5TmFtZXMtPnN0YWNrKSkK
</data>

          </attachment>
      

    </bug>

</bugzilla>