120581 2013-09-01 08:40:25 -0700 [GTK] Color of input button's text broken with recent gnome-themes-standard 2013-09-04 06:43:27 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 csaavedra csaavedra cgarcia commit-queue oldest_to_newest 923474 0 csaavedra 2013-09-01 08:40:25 -0700 Since this commit: commit 30609ba766dd055f41002dcb813225d619b1d951 Author: Cosimo Cecchi <cosimoc@gnome.org> Date: Sun Jun 16 17:37:36 2013 -0700 Adapt to changes in GTK+ state propagation As GTK+ stopped propagating state flags to children, we can get rid of all the wildcard overrides for color: and [text,icon]-shadow properties. Also bump the required GTK+ version to git master. The text in buttons (<input type="Submit">) is broken, and these are painted always white. Seems that this is somehow related to bug 118234 too. We need this to be merged to the 2.2 branch too. 924378 1 210449 csaavedra 2013-09-04 05:53:10 -0700 Created attachment 210449 Patch 924380 2 210449 cgarcia 2013-09-04 05:57:10 -0700 Comment on attachment 210449 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210449&action=review Thanks! > Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:96 > + else if (widgetType == GTK_TYPE_BUTTON) { > gtk_widget_path_iter_add_class(path, 0, GTK_STYLE_CLASS_BUTTON); > + gtk_widget_path_iter_add_class(path, 1, "text-button"); > + } I guess we don't have image buttons in WebKit, so we can assume that web buttons are always text buttons. 924399 3 210449 commit-queue 2013-09-04 06:43:25 -0700 Comment on attachment 210449 Patch Clearing flags on attachment: 210449 Committed r155039: <http://trac.webkit.org/changeset/155039> 924400 4 commit-queue 2013-09-04 06:43:27 -0700 All reviewed patches have been landed. Closing bug. 210449 2013-09-04 05:53:10 -0700 2013-09-04 06:43:25 -0700 Patch bug-120581-20130904155308.patch text/plain 2414 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0ODA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDBkNGJkODU5MTlhYWQ0 NDg3MzdkYmJhNmIzNGQ0Mzg3MTFjZTAwYS4uZTM2MDAyNTFlMmZiZGI4NTIyMTgyNzIxZmEyOTc4 Y2QzMjY0OTE3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA5LTA0ICBDbGF1 ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gQ29s b3Igb2YgaW5wdXQgYnV0dG9uJ3MgdGV4dCBicm9rZW4gd2l0aCByZWNlbnQgZ25vbWUtdGhlbWVz LXN0YW5kYXJkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjA1ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0azMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Z2V0U3R5bGVDb250ZXh0KTogYWRkIHRoZSAidGV4dC1idXR0b24iIGNsYXNzLgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyVGhlbWVHdGs6OnN5c3RlbUNvbG9yKTogVXNlIHRoZSBBQ1RJVkUgc3Rh dGUgZmxhZywKKyAgICAgICAgYXMgdGhpcyBpcyB0aGUgb25lIGFjdHVhbGx5IHVzZWQgZm9yIGJ1 dHRvbiBsYWJlbHMuCisKIDIwMTMtMDgtMjggIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KIAogICAgICAgICBBWDogV2ViUHJvY2VzcyBhdCBjb20uYXBwbGUuV2ViQ29yZTog V2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6cm9vdE9iamVjdCArIDI3CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGszLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0azMuY3BwCmluZGV4IGE2OGVmZTdkNjI4M2Y1 ZjMyODBiMGE2N2ZjOTIyNTIyODhmZGYxOTMuLmIzOTcwNWU4ZjM1Zjc3NjJiYTc1NDk1MGJjYzI1 MTVjNjFjZGNmY2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5k ZXJUaGVtZUd0azMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJU aGVtZUd0azMuY3BwCkBAIC05MCw4ICs5MCwxMCBAQCBzdGF0aWMgR3RrU3R5bGVDb250ZXh0KiBn ZXRTdHlsZUNvbnRleHQoR1R5cGUgd2lkZ2V0VHlwZSkKICAgICAgICAgZ3RrX3dpZGdldF9wYXRo X2l0ZXJfYWRkX2NsYXNzKHBhdGgsIDAsIEdUS19TVFlMRV9DTEFTU19FTlRSWSk7CiAgICAgZWxz ZSBpZiAod2lkZ2V0VHlwZSA9PSBHVEtfVFlQRV9BUlJPVykKICAgICAgICAgZ3RrX3dpZGdldF9w YXRoX2l0ZXJfYWRkX2NsYXNzKHBhdGgsIDAsICJhcnJvdyIpOwotICAgIGVsc2UgaWYgKHdpZGdl dFR5cGUgPT0gR1RLX1RZUEVfQlVUVE9OKQorICAgIGVsc2UgaWYgKHdpZGdldFR5cGUgPT0gR1RL X1RZUEVfQlVUVE9OKSB7CiAgICAgICAgIGd0a193aWRnZXRfcGF0aF9pdGVyX2FkZF9jbGFzcyhw YXRoLCAwLCBHVEtfU1RZTEVfQ0xBU1NfQlVUVE9OKTsKKyAgICAgICAgZ3RrX3dpZGdldF9wYXRo X2l0ZXJfYWRkX2NsYXNzKHBhdGgsIDEsICJ0ZXh0LWJ1dHRvbiIpOworICAgIH0KICAgICBlbHNl IGlmICh3aWRnZXRUeXBlID09IEdUS19UWVBFX1NDQUxFKQogICAgICAgICBndGtfd2lkZ2V0X3Bh dGhfaXRlcl9hZGRfY2xhc3MocGF0aCwgMCwgR1RLX1NUWUxFX0NMQVNTX1NDQUxFKTsKICAgICBl bHNlIGlmICh3aWRnZXRUeXBlID09IEdUS19UWVBFX1NFUEFSQVRPUikKQEAgLTk4OCw3ICs5OTAs NyBAQCBDb2xvciBSZW5kZXJUaGVtZUd0azo6c3lzdGVtQ29sb3IoQ1NTVmFsdWVJRCBjc3NWYWx1 ZUlkKSBjb25zdAogCiAgICAgc3dpdGNoIChjc3NWYWx1ZUlkKSB7CiAgICAgY2FzZSBDU1NWYWx1 ZUJ1dHRvbnRleHQ6Ci0gICAgICAgIGd0a19zdHlsZV9jb250ZXh0X2dldF9jb2xvcihnZXRTdHls ZUNvbnRleHQoR1RLX1RZUEVfQlVUVE9OKSwgc3RhdGljX2Nhc3Q8R3RrU3RhdGVGbGFncz4oMCks ICZnZGtSR0JBQ29sb3IpOworICAgICAgICBndGtfc3R5bGVfY29udGV4dF9nZXRfY29sb3IoZ2V0 U3R5bGVDb250ZXh0KEdUS19UWVBFX0JVVFRPTiksIEdUS19TVEFURV9GTEFHX0FDVElWRSwgJmdk a1JHQkFDb2xvcik7CiAgICAgICAgIHJldHVybiBnZGtSR0JBQ29sb3I7CiAgICAgY2FzZSBDU1NW YWx1ZUNhcHRpb250ZXh0OgogICAgICAgICBndGtfc3R5bGVfY29udGV4dF9nZXRfY29sb3IoZ2V0 U3R5bGVDb250ZXh0KEdUS19UWVBFX0VOVFJZKSwgc3RhdGljX2Nhc3Q8R3RrU3RhdGVGbGFncz4o MCksICZnZGtSR0JBQ29sb3IpOwo=