120545 2013-08-30 12:30:28 -0700 warning: unused parameter ‘point’ and unused parameter ‘area' in EwkView.cpp:1390 2013-08-31 17:20:14 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 santosh.ma webkit-unassigned cdumez commit-queue gyuyoung.kim lucas.de.marchi rakuco oldest_to_newest 923139 0 santosh.ma 2013-08-30 12:30:28 -0700 Need to guard with UNUSED_PARAM 923142 1 210149 santosh.ma 2013-08-30 12:35:42 -0700 Created attachment 210149 Patch 923288 2 210149 rakuco 2013-08-31 07:07:55 -0700 Comment on attachment 210149 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210149&action=review > Source/WebKit2/ChangeLog:3 > + warning: unused parameter ‘point’ and unused parameter ‘area' in EwkView.cpp:1390 This line seems to have a funny encoding. 923316 3 210198 santosh.ma 2013-08-31 11:19:18 -0700 Created attachment 210198 patch for landing 923366 4 210198 commit-queue 2013-08-31 17:20:11 -0700 Comment on attachment 210198 patch for landing Clearing flags on attachment: 210198 Committed r154934: <http://trac.webkit.org/changeset/154934> 923367 5 commit-queue 2013-08-31 17:20:14 -0700 All reviewed patches have been landed. Closing bug. 210149 2013-08-30 12:35:42 -0700 2013-08-31 11:19:05 -0700 Patch bug-120545-20130831010540.patch text/plain 1340 santosh.ma U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0OTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmE4NDFkNDlkMjRmOWVi N2UyYmU1YTFiMWZjZWYxYjMzZDIzNzcxNC4uMmY4YWQ0MWZmZGI4OTllOTlmMjkzOWZiN2YzNWVk ZjBlNTE2ZThmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA4LTMwICBTYW50 b3NoIE1haHRvICA8c2FudG9zaC5tYUBzYW1zdW5nLmNvbT4KKworICAgICAgICB3YXJuaW5nOiB1 bnVzZWQgcGFyYW1ldGVyIOKAmHBvaW504oCZICAgYW5kIHVudXNlZCBwYXJhbWV0ZXIg4oCYYXJl YScgaW4gRXdrVmlldy5jcHA6MTM5MAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTIwNTQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcDoKKyAgICAgICAg KEV3a1ZpZXc6OmRpZEZpbmRab29tYWJsZUFyZWEpOiBBZGRlZCBVTlVTRURfUEFSQU0uCisKIDIw MTMtMDgtMzAgIEJyaWFuIEhvbHQgIDxicmlhbi5ob2x0QHNhbXN1bmcuY29tPgogCiAgICAgICAg IFtHVEtdIFtXSzJdIFRlc3RXZWJLaXRXZWJWaWV3IHNuYXBzaG90IGZhaWxzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwCmluZGV4IDViYjg0OTdhM2ZiZDc1 YjVlMjJjODM3ZTg2NTU2ZTM5OTM0ZmU1MzkuLjBiYjg4MGQ2YWQ2ZWRmOGNkMjlmMDkxZjNhN2Jh NGI0ZjhjNzhlNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs L0V3a1ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1Zp ZXcuY3BwCkBAIC0xMzkwLDYgKzEzOTAsOCBAQCBQYXNzUmVmUHRyPGNhaXJvX3N1cmZhY2VfdD4g RXdrVmlldzo6dGFrZVNuYXBzaG90KCkKIHZvaWQgRXdrVmlldzo6ZGlkRmluZFpvb21hYmxlQXJl YShjb25zdCBXS1BvaW50JiBwb2ludCwgY29uc3QgV0tSZWN0JiBhcmVhKQogewogICAgIG5vdElt cGxlbWVudGVkKCk7CisgICAgVU5VU0VEX1BBUkFNKHBvaW50KTsKKyAgICBVTlVTRURfUEFSQU0o YXJlYSk7CiB9CiAKIEV2YXNfU21hcnRfQ2xhc3MgRXdrVmlldzo6cGFyZW50U21hcnRDbGFzcyA9 IEVWQVNfU01BUlRfQ0xBU1NfSU5JVF9OVUxMOwo= 210198 2013-08-31 11:19:18 -0700 2013-08-31 17:20:11 -0700 patch for landing bug-120545-20130831234915.patch text/plain 1307 santosh.ma U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0OTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjcwZjUzNDc2NDljMDBh NmFhZGRkY2MzNzI0MzJlZjAzZjNhNjcxOC4uODU4ZWQ0NGVhOTY4NzQwMjVhOTA3YjM5ZTRiMTJl YmMwYTUzMjVlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA4LTMxICBTYW50 b3NoIE1haHRvICA8c2FudG9zaC5tYUBzYW1zdW5nLmNvbT4KKworICAgICAgICB3YXJuaW5nOiB1 bnVzZWQgcGFyYW1ldGVyIHBvaW50IGFuZCBhcmVhIGluIEV3a1ZpZXcuY3BwOjEzOTAKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDU0NQorCisgICAg ICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9l ZmwvRXdrVmlldy5jcHA6CisgICAgICAgIChFd2tWaWV3OjpkaWRGaW5kWm9vbWFibGVBcmVhKTog QWRkZWQgVU5VU0VEX1BBUkFNLgorCiAyMDEzLTA4LTMxICBKYWUgSHl1biBQYXJrICA8amFlLnBh cmtAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgUmVtb3ZlIHVudXNlZCB2YXJpYWJsZSBpbiBM YXllclRyZWVIb3N0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2Vm bC9Fd2tWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcu Y3BwCmluZGV4IDViYjg0OTdhM2ZiZDc1YjVlMjJjODM3ZTg2NTU2ZTM5OTM0ZmU1MzkuLjBiYjg4 MGQ2YWQ2ZWRmOGNkMjlmMDkxZjNhN2JhNGI0ZjhjNzhlNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwCkBAIC0xMzkwLDYgKzEzOTAsOCBAQCBQYXNz UmVmUHRyPGNhaXJvX3N1cmZhY2VfdD4gRXdrVmlldzo6dGFrZVNuYXBzaG90KCkKIHZvaWQgRXdr Vmlldzo6ZGlkRmluZFpvb21hYmxlQXJlYShjb25zdCBXS1BvaW50JiBwb2ludCwgY29uc3QgV0tS ZWN0JiBhcmVhKQogewogICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgVU5VU0VEX1BBUkFNKHBv aW50KTsKKyAgICBVTlVTRURfUEFSQU0oYXJlYSk7CiB9CiAKIEV2YXNfU21hcnRfQ2xhc3MgRXdr Vmlldzo6cGFyZW50U21hcnRDbGFzcyA9IEVWQVNfU01BUlRfQ0xBU1NfSU5JVF9OVUxMOwo=