120544 2013-08-30 12:25:32 -0700 Web Inspector: inspector/storage-panel-dom-storage-update.html is flakey on the bots 2014-12-12 13:29:19 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED INVALID InRadar P2 Normal --- 1 joepeck joepeck commit-queue dino joepeck timothy webkit-bug-importer oldest_to_newest 923133 0 joepeck 2013-08-30 12:25:32 -0700 inspector/storage-panel-dom-storage-update.html is flakey on the bots. It looks like the test is relying on InspectorTest.runAfterPendingDispatches(…) to run code after DOM Storage add/update/clears. However, those are not pending dispatches / results of actions, but DOMStorage agent events. So we should instead listen for pending events. 923134 1 webkit-bug-importer 2013-08-30 12:25:40 -0700 <rdar://problem/14881605> 923138 2 210147 joepeck 2013-08-30 12:29:02 -0700 Created attachment 210147 [PATCH] Proposed Fix The test could probably be simplified even more (removing most of the runAfterPendingDispatches could probably be removed) but ideally this would be converted to a real protocol test. I think this should fix the flakey ness though. 923152 3 210147 commit-queue 2013-08-30 13:00:37 -0700 Comment on attachment 210147 [PATCH] Proposed Fix Clearing flags on attachment: 210147 Committed r154907: <http://trac.webkit.org/changeset/154907> 923153 4 commit-queue 2013-08-30 13:00:39 -0700 All reviewed patches have been landed. Closing bug. 923172 5 joepeck 2013-08-30 13:44:58 -0700 Ahh, WebKit2 bot still complains about this: <http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r154907%20(11253)/results.html> Investigating now that I can reproduce with -2. 923177 6 joepeck 2013-08-30 14:13:06 -0700 So adding an extra log makes the test not timeout right now which makes very little sense at the moment. function viewUpdatedAfterAddition() { InspectorTest.addResult("viewUpdatedAfterAddition"); InspectorTest.runAfterPendingDispatches(function() { 923185 7 joepeck 2013-08-30 14:43:10 -0700 (In reply to comment #6) > So adding an extra log makes the test not timeout right now which makes very little sense at the moment. > > function viewUpdatedAfterAddition() > { > InspectorTest.addResult("viewUpdatedAfterAddition"); > InspectorTest.runAfterPendingDispatches(function() { So apparently removing this runAfterPendingDispatches fixed things, as long as I then made running the event handlers aware of this. I have no idea why this caused any issue on WebKit 2. I have little interest in investigating that further right now when it was unnecessary anyways. 923187 8 joepeck 2013-08-30 14:44:02 -0700 Landed follow-up fix: <http://trac.webkit.org/changeset/154911> 930415 9 ap 2013-09-17 14:48:59 -0700 This change made it so that the test times out 100% of the time on WebKit2. The test also sometimes times out on WK1. Marked accordingly in <http://trac.webkit.org/r156002>. This doesn't happen when new Web Inspector is enabled (I don't know if the test runs properly then, but it's reported as passing). 966643 10 timothy 2014-01-10 15:37:21 -0800 Moving to the right component. 1054920 11 burg 2014-12-12 13:29:19 -0800 Closing as invalid, as this bug pertains to the old inspector UI and/or its tests. Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk. 210147 2013-08-30 12:29:02 -0700 2013-08-30 13:00:37 -0700 [PATCH] Proposed Fix proposed-DOM-fix.patch text/plain 5796 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0MGJlNjVkLi45OWJlY2NmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTMtMDgt MzAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIg SW5zcGVjdG9yOiBpbnNwZWN0b3Ivc3RvcmFnZS1wYW5lbC1kb20tc3RvcmFnZS11cGRhdGUuaHRt bCBpcyBmbGFrZXkgb24gdGhlIGJvdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyMDU0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEV4cGxpY2l0bHkgbGlzdGVuIGZvciBldmVudHMgaW5zdGVhZCBvZiBy dW5uaW5nIGNhbGxiYWNrcyBhZnRlciBhIGRlbGF5LgorCisgICAgICAgICogaW5zcGVjdG9yL3N0 b3JhZ2UtcGFuZWwtZG9tLXN0b3JhZ2UtdXBkYXRlLmh0bWw6CisKKzIwMTMtMDgtMzAgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9y OiBCcmVha3BvaW50cyBzaG91bGQgaGF2ZSBBdXRvbWF0aWNhbGx5IENvbnRpbnVlIE9wdGlvbgog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwMTg3CiAK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9zdG9yYWdlLXBhbmVsLWRvbS1zdG9y YWdlLXVwZGF0ZS5odG1sIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0b3JhZ2UtcGFuZWwtZG9t LXN0b3JhZ2UtdXBkYXRlLmh0bWwKaW5kZXggMTlhYTcyMi4uNzU2NjQ3NyAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0b3JhZ2UtcGFuZWwtZG9tLXN0b3JhZ2UtdXBkYXRlLmh0 bWwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0b3JhZ2UtcGFuZWwtZG9tLXN0b3JhZ2Ut dXBkYXRlLmh0bWwKQEAgLTIsNyArMiw2IEBACiA8aGVhZD4NCiA8c2NyaXB0IHNyYz0iLi4vaHR0 cC90ZXN0cy9pbnNwZWN0b3IvaW5zcGVjdG9yLXRlc3QuanMiPjwvc2NyaXB0Pg0KIDxzY3JpcHQ+ DQotDQogZnVuY3Rpb24gYWRkSXRlbShrZXksdmFsdWUpDQogew0KICAgICBsb2NhbFN0b3JhZ2Uu c2V0SXRlbShrZXksdmFsdWUpOw0KQEAgLTQwLDE1ICszOSw0NiBAQCBmdW5jdGlvbiB0ZXN0KCkK ICAgICAgICAgSW5zcGVjdG9yVGVzdC5hZGRSZXN1bHQoIktleVZhbHVlIHBhaXJzOiBbIiArIHJv d3Muam9pbigpICsgIl0iKTsNCiAgICAgfQ0KIA0KKyAgICB2YXIgbmV4dERPTVN0b3JhZ2VDbGVh ckhhbmRsZXIgPSBudWxsOw0KKyAgICBJbnNwZWN0b3JUZXN0LmFkZFNuaWZmZXIoV2ViSW5zcGVj dG9yLkRPTVN0b3JhZ2VEaXNwYXRjaGVyLnByb3RvdHlwZSwgImRvbVN0b3JhZ2VJdGVtc0NsZWFy ZWQiLCBmdW5jdGlvbigpIHsNCisgICAgICAgIGlmIChuZXh0RE9NU3RvcmFnZUNsZWFySGFuZGxl cikgew0KKyAgICAgICAgICAgIG5leHRET01TdG9yYWdlQ2xlYXJIYW5kbGVyKCk7DQorICAgICAg ICAgICAgbmV4dERPTVN0b3JhZ2VDbGVhckhhbmRsZXIgPSBudWxsOw0KKyAgICAgICAgfSBlbHNl DQorICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5hZGRSZXN1bHQoIkVSUk9SOiBkb21TdG9yYWdl SXRlbXNDbGVhcmVkIGV2ZW50IHdpdGhvdXQgaGFuZGxlciIpOw0KKyAgICB9LCB0cnVlKTsNCisN CisgICAgdmFyIG5leHRET01TdG9yYWdlQWRkSGFuZGxlciA9IG51bGw7DQorICAgIEluc3BlY3Rv clRlc3QuYWRkU25pZmZlcihXZWJJbnNwZWN0b3IuRE9NU3RvcmFnZURpc3BhdGNoZXIucHJvdG90 eXBlLCAiZG9tU3RvcmFnZUl0ZW1BZGRlZCIsIGZ1bmN0aW9uKCkgew0KKyAgICAgICAgaWYgKG5l eHRET01TdG9yYWdlQWRkSGFuZGxlcikgew0KKyAgICAgICAgICAgIG5leHRET01TdG9yYWdlQWRk SGFuZGxlcigpOw0KKyAgICAgICAgICAgIG5leHRET01TdG9yYWdlQWRkSGFuZGxlciA9IG51bGw7 DQorICAgICAgICB9IGVsc2UNCisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmFkZFJlc3VsdCgi RVJST1I6IGRvbVN0b3JhZ2VJdGVtQWRkZWQgZXZlbnQgd2l0aG91dCBoYW5kbGVyIik7DQorICAg IH0sIHRydWUpOw0KKw0KKyAgICB2YXIgbmV4dERPTVN0b3JhZ2VSZW1vdmVIYW5kbGVyID0gbnVs bDsNCisgICAgSW5zcGVjdG9yVGVzdC5hZGRTbmlmZmVyKFdlYkluc3BlY3Rvci5ET01TdG9yYWdl RGlzcGF0Y2hlci5wcm90b3R5cGUsICJkb21TdG9yYWdlSXRlbVJlbW92ZWQiLCBmdW5jdGlvbigp IHsNCisgICAgICAgIGlmIChuZXh0RE9NU3RvcmFnZVJlbW92ZUhhbmRsZXIpIHsNCisgICAgICAg ICAgICBuZXh0RE9NU3RvcmFnZVJlbW92ZUhhbmRsZXIoKTsNCisgICAgICAgICAgICBuZXh0RE9N U3RvcmFnZVJlbW92ZUhhbmRsZXIgPSBudWxsOw0KKyAgICAgICAgfSBlbHNlDQorICAgICAgICAg ICAgSW5zcGVjdG9yVGVzdC5hZGRSZXN1bHQoIkVSUk9SOiBkb21TdG9yYWdlSXRlbVJlbW92ZWQg ZXZlbnQgd2l0aG91dCBoYW5kbGVyIik7DQorICAgIH0sIHRydWUpOw0KKw0KKw0KICAgICBJbnNw ZWN0b3JUZXN0LnJ1blRlc3RTdWl0ZShbDQogICAgICAgICBmdW5jdGlvbiBpbml0aWFsaXplKG5l eHQpDQogICAgICAgICB7DQotICAgICAgICAgICAgZnVuY3Rpb24gaW5pdGlhbGl6ZWQocmVzdWx0 KQ0KKyAgICAgICAgICAgIGZ1bmN0aW9uIGRpZENsZWFyKHJlc3VsdCkNCiAgICAgICAgICAgICB7 DQogICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuYWRkUmVzdWx0KCJJbml0aWFsaXplZCBs b2NhbFN0b3JhZ2UgYnkgY2xlYXJpbmcgZW50cmllcyIpOw0KICAgICAgICAgICAgICAgICBuZXh0 KCk7DQogICAgICAgICAgICAgfQ0KLSAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZXZhbHVhdGVJ blBhZ2UoImNsZWFyKCkiLCBpbml0aWFsaXplZCApOw0KKw0KKyAgICAgICAgICAgIG5leHRET01T dG9yYWdlQ2xlYXJIYW5kbGVyID0gZGlkQ2xlYXI7DQorDQorICAgICAgICAgICAgSW5zcGVjdG9y VGVzdC5ldmFsdWF0ZUluUGFnZSgiY2xlYXIoKSIpOw0KICAgICAgICAgfSwNCiANCiAgICAgICAg IGZ1bmN0aW9uIHVwZGF0ZUxvY2FsU3RvcmFnZVZpZXcobmV4dCkNCkBAIC01OSw2ICs4OSw3IEBA IGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuYWRkUmVzdWx0 KCJSZXNvdXJjZSBQYW5lbCB3aXRoIGxvY2FsU3RvcmFnZSB2aWV3IHVwZGF0ZWQiKTsNCiAgICAg ICAgICAgICAgICAgbmV4dCgpOw0KICAgICAgICAgICAgIH0NCisNCiAgICAgICAgICAgICB2YXIg c3RvcmFnZXMgPSBXZWJJbnNwZWN0b3IuZG9tU3RvcmFnZU1vZGVsLnN0b3JhZ2VzKCk7DQogICAg ICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBzdG9yYWdlcy5sZW5ndGg7ICsraSkgew0KICAg ICAgICAgICAgICAgICBzdG9yYWdlID0gc3RvcmFnZXNbaV07DQpAQCAtNzQsOCArMTA1LDcgQEAg ZnVuY3Rpb24gdGVzdCgpCiAgICAgICAgIHsNCiAgICAgICAgICAgICBmdW5jdGlvbiB2aWV3VXBk YXRlZEFmdGVyQWRkaXRpb24oKQ0KICAgICAgICAgICAgIHsNCi0gICAgICAgICAgICAgICAgSW5z cGVjdG9yVGVzdC5ydW5BZnRlclBlbmRpbmdEaXNwYXRjaGVzKGZ1bmN0aW9uKCkNCi0gICAgICAg ICAgICAgICAgew0KKyAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LnJ1bkFmdGVyUGVuZGlu Z0Rpc3BhdGNoZXMoZnVuY3Rpb24oKSB7DQogICAgICAgICAgICAgICAgICAgICByb290Tm9kZSA9 IFdlYkluc3BlY3Rvci5wYW5lbHMucmVzb3VyY2VzLl9kb21TdG9yYWdlVmlld3MuZ2V0KHN0b3Jh Z2UpLl9kYXRhR3JpZC5yb290Tm9kZSgpOw0KICAgICAgICAgICAgICAgICAgICAgZHVtcERhdGFH cmlkKCk7DQogICAgICAgICAgICAgICAgICAgICBpZiAoY291bnQgPCA2KQ0KQEAgLTg1LDEzICsx MTUsMTAgQEAgZnVuY3Rpb24gdGVzdCgpCiAgICAgICAgICAgICAgICAgfSk7DQogICAgICAgICAg ICAgfQ0KIA0KLSAgICAgICAgICAgIGZ1bmN0aW9uIGl0ZW1BZGRlZChyZXN1bHQpDQotICAgICAg ICAgICAgew0KLSAgICAgICAgICAgICAgICB2aWV3VXBkYXRlZEFmdGVyQWRkaXRpb24oKTsNCi0g ICAgICAgICAgICB9DQorICAgICAgICAgICAgbmV4dERPTVN0b3JhZ2VBZGRIYW5kbGVyID0gdmll d1VwZGF0ZWRBZnRlckFkZGl0aW9uOw0KIA0KICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuYWRk UmVzdWx0KCJhZGRJdGVtKCdhIitjb3VudCsiJywnPXZhbHVlIitjb3VudCsiJykiKTsNCi0gICAg ICAgICAgICBJbnNwZWN0b3JUZXN0LmV2YWx1YXRlSW5QYWdlKCJhZGRJdGVtKCdhIitjb3VudCsi JywnPXZhbHVlIitjb3VudCsiJykiLCBpdGVtQWRkZWQgKTsNCisgICAgICAgICAgICBJbnNwZWN0 b3JUZXN0LmV2YWx1YXRlSW5QYWdlKCJhZGRJdGVtKCdhIitjb3VudCsiJywnPXZhbHVlIitjb3Vu dCsiJykiKTsNCiAgICAgICAgICAgICBjb3VudCsrOw0KICAgICAgICAgfSwNCiANCkBAIC0xMDks MTQgKzEzNiwxMSBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICAgICAgICAgICAgICB9KTsNCiAgICAg ICAgICAgICB9DQogDQotICAgICAgICAgICAgZnVuY3Rpb24gaXRlbVJlbW92ZWQocmVzdWx0KQ0K LSAgICAgICAgICAgIHsNCi0gICAgICAgICAgICAgICAgc2V0VGltZW91dCh2aWV3VXBkYXRlZEFm dGVyUmVtb3ZhbCwgMCApOw0KLSAgICAgICAgICAgIH0NCisgICAgICAgICAgICBuZXh0RE9NU3Rv cmFnZVJlbW92ZUhhbmRsZXIgPSB2aWV3VXBkYXRlZEFmdGVyUmVtb3ZhbDsNCiANCiAgICAgICAg ICAgICAtLWNvdW50Ow0KICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuYWRkUmVzdWx0KCJyZW1v dmVJdGVtKCdhIitjb3VudCsiJykiKTsNCi0gICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV2YWx1 YXRlSW5QYWdlKCJyZW1vdmVJdGVtKCdhIitjb3VudCsiJykiLCBpdGVtUmVtb3ZlZCApOw0KKyAg ICAgICAgICAgIEluc3BlY3RvclRlc3QuZXZhbHVhdGVJblBhZ2UoInJlbW92ZUl0ZW0oJ2EiK2Nv dW50KyInKSIpOw0KICAgICAgICAgfSwNCiANCiAgICAgICAgIGZ1bmN0aW9uIGNsZWFyVGVzdChu ZXh0KQ0KQEAgLTEzMCwyMSArMTU0LDE2IEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICAgICAg ICAgIH0pOw0KICAgICAgICAgICAgIH0NCiANCi0gICAgICAgICAgICBmdW5jdGlvbiBjbGVhcmVk KHJlc3VsdCkNCi0gICAgICAgICAgICB7DQotICAgICAgICAgICAgICAgIHNldFRpbWVvdXQodmll d1VwZGF0ZWRBZnRlckNsZWFyLCAwICk7DQotICAgICAgICAgICAgfQ0KKyAgICAgICAgICAgIG5l eHRET01TdG9yYWdlQ2xlYXJIYW5kbGVyID0gdmlld1VwZGF0ZWRBZnRlckNsZWFyOw0KIA0KICAg ICAgICAgICAgIEluc3BlY3RvclRlc3QuYWRkUmVzdWx0KCJjbGVhcigpIik7DQotICAgICAgICAg ICAgSW5zcGVjdG9yVGVzdC5ldmFsdWF0ZUluUGFnZSgiY2xlYXIoKSIsIGNsZWFyZWQgKTsNCisg ICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV2YWx1YXRlSW5QYWdlKCJjbGVhcigpIik7DQogICAg ICAgICB9DQogICAgIF0pOw0KIH0NCiA8L3NjcmlwdD4NCiA8L2hlYWQ+DQotDQogPGJvZHkgb25s b2FkPSJydW5UZXN0KCkiPg0KIDxwPlRlc3QgdGhhdCBzdG9yYWdlIHBhbmVsIGlzIHByZXNlbnQg YW5kIHRoYXQgaXQgY29udGFpbnMgY29ycmVjdCBkYXRhIHdoZW5ldmVyIGxvY2FsU3RvcmFnZSBp cyB1cGRhdGVkLjwvcD4NCiA8L2JvZHk+DQogPC9odG1sPg0KLQ0K