120543 2013-08-30 12:11:54 -0700 warning: unused parameter ‘renderingMode' in ImageBufferCairo.cpp:94 2013-08-31 22:03:57 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 santosh.ma webkit-unassigned commit-queue d-r oldest_to_newest 923124 0 santosh.ma 2013-08-30 12:11:54 -0700 ‘renderingMode' should be guarded with UNUSED_PARAM() 923135 1 210146 santosh.ma 2013-08-30 12:25:45 -0700 Created attachment 210146 Patch 923140 2 210146 darin 2013-08-30 12:30:29 -0700 Comment on attachment 210146 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210146&action=review > Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:106 > + UNUSED_PARAM(renderingMode); I think ASSERT_UNUSED might be better here, since we know what value we support for rendering mode. 923313 3 210197 santosh.ma 2013-08-31 11:09:48 -0700 Created attachment 210197 patch for landing 923314 4 210197 commit-queue 2013-08-31 11:10:53 -0700 Comment on attachment 210197 patch for landing Rejecting attachment 210197 from commit-queue. santosh.ma@samsung.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 923389 5 210197 commit-queue 2013-08-31 22:03:54 -0700 Comment on attachment 210197 patch for landing Clearing flags on attachment: 210197 Committed r154936: <http://trac.webkit.org/changeset/154936> 923390 6 commit-queue 2013-08-31 22:03:57 -0700 All reviewed patches have been landed. Closing bug. 210146 2013-08-30 12:25:45 -0700 2013-08-31 11:09:37 -0700 Patch bug-120543-20130831005543.patch text/plain 1535 santosh.ma U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0OTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmZhMzM5NDE5M2MzYWFl MDAzNTE3YjJmMTBhNDYwZTcxOTUwNzE0ZS4uNjZkYjYxYzU3ZDNhODdjODQ2NWFlYmNmNGIwODA1 OWM3MDM0ZmNiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA4LTMwICBTYW50 b3NoIE1haHRvICA8c2FudG9zaC5tYUBzYW1zdW5nLmNvbT4KKworICAgICAgICB3YXJuaW5nOiB1 bnVzZWQgcGFyYW1ldGVyIOKAmHJlbmRlcmluZ01vZGUnICBpbiBJbWFnZUJ1ZmZlckNhaXJvLmNw cDo5NAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIw NTQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4 aW5nIHdhcm5pbmcgYnkgYWRkaW5nIFVOVVNFRF9QQVJBTS4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2NhaXJvL0ltYWdlQnVmZmVyQ2Fpcm8uY3BwOgorICAgICAgICAoV2ViQ29yZTo6 SW1hZ2VCdWZmZXI6OkltYWdlQnVmZmVyKToKKwogMjAxMy0wOC0zMCAgTGVvIFlhbmcgIDxsZW95 YW5nQGJsYWNrYmVycnkuY29tPgogCiAgICAgICAgIE1ha2Ugc3VyZSByZW1vdmUgQ2FjaGVkUmVz b3VyY2VDbGllbnQgd2hlbiBkZXN0cnVjdGluZyBJY29uTG9hZGVyCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9JbWFnZUJ1ZmZlckNhaXJvLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ltYWdlQnVmZmVyQ2Fpcm8u Y3BwCmluZGV4IDRjZjcxNjYxMzc1N2YxNjk5M2Q0MTA5ZDQ2OGY2NWVlN2JjYzEzMjMuLjliZTY2 M2M4ZTRlOTlkNDkzYTQ2OTBjM2FkNzM0ZDgxZWI4MmM0ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ltYWdlQnVmZmVyQ2Fpcm8uY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ltYWdlQnVmZmVyQ2Fpcm8u Y3BwCkBAIC0xMDIsNiArMTAyLDggQEAgSW1hZ2VCdWZmZXI6OkltYWdlQnVmZmVyKGNvbnN0IElu dFNpemUmIHNpemUsIGZsb2F0IC8qIHJlc29sdXRpb25TY2FsZSAqLywgQ29sb3IKICAgICBpZiAo cmVuZGVyaW5nTW9kZSA9PSBBY2NlbGVyYXRlZCkKICAgICAgICAgbV9kYXRhLm1fc3VyZmFjZSA9 IGNyZWF0ZUNhaXJvR0xTdXJmYWNlKHNpemUsIG1fZGF0YS5tX3RleHR1cmUpOwogICAgIGVsc2UK KyNlbHNlCisgICAgVU5VU0VEX1BBUkFNKHJlbmRlcmluZ01vZGUpOwogI2VuZGlmCiAgICAgICAg IG1fZGF0YS5tX3N1cmZhY2UgPSBhZG9wdFJlZihjYWlyb19pbWFnZV9zdXJmYWNlX2NyZWF0ZShD QUlST19GT1JNQVRfQVJHQjMyLCBzaXplLndpZHRoKCksIHNpemUuaGVpZ2h0KCkpKTsKIAo= 210197 2013-08-31 11:09:48 -0700 2013-08-31 22:03:54 -0700 patch for landing bug-120543-20130831233946.patch text/plain 1554 santosh.ma U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0OTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzA1N2Y4ZGExY2MxMmEx ZTI2NmZkMDFlMjYwYjA2Mzg5NTNkMWI0My4uMTNmNWQ0ZjMwNTNkZDk0N2JkY2Q4YTY5NGI0NDk1 NzdjYzE4ODk4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA4LTMxICBTYW50 b3NoIE1haHRvICA8c2FudG9zaC5tYUBzYW1zdW5nLmNvbT4KKworICAgICAgICB3YXJuaW5nOiB1 bnVzZWQgcGFyYW1ldGVyIOKAmHJlbmRlcmluZ01vZGUnICBpbiBJbWFnZUJ1ZmZlckNhaXJvLmNw cDo5NAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIw NTQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgRml4aW5n IHdhcm5pbmcgYnkgYWRkaW5nIEFTU0VSVF9VTlVTRUQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9jYWlyby9JbWFnZUJ1ZmZlckNhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Oklt YWdlQnVmZmVyOjpJbWFnZUJ1ZmZlcik6CisKIDIwMTMtMDgtMzEgIEFuZHJlYXMgS2xpbmcgIDxh a2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFBvc3RBdHRhY2hDYWxsYmFja0Rpc2FibGVyIHNo b3VsZCB0YWtlIGEgQ29udGFpbmVyTm9kZSYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jYWlyby9JbWFnZUJ1ZmZlckNhaXJvLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ltYWdlQnVmZmVyQ2Fpcm8uY3BwCmluZGV4IDRj ZjcxNjYxMzc1N2YxNjk5M2Q0MTA5ZDQ2OGY2NWVlN2JjYzEzMjMuLjhjNjJlN2VkYTY1ZjM3MThh NTU3NDNkMGM3ZGUyZGY5M2FhNDI0MzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NhaXJvL0ltYWdlQnVmZmVyQ2Fpcm8uY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ltYWdlQnVmZmVyQ2Fpcm8uY3BwCkBAIC0xMDIs NiArMTAyLDggQEAgSW1hZ2VCdWZmZXI6OkltYWdlQnVmZmVyKGNvbnN0IEludFNpemUmIHNpemUs IGZsb2F0IC8qIHJlc29sdXRpb25TY2FsZSAqLywgQ29sb3IKICAgICBpZiAocmVuZGVyaW5nTW9k ZSA9PSBBY2NlbGVyYXRlZCkKICAgICAgICAgbV9kYXRhLm1fc3VyZmFjZSA9IGNyZWF0ZUNhaXJv R0xTdXJmYWNlKHNpemUsIG1fZGF0YS5tX3RleHR1cmUpOwogICAgIGVsc2UKKyNlbHNlCisgICAg QVNTRVJUX1VOVVNFRChyZW5kZXJpbmdNb2RlLCByZW5kZXJpbmdNb2RlICE9IEFjY2VsZXJhdGVk KTsKICNlbmRpZgogICAgICAgICBtX2RhdGEubV9zdXJmYWNlID0gYWRvcHRSZWYoY2Fpcm9faW1h Z2Vfc3VyZmFjZV9jcmVhdGUoQ0FJUk9fRk9STUFUX0FSR0IzMiwgc2l6ZS53aWR0aCgpLCBzaXpl LmhlaWdodCgpKSk7CiAK