120541 2013-08-30 11:37:11 -0700 Make sure remove CachedResourceClient when destructing IconLoader 2013-10-03 11:51:03 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 leoyang leoyang commit-queue japhet mark.toller staikos oldest_to_newest 923108 0 leoyang 2013-08-30 11:37:11 -0700 It's a good practice to call CachedResource::removeClient(client) when the client destructing. We need to do this for InconLoader to prevent m_resource from keeping dangling client in case m_resource is referenced by someone else in the future. 923113 1 210141 leoyang 2013-08-30 11:43:13 -0700 Created attachment 210141 Patch 923118 2 210141 darin 2013-08-30 11:50:18 -0700 Comment on attachment 210141 Patch I am really concerned that we are doing these fixes without regression tests. Over the years we have found the extra effort to demonstrate the problem with a test is well worth it. 923121 3 leoyang 2013-08-30 11:58:11 -0700 (In reply to comment #2) > (From update of attachment 210141 [details]) > I am really concerned that we are doing these fixes without regression tests. Over the years we have found the extra effort to demonstrate the problem with a test is well worth it. I understand the importance of regression tests. But for this specific change it's just defensive and following the common good practice of removing client when destructing. At the moment this is not a bug without the patch because m_resource is going to be destroyed soon anyway. 923130 4 210141 commit-queue 2013-08-30 12:20:31 -0700 Comment on attachment 210141 Patch Clearing flags on attachment: 210141 Committed r154905: <http://trac.webkit.org/changeset/154905> 923131 5 commit-queue 2013-08-30 12:20:32 -0700 All reviewed patches have been landed. Closing bug. 935896 6 ap 2013-10-03 11:51:03 -0700 *** Bug 106663 has been marked as a duplicate of this bug. *** 210141 2013-08-30 11:43:13 -0700 2013-08-30 12:20:31 -0700 Patch 0001-Make-sure-remove-CachedResourceClient-when-destructi.patch text/plain 2271 leoyang RnJvbSA3N2E4YTEwYjI2ZDA4NTk2OTZlYmE5YTI5OTlkOTNkYzRmMmY1Nzg1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVveWFuZ0BibGFja2JlcnJ5LmNvbT4KRGF0 ZTogRnJpLCAzMCBBdWcgMjAxMyAxNDo0MTozOSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIE1ha2Ug c3VyZSByZW1vdmUgQ2FjaGVkUmVzb3VyY2VDbGllbnQgd2hlbiBkZXN0cnVjdGluZwogSWNvbkxv YWRlciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwNTQxCgpSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCkl0J3MgYSBnb29kIHByYWN0aWNlIHRvIGNhbGwgQ2Fj aGVkUmVzb3VyY2U6OnJlbW92ZUNsaWVudChjbGllbnQpCndoZW4gdGhlIGNsaWVudCBpcyBiZWlu ZyBkZXN0cnVjdGVkLiBXZSBuZWVkIHRvIGRvIHRoaXMgZm9yIEluY29uTG9hZGVyCnRvIHByZXZl bnQgbV9yZXNvdXJjZSBmcm9tIGtlZXBpbmcgZGFuZ2xpbmcgY2xpZW50IGluIGNhc2UgbV9yZXNv dXJjZQppcyByZWZlcmVuY2VkIGJ5IHNvbWVvbmUgZWxzZSBpbiB0aGUgZnV0dXJlLgoKRm91bmQg YnkgY29kZSBpbnNwZWN0aW9uLiBKdXN0IGEgZGVmZW5zaXZlIGVuaGFuY2VtZW50IG5vIG5ldyB0 ZXN0cy4KCiogbG9hZGVyL2ljb24vSWNvbkxvYWRlci5jcHA6CihXZWJDb3JlOjpJY29uTG9hZGVy Ojp+SWNvbkxvYWRlcik6CgpDaGFuZ2UtSWQ6IEk4NjE1Yzc1YWE5NzE1YTg1MzgwODIyMGJiYjkx MjQwODQyNTFjY2E4Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgfCAxNyArKysrKysrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvbG9hZGVyL2ljb24vSWNv bkxvYWRlci5jcHAgfCAgMSArCiAyIGZpbGVzIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKykKCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKaW5kZXggNjUxNGU2NC4uMWM1OTFlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBA CisyMDEzLTA4LTMwICBMZW8gWWFuZyAgPGxlb3lhbmdAYmxhY2tiZXJyeS5jb20+CisKKyAgICAg ICAgTWFrZSBzdXJlIHJlbW92ZSBDYWNoZWRSZXNvdXJjZUNsaWVudCB3aGVuIGRlc3RydWN0aW5n IEljb25Mb2FkZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyMDU0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEl0J3MgYSBnb29kIHByYWN0aWNlIHRvIGNhbGwgQ2FjaGVkUmVzb3VyY2U6OnJlbW92ZUNs aWVudChjbGllbnQpCisgICAgICAgIHdoZW4gdGhlIGNsaWVudCBpcyBiZWluZyBkZXN0cnVjdGVk LiBXZSBuZWVkIHRvIGRvIHRoaXMgZm9yIEluY29uTG9hZGVyCisgICAgICAgIHRvIHByZXZlbnQg bV9yZXNvdXJjZSBmcm9tIGtlZXBpbmcgZGFuZ2xpbmcgY2xpZW50IGluIGNhc2UgbV9yZXNvdXJj ZQorICAgICAgICBpcyByZWZlcmVuY2VkIGJ5IHNvbWVvbmUgZWxzZSBpbiB0aGUgZnV0dXJlLgor CisgICAgICAgIEZvdW5kIGJ5IGNvZGUgaW5zcGVjdGlvbi4gSnVzdCBhIGRlZmVuc2l2ZSBlbmhh bmNlbWVudCBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBsb2FkZXIvaWNvbi9JY29uTG9hZGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okljb25Mb2FkZXI6On5JY29uTG9hZGVyKToKKwogMjAx My0wOC0zMCAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgRG9j dW1lbnQgc3R5bGUgcmVzb2x2ZSBzaG91bGQgdGFrZSBEb2N1bWVudCYuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2xvYWRlci9pY29uL0ljb25Mb2FkZXIuY3BwCmluZGV4IGMzMGUyODcuLmMzMmQxYmMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9pY29uL0ljb25Mb2FkZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9pY29uL0ljb25Mb2FkZXIuY3BwCkBAIC01NSw2ICs1NSw3IEBA IFBhc3NPd25QdHI8SWNvbkxvYWRlcj4gSWNvbkxvYWRlcjo6Y3JlYXRlKEZyYW1lKiBmcmFtZSkK IAogSWNvbkxvYWRlcjo6fkljb25Mb2FkZXIoKQogeworICAgIHN0b3BMb2FkaW5nKCk7CiB9CiAK IHZvaWQgSWNvbkxvYWRlcjo6c3RhcnRMb2FkaW5nKCkKLS0gCjEuOC40LnJjMwoK