120524 2013-08-30 06:27:25 -0700 Compile warning fix: In graphics/cairo/GraphicsContextCairo.cpp. 2013-09-06 04:39:15 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abrhm webkit-unassigned commit-queue d-r kling ossy oldest_to_newest 922915 0 abrhm 2013-08-30 06:27:25 -0700 In Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp There is an unused parameter in GraphicsContext::fillRectWithRoundedHole function. 922917 1 210098 abrhm 2013-08-30 06:29:50 -0700 Created attachment 210098 Proposed patch 922949 2 210098 darin 2013-08-30 08:01:48 -0700 Comment on attachment 210098 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=210098&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Commit queue won’t land a patch with the word OOPS in it. 922966 3 210098 commit-queue 2013-08-30 08:24:23 -0700 Comment on attachment 210098 Proposed patch Rejecting attachment 210098 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 210098, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/1648125 922983 4 210116 abrhm 2013-08-30 08:48:35 -0700 Created attachment 210116 Fixed patch 923004 5 210116 commit-queue 2013-08-30 09:38:10 -0700 Comment on attachment 210116 Fixed patch Clearing flags on attachment: 210116 Committed r154888: <http://trac.webkit.org/changeset/154888> 210098 2013-08-30 06:29:50 -0700 2013-09-06 04:39:15 -0700 Proposed patch patch41.patch text/plain 1477 abrhm ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxYWIxMGE5Li44ZjVmODU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMDgtMzAgIEdhYm9yIEFicmFoYW0gIDxhYnJobUBpbmYudS1zemVnZWQuaHU+CisK KyAgICAgICAgRml4IHVudXNlZCBwYXJhbWV0ZXIgd2FybmluZyBpbiBncmFwaGljcy9jYWlyby9H cmFwaGljc0NvbnRleHRDYWlyby5jcHAgZmlsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDUyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAoT09QUyEpLgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpmaWxsUmVjdFdpdGhSb3VuZGVkSG9sZSk6CisK IDIwMTMtMDgtMzAgIEFuZHJlaSBQYXJ2dSAgPHBhcnZ1QGFkb2JlLmNvbT4KIAogICAgICAgICBb Q1NTIE1hc2tpbmddIC13ZWJraXQtbWFzay1yZXBlYXQ6IHNwYWNlIGRvZXMgbm90IHdvcmsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNz Q29udGV4dENhaXJvLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJv L0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcAppbmRleCAzYzhjYzkzLi5jN2VhNzZkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRl eHRDYWlyby5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8v R3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwCkBAIC0xMDQwLDcgKzEwNDAsNyBAQCB2b2lkIEdyYXBo aWNzQ29udGV4dDo6ZmlsbFJvdW5kZWRSZWN0KGNvbnN0IEludFJlY3QmIHIsIGNvbnN0IEludFNp emUmIHRvcExlZnQsCiAgICAgY2Fpcm9fcmVzdG9yZShjcik7CiB9CiAKLXZvaWQgR3JhcGhpY3ND b250ZXh0OjpmaWxsUmVjdFdpdGhSb3VuZGVkSG9sZShjb25zdCBJbnRSZWN0JiByZWN0LCBjb25z dCBSb3VuZGVkUmVjdCYgcm91bmRlZEhvbGVSZWN0LCBjb25zdCBDb2xvciYgY29sb3IsIENvbG9y U3BhY2UgY29sb3JTcGFjZSkKK3ZvaWQgR3JhcGhpY3NDb250ZXh0OjpmaWxsUmVjdFdpdGhSb3Vu ZGVkSG9sZShjb25zdCBJbnRSZWN0JiByZWN0LCBjb25zdCBSb3VuZGVkUmVjdCYgcm91bmRlZEhv bGVSZWN0LCBjb25zdCBDb2xvciYgY29sb3IsIENvbG9yU3BhY2UpCiB7CiAgICAgaWYgKHBhaW50 aW5nRGlzYWJsZWQoKSB8fCAhY29sb3IuaXNWYWxpZCgpKQogICAgICAgICByZXR1cm47Cg== 210116 2013-08-30 08:48:35 -0700 2013-08-30 09:38:10 -0700 Fixed patch patch42.patch text/plain 1450 abrhm ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlNTk3ZTg0Li41OThlM2MzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTMtMDgtMzAgIEdhYm9yIEFicmFoYW0gIDxhYnJobUBpbmYudS1zemVnZWQuaHU+CisK KyAgICAgICAgRml4IHVudXNlZCBwYXJhbWV0ZXIgd2FybmluZyBpbiBncmFwaGljcy9jYWlyby9H cmFwaGljc0NvbnRleHRDYWlyby5jcHAgZmlsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDUyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3ND b250ZXh0Q2Fpcm8uY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpmaWxs UmVjdFdpdGhSb3VuZGVkSG9sZSk6CisKIDIwMTMtMDgtMzAgIFRhbWFzIEN6ZW5lICA8dGN6ZW5l QGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBSZXNvbHZlIHVudXNlZCBwYXJhbWV0ZXIgd2Fy bmluZyBpbiBGaW5kQ29udHJvbGxlci5jcHAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcApp bmRleCAzYzhjYzkzLi5jN2VhNzZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwCkBA IC0xMDQwLDcgKzEwNDAsNyBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6ZmlsbFJvdW5kZWRSZWN0 KGNvbnN0IEludFJlY3QmIHIsIGNvbnN0IEludFNpemUmIHRvcExlZnQsCiAgICAgY2Fpcm9fcmVz dG9yZShjcik7CiB9CiAKLXZvaWQgR3JhcGhpY3NDb250ZXh0OjpmaWxsUmVjdFdpdGhSb3VuZGVk SG9sZShjb25zdCBJbnRSZWN0JiByZWN0LCBjb25zdCBSb3VuZGVkUmVjdCYgcm91bmRlZEhvbGVS ZWN0LCBjb25zdCBDb2xvciYgY29sb3IsIENvbG9yU3BhY2UgY29sb3JTcGFjZSkKK3ZvaWQgR3Jh cGhpY3NDb250ZXh0OjpmaWxsUmVjdFdpdGhSb3VuZGVkSG9sZShjb25zdCBJbnRSZWN0JiByZWN0 LCBjb25zdCBSb3VuZGVkUmVjdCYgcm91bmRlZEhvbGVSZWN0LCBjb25zdCBDb2xvciYgY29sb3Is IENvbG9yU3BhY2UpCiB7CiAgICAgaWYgKHBhaW50aW5nRGlzYWJsZWQoKSB8fCAhY29sb3IuaXNW YWxpZCgpKQogICAgICAgICByZXR1cm47Cg==