120516 2013-08-30 01:56:24 -0700 Resolve unused parameter warning in FindController.cpp 2013-08-30 08:24:25 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 tczene webkit-unassigned commit-queue oldest_to_newest 922847 0 tczene 2013-08-30 01:56:24 -0700 Resolve unused parameter warning in FindController.cpp 922848 1 210079 tczene 2013-08-30 01:57:56 -0700 Created attachment 210079 proposed patch 922947 2 210079 darin 2013-08-30 08:00:12 -0700 Comment on attachment 210079 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=210079&action=review > Source/WebKit2/WebProcess/WebPage/FindController.cpp:397 > +void FindController::drawRect(PageOverlay* /*pageOverlay*/, GraphicsContext& graphicsContext, const IntRect& dirtyRect) Should remove the argument name entirely. There is no information conveyed by a commented-out name that repeats the type. 922965 3 210079 commit-queue 2013-08-30 08:24:22 -0700 Comment on attachment 210079 proposed patch Clearing flags on attachment: 210079 Committed r154883: <http://trac.webkit.org/changeset/154883> 922967 4 commit-queue 2013-08-30 08:24:25 -0700 All reviewed patches have been landed. Closing bug. 210079 2013-08-30 01:57:56 -0700 2013-08-30 08:24:22 -0700 proposed patch nyolcadik text/plain 1380 tczene ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlNDBjNTAzLi5mZDNlODUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTMtMDgtMzAgIFRhbWFzIEN6ZW5lICA8dGN6ZW5lQGluZi51LXN6ZWdlZC5odT4KKwor ICAgICAgICBSZXNvbHZlIHVudXNlZCBwYXJhbWV0ZXIgd2FybmluZyBpbiBGaW5kQ29udHJvbGxl ci5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy MDUxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog V2ViUHJvY2Vzcy9XZWJQYWdlL0ZpbmRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 RmluZENvbnRyb2xsZXI6OmRyYXdSZWN0KToKKwogMjAxMy0wOC0yOSAgU2FtIFdlaW5pZyAgPHNh bUB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBFTkFCTEUgZ2F1cmRzIGZvciBQcm9taXNlcwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0ZpbmRDb250cm9s bGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9GaW5kQ29udHJvbGxl ci5jcHAKaW5kZXggMWRiN2RkYS4uYWViOWUyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL0ZpbmRDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRmluZENvbnRyb2xsZXIuY3BwCkBAIC0zOTQsNyArMzk0LDcg QEAgc3RhdGljIGNvbnN0IGZsb2F0IG92ZXJsYXlCYWNrZ3JvdW5kR3JlZW4gPSAwLjE7CiBzdGF0 aWMgY29uc3QgZmxvYXQgb3ZlcmxheUJhY2tncm91bmRCbHVlID0gMC4xOwogc3RhdGljIGNvbnN0 IGZsb2F0IG92ZXJsYXlCYWNrZ3JvdW5kQWxwaGEgPSAwLjI1OwogCi12b2lkIEZpbmRDb250cm9s bGVyOjpkcmF3UmVjdChQYWdlT3ZlcmxheSogcGFnZU92ZXJsYXksIEdyYXBoaWNzQ29udGV4dCYg Z3JhcGhpY3NDb250ZXh0LCBjb25zdCBJbnRSZWN0JiBkaXJ0eVJlY3QpCit2b2lkIEZpbmRDb250 cm9sbGVyOjpkcmF3UmVjdChQYWdlT3ZlcmxheSogLypwYWdlT3ZlcmxheSovLCBHcmFwaGljc0Nv bnRleHQmIGdyYXBoaWNzQ29udGV4dCwgY29uc3QgSW50UmVjdCYgZGlydHlSZWN0KQogewogICAg IENvbG9yIG92ZXJsYXlCYWNrZ3JvdW5kQ29sb3Iob3ZlcmxheUJhY2tncm91bmRSZWQsIG92ZXJs YXlCYWNrZ3JvdW5kR3JlZW4sIG92ZXJsYXlCYWNrZ3JvdW5kQmx1ZSwgb3ZlcmxheUJhY2tncm91 bmRBbHBoYSk7CiAK