120501 2013-08-29 16:38:25 -0700 Avoid Node references from AXObjectCache from leaking 2013-09-04 08:44:06 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate, InRadar P2 Normal --- 1 rniwa rniwa cfleizach darin ggaren jcraig webkit-bug-importer oldest_to_newest 922734 0 rniwa 2013-08-29 16:38:25 -0700 Merge https://chromium.googlesource.com/chromium/blink/+/454f31497613b6d0fbcfb0df757254b64a177c06 A real world example of this would be selecting an <option> item inside frame by keyboard. The node will not be deref()-ed until the topDocument() is detached. The issue was that AccessibilityMenuListOption is created in childrenChanged() hook called when its RenderObject is being destroyed. This patch modifies AccessibilityMenuListPopup so it won't create AccessibilityMenuListOption if its element is already detached. 922735 1 webkit-bug-importer 2013-08-29 16:38:36 -0700 <rdar://problem/14874010> 922749 2 210051 rniwa 2013-08-29 17:08:20 -0700 Created attachment 210051 Fixes the bug 922752 3 210051 darin 2013-08-29 17:13:47 -0700 Comment on attachment 210051 Fixes the bug This seems OK, but I’m really surprised that attached() is the right check to make here. I guess the option elements don’t themselves have renderers? In most cases like this I think we’d check renderer() to see if it’s non-zero. 922759 4 rniwa 2013-08-29 17:25:30 -0700 +geoff It's sad that we can't test for the number of leaked documents in WebKit reliably but we can in Blink. 922760 5 rniwa 2013-08-29 17:26:03 -0700 Committed r154859: <http://trac.webkit.org/changeset/154859> 924449 6 ggaren 2013-09-04 08:44:06 -0700 > It's sad that we can't test for the number of leaked documents in WebKit reliably but we can in Blink. It's trivial to count the number of live documents. Not sure what you mean by this. 210051 2013-08-29 17:08:20 -0700 2013-08-29 17:13:47 -0700 Fixes the bug bug-120501-20130829170820.patch text/plain 3208 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDg1NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEzLTA4LTI5ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEF2b2lkIE5vZGUgcmVmZXJlbmNl cyBmcm9tIEFYT2JqZWN0Q2FjaGUgZnJvbSBsZWFraW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA1MDEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNZXJnZSBodHRwczovL2Nocm9taXVtLmdvb2dsZXNv dXJjZS5jb20vY2hyb21pdW0vYmxpbmsvKy80NTRmMzE0OTc2MTNiNmQwZmJjZmIwZGY3NTcyNTRi NjRhMTc3YzA2CisgICAgICAgIHdpdGhvdXQgYW55IHRlc3RzIHNpbmNlIHdlIGRvbid0IGhhdmUg dGhlIHNhbWUgaW5mcmFzdHJ1Y3R1cmUgdG8gZGV0ZWN0IGxlYWtzIGluIFdlYktpdC4KKworICAg ICAgICBBIHJlYWwgd29ybGQgZXhhbXBsZSBvZiB0aGlzIHdvdWxkIGJlIHNlbGVjdGluZyBhbiA8 b3B0aW9uPiBpdGVtIGluc2lkZSBmcmFtZSBieSBrZXlib2FyZC4gVGhlIG5vZGUgd2lsbCBub3Qg YmUgZGVyZWYoKS1lZCB1bnRpbCB0aGUgdG9wRG9jdW1lbnQoKSBpcyBkZXRhY2hlZC4gCisKKyAg ICAgICAgVGhlIGlzc3VlIHdhcyB0aGF0IEFjY2Vzc2liaWxpdHlNZW51TGlzdE9wdGlvbiBpcyBj cmVhdGVkIGluIGNoaWxkcmVuQ2hhbmdlZCgpCisgICAgICAgIGhvb2sgY2FsbGVkIHdoZW4gaXRz IFJlbmRlck9iamVjdCBpcyBiZWluZyBkZXN0cm95ZWQuIFRoaXMgcGF0Y2ggbW9kaWZpZXMgQWNj ZXNzaWJpbGl0eU1lbnVMaXN0UG9wdXAgc28gaXQgd29uJ3QgY3JlYXRlIEFjY2Vzc2liaWxpdHlN ZW51TGlzdE9wdGlvbiBpZiBpdHMKKyAgICAgICAgZWxlbWVudCBpcyBhbHJlYWR5IGRldGFjaGVk LgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TWVudUxpc3RQb3B1cC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5TWVudUxpc3RQb3B1cDo6bWVudUxp c3RPcHRpb25BY2Nlc3NpYmlsaXR5T2JqZWN0KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy TWVudUxpc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTWVudUxpc3Q6OmRpZFVwZGF0 ZUFjdGl2ZU9wdGlvbik6CisKIDIwMTMtMDgtMjkgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNo QGFwcGxlLmNvbT4KIAogICAgICAgICBBWDogQ3Jhc2ggd2hlbiBWb2ljZU92ZXIgcmVmZXJlbmNl IGEgVGV4dE1hcmtlciBmcm9tIGFuIGlmcmFtZSB0aGF0IGhhcyBiZWVuIHJlbW92ZWQKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU1lbnVMaXN0UG9wdXAu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJp bGl0eU1lbnVMaXN0UG9wdXAuY3BwCShyZXZpc2lvbiAxNTQ4NTMpCisrKyBTb3VyY2UvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlNZW51TGlzdFBvcHVwLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNzAsNyArNzAsNyBAQCBib29sIEFjY2Vzc2liaWxpdHlNZW51TGlzdFBvcHVwOjpj b21wdXRlCiAKIEFjY2Vzc2liaWxpdHlNZW51TGlzdE9wdGlvbiogQWNjZXNzaWJpbGl0eU1lbnVM aXN0UG9wdXA6Om1lbnVMaXN0T3B0aW9uQWNjZXNzaWJpbGl0eU9iamVjdChIVE1MRWxlbWVudCog ZWxlbWVudCkgY29uc3QKIHsKLSAgICBpZiAoIWVsZW1lbnQgfHwgIWlzSFRNTE9wdGlvbkVsZW1l bnQoZWxlbWVudCkpCisgICAgaWYgKCFlbGVtZW50IHx8ICFpc0hUTUxPcHRpb25FbGVtZW50KGVs ZW1lbnQpIHx8ICFlbGVtZW50LT5hdHRhY2hlZCgpKQogICAgICAgICByZXR1cm4gMDsKIAogICAg IEFjY2Vzc2liaWxpdHlPYmplY3QqIG9iamVjdCA9IGRvY3VtZW50KCktPmF4T2JqZWN0Q2FjaGUo KS0+Z2V0T3JDcmVhdGUoTWVudUxpc3RPcHRpb25Sb2xlKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJNZW51TGlzdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlck1lbnVMaXN0LmNwcAkocmV2aXNpb24gMTU0ODUzKQorKysgU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1lbnVMaXN0LmNwcAkod29ya2luZyBjb3B5KQpA QCAtMzkyLDEwICszOTIsMTIgQEAgdm9pZCBSZW5kZXJNZW51TGlzdDo6ZGlkVXBkYXRlQWN0aXZl T3B0aQogICAgIGlmIChsaXN0SW5kZXggPCAwIHx8IGxpc3RJbmRleCA+PSBzdGF0aWNfY2FzdDxp bnQ+KHNlbGVjdC0+bGlzdEl0ZW1zKCkuc2l6ZSgpKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAg QVNTRVJUKHNlbGVjdC0+bGlzdEl0ZW1zKClbbGlzdEluZGV4XSk7Ci0KLSAgICBpZiAoQWNjZXNz aWJpbGl0eU1lbnVMaXN0KiBtZW51TGlzdCA9IHN0YXRpY19jYXN0PEFjY2Vzc2liaWxpdHlNZW51 TGlzdCo+KGRvY3VtZW50KCkuYXhPYmplY3RDYWNoZSgpLT5nZXQodGhpcykpKQotICAgICAgICBt ZW51TGlzdC0+ZGlkVXBkYXRlQWN0aXZlT3B0aW9uKG9wdGlvbkluZGV4KTsKKyAgICBIVE1MRWxl bWVudCogbGlzdEl0ZW0gPSBzZWxlY3QtPmxpc3RJdGVtcygpW2xpc3RJbmRleF07CisgICAgQVNT RVJUKGxpc3RJdGVtKTsKKyAgICBpZiAobGlzdEl0ZW0tPmF0dGFjaGVkKCkpIHsKKyAgICAgICAg aWYgKEFjY2Vzc2liaWxpdHlNZW51TGlzdCogbWVudUxpc3QgPSBzdGF0aWNfY2FzdDxBY2Nlc3Np YmlsaXR5TWVudUxpc3QqPihkb2N1bWVudCgpLmF4T2JqZWN0Q2FjaGUoKS0+Z2V0KHRoaXMpKSkK KyAgICAgICAgICAgIG1lbnVMaXN0LT5kaWRVcGRhdGVBY3RpdmVPcHRpb24ob3B0aW9uSW5kZXgp OworICAgIH0KIH0KIAogU3RyaW5nIFJlbmRlck1lbnVMaXN0OjppdGVtVGV4dCh1bnNpZ25lZCBs aXN0SW5kZXgpIGNvbnN0Cg==