120491 2013-08-29 14:13:47 -0700 new-run-webkit-tests does not respect --no-sample-on-timeout switch 2013-08-29 17:09:18 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue dpranke glenn oldest_to_newest 922670 0 joepeck 2013-08-29 14:13:47 -0700 Sampling is still happening on tests that timeout even if the --no-sample-on-timeout switch is passed. shell> ./Tools/Scripts/run-webkit-tests --no-sample-on-timeout --time-out-ms=1000 test-that-times-out.html This is super frustrating, and makes running tests take a long time if the timeout. 922671 1 210031 joepeck 2013-08-29 14:14:37 -0700 Created attachment 210031 [PATCH] Proposed Fix 922750 2 210031 commit-queue 2013-08-29 17:09:16 -0700 Comment on attachment 210031 [PATCH] Proposed Fix Clearing flags on attachment: 210031 Committed r154857: <http://trac.webkit.org/changeset/154857> 922751 3 commit-queue 2013-08-29 17:09:18 -0700 All reviewed patches have been landed. Closing bug. 210031 2013-08-29 14:14:37 -0700 2013-08-29 17:09:16 -0700 [PATCH] Proposed Fix proposed-fix.patch text/plain 1200 joepeck ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxZTc4 MWY5Li4zYjlhNmYzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMDgtMjkgIEpvc2VwaCBQZWNvcmFybyAgPHBl Y29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBuZXctcnVuLXdlYmtpdC10ZXN0cyBkb2VzIG5v dCByZXNwZWN0IC0tbm8tc2FtcGxlLW9uLXRpbWVvdXQgc3dpdGNoCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA0OTEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9z ZXJ2ZXJfcHJvY2Vzcy5weToKKyAgICAgICAgKFNlcnZlclByb2Nlc3MuX2hhbmRsZV90aW1lb3V0 KToKKwogMjAxMy0wOC0yOSAgQWxiZXJ0byBHYXJjaWEgIDxiZXJ0b0BpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtHVEtdIFVwZGF0ZSBhcHQgZGVwZW5kZW5jeSBsaXN0CmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvc2VydmVyX3Byb2Nlc3MucHkgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3BvcnQvc2VydmVyX3Byb2Nlc3MucHkKaW5kZXggODE4NGQyNS4uNTZmOWZkOCAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3NlcnZlcl9wcm9jZXNzLnB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQpAQCAt MjEyLDcgKzIxMiw4IEBAIGNsYXNzIFNlcnZlclByb2Nlc3Mob2JqZWN0KToKIAogICAgIGRlZiBf aGFuZGxlX3RpbWVvdXQoc2VsZik6CiAgICAgICAgIHNlbGYudGltZWRfb3V0ID0gVHJ1ZQotICAg ICAgICBzZWxmLl9wb3J0LnNhbXBsZV9wcm9jZXNzKHNlbGYuX25hbWUsIHNlbGYuX3Byb2MucGlk KQorICAgICAgICBpZiBzZWxmLl9wb3J0LmdldF9vcHRpb24oInNhbXBsZV9vbl90aW1lb3V0Iik6 CisgICAgICAgICAgICBzZWxmLl9wb3J0LnNhbXBsZV9wcm9jZXNzKHNlbGYuX25hbWUsIHNlbGYu X3Byb2MucGlkKQogCiAgICAgZGVmIF9zcGxpdF9zdHJpbmdfYWZ0ZXJfaW5kZXgoc2VsZiwgc3Ry aW5nLCBpbmRleCk6CiAgICAgICAgIHJldHVybiBzdHJpbmdbOmluZGV4XSwgc3RyaW5nW2luZGV4 Ol0K