120490 2013-08-29 14:07:39 -0700 XMLSerializer-attribute-namespace-prefix-conflicts can't produce reliable results 2013-08-31 14:05:00 -0700 1 1 1 Unclassified WebKit XML 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino rwlbuis ap benjamin commit-queue darin rniwa oldest_to_newest 922668 0 dino 2013-08-29 14:07:39 -0700 The test fast/dom/XMLSerializer-attribute-namespace-prefix-conflicts.html creates some duplicated namespaces and serializes the output. Since the unique namespace prefixes are based on an incrementing number, the actual prefixes are not reliably identical across runs. The expected result can't simply be the text dump of a single run. I'm going to mark the test as [ PASS FAIL ] for now. 922669 1 dino 2013-08-29 14:11:40 -0700 TestExpectations updated in https://trac.webkit.org/r154842 922678 2 rwlbuis 2013-08-29 14:38:29 -0700 This seems to be a Debug only problem. Will have a look. 922782 3 rwlbuis 2013-08-29 19:27:42 -0700 (In reply to comment #2) > This seems to be a Debug only problem. Will have a look. I found a possible fix, will likely provide a patch tomorrow. 923232 4 dino 2013-08-30 16:28:44 -0700 I'm skipping the tests for now. Please unskip in the patch. Thanks! 923233 5 dino 2013-08-30 16:34:04 -0700 https://trac.webkit.org/r154918 923244 6 210178 rwlbuis 2013-08-30 19:27:05 -0700 Created attachment 210178 Patch 923246 7 rwlbuis 2013-08-30 19:31:55 -0700 I debugged this a bit. It seems fastMalloc can return identical pointers for strings with differing hash values in StringImpl::createUninitializedInternalNonEmpty(). Specifically what happens on the test is that NS1 is not found so it is written out. Then for the next element, NS2 is tried but it already exists in a ancestor element. Then NS3, NS4 etc. all seem to reuse the same internal StringImpl pointer (for already existing NS2) even though the strings are obviously different,. I wonder if I am using the API wrong or if this is a bug... 923247 8 210178 dino 2013-08-30 19:35:42 -0700 Comment on attachment 210178 Patch This looks fine to me. However, we should probably check if there is a bug in AtomicString. cc-ing Ben. 923255 9 210178 rniwa 2013-08-30 20:30:48 -0700 Comment on attachment 210178 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210178&action=review > Source/WebCore/ChangeLog:8 > + Avoid toAtomicString which sometimes returns the same internal AtomicStringImpl* for two different strings. That definitely sounds like a serious bug! 923256 10 rniwa 2013-08-30 20:32:57 -0700 (In reply to comment #7) > I debugged this a bit. It seems fastMalloc can return identical pointers for strings with differing hash values in StringImpl::createUninitializedInternalNonEmpty(). Specifically what happens on the test is that NS1 is not found so it is written out. Then for the next element, NS2 is tried but it already exists in a ancestor element. Then NS3, NS4 etc. all seem to reuse the same internal StringImpl pointer (for already existing NS2) even though the strings are obviously different,. I wonder if I am using the API wrong or if this is a bug... Maybe you're not retaining each AtomicString? 923294 11 darin 2013-08-31 08:16:11 -0700 (In reply to comment #10) > Maybe you're not retaining each AtomicString? Sounds likely. We can definitely get the same AtomicStringImpl twice if the first one is deallocated before the second one is allocated. 923295 12 210178 darin 2013-08-31 08:17:07 -0700 Comment on attachment 210178 Patch This patch is definitely wrong. It covers up a bug elsewhere. 923302 13 210194 rwlbuis 2013-08-31 09:16:47 -0700 Created attachment 210194 Patch 923348 14 210194 commit-queue 2013-08-31 14:04:57 -0700 Comment on attachment 210194 Patch Clearing flags on attachment: 210194 Committed r154932: <http://trac.webkit.org/changeset/154932> 923349 15 commit-queue 2013-08-31 14:05:00 -0700 All reviewed patches have been landed. Closing bug. 210178 2013-08-30 19:27:05 -0700 2013-08-31 09:16:42 -0700 Patch bug-120490-20130830222647.patch text/plain 3107 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0OTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGE0MmNjNDBmMjljZDFj YTAzMWY2NTA0MTI4ZTcwMDE0MDE2NjRiNy4uZTYzM2M4YTdjOGZjNTZmMmZjMjQ2Njk3MmMwNmNm ZmQyYjg4NjBjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA4LTMwICBSb2Ig QnVpcyAgPHJ3bGJ1aXNAd2Via2l0Lm9yZz4KKworICAgICAgICBYTUxTZXJpYWxpemVyLWF0dHJp YnV0ZS1uYW1lc3BhY2UtcHJlZml4LWNvbmZsaWN0cyBjYW4ndCBwcm9kdWNlIHJlbGlhYmxlIHJl c3VsdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy MDQ5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEF2 b2lkIHRvQXRvbWljU3RyaW5nIHdoaWNoIHNvbWV0aW1lcyByZXR1cm5zIHRoZSBzYW1lIGludGVy bmFsIEF0b21pY1N0cmluZ0ltcGwqIGZvciB0d28gZGlmZmVyZW50IHN0cmluZ3MuCisKKyAgICAg ICAgKiBlZGl0aW5nL01hcmt1cEFjY3VtdWxhdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1h cmt1cEFjY3VtdWxhdG9yOjpnZW5lcmF0ZVVuaXF1ZVByZWZpeCk6CisKIDIwMTMtMDgtMzAgIEJy ZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbmRvd3NdIEJ1 aWxkIGZpeCBhZnRlciByMTU0OTIxLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9NYXJrdXBBY2N1bXVsYXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL01hcmt1cEFj Y3VtdWxhdG9yLmNwcAppbmRleCA5ZGY1OTUyNDk3MzVmM2NlZGE3ZTA4NDJjY2ZjNjkzMDFmNzMw ZDBjLi44MDAxOWQ3ZDI1NzAzMmQ2MTYyNWQyODMxNjlkMGViNzJlNmFiZjcxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL01hcmt1cEFjY3VtdWxhdG9yLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9lZGl0aW5nL01hcmt1cEFjY3VtdWxhdG9yLmNwcApAQCAtNDg0LDcgKzQ4NCw3 IEBAIHZvaWQgTWFya3VwQWNjdW11bGF0b3I6OmdlbmVyYXRlVW5pcXVlUHJlZml4KFF1YWxpZmll ZE5hbWUmIHByZWZpeGVkTmFtZSwgY29uc3QKICAgICAgICAgYnVpbGRlci5jbGVhcigpOwogICAg ICAgICBidWlsZGVyLmFwcGVuZCgiTlMiKTsKICAgICAgICAgYnVpbGRlci5hcHBlbmROdW1iZXIo KyttX3ByZWZpeExldmVsKTsKLSAgICAgICAgY29uc3QgQXRvbWljU3RyaW5nJiBuYW1lID0gYnVp bGRlci50b0F0b21pY1N0cmluZygpOworICAgICAgICBjb25zdCBBdG9taWNTdHJpbmcmIG5hbWUg PSBidWlsZGVyLnRvU3RyaW5nKCk7CiAgICAgICAgIGlmICghbmFtZXNwYWNlcy5nZXQobmFtZS5p bXBsKCkpKSB7CiAgICAgICAgICAgICBwcmVmaXhlZE5hbWUuc2V0UHJlZml4KG5hbWUpOwogICAg ICAgICAgICAgcmV0dXJuOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDJlOWVmZGU0ZmZmMzU2NmFmMjZjZmIxYmZmMDEzMmJi NWI0Njk2MDcuLjcxMGRmYjMzZjdlY2U1MjBhN2M0NjIwYmQ0ODYxYzIzMDY2ZWQyMzAgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNCBAQAorMjAxMy0wOC0zMCAgUm9iIEJ1aXMgIDxyd2xidWlzQHdlYmtpdC5v cmc+CisKKyAgICAgICAgWE1MU2VyaWFsaXplci1hdHRyaWJ1dGUtbmFtZXNwYWNlLXByZWZpeC1j b25mbGljdHMgY2FuJ3QgcHJvZHVjZSByZWxpYWJsZSByZXN1bHRzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA0OTAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbnNraXAgdGhlc2UgcHJldmlvdXNseSBm YWlsaW5nIHRlc3RzLgorCisgICAgICAgICogVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxMy0wOC0z MCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBWaWRl byB3aXRoIG9iamVjdC1maXQ6IGNvdmVyIGNhbiBzcGlsbCBvdXRzaWRlIHRoZSBib3gKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9UZXN0RXhw ZWN0YXRpb25zCmluZGV4IGU2ZjA3N2U3ZTgyZDBlNDc4NTE3ODZhNDgzMDI2NjExZTRhMTlkYTEu LjVhNTA2Mjc3YjMwYzJmNWVhMjkzOTU1ZWQ5MzU0MzMwNDVlODNjZTggMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0 aW9ucwpAQCAtMzcsOSArMzcsMyBAQCB3ZWJraXQub3JnL2IvMTE5MDk0IGZhc3QvZm9ybXMvY29s b3IvaW5wdXQtY29sb3Itb25jaGFuZ2UtZXZlbnQuaHRtbCBbIENyYXNoIFBhcwogCiAjIFRoaXMg dGVzdCB3aWxsIHJ1biBzbG93bHkgaW4gZGVidWcgbW9kZSwgYnV0IGlzIHBsZW50eSBmYXN0IGlu IHJlbGVhc2UuCiBbIERlYnVnIF0gZmFzdC9qcy9yZWdyZXNzL2Vtc2NyaXB0ZW4tbWVtb3BzLmh0 bWwgWyBTa2lwIF0KLQotWyBEZWJ1ZyBdIHdlYmtpdC5vcmcvYi8xMjA0OTAgZmFzdC9kb20vWE1M U2VyaWFsaXplci1hdHRyaWJ1dGUtbmFtZXNwYWNlLXByZWZpeC1jb25mbGljdHMuaHRtbCBbIFNr aXAgXQotWyBEZWJ1ZyBdIHdlYmtpdC5vcmcvYi8xMjA0OTAgZmFzdC9kb20vWE1MU2VyaWFsaXpl ci1zYW1lLXByZWZpeC1kaWZmZXJlbnQtbmFtZXNwYWNlcy1jb25mbGljdC5odG1sIFsgU2tpcCBd Ci1bIERlYnVnIF0gd2Via2l0Lm9yZy9iLzEyMDQ5MCBmYXN0L2RvbS9YTUxTZXJpYWxpemVyLXNl dEF0dHJpYnV0ZU5TLW5hbWVzcGFjZS1uby1wcmVmaXguaHRtbCBbIFNraXAgXQotWyBEZWJ1ZyBd IHdlYmtpdC5vcmcvYi8xMjA0OTAgc3ZnL2N1c3RvbS94bGluay1wcmVmaXgtZ2VuZXJhdGlvbi1p bi1hdHRyaWJ1dGVzLmh0bWwgWyBTa2lwIF0KLQo= 210194 2013-08-31 09:16:47 -0700 2013-08-31 14:04:57 -0700 Patch bug-120490-20130831121629.patch text/plain 2827 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0OTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGE0MmNjNDBmMjljZDFj YTAzMWY2NTA0MTI4ZTcwMDE0MDE2NjRiNy4uOTE2NTMzNmJhYjllMjkyNjI0MDQ1NjBlYTkyMjcy ODZiYWRmN2FjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA4LTMxICBSb2Ig QnVpcyAgPHJ3bGJ1aXNAd2Via2l0Lm9yZz4KKworICAgICAgICBYTUxTZXJpYWxpemVyLWF0dHJp YnV0ZS1uYW1lc3BhY2UtcHJlZml4LWNvbmZsaWN0cyBjYW4ndCBwcm9kdWNlIHJlbGlhYmxlIHJl c3VsdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy MDQ5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJl dGFpbiB0aGUga2V5IG9mIHRoZSBuYW1lc3BhY2VzIG1hcCBieSB1c2luZyBBdG9taWNTdHJpbmcg YXMga2V5IGluc3RlYWQgb2YgQXRvbWljU3RyaW5nSW1wbCouCisKKyAgICAgICAgKiBlZGl0aW5n L01hcmt1cEFjY3VtdWxhdG9yLmg6CisKIDIwMTMtMDgtMzAgIEJyZW50IEZ1bGdoYW0gIDxiZnVs Z2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbmRvd3NdIEJ1aWxkIGZpeCBhZnRlciByMTU0 OTIxLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9NYXJrdXBBY2N1bXVsYXRv ci5oIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9NYXJrdXBBY2N1bXVsYXRvci5oCmluZGV4IGI4 NzI3NDA0ZWFlZmRiNzIyNDhjM2NjMGNhYjY4MDZlYmU4OTkzOGIuLjE0MjU1OWE0MjEyMzFiNWNh MDRkYTFiMTBlMzU3MDlhNTM3ZDE0OGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRp bmcvTWFya3VwQWNjdW11bGF0b3IuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL01hcmt1 cEFjY3VtdWxhdG9yLmgKQEAgLTM5LDcgKzM5LDcgQEAgY2xhc3MgRWxlbWVudDsKIGNsYXNzIE5v ZGU7CiBjbGFzcyBSYW5nZTsKIAotdHlwZWRlZiBIYXNoTWFwPEF0b21pY1N0cmluZ0ltcGwqLCBB dG9taWNTdHJpbmdJbXBsKj4gTmFtZXNwYWNlczsKK3R5cGVkZWYgSGFzaE1hcDxBdG9taWNTdHJp bmcsIEF0b21pY1N0cmluZ0ltcGwqPiBOYW1lc3BhY2VzOwogCiBlbnVtIEVudGl0eU1hc2sgewog ICAgIEVudGl0eUFtcCA9IDB4MDAwMSwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyZTllZmRlNGZmZjM1NjZhZjI2Y2ZiMWJm ZjAxMzJiYjViNDY5NjA3Li41MTYxMjFjMDU1YmFkOWRhY2Y5YTVmOTE0MDJkNWE4NzlkOTVmNTdh IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDgtMzEgIFJvYiBCdWlzICA8cndsYnVpc0B3 ZWJraXQub3JnPgorCisgICAgICAgIFhNTFNlcmlhbGl6ZXItYXR0cmlidXRlLW5hbWVzcGFjZS1w cmVmaXgtY29uZmxpY3RzIGNhbid0IHByb2R1Y2UgcmVsaWFibGUgcmVzdWx0cworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwNDkwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVW5za2lwIHRoZXNlIHByZXZp b3VzbHkgZmFpbGluZyB0ZXN0cy4KKworICAgICAgICAqIFRlc3RFeHBlY3RhdGlvbnM6CisKIDIw MTMtMDgtMzAgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAg ICAgVmlkZW8gd2l0aCBvYmplY3QtZml0OiBjb3ZlciBjYW4gc3BpbGwgb3V0c2lkZSB0aGUgYm94 CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMv VGVzdEV4cGVjdGF0aW9ucwppbmRleCBlNmYwNzdlN2U4MmQwZTQ3ODUxNzg2YTQ4MzAyNjYxMWU0 YTE5ZGExLi5hYWZhYWViMjFjYWVlYmU1OGFjNTI3N2I4MjFkMWU4NjE3MmYyMjNiIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL1Rlc3RF eHBlY3RhdGlvbnMKQEAgLTM4LDggKzM4LDMgQEAgd2Via2l0Lm9yZy9iLzExOTA5NCBmYXN0L2Zv cm1zL2NvbG9yL2lucHV0LWNvbG9yLW9uY2hhbmdlLWV2ZW50Lmh0bWwgWyBDcmFzaCBQYXMKICMg VGhpcyB0ZXN0IHdpbGwgcnVuIHNsb3dseSBpbiBkZWJ1ZyBtb2RlLCBidXQgaXMgcGxlbnR5IGZh c3QgaW4gcmVsZWFzZS4KIFsgRGVidWcgXSBmYXN0L2pzL3JlZ3Jlc3MvZW1zY3JpcHRlbi1tZW1v cHMuaHRtbCBbIFNraXAgXQogCi1bIERlYnVnIF0gd2Via2l0Lm9yZy9iLzEyMDQ5MCBmYXN0L2Rv bS9YTUxTZXJpYWxpemVyLWF0dHJpYnV0ZS1uYW1lc3BhY2UtcHJlZml4LWNvbmZsaWN0cy5odG1s IFsgU2tpcCBdCi1bIERlYnVnIF0gd2Via2l0Lm9yZy9iLzEyMDQ5MCBmYXN0L2RvbS9YTUxTZXJp YWxpemVyLXNhbWUtcHJlZml4LWRpZmZlcmVudC1uYW1lc3BhY2VzLWNvbmZsaWN0Lmh0bWwgWyBT a2lwIF0KLVsgRGVidWcgXSB3ZWJraXQub3JnL2IvMTIwNDkwIGZhc3QvZG9tL1hNTFNlcmlhbGl6 ZXItc2V0QXR0cmlidXRlTlMtbmFtZXNwYWNlLW5vLXByZWZpeC5odG1sIFsgU2tpcCBdCi1bIERl YnVnIF0gd2Via2l0Lm9yZy9iLzEyMDQ5MCBzdmcvY3VzdG9tL3hsaW5rLXByZWZpeC1nZW5lcmF0 aW9uLWluLWF0dHJpYnV0ZXMuaHRtbCBbIFNraXAgXQotCg==