120484 2013-08-29 12:32:48 -0700 Web Inspector: Alt-up and Alt-down don't work when cursor is in unit 2022-03-01 02:56:48 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar, Regression P2 Normal --- 1 timothy timothy graouts joepeck timothy webkit-bug-importer oldest_to_newest 922609 0 timothy 2013-08-29 12:32:48 -0700 Also Option-Up arrow in "translate3d" should not modify number to make" translate4d". <rdar://problem/13877085> 922611 1 210017 timothy 2013-08-29 12:37:21 -0700 Created attachment 210017 Patch 922708 2 210017 joepeck 2013-08-29 15:52:33 -0700 Comment on attachment 210017 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210017&action=review > Source/WebInspectorUI/UserInterface/CodeMirrorAdditions.js:387 > + var token = codeMirror.getTokenAt(position); > + if (token && token.type && /\bnumber\b/.test(token.type)) > + return token; It may be worth mentioning in a comment that CodeMirror outputs a single "number" token when CSS numbers are connected to units. It took me a while to figure out that "100px" is parsed as a single token in CodeMirror: Token: 'number' Position: '9' Stack: 'propertyValue' Current: '100px' 923103 3 timothy 2013-08-30 11:24:07 -0700 http://trac.webkit.org/changeset/154897 210017 2013-08-29 12:37:21 -0700 2022-03-01 02:56:48 -0800 Patch bug-120484-20130829123730.patch text/plain 4737 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0NzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAx M2JlZWM0ZjEzZWYwNTMyYWJmNzU4ODU1M2VkNWE2NjkwNTg3MmZiLi5mZWM0NjAxZTQwNWY3N2E4 Y2IwNWQ1ZGRlZmIyZmQ4MWVlYzkwNzNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxMy0wOC0yOSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgT25seSBtb2RpZnkgbnVtYmVycyBpZiB0aGV5IGFyZSBpZGVudGlmaWVk IGJ5IENvZGVNaXJyb3IgYXMgYSBudW1iZXIuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDQ4NAorCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8x Mzg3NzA4NT4gUkVHUkVTU0lPTjogQWx0LXVwIGFuZCBBbHQtZG93biBkb24ndCB3b3JrIHdoZW4g Y3Vyc29yIGlzIGluIHVuaXQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEzMDU4Njk3PiBQQVJJ VFk6IE9wdGlvbi1VcCBhcnJvdyBpbiAidHJhbnNsYXRlM2QiIHNob3VsZCBub3QgbW9kaWZ5IG51 bWJlciB0byBtYWtlIiB0cmFuc2xhdGU0ZCIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29kZU1pcnJvckFkZGl0aW9ucy5q czoKKyAgICAgICAgKENvZGVNaXJyb3IucHJvdG90eXBlLmFsdGVyTnVtYmVySW5SYW5nZSk6IENv cnJlY3RseSBwcmVzZXJ2ZSB0aGUgc2VsZWN0aW9uLCBldmVuIGlmIGl0IGRpZmZlcnMgZnJvbQor ICAgICAgICB0aGUgcmFuZ2UgcGFzc2VkIGluLgorICAgICAgICAoYWx0ZXJOdW1iZXIpOiBGaW5k IG51bWJlciB0b2tlbnMgYW5kIHBhc3MgdGhvc2UgdG8gYWx0ZXJOdW1iZXJJblJhbmdlLgorICAg ICAgICAoYWx0ZXJOdW1iZXIuZmluZE51bWJlclRva2VuKTogQWRkZWQuIEhlbHBlci4KKwogMjAx My0wOC0yNiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IFdlIHNob3VsZCByZWdlbmVyYXRlIEluc3BlY3RvckJhY2tlbmRDb21t YW5kcy5qcyBmb3IgTGVnYWN5IEluc3BlY3Rvci5qc29uIHZlcnNpb25zCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db2RlTWlycm9yQWRkaXRpb25zLmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29kZU1pcnJvckFkZGl0aW9u cy5qcwppbmRleCBkYjk1MDhjOTllMzYxZjYwZThkNzRkYjEzZWZhYTQyMjAxNTU2MDVhLi5lMzJl MjlkNWVhNzQ3OWU3ODdkMzlmMTNlYjdlMjZhMGFjNDdhYzYxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db2RlTWlycm9yQWRkaXRpb25zLmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvZGVNaXJyb3JBZGRpdGlvbnMu anMKQEAgLTI4MSwxMSArMjgxLDE3IEBACiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0pOwog Ci0gICAgQ29kZU1pcnJvci5kZWZpbmVFeHRlbnNpb24oImFsdGVyTnVtYmVySW5SYW5nZSIsIGZ1 bmN0aW9uKGFtb3VudCwgc3RhcnRQb3NpdGlvbiwgZW5kUG9zaXRpb24sIGFmZmVjdHNTZWxlY3Rp b24pIHsKKyAgICBDb2RlTWlycm9yLmRlZmluZUV4dGVuc2lvbigiYWx0ZXJOdW1iZXJJblJhbmdl IiwgZnVuY3Rpb24oYW1vdW50LCBzdGFydFBvc2l0aW9uLCBlbmRQb3NpdGlvbiwgdXBkYXRlU2Vs ZWN0aW9uKSB7CiAgICAgICAgIC8vIFdlIGRvbid0IHRyeSBpZiB0aGUgcmFuZ2UgaXMgbXVsdGls aW5lLCBwYXNzIHRvIGFub3RoZXIga2V5IGhhbmRsZXIuCiAgICAgICAgIGlmIChzdGFydFBvc2l0 aW9uLmxpbmUgIT09IGVuZFBvc2l0aW9uLmxpbmUpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7 CiAKKyAgICAgICAgaWYgKHVwZGF0ZVNlbGVjdGlvbikgeworICAgICAgICAgICAgLy8gUmVtZW1i ZXIgdGhlIGN1cnNvciBwb3NpdGlvbi9zZWxlY3Rpb24uCisgICAgICAgICAgICB2YXIgc2VsZWN0 aW9uU3RhcnQgPSB0aGlzLmdldEN1cnNvcigic3RhcnQiKTsKKyAgICAgICAgICAgIHZhciBzZWxl Y3Rpb25FbmQgPSB0aGlzLmdldEN1cnNvcigiZW5kIik7CisgICAgICAgIH0KKwogICAgICAgICB2 YXIgbGluZSA9IHRoaXMuZ2V0TGluZShzdGFydFBvc2l0aW9uLmxpbmUpOwogCiAgICAgICAgIHZh ciBmb3VuZFBlcmlvZCA9IGZhbHNlOwpAQCAtMzUzLDE3ICszNTksMjAgQEAKIAogICAgICAgICB0 aGlzLnJlcGxhY2VSYW5nZShhbHRlcmVkTnVtYmVyU3RyaW5nLCBmcm9tLCB0byk7CiAKLSAgICAg ICAgaWYgKGFmZmVjdHNTZWxlY3Rpb24pIHsKLSAgICAgICAgICAgIHZhciBuZXdUbyA9IHtsaW5l OiBzdGFydFBvc2l0aW9uLmxpbmUsIGNoOiBmcm9tLmNoICsgYWx0ZXJlZE51bWJlclN0cmluZy5s ZW5ndGh9OworICAgICAgICBpZiAodXBkYXRlU2VsZWN0aW9uKSB7CisgICAgICAgICAgICB2YXIg cHJldmlvdXNMZW5ndGggPSB0by5jaCAtIGZyb20uY2g7CisgICAgICAgICAgICB2YXIgbmV3TGVu Z3RoID0gYWx0ZXJlZE51bWJlclN0cmluZy5sZW5ndGg7CiAKICAgICAgICAgICAgIC8vIEZpeCB1 cCB0aGUgc2VsZWN0aW9uIHNvIGl0IGZvbGxvd3MgdGhlIGluY3JlYXNlIG9yIGRlY3JlYXNlIGlu IHRoZSByZXBsYWNlbWVudCBsZW5ndGguCi0gICAgICAgICAgICBpZiAoZW5kUG9zaXRpb24uY2gg Pj0gdG8uY2gpCi0gICAgICAgICAgICAgICAgZW5kUG9zaXRpb24gPSBuZXdUbzsKKyAgICAgICAg ICAgIGlmIChwcmV2aW91c0xlbmd0aCAhPSBuZXdMZW5ndGgpIHsKKyAgICAgICAgICAgICAgICBp ZiAoc2VsZWN0aW9uU3RhcnQubGluZSA9PT0gZnJvbS5saW5lICYmIHNlbGVjdGlvblN0YXJ0LmNo ID4gZnJvbS5jaCkKKyAgICAgICAgICAgICAgICAgICAgc2VsZWN0aW9uU3RhcnQuY2ggKz0gbmV3 TGVuZ3RoIC0gcHJldmlvdXNMZW5ndGg7CiAKLSAgICAgICAgICAgIGlmIChzdGFydFBvc2l0aW9u LmNoID49IHRvLmNoKQotICAgICAgICAgICAgICAgIHN0YXJ0UG9zaXRpb24gPSBuZXdUbzsKKyAg ICAgICAgICAgICAgICBpZiAoc2VsZWN0aW9uRW5kLmxpbmUgPT09IGZyb20ubGluZSAmJiBzZWxl Y3Rpb25FbmQuY2ggPiBmcm9tLmNoKQorICAgICAgICAgICAgICAgICAgICBzZWxlY3Rpb25FbmQu Y2ggKz0gbmV3TGVuZ3RoIC0gcHJldmlvdXNMZW5ndGg7CisgICAgICAgICAgICB9CiAKLSAgICAg ICAgICAgIHRoaXMuc2V0U2VsZWN0aW9uKHN0YXJ0UG9zaXRpb24sIGVuZFBvc2l0aW9uKTsKKyAg ICAgICAgICAgIHRoaXMuc2V0U2VsZWN0aW9uKHNlbGVjdGlvblN0YXJ0LCBzZWxlY3Rpb25FbmQp OwogICAgICAgICB9CiAKICAgICAgICAgcmV0dXJuIHRydWU7CkBAIC0zNzEsMTAgKzM4MCwyOCBA QAogCiAgICAgZnVuY3Rpb24gYWx0ZXJOdW1iZXIoYW1vdW50LCBjb2RlTWlycm9yKQogICAgIHsK LSAgICAgICAgdmFyIHN0YXJ0UG9zaXRpb24gPSBjb2RlTWlycm9yLmdldEN1cnNvcigiYW5jaG9y Iik7Ci0gICAgICAgIHZhciBlbmRQb3NpdGlvbiA9IGNvZGVNaXJyb3IuZ2V0Q3Vyc29yKCJoZWFk Iik7CisgICAgICAgIGZ1bmN0aW9uIGZpbmROdW1iZXJUb2tlbihwb3NpdGlvbikKKyAgICAgICAg eworICAgICAgICAgICAgdmFyIHRva2VuID0gY29kZU1pcnJvci5nZXRUb2tlbkF0KHBvc2l0aW9u KTsKKyAgICAgICAgICAgIGlmICh0b2tlbiAmJiB0b2tlbi50eXBlICYmIC9cYm51bWJlclxiLy50 ZXN0KHRva2VuLnR5cGUpKQorICAgICAgICAgICAgICAgIHJldHVybiB0b2tlbjsKKyAgICAgICAg ICAgIHJldHVybiBudWxsOworICAgICAgICB9CisKKyAgICAgICAgdmFyIHBvc2l0aW9uID0gY29k ZU1pcnJvci5nZXRDdXJzb3IoImhlYWQiKTsKKyAgICAgICAgdmFyIHRva2VuID0gZmluZE51bWJl clRva2VuKHBvc2l0aW9uKTsKKworICAgICAgICBpZiAoIXRva2VuKSB7CisgICAgICAgICAgICAv LyBJZiB0aGUgY3Vyc29yIGlzIGF0IHRoZSBvdXRzaWRlIGJlZ2lubmluZyBvZiB0aGUgdG9rZW4s IHRoZSBwcmV2aW91cworICAgICAgICAgICAgLy8gZmluZE51bWJlclRva2VuIHdvbnQgZmluZCBp dC4gU28gY2hlY2sgdGhlIG5leHQgY29sdW1uIGZvciBhIG51bWJlciB0b28uCisgICAgICAgICAg ICBwb3NpdGlvbi5jaCArPSAxOworICAgICAgICAgICAgdG9rZW4gPSBmaW5kTnVtYmVyVG9rZW4o cG9zaXRpb24pOworICAgICAgICB9CisKKyAgICAgICAgaWYgKCF0b2tlbikKKyAgICAgICAgICAg IHJldHVybiBDb2RlTWlycm9yLlBhc3M7CiAKLSAgICAgICAgdmFyIGZvdW5kTnVtYmVyID0gY29k ZU1pcnJvci5hbHRlck51bWJlckluUmFuZ2UoYW1vdW50LCBzdGFydFBvc2l0aW9uLCBlbmRQb3Np dGlvbiwgdHJ1ZSk7CisgICAgICAgIHZhciBmb3VuZE51bWJlciA9IGNvZGVNaXJyb3IuYWx0ZXJO dW1iZXJJblJhbmdlKGFtb3VudCwge2NoOiB0b2tlbi5zdGFydCwgbGluZTogcG9zaXRpb24ubGlu ZX0sIHtjaDogdG9rZW4uZW5kLCBsaW5lOiBwb3NpdGlvbi5saW5lfSwgdHJ1ZSk7CiAgICAgICAg IGlmICghZm91bmROdW1iZXIpCiAgICAgICAgICAgICByZXR1cm4gQ29kZU1pcnJvci5QYXNzOwog ICAgIH0K