120479 2013-08-29 10:41:34 -0700 Possible dangling CachedResourceClient of StyleRuleImport and XSLImportRule 2013-08-30 09:39:01 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 leoyang leoyang commit-queue esprehn+autocc glenn kling koivisto macpherson menard staikos oldest_to_newest 922546 0 leoyang 2013-08-29 10:41:34 -0700 In StyleRuleImport::requestStyleSheet() and XSLImportRule::loadSheet() we don't call removeClient() for m_cachedSheet before assign m_cachedSheet a new value. This could leave *this* as a client of the old cached sheet and dangling after *this* is deleted. 922556 1 210003 leoyang 2013-08-29 10:58:03 -0700 Created attachment 210003 Patch 922582 2 210003 darin 2013-08-29 11:58:01 -0700 Comment on attachment 210003 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210003&action=review Fix looks good, but needs a test or an explanation of why there is no test. > Source/WebCore/ChangeLog:14 > + No functionalities changed no new tests. This fixes a bug. It’s not right to say “no functionalities changed”. I am guessing you noticed the bug by code inspection. Once you knew the bug existed, did you try to make a test case? Why were you unable to do so? The comment here should address those questions, rather than incorrectly saying that nothing was changed. 922593 3 210003 leoyang 2013-08-29 12:07:41 -0700 Comment on attachment 210003 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210003&action=review >> Source/WebCore/ChangeLog:14 >> + No functionalities changed no new tests. > > This fixes a bug. It’s not right to say “no functionalities changed”. I am guessing you noticed the bug by code inspection. Once you knew the bug existed, did you try to make a test case? Why were you unable to do so? The comment here should address those questions, rather than incorrectly saying that nothing was changed. Yes I found the bug by code inspection. I tried to make a test case but I don't know how I can manipulate import rules by Javascript. Is there a way to do that or should I just say no way to test it automatically? 922925 4 210102 leoyang 2013-08-30 07:01:28 -0700 Created attachment 210102 Patch v2 922989 5 210102 darin 2013-08-30 09:16:01 -0700 Comment on attachment 210102 Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=210102&action=review > Source/WebCore/ChangeLog:14 > + Found by code inspection. Seems no way to test it automatically. I don’t think we should give up on figuring out what the actual symptom of this is. I suspect eventually we could come up with a way to test it. 923005 6 210102 commit-queue 2013-08-30 09:38:59 -0700 Comment on attachment 210102 Patch v2 Clearing flags on attachment: 210102 Committed r154889: <http://trac.webkit.org/changeset/154889> 923006 7 commit-queue 2013-08-30 09:39:01 -0700 All reviewed patches have been landed. Closing bug. 210003 2013-08-29 10:58:03 -0700 2013-08-30 07:01:28 -0700 Patch 0001-Possible-dangling-CachedResourceClient-of-StyleRuleI.patch text/plain 3491 leoyang RnJvbSA0NzNkYjJjZmQ1MmI1MTA5NmQ0OWNmNWQzYTEzMzE2YjJkNDg5OWFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVveWFuZ0BibGFja2JlcnJ5LmNvbT4KRGF0 ZTogVGh1LCAyOSBBdWcgMjAxMyAxMzo1NjoxNiAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFBvc3Np YmxlIGRhbmdsaW5nIENhY2hlZFJlc291cmNlQ2xpZW50IG9mIFN0eWxlUnVsZUltcG9ydCBhbmQK IFhTTEltcG9ydFJ1bGUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy MDQ3OQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpJbiBTdHlsZVJ1bGVJbXBvcnQ6OnJl cXVlc3RTdHlsZVNoZWV0KCkgYW5kIFhTTEltcG9ydFJ1bGU6OmxvYWRTaGVldCgpIHdlCmRpZG4n dCBjYWxsIHJlbW92ZUNsaWVudCgpIGZvciBtX2NhY2hlZFNoZWV0IGJlZm9yZSBhc3NpZ25pbmcg bV9jYWNoZWRTaGVldAphIG5ldyB2YWx1ZS4gVGhpcyBjb3VsZCBsZWF2ZSB0aGUgY2xpZW50IGFz IGEgY2xpZW50IG9mIHRoZSBvbGQgY2FjaGVkCnNoZWV0IGFuZCBkYW5nbGluZyBhZnRlciB0aGUg Y2xpZW50IGlzIGRlbGV0ZWQuIEZpeCB0aGVtIGJ5IGNhbGxpbmcgcmVtb3ZlQ2xpZW50KCkKYmVm b3JlIGFzc2lnbmluZyBtX2NhY2hlU2hlZXQgYSBuZXcgdmFsdWUuCgpObyBmdW5jdGlvbmFsaXRp ZXMgY2hhbmdlZCBubyBuZXcgdGVzdHMuCgoqIGNzcy9TdHlsZVJ1bGVJbXBvcnQuY3BwOgooV2Vi Q29yZTo6U3R5bGVSdWxlSW1wb3J0OjpyZXF1ZXN0U3R5bGVTaGVldCk6CiogeG1sL1hTTEltcG9y dFJ1bGUuY3BwOgooV2ViQ29yZTo6WFNMSW1wb3J0UnVsZTo6bG9hZFNoZWV0KToKCkNoYW5nZS1J ZDogSWJiZDYzOTZlNjE2YTc0OTU4MTRjM2VjNjY4NTY3MjQzMjZkNmNmMmUKLS0tCiBTb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICB8IDIwICsrKysrKysrKysrKysrKysrKysr CiBTb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSdWxlSW1wb3J0LmNwcCB8ICAyICsrCiBTb3VyY2Uv V2ViQ29yZS94bWwvWFNMSW1wb3J0UnVsZS5jcHAgICB8ICAyICsrCiAzIGZpbGVzIGNoYW5nZWQs IDI0IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmE1Y2VlNy4uMTBmMDVjNiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTA4LTI5ICBMZW8gWWFuZyAgPGxlb3lhbmdAYmxh Y2tiZXJyeS5jb20+CisKKyAgICAgICAgUG9zc2libGUgZGFuZ2xpbmcgQ2FjaGVkUmVzb3VyY2VD bGllbnQgb2YgU3R5bGVSdWxlSW1wb3J0IGFuZCBYU0xJbXBvcnRSdWxlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA0NzkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBTdHlsZVJ1bGVJbXBvcnQ6OnJl cXVlc3RTdHlsZVNoZWV0KCkgYW5kIFhTTEltcG9ydFJ1bGU6OmxvYWRTaGVldCgpIHdlCisgICAg ICAgIGRpZG4ndCBjYWxsIHJlbW92ZUNsaWVudCgpIGZvciBtX2NhY2hlZFNoZWV0IGJlZm9yZSBh c3NpZ25pbmcgbV9jYWNoZWRTaGVldAorICAgICAgICBhIG5ldyB2YWx1ZS4gVGhpcyBjb3VsZCBs ZWF2ZSB0aGUgY2xpZW50IGFzIGEgY2xpZW50IG9mIHRoZSBvbGQgY2FjaGVkCisgICAgICAgIHNo ZWV0IGFuZCBkYW5nbGluZyBhZnRlciB0aGUgY2xpZW50IGlzIGRlbGV0ZWQuIEZpeCB0aGVtIGJ5 IGNhbGxpbmcgcmVtb3ZlQ2xpZW50KCkKKyAgICAgICAgYmVmb3JlIGFzc2lnbmluZyBtX2NhY2hl U2hlZXQgYSBuZXcgdmFsdWUuCisKKyAgICAgICAgTm8gZnVuY3Rpb25hbGl0aWVzIGNoYW5nZWQg bm8gbmV3IHRlc3RzLgorCisgICAgICAgICogY3NzL1N0eWxlUnVsZUltcG9ydC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpTdHlsZVJ1bGVJbXBvcnQ6OnJlcXVlc3RTdHlsZVNoZWV0KToKKyAgICAg ICAgKiB4bWwvWFNMSW1wb3J0UnVsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpYU0xJbXBvcnRS dWxlOjpsb2FkU2hlZXQpOgorCiAyMDEzLTA4LTI5ICBBcm5hdWQgUmVuZXZpZXIgIDxhLnJlbmV2 aWVyQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtjYWlyb10gY2FudmFzIGRyYXdpbmcgb24gaXRz ZWxmIGRvZXNuJ3Qgd29yayB3aXRoIGFjY2VsZXJhdGVkIGNhbnZhcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvY3NzL1N0eWxlUnVsZUltcG9ydC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3Mv U3R5bGVSdWxlSW1wb3J0LmNwcAppbmRleCBhNTQxZWJkLi4wOTU2NjA5IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSdWxlSW1wb3J0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9jc3MvU3R5bGVSdWxlSW1wb3J0LmNwcApAQCAtMTE5LDYgKzExOSw4IEBAIHZvaWQgU3R5bGVS dWxlSW1wb3J0OjpyZXF1ZXN0U3R5bGVTaGVldCgpCiAKICAgICBDYWNoZWRSZXNvdXJjZVJlcXVl c3QgcmVxdWVzdChSZXNvdXJjZVJlcXVlc3QoYWJzVVJMKSwgbV9wYXJlbnRTdHlsZVNoZWV0LT5j aGFyc2V0KCkpOwogICAgIHJlcXVlc3Quc2V0SW5pdGlhdG9yKGNhY2hlZFJlc291cmNlUmVxdWVz dEluaXRpYXRvcnMoKS5jc3MpOworICAgIGlmIChtX2NhY2hlZFNoZWV0KQorICAgICAgICBtX2Nh Y2hlZFNoZWV0LT5yZW1vdmVDbGllbnQoJm1fc3R5bGVTaGVldENsaWVudCk7CiAgICAgaWYgKG1f cGFyZW50U3R5bGVTaGVldC0+aXNVc2VyU3R5bGVTaGVldCgpKQogICAgICAgICBtX2NhY2hlZFNo ZWV0ID0gY2FjaGVkUmVzb3VyY2VMb2FkZXItPnJlcXVlc3RVc2VyQ1NTU3R5bGVTaGVldChyZXF1 ZXN0KTsKICAgICBlbHNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvWFNMSW1wb3J0 UnVsZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS94bWwvWFNMSW1wb3J0UnVsZS5jcHAKaW5kZXggZTYy OTU5ZS4uNzg3ODQ2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUveG1sL1hTTEltcG9ydFJ1 bGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3htbC9YU0xJbXBvcnRSdWxlLmNwcApAQCAtMTAw LDYgKzEwMCw4IEBAIHZvaWQgWFNMSW1wb3J0UnVsZTo6bG9hZFNoZWV0KCkKICAgICB9CiAgICAg CiAgICAgQ2FjaGVkUmVzb3VyY2VSZXF1ZXN0IHJlcXVlc3QoUmVzb3VyY2VSZXF1ZXN0KGNhY2hl ZFJlc291cmNlTG9hZGVyLT5kb2N1bWVudCgpLT5jb21wbGV0ZVVSTChhYnNIcmVmKSkpOworICAg IGlmIChtX2NhY2hlZFNoZWV0KQorICAgICAgICBtX2NhY2hlZFNoZWV0LT5yZW1vdmVDbGllbnQo dGhpcyk7CiAgICAgbV9jYWNoZWRTaGVldCA9IGNhY2hlZFJlc291cmNlTG9hZGVyLT5yZXF1ZXN0 WFNMU3R5bGVTaGVldChyZXF1ZXN0KTsKICAgICAKICAgICBpZiAobV9jYWNoZWRTaGVldCkgewot LSAKMS44LjQucmMzCgo= 210102 2013-08-30 07:01:28 -0700 2013-08-30 09:38:59 -0700 Patch v2 0001-Possible-dangling-CachedResourceClient-of-StyleRuleI.patch text/plain 3539 leoyang RnJvbSAxNGNhMzA1MjMxZDI2ZGNmNWE1NDgzZGE4NWNmZjc2NTdmMzVmODhjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVveWFuZ0BibGFja2JlcnJ5LmNvbT4KRGF0 ZTogRnJpLCAzMCBBdWcgMjAxMyAxMDowMDowNiAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFBvc3Np YmxlIGRhbmdsaW5nIENhY2hlZFJlc291cmNlQ2xpZW50IG9mIFN0eWxlUnVsZUltcG9ydCBhbmQK IFhTTEltcG9ydFJ1bGUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy MDQ3OQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpJbiBTdHlsZVJ1bGVJbXBvcnQ6OnJl cXVlc3RTdHlsZVNoZWV0KCkgYW5kIFhTTEltcG9ydFJ1bGU6OmxvYWRTaGVldCgpIHdlCmRpZG4n dCBjYWxsIHJlbW92ZUNsaWVudCgpIGZvciBtX2NhY2hlZFNoZWV0IGJlZm9yZSBhc3NpZ25pbmcg bV9jYWNoZWRTaGVldAphIG5ldyB2YWx1ZS4gVGhpcyBjb3VsZCBsZWF2ZSB0aGUgY2xpZW50IGFz IGEgY2xpZW50IG9mIHRoZSBvbGQgY2FjaGVkCnNoZWV0IGFuZCBkYW5nbGluZyBhZnRlciB0aGUg Y2xpZW50IGlzIGRlbGV0ZWQuIEZpeCB0aGVtIGJ5IGNhbGxpbmcgcmVtb3ZlQ2xpZW50KCkKYmVm b3JlIGFzc2lnbmluZyBtX2NhY2hlU2hlZXQgYSBuZXcgdmFsdWUuCgpGb3VuZCBieSBjb2RlIGlu c3BlY3Rpb24uIFNlZW1zIG5vIHdheSB0byB0ZXN0IGl0IGF1dG9tYXRpY2FsbHkuCgoqIGNzcy9T dHlsZVJ1bGVJbXBvcnQuY3BwOgooV2ViQ29yZTo6U3R5bGVSdWxlSW1wb3J0OjpyZXF1ZXN0U3R5 bGVTaGVldCk6CiogeG1sL1hTTEltcG9ydFJ1bGUuY3BwOgooV2ViQ29yZTo6WFNMSW1wb3J0UnVs ZTo6bG9hZFNoZWV0KToKCkNoYW5nZS1JZDogSTE0N2ZmYjc0NzViZDE4NzQ0MTZmNDVlOTFkYTll MjNhYTQ0MzNjYTUKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICB8 IDIwICsrKysrKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSdWxlSW1w b3J0LmNwcCB8ICAyICsrCiBTb3VyY2UvV2ViQ29yZS94bWwvWFNMSW1wb3J0UnVsZS5jcHAgICB8 ICAyICsrCiAzIGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmE1Y2VlNy4uZTUwY2I4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTA4LTI5 ICBMZW8gWWFuZyAgPGxlb3lhbmdAYmxhY2tiZXJyeS5jb20+CisKKyAgICAgICAgUG9zc2libGUg ZGFuZ2xpbmcgQ2FjaGVkUmVzb3VyY2VDbGllbnQgb2YgU3R5bGVSdWxlSW1wb3J0IGFuZCBYU0xJ bXBvcnRSdWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjA0NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJbiBTdHlsZVJ1bGVJbXBvcnQ6OnJlcXVlc3RTdHlsZVNoZWV0KCkgYW5kIFhTTEltcG9ydFJ1 bGU6OmxvYWRTaGVldCgpIHdlCisgICAgICAgIGRpZG4ndCBjYWxsIHJlbW92ZUNsaWVudCgpIGZv ciBtX2NhY2hlZFNoZWV0IGJlZm9yZSBhc3NpZ25pbmcgbV9jYWNoZWRTaGVldAorICAgICAgICBh IG5ldyB2YWx1ZS4gVGhpcyBjb3VsZCBsZWF2ZSB0aGUgY2xpZW50IGFzIGEgY2xpZW50IG9mIHRo ZSBvbGQgY2FjaGVkCisgICAgICAgIHNoZWV0IGFuZCBkYW5nbGluZyBhZnRlciB0aGUgY2xpZW50 IGlzIGRlbGV0ZWQuIEZpeCB0aGVtIGJ5IGNhbGxpbmcgcmVtb3ZlQ2xpZW50KCkKKyAgICAgICAg YmVmb3JlIGFzc2lnbmluZyBtX2NhY2hlU2hlZXQgYSBuZXcgdmFsdWUuCisKKyAgICAgICAgRm91 bmQgYnkgY29kZSBpbnNwZWN0aW9uLiBTZWVtcyBubyB3YXkgdG8gdGVzdCBpdCBhdXRvbWF0aWNh bGx5LgorCisgICAgICAgICogY3NzL1N0eWxlUnVsZUltcG9ydC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpTdHlsZVJ1bGVJbXBvcnQ6OnJlcXVlc3RTdHlsZVNoZWV0KToKKyAgICAgICAgKiB4bWwv WFNMSW1wb3J0UnVsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpYU0xJbXBvcnRSdWxlOjpsb2Fk U2hlZXQpOgorCiAyMDEzLTA4LTI5ICBBcm5hdWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNhbXN1 bmcuY29tPgogCiAgICAgICAgIFtjYWlyb10gY2FudmFzIGRyYXdpbmcgb24gaXRzZWxmIGRvZXNu J3Qgd29yayB3aXRoIGFjY2VsZXJhdGVkIGNhbnZhcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvY3NzL1N0eWxlUnVsZUltcG9ydC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSdWxl SW1wb3J0LmNwcAppbmRleCBhNTQxZWJkLi4wOTU2NjA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvU3R5bGVSdWxlSW1wb3J0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5 bGVSdWxlSW1wb3J0LmNwcApAQCAtMTE5LDYgKzExOSw4IEBAIHZvaWQgU3R5bGVSdWxlSW1wb3J0 OjpyZXF1ZXN0U3R5bGVTaGVldCgpCiAKICAgICBDYWNoZWRSZXNvdXJjZVJlcXVlc3QgcmVxdWVz dChSZXNvdXJjZVJlcXVlc3QoYWJzVVJMKSwgbV9wYXJlbnRTdHlsZVNoZWV0LT5jaGFyc2V0KCkp OwogICAgIHJlcXVlc3Quc2V0SW5pdGlhdG9yKGNhY2hlZFJlc291cmNlUmVxdWVzdEluaXRpYXRv cnMoKS5jc3MpOworICAgIGlmIChtX2NhY2hlZFNoZWV0KQorICAgICAgICBtX2NhY2hlZFNoZWV0 LT5yZW1vdmVDbGllbnQoJm1fc3R5bGVTaGVldENsaWVudCk7CiAgICAgaWYgKG1fcGFyZW50U3R5 bGVTaGVldC0+aXNVc2VyU3R5bGVTaGVldCgpKQogICAgICAgICBtX2NhY2hlZFNoZWV0ID0gY2Fj aGVkUmVzb3VyY2VMb2FkZXItPnJlcXVlc3RVc2VyQ1NTU3R5bGVTaGVldChyZXF1ZXN0KTsKICAg ICBlbHNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvWFNMSW1wb3J0UnVsZS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS94bWwvWFNMSW1wb3J0UnVsZS5jcHAKaW5kZXggZTYyOTU5ZS4uNzg3 ODQ2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUveG1sL1hTTEltcG9ydFJ1bGUuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3htbC9YU0xJbXBvcnRSdWxlLmNwcApAQCAtMTAwLDYgKzEwMCw4 IEBAIHZvaWQgWFNMSW1wb3J0UnVsZTo6bG9hZFNoZWV0KCkKICAgICB9CiAgICAgCiAgICAgQ2Fj aGVkUmVzb3VyY2VSZXF1ZXN0IHJlcXVlc3QoUmVzb3VyY2VSZXF1ZXN0KGNhY2hlZFJlc291cmNl TG9hZGVyLT5kb2N1bWVudCgpLT5jb21wbGV0ZVVSTChhYnNIcmVmKSkpOworICAgIGlmIChtX2Nh Y2hlZFNoZWV0KQorICAgICAgICBtX2NhY2hlZFNoZWV0LT5yZW1vdmVDbGllbnQodGhpcyk7CiAg ICAgbV9jYWNoZWRTaGVldCA9IGNhY2hlZFJlc291cmNlTG9hZGVyLT5yZXF1ZXN0WFNMU3R5bGVT aGVldChyZXF1ZXN0KTsKICAgICAKICAgICBpZiAobV9jYWNoZWRTaGVldCkgewotLSAKMS44LjQu cmMzCgo=