120462 2013-08-29 04:36:20 -0700 Performance tester bots should report the number of failing tests 2013-09-11 11:29:38 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77037 1 abrhm rniwa commit-queue kadam lforschler ossy rniwa zarvai oldest_to_newest 922397 0 abrhm 2013-08-29 04:36:20 -0700 It would be easier to track Perf test results with this change. 927732 1 211299 abrhm 2013-09-11 05:18:35 -0700 Created attachment 211299 Proposed patch Proposed fix. 927748 2 211299 ossy 2013-09-11 06:41:40 -0700 Comment on attachment 211299 Proposed patch LGTM, r=me. 927750 3 ossy 2013-09-11 06:42:13 -0700 Lucas, could you restart the build.webkit.org after it landed please? 927758 4 211299 commit-queue 2013-09-11 07:06:29 -0700 Comment on attachment 211299 Proposed patch Clearing flags on attachment: 211299 Committed r155523: <http://trac.webkit.org/changeset/155523> 927759 5 commit-queue 2013-09-11 07:06:32 -0700 All reviewed patches have been landed. Closing bug. 927780 6 lforschler 2013-09-11 08:02:37 -0700 This patch breaks the buildbot, the indentation appears incorrect on line 674. I've udpated the master to r155522, and restarted it. Please land a fix and i'll restart again. 927850 7 ossy 2013-09-11 10:31:53 -0700 (In reply to comment #6) > This patch breaks the buildbot, the indentation appears incorrect on line 674. I've udpated the master to r155522, and restarted it. > > Please land a fix and i'll restart again. Ouch ... Sorry for the breakage. I landed the fix in http://trac.webkit.org/changeset/155538 The problem was that rniwa used 3 spaces for indentation in http://trac.webkit.org/changeset/105848 Additionaly there was a typo in the patch. @Gábor, please run mastercfg_unittest.py next time yout touch the master.cfg (I thought, you did it ... ) 927886 8 lforschler 2013-09-11 11:29:38 -0700 master restarted. Please watch out for any funky-ness. 211299 2013-09-11 05:18:35 -0700 2013-09-11 07:06:29 -0700 Proposed patch patch45.patch text/plain 1466 abrhm ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IDFlZDcyZjAuLmQxNzdjM2QgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcK KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZwpAQCAtNjcxLDYgKzY3MSwxNSBAQCBjbGFzcyBSdW5BbmRVcGxvYWRQZXJmVGVzdHMo c2hlbGwuVGVzdCk6CiAgICAgICAgc2VsZi5zZXRDb21tYW5kKHNlbGYuY29tbWFuZCkKICAgICAg ICByZXR1cm4gc2hlbGwuVGVzdC5zdGFydChzZWxmKQogCisgICAgZGVmIGdldFRleHQoc2VsZiwg Y21kLCByZXN1bHRzKToKKyAgICAgICAgcmV0dXJuIHNlbGYuZ2V0VGV4dDIoY21kLCByZXN1bHRz KQorCisgICAgZGVmIGdldFRleHQyKHNlbGYsIGNtZCwgcmVzdWx0cyk6CisgICAgICAgIGlmIHJl c3VsdHMgIT0gU1VDQ0VTUworICAgICAgICAgICAgcmV0dXJuIFsiJWQgcGVyZiB0ZXN0cyBmYWls ZWQiICUgY21kLnJjXQorCisgICAgICAgIHJldHVybiBbc2VsZi5uYW1lXQorCiAKIGNsYXNzIFJ1 bkFuZFVwbG9hZFBlcmZUZXN0c1dlYktpdDIoUnVuQW5kVXBsb2FkUGVyZlRlc3RzKToKICAgICBk ZWYgc3RhcnQoc2VsZik6CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFu Z2VMb2cKaW5kZXggNzg5N2U1My4uMjdlZWM3NCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9n CisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA5LTExICBHYWJv ciBBYnJhaGFtICA8YWJyaG1AaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFBlcmZvcm1hbmNl IHRlc3RlciBib3RzIHNob3VsZCByZXBvcnQgdGhlIG51bWJlciBvZiBmYWlsaW5nIHRlc3RzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA0NjIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmc6CisgICAgICAgIChS dW5BbmRVcGxvYWRQZXJmVGVzdHMuc3RhcnQuZ2V0VGV4dCk6CisgICAgICAgIChSdW5BbmRVcGxv YWRQZXJmVGVzdHMuc3RhcnQpOgorICAgICAgICAoUnVuQW5kVXBsb2FkUGVyZlRlc3RzKToKKyAg ICAgICAgKFJ1bkFuZFVwbG9hZFBlcmZUZXN0cy5zdGFydC5nZXRUZXh0Mik6CisKIDIwMTMtMDkt MTEgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0FU S10gQWRkcyBtYXBwaW5nIE1lbnVJdGVtUmFkaW9Sb2xlIHRvIEFUSwo=