120458 2013-08-29 02:04:41 -0700 [GTK][WTR] A ContextMenu open with eventSender.contextClick leaves next tests's mouse events not working 2025-02-24 06:48:33 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID Gtk, LayoutTestFailure P2 Normal --- 120401 1 spena spena andersca bugs-noreply cgarcia gustavo mrobinson sam oldest_to_newest 922372 0 spena 2013-08-29 02:04:41 -0700 When I was investigating bug #120401, I noticed that after editing/selection/empty-cell-right-click.html was run, next tests would stop passing. Once I removed it from the lists, the tests would behave correctly (their exact behaviour depending on whether the patch fixing the ClickCounter state was applied or not). I then debugged a bit more and found that when the ContextMenu is shown, it seems to swallow all next mouse events: that's the reason for all tests running after it being flaky. In order to confirm this, I added a call in WebPageProxy to hide the context menu with m_activeContextMenu->hideContextMenu() whenever a test finishes. Again, as in bug #120401, I'm not sure on the right approach for this, so I would appreciate comments :) 922373 1 spena 2013-08-29 02:05:57 -0700 For completeness, since I just said that I added the call but didn't mention what happened afterwards: hiding the context menu gets all mouse events processing again. 929711 2 211787 spena 2013-09-16 08:25:57 -0700 Created attachment 211787 Patch When resetting the WebView to a consistent state, hide the active context menu, if any. This patch depends on bug #120401 929716 3 211787 mrobinson 2013-09-16 08:31:57 -0700 Comment on attachment 211787 Patch Perhaps you could avoid private API by using gtk_menu_popdown? 929719 4 cgarcia 2013-09-16 08:34:27 -0700 Mac runs a nested main loop for context menus, I wonder how they finish that loop then. We should try to use the same solution that other ports if possible before trying our own thing 929734 5 spena 2013-09-16 08:54:35 -0700 Anders & Sam, I see you were working in: Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm, where WebContextMenuProxyMac::showContextMenu calls WKPopupContextMenu and later [m_popup.get() dismissPopUp]; In GTK, when creating events with the EventSenderProxy in WebKitTestRunner, our calls to contextClick show the context menu, and after that it remains open, swallowing further mouse events. This patch manually closes the popup menu, but as Carlos says in comment #4, we would like to know how you deal/dealt with this in the Mac port. Thanks! 1150881 6 211787 mcatanzaro 2015-12-22 06:52:37 -0800 Comment on attachment 211787 Patch I'm resetting the r? flag on this, since the patch is quite old. We have no flakiness expectations for this test, so I presume this problem has since been solved and the bug is obsolete? Is this still causing any test failures? 1150885 7 spena 2015-12-22 07:17:16 -0800 (In reply to comment #6) > Comment on attachment 211787 [details] > Patch > > I'm resetting the r? flag on this, since the patch is quite old. > > We have no flakiness expectations for this test, so I presume this problem > has since been solved and the bug is obsolete? Is this still causing any > test failures? Hi Michael, I have been quite disconnected from this lately, so I can't tell if this is still an issue. (To be honest, I thought I had cleared r? from all my bugs, I'm surprised this one still had it. Sorry about that) 2097361 8 spena 2025-02-24 06:48:33 -0800 This is no longer happening in https://commits.webkit.org/290939@main, and has probably been fixed for a long time. Closing 211787 2013-09-16 08:25:57 -0700 2015-12-22 06:52:37 -0800 Patch bug-120458-20130916162533.patch text/plain 3773 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1ODQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWY4MGI5MTk0ODAxNDhm NWQwNDI5ODNlN2MxMjUxMTkyZTEzZGNlZi4uNTcyMWRkYTYxMmJiNDg0NTNhMTUwYjQ5MGY2ZWEx NDI1MTM0MWFmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEzLTA5LTE2ICBTaW1v biBQZW5hICA8c2ltb24ucGVuYUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbR1RLXVtXVFJdIEEg Q29udGV4dE1lbnUgb3BlbiB3aXRoIGV2ZW50U2VuZGVyLmNvbnRleHRDbGljayBsZWF2ZXMgbmV4 dCB0ZXN0cydzIG1vdXNlIGV2ZW50cyBub3Qgd29ya2luZworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwNDU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR1RLJ3MgQ29udGV4dE1lbnUgZ3JhYnMgR2RrRXZl bnRzLCBzbyB3aGVuIHRoZSBFdmVudFNlbmRlclByb3h5CisgICAgICAgIGZha2VzIGEgQ29udGV4 dENsaWNrIGFuZCBvcGVucyB0aGUgQ29udGV4dE1lbnUsIGl0IHJlbWFpbnMgb3BlbiwKKyAgICAg ICAgc3dhbGxvd2luZyBmdXJ0aGVyIGV2ZW50cy4KKworICAgICAgICBGb3IgZXhhbXBsZSwgd2hl biBydW5uaW5nIHRoZSBMYXlvdXRUZXN0cywgdGVzdHMgbGlrZQorICAgICAgICBlZGl0aW5nL3Nl bGVjdGlvbi9lbXB0eS1jZWxsLXJpZ2h0LWNsaWNrLmh0bWwgb3BlbiB0aGUKKyAgICAgICAgQ29u dGV4dE1lbnUsIHNvIGFsbCB0ZXN0cyBydW5uaW5nIGFmdGVyd2FyZHMgdGhhdCByZWx5IG9uCisg ICAgICAgIE1vdXNlRXZlbnRzIHdpbGwgYmUgZmxha3kuCisKKyAgICAgICAgVGhpcyBwYXRjaCBh ZGRzIGEgbWV0aG9kIHRvIFdlYktpdFdlYlZpZXdCYXNlIHRvIGhpZGUgdGhlCisgICAgICAgIENv bnRleHRNZW51LCBjYWxsaW5nIGl0IHdoZW4gcmVzZXR0aW5nIHRoZSBXZWJWaWV3IHRvIGNvbnNp c3RlbnQKKyAgICAgICAgdmFsdWVzLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL2d0ay9X S1ZpZXcuY3BwOgorICAgICAgICAoV0tWaWV3UmVzZXRTdGF0ZVRvQ29uc2lzdGVudFZhbHVlcyk6 IGNhbGwKKyAgICAgICAgd2Via2l0V2ViVmlld0Jhc2VIaWRlQ29udGV4dE1lbnUgaW4KKyAgICAg ICAgV0tWaWV3UmVzZXRTdGF0ZVRvQ29uc2lzdGVudFZhbHVlcy4KKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3 QmFzZUhpZGVDb250ZXh0TWVudSk6IElmIHRoZXJlIGlzIGFuIGFjdGl2ZSBjb250ZXh0IG1lbnUs IGhpZGUgaXQuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2VQ cml2YXRlLmg6IERlY2xhcmUgdGhlCisgICAgICAgIHdlYmtpdFdlYlZpZXdCYXNlSGlkZUNvbnRl eHRNZW51IG1ldGhvZC4KKwogMjAxMy0wOC0yOCAgU2ltb24gUGVuYSAgPHNpbW9uLnBlbmFAc2Ft c3VuZy5jb20+CiAKICAgICAgICAgW0dUS11bV1RSXSBTZXZlcmFsIGVkaXRpbmcvc2VsZWN0aW9u IHRlc3RzIGFyZSBmbGFreSBhcyBDbGlja0NvdW50ZXIgaXMgbm90IHJlc2V0IGJldHdlZW4gdGVz dCBydW5zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvZ3RrL1dL Vmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvZ3RrL1dLVmlldy5jcHAK aW5kZXggNDg1ZDY1YzJlZWZlNjBiMGJhZmFkODcxZWQ5MjU4ZjhhM2U0M2E5Yy4uNDk1NDhmYmU1 NzZhYTI3YjMxZGQxMjA4ZjJhNWNlOTViMzZlM2IyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9DL2d0ay9XS1ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvQy9ndGsvV0tWaWV3LmNwcApAQCAtNTMsNCArNTMsNSBAQCB2b2lkIFdLVmll d1NldEZvY3VzKFdLVmlld1JlZiB2aWV3UmVmLCBib29sIGZvY3VzZWQpCiB2b2lkIFdLVmlld1Jl c2V0U3RhdGVUb0NvbnNpc3RlbnRWYWx1ZXMoV0tWaWV3UmVmIHZpZXdSZWYpCiB7CiAgICAgd2Vi a2l0V2ViVmlld0Jhc2VSZXNldENsaWNrQ291bnRlcih0b0ltcGwodmlld1JlZikpOworICAgIHdl YmtpdFdlYlZpZXdCYXNlSGlkZUNvbnRleHRNZW51KHRvSW1wbCh2aWV3UmVmKSk7CiB9CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFz ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFz ZS5jcHAKaW5kZXggMzllODM0ODE1MTIwYTc4NzJiMWZiZmQwM2I0M2YyZjEyYzgzMWYxZi4uYThm N2UxZWMwMTJhMDZjZGUyNmY0MjJjMzY2OTRkYzVjZGVlYzY5MyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcApAQCAt MTExNywzICsxMTE3LDkgQEAgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZVJlc2V0Q2xpY2tDb3VudGVy KFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJraXRXZWJWaWV3QmFzZSkKIHsKICAgICB3ZWJraXRXZWJW aWV3QmFzZS0+cHJpdi0+Y2xpY2tDb3VudGVyLnJlc2V0KCk7CiB9CisKK3ZvaWQgd2Via2l0V2Vi Vmlld0Jhc2VIaWRlQ29udGV4dE1lbnUoV2ViS2l0V2ViVmlld0Jhc2UqIHdlYmtpdFdlYlZpZXdC YXNlKQoreworICAgIGlmICh3ZWJraXRXZWJWaWV3QmFzZS0+cHJpdi0+YWN0aXZlQ29udGV4dE1l bnVQcm94eSkKKyAgICAgICAgd2Via2l0V2ViVmlld0Jhc2UtPnByaXYtPmFjdGl2ZUNvbnRleHRN ZW51UHJveHktPmhpZGVDb250ZXh0TWVudSgpOworfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlLmggYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUuaAppbmRl eCA2ZjU4OGMxOWRkYzIxMTcyMDgyYzZmZmY1YzkwOTBlNDEyMGRjZTcwLi40OWM5YzkxYmRhYTdi MDQ4NGJkMDU2M2JhMTU0MWE5MGIwNWZkZDc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUuaAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUuaApAQCAt NzEsNSArNzEsNiBAQCB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlQWRkQXV0aGVudGljYXRpb25EaWFs b2coV2ViS2l0V2ViVmlld0Jhc2UqLCBHdGtXaWRnZXQqIGF1dAogdm9pZCB3ZWJraXRXZWJWaWV3 QmFzZUNhbmNlbEF1dGhlbnRpY2F0aW9uRGlhbG9nKFdlYktpdFdlYlZpZXdCYXNlKik7CiB2b2lk IHdlYmtpdFdlYlZpZXdCYXNlQWRkV2ViSW5zcGVjdG9yKFdlYktpdFdlYlZpZXdCYXNlKiwgR3Rr V2lkZ2V0KiBpbnNwZWN0b3IpOwogdm9pZCB3ZWJraXRXZWJWaWV3QmFzZVJlc2V0Q2xpY2tDb3Vu dGVyKFdlYktpdFdlYlZpZXdCYXNlKik7Cit2b2lkIHdlYmtpdFdlYlZpZXdCYXNlSGlkZUNvbnRl eHRNZW51KFdlYktpdFdlYlZpZXdCYXNlKik7CiAKICNlbmRpZiAvLyBXZWJLaXRXZWJWaWV3QmFz ZVByaXZhdGVfaAo=