120438 2013-08-28 14:56:19 -0700 LayoutTests on Windows debug fails and exits early on dom/html/level2/html/AppletsCollection.html 2013-08-28 16:39:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 roger_fong bfulgham andersca bfulgham roger_fong thorton oldest_to_newest 922207 0 roger_fong 2013-08-28 14:56:19 -0700 Error message here: 13:48:43.089 2308 worker/2 dom/html/level2/html/AppletsCollection.html crashed, (stderr lines): 13:48:43.089 2308 ASSERTION FAILED: could not find localizable string The plug-in can�t be found in bundle 13:48:43.089 2308 result.get() != notFound 13:48:43.089 2308 ..\platform\win\LocalizedStringsWin.cpp(53) : WebCore::localizedString Regression at: http://trac.webkit.org/changeset/154764 922235 1 209929 bfulgham 2013-08-28 16:27:07 -0700 Created attachment 209929 Patch 922237 2 209929 thorton 2013-08-28 16:32:52 -0700 Comment on attachment 209929 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209929&action=review > Source/WebKit/win/ChangeLog:3 > + [Windows] LayoutTests on Windows dbug fails and exits early debug? > Source/WebKit/win/ChangeLog:9 > + escape non-ASCII characters so the byte stream is correct for localized Are smart quotes usually used in the UI on Windows? 922245 3 bfulgham 2013-08-28 16:37:02 -0700 There's a good write-up about why this problem happened here: http://cboard.cprogramming.com/cplusplus-programming/145590-non-english-characters-cout-2.html#post1086757 Basically, Visual Studio assumes any narrow-character arrays contain only local encoding (e.g., ASCII in this case). It takes anything that doesn't fall into that category and spits it out as '?'. When that happens, our localized string lookup fails and we get the assertion. I didn't notice this because I run my tests in Release mode. :-( 922246 4 bfulgham 2013-08-28 16:37:53 -0700 (In reply to comment #2) > (From update of attachment 209929 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=209929&action=review > > > Source/WebKit/win/ChangeLog:3 > > + [Windows] LayoutTests on Windows dbug fails and exits early > > debug? Drat! > > Source/WebKit/win/ChangeLog:9 > > + escape non-ASCII characters so the byte stream is correct for localized > > Are smart quotes usually used in the UI on Windows? It depends on the application. Here I want to just use the existing localized strings so that we can reuse any localized version of the WebKit strings file without having to retranslate it. 922248 5 bfulgham 2013-08-28 16:39:57 -0700 Committed r154790: <http://trac.webkit.org/changeset/154790> 209929 2013-08-28 16:27:07 -0700 2013-08-28 16:32:52 -0700 Patch bug-120438-20130828162725.patch text/plain 3548 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDc4NSkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA4LTI4 ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5kb3dz XSBMYXlvdXRUZXN0cyBvbiBXaW5kb3dzIGRidWcgZmFpbHMgYW5kIGV4aXRzIGVhcmx5CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA0MzgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBWaXN1YWwgU3R1ZGlv IG1pc2hhbmRsZXMgY2hhciogY29udGFpbmluZyB1dGY4LWNvbnRlbnQuIE11c3QgbWFudWFsbHkK KyAgICAgICAgZXNjYXBlIG5vbi1BU0NJSSBjaGFyYWN0ZXJzIHNvIHRoZSBieXRlIHN0cmVhbSBp cyBjb3JyZWN0IGZvciBsb2NhbGl6ZWQKKyAgICAgICAgc3RyaW5nIGxvb2t1cC4KKworICAgICAg ICAqIFdlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcDoKKyAgICAgICAgKFdl YkZyYW1lTG9hZGVyQ2xpZW50OjpjYW5ub3RTaG93VVJMRXJyb3IpOiBSZXBsYWNlIHVuaWNvZGUg YXBvc3Ryb3BoZQorICAgICAgICBjaGFyYWN0ZXIgd2l0aCB1dGY4LWJ5dGUgZXF1aXZhbGVudC4K KyAgICAgICAgKFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpjYW5ub3RTaG93TUlNRVR5cGVFcnJvcik6 IERpdHRvLgorICAgICAgICAoV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGlkRmFpbFRv U3RhcnRQbHVnaW4pOiBEaXR0by4KKwogMjAxMy0wOC0yOCAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxn aGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luZG93c10gUHJvdmlkZSB1c2VmdWwgZXJyb3Ig bWVzc2FnZXMgZm9yIFdlYktpdEVycm9yRG9tYWluIGVycm9ycwpJbmRleDogU291cmNlL1dlYktp dC93aW4vV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50 LmNwcAkocmV2aXNpb24gMTU0NzY0KQorKysgU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1cHBv cnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04ODAsNyArODgw LDcgQEAgUmVzb3VyY2VFcnJvciBXZWJGcmFtZUxvYWRlckNsaWVudDo6YmxvYwogCiBSZXNvdXJj ZUVycm9yIFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpjYW5ub3RTaG93VVJMRXJyb3IoY29uc3QgUmVz b3VyY2VSZXF1ZXN0JiByZXF1ZXN0KQogewotICAgIHJldHVybiBSZXNvdXJjZUVycm9yKFN0cmlu ZyhXZWJLaXRFcnJvckRvbWFpbiksIFdlYktpdEVycm9yQ2Fubm90U2hvd1VSTCwgcmVxdWVzdC51 cmwoKS5zdHJpbmcoKSwgV0VCX1VJX1NUUklORygiVGhlIFVSTCBjYW6SdCBiZSBzaG93biIsICJX ZWJLaXRFcnJvckNhbm5vdFNob3dVUkwgZGVzY3JpcHRpb24iKSk7CisgICAgcmV0dXJuIFJlc291 cmNlRXJyb3IoU3RyaW5nKFdlYktpdEVycm9yRG9tYWluKSwgV2ViS2l0RXJyb3JDYW5ub3RTaG93 VVJMLCByZXF1ZXN0LnVybCgpLnN0cmluZygpLCBXRUJfVUlfU1RSSU5HKCJUaGUgVVJMIGNhblx4 RTJceDgwXHg5OXQgYmUgc2hvd24iLCAiV2ViS2l0RXJyb3JDYW5ub3RTaG93VVJMIGRlc2NyaXB0 aW9uIikpOwogfQogCiBSZXNvdXJjZUVycm9yIFdlYkZyYW1lTG9hZGVyQ2xpZW50OjppbnRlcnJ1 cHRlZEZvclBvbGljeUNoYW5nZUVycm9yKGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCkK QEAgLTg5MCw3ICs4OTAsNyBAQCBSZXNvdXJjZUVycm9yIFdlYkZyYW1lTG9hZGVyQ2xpZW50Ojpp bnRlCiAKIFJlc291cmNlRXJyb3IgV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmNhbm5vdFNob3dNSU1F VHlwZUVycm9yKGNvbnN0IFJlc291cmNlUmVzcG9uc2UmIHJlc3BvbnNlKQogewotICAgIHJldHVy biBSZXNvdXJjZUVycm9yKFN0cmluZygpLCBXZWJLaXRFcnJvckNhbm5vdFNob3dNSU1FVHlwZSwg cmVzcG9uc2UudXJsKCkuc3RyaW5nKCksIFdFQl9VSV9TVFJJTkcoIkNvbnRlbnQgd2l0aCBzcGVj aWZpZWQgTUlNRSB0eXBlIGNhbpJ0IGJlIHNob3duIiwgIldlYktpdEVycm9yQ2Fubm90U2hvd01J TUVUeXBlIGRlc2NyaXB0aW9uIikpOworICAgIHJldHVybiBSZXNvdXJjZUVycm9yKFN0cmluZygp LCBXZWJLaXRFcnJvckNhbm5vdFNob3dNSU1FVHlwZSwgcmVzcG9uc2UudXJsKCkuc3RyaW5nKCks IFdFQl9VSV9TVFJJTkcoIkNvbnRlbnQgd2l0aCBzcGVjaWZpZWQgTUlNRSB0eXBlIGNhblx4RTJc eDgwXHg5OXQgYmUgc2hvd24iLCAiV2ViS2l0RXJyb3JDYW5ub3RTaG93TUlNRVR5cGUgZGVzY3Jp cHRpb24iKSk7CiB9CiAKIFJlc291cmNlRXJyb3IgV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmZpbGVE b2VzTm90RXhpc3RFcnJvcihjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25zZSkKQEAgLTEx NDQsMTEgKzExNDQsMTEgQEAgdm9pZCBXZWJGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hEaWRG YQogICAgIHN3aXRjaCAocGx1Z2luVmlldy0+c3RhdHVzKCkpIHsKICAgICAgICAgY2FzZSBQbHVn aW5TdGF0dXNDYW5Ob3RGaW5kUGx1Z2luOgogICAgICAgICAgICAgZXJyb3JDb2RlID0gV2ViS2l0 RXJyb3JDYW5ub3RGaW5kUGx1Z0luOwotICAgICAgICAgICAgZGVzY3JpcHRpb24gPSBXRUJfVUlf U1RSSU5HKCJUaGUgcGx1Zy1pbiBjYW6SdCBiZSBmb3VuZCIsICJXZWJLaXRFcnJvckNhbm5vdEZp bmRQbHVnaW4gZGVzY3JpcHRpb24iKTsKKyAgICAgICAgICAgIGRlc2NyaXB0aW9uID0gV0VCX1VJ X1NUUklORygiVGhlIHBsdWctaW4gY2FuXHhFMlx4ODBceDk5dCBiZSBmb3VuZCIsICJXZWJLaXRF cnJvckNhbm5vdEZpbmRQbHVnaW4gZGVzY3JpcHRpb24iKTsKICAgICAgICAgICAgIGJyZWFrOwog ICAgICAgICBjYXNlIFBsdWdpblN0YXR1c0Nhbk5vdExvYWRQbHVnaW46CiAgICAgICAgICAgICBl cnJvckNvZGUgPSBXZWJLaXRFcnJvckNhbm5vdExvYWRQbHVnSW47Ci0gICAgICAgICAgICBkZXNj cmlwdGlvbiA9IFdFQl9VSV9TVFJJTkcoIlRoZSBwbHVnLWluIGNhbpJ0IGJlIGxvYWRlZCIsICJX ZWJLaXRFcnJvckNhbm5vdExvYWRQbHVnaW4gZGVzY3JpcHRpb24iKTsKKyAgICAgICAgICAgIGRl c2NyaXB0aW9uID0gV0VCX1VJX1NUUklORygiVGhlIHBsdWctaW4gY2FuXHhFMlx4ODBceDk5dCBi ZSBsb2FkZWQiLCAiV2ViS2l0RXJyb3JDYW5ub3RMb2FkUGx1Z2luIGRlc2NyaXB0aW9uIik7CiAg ICAgICAgICAgICBicmVhazsKICAgICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgIEFTU0VSVF9O T1RfUkVBQ0hFRCgpOwo=