120435 2013-08-28 12:26:00 -0700 Decrease number of workers used in NRWT by the Windows port 2013-08-28 13:33:43 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 roger_fong roger_fong bfulgham commit-queue dpranke glenn roger_fong oldest_to_newest 922150 0 roger_fong 2013-08-28 12:26:00 -0700 Right now we're maxing out the number of workers. This tends to cause various issues such as test results being off by 1, flakiness, and occasional timeouts. Maxing out the number of threads might actually in some cases slow down the test cases rather than speed them up. Decreasing the number of workers to half the available cores (just to be on the safe side). 922166 1 209918 roger_fong 2013-08-28 13:19:57 -0700 Created attachment 209918 Patch 922173 2 209918 bfulgham 2013-08-28 13:28:38 -0700 Comment on attachment 209918 Patch Yes! r=me. 922174 3 roger_fong 2013-08-28 13:33:43 -0700 Awesome thanks, hopefully we'll start seeing some more stability in the bots now. Committed: https://trac.webkit.org/r154776 209918 2013-08-28 13:19:57 -0700 2013-08-28 13:28:37 -0700 Patch bug-120435-20130828131956.patch text/plain 1171 roger_fong SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1NDc2NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEzLTA4LTI4ICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+ CisKKyAgICAgICAgRGVjcmVhc2UgbnVtYmVyIG9mIHdvcmtlcnMgdXNlZCBpbiBOUldUIGJ5IHRo ZSBXaW5kb3dzIHBvcnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjA0MzUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5OgorICAgICAgICAoV2luUG9y dC5kZWZhdWx0X2NoaWxkX3Byb2Nlc3Nlcyk6CisKIDIwMTMtMDgtMjggIEFsbGFuIFNhbmRmZWxk IEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CiAKICAgICAgICAgSHR0cCB0ZXN0cyBm YWlscyBvbiBEZWJpYW4gd2l0aCBBcGFjaGUgMi40CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtp dHB5L3BvcnQvd2luLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9y dC93aW4ucHkJKHJldmlzaW9uIDE1NDcwNCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9y dC93aW4ucHkJKHdvcmtpbmcgY29weSkKQEAgLTg5LDYgKzg5LDkgQEAgY2xhc3MgV2luUG9ydChB cHBsZVBvcnQpOgogICAgIGRlZiBvcGVyYXRpbmdfc3lzdGVtKHNlbGYpOgogICAgICAgICByZXR1 cm4gJ3dpbicKIAorICAgIGRlZiBkZWZhdWx0X2NoaWxkX3Byb2Nlc3NlcyhzZWxmKToKKyAgICAg ICAgcmV0dXJuIHNlbGYuX2V4ZWN1dGl2ZS5jcHVfY291bnQoKSAvIDIKKwogICAgIGRlZiBzaG93 X3Jlc3VsdHNfaHRtbF9maWxlKHNlbGYsIHJlc3VsdHNfZmlsZW5hbWUpOgogICAgICAgICBzZWxm Ll9ydW5fc2NyaXB0KCdydW4tc2FmYXJpJywgW2Fic3BhdGhfdG9fdXJpKFN5c3RlbUhvc3QoKS5w bGF0Zm9ybSwgcmVzdWx0c19maWxlbmFtZSldKQogCg==