120432 2013-08-28 11:39:22 -0700 REGRESSION(r154586): Past names map should only be used when named item is empty 2013-08-28 11:58:50 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 120277 120328 1 rniwa rniwa andersca darin kling koivisto sam oldest_to_newest 922130 0 rniwa 2013-08-28 11:39:22 -0700 When we found any form associated element or associated image elements for a given name, we should not be using the past names map. i.e. the past names map should only be used if there are not elements matching the name. This accidentally regressed in http://trac.webkit.org/changeset/154586 because the old code behaved correctly when getNamedElements were called in pairs. 922136 1 209913 rniwa 2013-08-28 11:56:13 -0700 Created attachment 209913 Fixes the bug 922137 2 209913 andersca 2013-08-28 11:57:23 -0700 Comment on attachment 209913 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=209913&action=review > Source/WebCore/html/HTMLFormElement.cpp:684 > + else if (elementFromPast && !namedItems.size()) Please use namedItems.isEmpty() instead. 922138 3 rniwa 2013-08-28 11:58:50 -0700 Committed r154765: <http://trac.webkit.org/changeset/154765> 209913 2013-08-28 11:56:13 -0700 2013-08-28 11:57:23 -0700 Fixes the bug bug-120432-20130828115612.patch text/plain 4376 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDc2NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA4LTI4ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE1NDU4Nik6 IFBhc3QgbmFtZXMgbWFwIHNob3VsZCBvbmx5IGJlIHVzZWQgd2hlbiBuYW1lZCBpdGVtIGlzIGVt cHR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA0 MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb24n dCBhZGQgdGhlIGVsZW1lbnQgZnJvbSB0aGUgcGFzdCBuYW1lcyBtYXAgaWYgd2UndmUgZm91bmQg ZWxlbWVudHMgb2YgdGhlIGdpdmVuIG5hbWUuCisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy9w YXN0LW5hbWVzLW1hcC1zaG91bGQtYmUtdXNlZC1vbmx5LXdoZW4tbmFtZWQtaXRlbS1pcy1lbXB0 eS5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxGb3JtRWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpIVE1MRm9ybUVsZW1lbnQ6OmdldE5hbWVkRWxlbWVudHMpOgorCiAyMDEzLTA4LTI3 ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIERvbid0IGtlZXAg dW5hc3NvY2lhdGVkIGVsZW1lbnRzIGluIHRoZSBwYXN0IG5hbWVzIG1hcApJbmRleDogU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcAkocmV2aXNpb24gMTU0NzYxKQorKysgU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02 NzgsMTEgKzY3OCwxMCBAQCB2b2lkIEhUTUxGb3JtRWxlbWVudDo6Z2V0TmFtZWRFbGVtZW50cyhj CiAgICAgLy8gaHR0cDovL3d3dy53aGF0d2cub3JnL3NwZWNzL3dlYi1hcHBzL2N1cnJlbnQtd29y ay9tdWx0aXBhZ2UvZm9ybXMuaHRtbCNkb20tZm9ybS1uYW1lZGl0ZW0KICAgICBlbGVtZW50cygp LT5uYW1lZEl0ZW1zKG5hbWUsIG5hbWVkSXRlbXMpOwogCi0gICAgLy8gRklYTUU6IFRoZSBzcGVj aWZpY2F0aW9uIHNheXMgd2Ugc2hvdWxkIG5vdCBhZGQgdGhlIGVsZW1lbnQgZnJvbSB0aGUgcGFz dCB3aGVuIG5hbWVzIG1hcCB3aGVuIG5hbWVkSXRlbXMgaXMgbm90IGVtcHR5LgogICAgIEhUTUxF bGVtZW50KiBlbGVtZW50RnJvbVBhc3QgPSBlbGVtZW50RnJvbVBhc3ROYW1lc01hcChuYW1lKTsK ICAgICBpZiAobmFtZWRJdGVtcy5zaXplKCkgPT0gMSAmJiBuYW1lZEl0ZW1zLmZpcnN0KCkgIT0g ZWxlbWVudEZyb21QYXN0KQogICAgICAgICBhZGRUb1Bhc3ROYW1lc01hcCh0b0hUTUxFbGVtZW50 KG5hbWVkSXRlbXMuZmlyc3QoKS5nZXQoKSktPmFzRm9ybU5hbWVkSXRlbSgpLCBuYW1lKTsKLSAg ICBlbHNlIGlmIChlbGVtZW50RnJvbVBhc3QgJiYgbmFtZWRJdGVtcy5maW5kKGVsZW1lbnRGcm9t UGFzdCkgPT0gbm90Rm91bmQpCisgICAgZWxzZSBpZiAoZWxlbWVudEZyb21QYXN0ICYmICFuYW1l ZEl0ZW1zLnNpemUoKSkKICAgICAgICAgbmFtZWRJdGVtcy5hcHBlbmQoZWxlbWVudEZyb21QYXN0 KTsKIH0KIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTU0NzY0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDgtMjggIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTU0NTg2KTog UGFzdCBuYW1lcyBtYXAgc2hvdWxkIG9ubHkgYmUgdXNlZCB3aGVuIG5hbWVkIGl0ZW0gaXMgZW1w dHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDQz MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBh IHJlZ3Jlc3Npb24gdGVzdCBzbyB0aGF0IHdlIG5ldmVyIHJlZ3Jlc3MgYWdhaW4uCisKKyAgICAg ICAgKiBmYXN0L2Zvcm1zL3Bhc3QtbmFtZXMtbWFwLXNob3VsZC1iZS11c2VkLW9ubHktd2hlbi1u YW1lZC1pdGVtLWlzLWVtcHR5LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9m b3Jtcy9wYXN0LW5hbWVzLW1hcC1zaG91bGQtYmUtdXNlZC1vbmx5LXdoZW4tbmFtZWQtaXRlbS1p cy1lbXB0eS5odG1sOiBBZGRlZC4KKwogMjAxMy0wOC0yOCAgUnlvc3VrZSBOaXdhICA8cm5pd2FA d2Via2l0Lm9yZz4KIAogICAgICAgICBGaXggYSB0eXBvIGluIHRoZSB0ZXN0IG5hbWUuCkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Bhc3QtbmFtZXMtbWFwLXNob3VsZC1iZS11c2VkLW9u bHktd2hlbi1uYW1lZC1pdGVtLWlzLWVtcHR5LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Bhc3QtbmFtZXMtbWFwLXNob3VsZC1iZS11c2VkLW9ubHkt d2hlbi1uYW1lZC1pdGVtLWlzLWVtcHR5LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExh eW91dFRlc3RzL2Zhc3QvZm9ybXMvcGFzdC1uYW1lcy1tYXAtc2hvdWxkLWJlLXVzZWQtb25seS13 aGVuLW5hbWVkLWl0ZW0taXMtZW1wdHktZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0w LDAgKzEsOCBAQAorUEFTUyBmb3JtWydmb28nXSBpcyBmb3JtLmNoaWxkTm9kZXNbMF0KK1BBU1Mg Zm9ybVsnYmFyJ11bMF0gaXMgZm9ybS5jaGlsZE5vZGVzWzFdCitQQVNTIGZvcm1bJ2JhciddWzFd IGlzIGZvcm0uY2hpbGROb2Rlc1syXQorUEFTUyBmb3JtLmNoaWxkTm9kZXNbMF0ubmFtZSA9ICdi YXInOyBmb3JtLmNoaWxkTm9kZXNbMV0ubmFtZSA9IGZvcm0uY2hpbGROb2Rlc1syXS5uYW1lID0g J2Zvbyc7IGZvcm1bJ2ZvbyddLmxlbmd0aCBpcyAyCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBp cyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9w YXN0LW5hbWVzLW1hcC1zaG91bGQtYmUtdXNlZC1vbmx5LXdoZW4tbmFtZWQtaXRlbS1pcy1lbXB0 eS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvcGFzdC1uYW1lcy1t YXAtc2hvdWxkLWJlLXVzZWQtb25seS13aGVuLW5hbWVkLWl0ZW0taXMtZW1wdHkuaHRtbAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvcGFzdC1uYW1lcy1tYXAtc2hvdWxk LWJlLXVzZWQtb25seS13aGVuLW5hbWVkLWl0ZW0taXMtZW1wdHkuaHRtbAkod29ya2luZyBjb3B5 KQpAQCAtMCwwICsxLDE5IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8Zm9y bT48aW5wdXQgdHlwZT0idGV4dCIgbmFtZT0iZm9vIj48aW5wdXQgdHlwZT0idGV4dCIgbmFtZT0i YmFyIj48aW5wdXQgdHlwZT0idGV4dCIgbmFtZT0iYmFyIj48L2Zvcm0+Cis8c2NyaXB0IHNyYz0i Li4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CisKK3Zh ciBmb3JtID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcignZm9ybScpOworc2hvdWxkQmUoImZvcm1b J2ZvbyddIiwgImZvcm0uY2hpbGROb2Rlc1swXSIpOworc2hvdWxkQmUoImZvcm1bJ2JhciddWzBd IiwgImZvcm0uY2hpbGROb2Rlc1sxXSIpOworc2hvdWxkQmUoImZvcm1bJ2JhciddWzFdIiwgImZv cm0uY2hpbGROb2Rlc1syXSIpOworc2hvdWxkQmUoImZvcm0uY2hpbGROb2Rlc1swXS5uYW1lID0g J2Jhcic7IGZvcm0uY2hpbGROb2Rlc1sxXS5uYW1lID0gZm9ybS5jaGlsZE5vZGVzWzJdLm5hbWUg PSAnZm9vJzsgZm9ybVsnZm9vJ10ubGVuZ3RoIiwgIjIiKTsKKwordmFyIHN1Y2Nlc3NmdWxseVBh cnNlZCA9IHRydWU7CisKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9q cy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=