120428 2013-08-28 11:04:48 -0700 [Windows] Provide useful error messages for WebKitErrorDomain errors 2013-08-28 11:44:28 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham commit-queue webkit-bug-importer oldest_to_newest 922105 0 bfulgham 2013-08-28 11:04:48 -0700 The current handlers for things like "Content with specified MIME type can't be shown" and "Not allowed to use restricted network port" simply return an empty string for display to the user. This results in mysterious blank "OK" alert boxes that are the only clue that something went wrong with Windows WebKit when attempting to view some content. This bug uses the existing WEB_UI_STRINGS defined for these error codes and allows Windows WebKit to display them. 922106 1 webkit-bug-importer 2013-08-28 11:05:45 -0700 <rdar://problem/14858310> 922109 2 209906 bfulgham 2013-08-28 11:08:29 -0700 Created attachment 209906 Patch 922112 3 commit-queue 2013-08-28 11:11:53 -0700 Attachment 209906 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp']" exit_code: 1 Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:883: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:893: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:1147: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:1151: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 922118 4 bfulgham 2013-08-28 11:21:15 -0700 (In reply to comment #3) > Attachment 209906 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp']" exit_code: 1 > Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:883: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] > Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:893: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] > Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:1147: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] > Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:1151: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] > Total errors found: 4 in 2 files The character codes must be present to match the existing string keys in the localizedStrings file. 922131 5 bfulgham 2013-08-28 11:44:28 -0700 Committed r154764: <http://trac.webkit.org/changeset/154764> 209906 2013-08-28 11:08:29 -0700 2013-08-28 11:26:57 -0700 Patch bug-120428-20130828110849.patch text/plain 6814 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDc1OSkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA4LTI4 ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5kb3dz XSBQcm92aWRlIHVzZWZ1bCBlcnJvciBtZXNzYWdlcyBmb3IgV2ViS2l0RXJyb3JEb21haW4gZXJy b3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjA0 MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdl YkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcDoKKyAgICAgICAgKFdlYkZyYW1l TG9hZGVyQ2xpZW50OjpjYW5jZWxsZWRFcnJvcik6IFByb3ZpZGUgdGV4dCBmb3IgdGhpcyBlcnJv ci4KKyAgICAgICAgKFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpibG9ja2VkRXJyb3IpOiBIb29rIHVw IFdFQl9VSV9TVFJJTkcgZm9yIHRoaXMgZXJyb3IuCisgICAgICAgIChXZWJGcmFtZUxvYWRlckNs aWVudDo6Y2Fubm90U2hvd1VSTEVycm9yKTogRGl0dG8KKyAgICAgICAgKFdlYkZyYW1lTG9hZGVy Q2xpZW50OjppbnRlcnJ1cHRlZEZvclBvbGljeUNoYW5nZUVycm9yKTogRGl0dG8KKyAgICAgICAg KFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpjYW5ub3RTaG93TUlNRVR5cGVFcnJvcik6IERpdHRvCisg ICAgICAgIChXZWJGcmFtZUxvYWRlckNsaWVudDo6ZmlsZURvZXNOb3RFeGlzdEVycm9yKTogUHJv dmlkZSB0ZXh0IGZvciB0aGlzIGVycm9yLgorICAgICAgICAoV2ViRnJhbWVMb2FkZXJDbGllbnQ6 OnBsdWdpbldpbGxIYW5kbGVMb2FkRXJyb3IpOiBIb29rIHVwIFdFQl9VSV9TVFJJTkcgZm9yIHRo aXMgZXJyb3IuCisgICAgICAgIChXZWJGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hEaWRGYWls VG9TdGFydFBsdWdpbik6IERpdHRvLgorICAgICAgICAoV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmNy ZWF0ZUphdmFBcHBsZXRXaWRnZXQpOiBEaXR0by4KKyAgICAgICAgKFdlYkZyYW1lTG9hZGVyQ2xp ZW50Ojp3ZWJIaXN0b3J5KTogUmVtb3ZlIGJsYW5rIGxpbmUgYWJvdmUgbWV0aG9kLgorCiAyMDEz LTA4LTI3ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtX aW5kb3dzXSBMb2FkZXIgaXMgbm90IHByb3Blcmx5IGRldGVybWluaW5nIHN1cHBvcnRlZCBNSU1F IHR5cGVzCkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxv YWRlckNsaWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1 cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCShyZXZpc2lvbiAxNTQ3NTkpCisrKyBTb3Vy Y2UvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTcxLDYgKzcxLDcgQEAKICNpbmNsdWRlIDxXZWJDb3JlL0hUTUxQYXJz ZXJJZGlvbXMuaD4KICNpbmNsdWRlIDxXZWJDb3JlL0hUTUxQbHVnSW5FbGVtZW50Lmg+CiAjaW5j bHVkZSA8V2ViQ29yZS9IaXN0b3J5SXRlbS5oPgorI2luY2x1ZGUgPFdlYkNvcmUvTG9jYWxpemVk U3RyaW5ncy5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUGFnZS5oPgogI2luY2x1ZGUgPFdlYkNvcmUv UGx1Z2luUGFja2FnZS5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUGx1Z2luVmlldy5oPgpAQCAtODY5 LDQyICs4NzAsMzcgQEAgUmVzb3VyY2VFcnJvciBXZWJGcmFtZUxvYWRlckNsaWVudDo6Y2FuYwog ewogICAgIC8vIEZJWE1FOiBOZWVkIENoaWNrZW5DYXQgdG8gaW5jbHVkZSBDRk5ldHdvcmsvQ0ZV UkxFcnJvci5oIHRvIGdldCB0aGVzZSB2YWx1ZXMKICAgICAvLyBBbHRlcm5hdGl2ZWx5LCB3ZSBj b3VsZCBjcmVhdGUgb3VyIG93biBlcnJvciBkb21haW4vY29kZXMuCi0gICAgcmV0dXJuIFJlc291 cmNlRXJyb3IoU3RyaW5nKFdlYlVSTEVycm9yRG9tYWluKSwgLTk5OSwgcmVxdWVzdC51cmwoKS5z dHJpbmcoKSwgU3RyaW5nKCkpOworICAgIHJldHVybiBSZXNvdXJjZUVycm9yKFN0cmluZyhXZWJV UkxFcnJvckRvbWFpbiksIC05OTksIHJlcXVlc3QudXJsKCkuc3RyaW5nKCksIFN0cmluZygiQ2Fu Y2VsbGVkIikpOwogfQogCiBSZXNvdXJjZUVycm9yIFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpibG9j a2VkRXJyb3IoY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0KQogewotICAgIC8vIEZJWE1F OiBOZWVkIHRvIGltcGxlbWVudCB0aGUgU3RyaW5nIGRlc2NyaXB0aW9ucyBmb3IgZXJyb3JzIGlu IHRoZSBXZWJLaXRFcnJvckRvbWFpbiBhbmQgaGF2ZSB0aGVtIGxvY2FsaXplZAotICAgIHJldHVy biBSZXNvdXJjZUVycm9yKFN0cmluZyhXZWJLaXRFcnJvckRvbWFpbiksIFdlYktpdEVycm9yQ2Fu bm90VXNlUmVzdHJpY3RlZFBvcnQsIHJlcXVlc3QudXJsKCkuc3RyaW5nKCksIFN0cmluZygpKTsK KyAgICByZXR1cm4gUmVzb3VyY2VFcnJvcihTdHJpbmcoV2ViS2l0RXJyb3JEb21haW4pLCBXZWJL aXRFcnJvckNhbm5vdFVzZVJlc3RyaWN0ZWRQb3J0LCByZXF1ZXN0LnVybCgpLnN0cmluZygpLCBX RUJfVUlfU1RSSU5HKCJOb3QgYWxsb3dlZCB0byB1c2UgcmVzdHJpY3RlZCBuZXR3b3JrIHBvcnQi LCAiV2ViS2l0RXJyb3JDYW5ub3RVc2VSZXN0cmljdGVkUG9ydCBkZXNjcmlwdGlvbiIpKTsKIH0K IAogUmVzb3VyY2VFcnJvciBXZWJGcmFtZUxvYWRlckNsaWVudDo6Y2Fubm90U2hvd1VSTEVycm9y KGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCkKIHsKLSAgICAvLyBGSVhNRTogTmVlZCB0 byBpbXBsZW1lbnQgdGhlIFN0cmluZyBkZXNjcmlwdGlvbnMgZm9yIGVycm9ycyBpbiB0aGUgV2Vi S2l0RXJyb3JEb21haW4gYW5kIGhhdmUgdGhlbSBsb2NhbGl6ZWQKLSAgICByZXR1cm4gUmVzb3Vy Y2VFcnJvcihTdHJpbmcoV2ViS2l0RXJyb3JEb21haW4pLCBXZWJLaXRFcnJvckNhbm5vdFNob3dV UkwsIHJlcXVlc3QudXJsKCkuc3RyaW5nKCksIFN0cmluZygpKTsKKyAgICByZXR1cm4gUmVzb3Vy Y2VFcnJvcihTdHJpbmcoV2ViS2l0RXJyb3JEb21haW4pLCBXZWJLaXRFcnJvckNhbm5vdFNob3dV UkwsIHJlcXVlc3QudXJsKCkuc3RyaW5nKCksIFdFQl9VSV9TVFJJTkcoIlRoZSBVUkwgY2FuknQg YmUgc2hvd24iLCAiV2ViS2l0RXJyb3JDYW5ub3RTaG93VVJMIGRlc2NyaXB0aW9uIikpOwogfQog CiBSZXNvdXJjZUVycm9yIFdlYkZyYW1lTG9hZGVyQ2xpZW50OjppbnRlcnJ1cHRlZEZvclBvbGlj eUNoYW5nZUVycm9yKGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCkKIHsKLSAgICAvLyBG SVhNRTogTmVlZCB0byBpbXBsZW1lbnQgdGhlIFN0cmluZyBkZXNjcmlwdGlvbnMgZm9yIGVycm9y cyBpbiB0aGUgV2ViS2l0RXJyb3JEb21haW4gYW5kIGhhdmUgdGhlbSBsb2NhbGl6ZWQKLSAgICBy ZXR1cm4gUmVzb3VyY2VFcnJvcihTdHJpbmcoV2ViS2l0RXJyb3JEb21haW4pLCBXZWJLaXRFcnJv ckZyYW1lTG9hZEludGVycnVwdGVkQnlQb2xpY3lDaGFuZ2UsIHJlcXVlc3QudXJsKCkuc3RyaW5n KCksIFN0cmluZygpKTsKKyAgICByZXR1cm4gUmVzb3VyY2VFcnJvcihTdHJpbmcoV2ViS2l0RXJy b3JEb21haW4pLCBXZWJLaXRFcnJvckZyYW1lTG9hZEludGVycnVwdGVkQnlQb2xpY3lDaGFuZ2Us IHJlcXVlc3QudXJsKCkuc3RyaW5nKCksIFdFQl9VSV9TVFJJTkcoIkZyYW1lIGxvYWQgaW50ZXJy dXB0ZWQiLCAiV2ViS2l0RXJyb3JGcmFtZUxvYWRJbnRlcnJ1cHRlZEJ5UG9saWN5Q2hhbmdlIGRl c2NyaXB0aW9uIikpOwogfQogCi1SZXNvdXJjZUVycm9yIFdlYkZyYW1lTG9hZGVyQ2xpZW50Ojpj YW5ub3RTaG93TUlNRVR5cGVFcnJvcihjb25zdCBSZXNvdXJjZVJlc3BvbnNlJikKK1Jlc291cmNl RXJyb3IgV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmNhbm5vdFNob3dNSU1FVHlwZUVycm9yKGNvbnN0 IFJlc291cmNlUmVzcG9uc2UmIHJlc3BvbnNlKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0g ICAgcmV0dXJuIFJlc291cmNlRXJyb3IoKTsKKyAgICByZXR1cm4gUmVzb3VyY2VFcnJvcihTdHJp bmcoKSwgV2ViS2l0RXJyb3JDYW5ub3RTaG93TUlNRVR5cGUsIHJlc3BvbnNlLnVybCgpLnN0cmlu ZygpLCBXRUJfVUlfU1RSSU5HKCJDb250ZW50IHdpdGggc3BlY2lmaWVkIE1JTUUgdHlwZSBjYW6S dCBiZSBzaG93biIsICJXZWJLaXRFcnJvckNhbm5vdFNob3dNSU1FVHlwZSBkZXNjcmlwdGlvbiIp KTsKIH0KIAotUmVzb3VyY2VFcnJvciBXZWJGcmFtZUxvYWRlckNsaWVudDo6ZmlsZURvZXNOb3RF eGlzdEVycm9yKGNvbnN0IFJlc291cmNlUmVzcG9uc2UmKQorUmVzb3VyY2VFcnJvciBXZWJGcmFt ZUxvYWRlckNsaWVudDo6ZmlsZURvZXNOb3RFeGlzdEVycm9yKGNvbnN0IFJlc291cmNlUmVzcG9u c2UmIHJlc3BvbnNlKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIFJlc291 cmNlRXJyb3IoKTsKKyAgICByZXR1cm4gUmVzb3VyY2VFcnJvcihTdHJpbmcoV2ViVVJMRXJyb3JE b21haW4pLCAtMTEwMCwgcmVzcG9uc2UudXJsKCkuc3RyaW5nKCksIFN0cmluZygiRmlsZSBkb2Vz IG5vdCBleGlzdC4iKSk7CiB9CiAKIFJlc291cmNlRXJyb3IgV2ViRnJhbWVMb2FkZXJDbGllbnQ6 OnBsdWdpbldpbGxIYW5kbGVMb2FkRXJyb3IoY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVzcG9u c2UpCiB7Ci0gICAgcmV0dXJuIFJlc291cmNlRXJyb3IoU3RyaW5nKFdlYktpdEVycm9yRG9tYWlu KSwgV2ViS2l0RXJyb3JQbHVnSW5XaWxsSGFuZGxlTG9hZCwgcmVzcG9uc2UudXJsKCkuc3RyaW5n KCksIFN0cmluZygpKTsKKyAgICByZXR1cm4gUmVzb3VyY2VFcnJvcihTdHJpbmcoV2ViS2l0RXJy b3JEb21haW4pLCBXZWJLaXRFcnJvclBsdWdJbldpbGxIYW5kbGVMb2FkLCByZXNwb25zZS51cmwo KS5zdHJpbmcoKSwgV0VCX1VJX1NUUklORygiUGx1Zy1pbiBoYW5kbGVkIGxvYWQiLCAiV2ViS2l0 RXJyb3JQbHVnSW5XaWxsSGFuZGxlTG9hZCBkZXNjcmlwdGlvbiIpKTsKIH0KIAogYm9vbCBXZWJG cmFtZUxvYWRlckNsaWVudDo6c2hvdWxkRmFsbEJhY2soY29uc3QgUmVzb3VyY2VFcnJvciYgZXJy b3IpCkBAIC0xMTQ0LDEyICsxMTQwLDE1IEBAIHZvaWQgV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmRp c3BhdGNoRGlkRmEKICAgICB1c2VySW5mb0JhZy0+c2V0RGljdGlvbmFyeSh1c2VySW5mby5nZXQo KSk7CiAgCiAgICAgaW50IGVycm9yQ29kZSA9IDA7CisgICAgU3RyaW5nIGRlc2NyaXB0aW9uOwog ICAgIHN3aXRjaCAocGx1Z2luVmlldy0+c3RhdHVzKCkpIHsKICAgICAgICAgY2FzZSBQbHVnaW5T dGF0dXNDYW5Ob3RGaW5kUGx1Z2luOgogICAgICAgICAgICAgZXJyb3JDb2RlID0gV2ViS2l0RXJy b3JDYW5ub3RGaW5kUGx1Z0luOworICAgICAgICAgICAgZGVzY3JpcHRpb24gPSBXRUJfVUlfU1RS SU5HKCJUaGUgcGx1Zy1pbiBjYW6SdCBiZSBmb3VuZCIsICJXZWJLaXRFcnJvckNhbm5vdEZpbmRQ bHVnaW4gZGVzY3JpcHRpb24iKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIFBs dWdpblN0YXR1c0Nhbk5vdExvYWRQbHVnaW46CiAgICAgICAgICAgICBlcnJvckNvZGUgPSBXZWJL aXRFcnJvckNhbm5vdExvYWRQbHVnSW47CisgICAgICAgICAgICBkZXNjcmlwdGlvbiA9IFdFQl9V SV9TVFJJTkcoIlRoZSBwbHVnLWluIGNhbpJ0IGJlIGxvYWRlZCIsICJXZWJLaXRFcnJvckNhbm5v dExvYWRQbHVnaW4gZGVzY3JpcHRpb24iKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBk ZWZhdWx0OgogICAgICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CkBAIC0xMjMzLDcgKzEy MzIsNyBAQCBQYXNzUmVmUHRyPFdpZGdldD4gV2ViRnJhbWVMb2FkZXJDbGllbnQ6CiAKICAgICBD T01QdHI8Q0ZEaWN0aW9uYXJ5UHJvcGVydHlCYWc+IHVzZXJJbmZvQmFnID0gQ0ZEaWN0aW9uYXJ5 UHJvcGVydHlCYWc6OmNyZWF0ZUluc3RhbmNlKCk7CiAKLSAgICBSZXNvdXJjZUVycm9yIHJlc291 cmNlRXJyb3IoU3RyaW5nKFdlYktpdEVycm9yRG9tYWluKSwgV2ViS2l0RXJyb3JKYXZhVW5hdmFp bGFibGUsIFN0cmluZygpLCBTdHJpbmcoKSk7CisgICAgUmVzb3VyY2VFcnJvciByZXNvdXJjZUVy cm9yKFN0cmluZyhXZWJLaXRFcnJvckRvbWFpbiksIFdlYktpdEVycm9ySmF2YVVuYXZhaWxhYmxl LCBTdHJpbmcoKSwgV0VCX1VJX1NUUklORygiSmF2YSBpcyB1bmF2YWlsYWJsZSIsICJXZWJLaXRF cnJvckphdmFVbmF2YWlsYWJsZSBkZXNjcmlwdGlvbiIpKTsKICAgICBDT01QdHI8SVdlYkVycm9y PiBlcnJvcihBZG9wdENPTSwgV2ViRXJyb3I6OmNyZWF0ZUluc3RhbmNlKHJlc291cmNlRXJyb3Is IHVzZXJJbmZvQmFnLmdldCgpKSk7CiAKICAgICBGcmFtZSogY29yZUZyYW1lID0gY29yZShtX3dl YkZyYW1lKTsKQEAgLTEyNTIsNyArMTI1MSw2IEBAIFdlYkhpc3RvcnkqIFdlYkZyYW1lTG9hZGVy Q2xpZW50Ojp3ZWJIaXMKICAgICByZXR1cm4gV2ViSGlzdG9yeTo6c2hhcmVkSGlzdG9yeSgpOwog fQogCi0KIFN0cmluZyBXZWJGcmFtZUxvYWRlckNsaWVudDo6b3ZlcnJpZGVNZWRpYVR5cGUoKSBj b25zdAogewogICAgIG5vdEltcGxlbWVudGVkKCk7Cg==