120414 2013-08-28 07:07:50 -0700 Share attach loops between Elements and ShadowRoots 2013-08-28 07:48:24 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned oldest_to_newest 921984 0 koivisto 2013-08-28 07:07:50 -0700 less code 921990 1 209882 koivisto 2013-08-28 07:12:08 -0700 Created attachment 209882 patch 922001 2 209882 kling 2013-08-28 07:30:40 -0700 Comment on attachment 209882 patch r=me. Needs more references but whatever. 922004 3 koivisto 2013-08-28 07:48:14 -0700 https://trac.webkit.org/r154746 922005 4 koivisto 2013-08-28 07:48:24 -0700 with references! 209882 2013-08-28 07:12:08 -0700 2013-08-28 07:30:40 -0700 patch attach-children-share.patch text/plain 4544 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDc0MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA4LTI4ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBTaGFyZSBhdHRhY2ggbG9vcHMg YmV0d2VlbiBFbGVtZW50cyBhbmQgU2hhZG93Um9vdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDQxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3R5bGUvU3R5bGVSZXNvbHZlVHJlZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpTdHlsZTo6YXR0YWNoQ2hpbGRyZW4pOgorICAgICAgICAoV2ViQ29y ZTo6U3R5bGU6OmF0dGFjaFNoYWRvd1Jvb3QpOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGU6OmRl dGFjaENoaWxkcmVuKToKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlOjpkZXRhY2hTaGFkb3dSb290 KToKKwogMjAxMy0wOC0yOCAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAK ICAgICAgICAgUkVHUkVTU0lPTihyMTU0NzA4KTogSXQgYnJva2UgYWxsIHBsdWdpbiB0ZXN0cyBv biBHVEsgYW5kIFF0IFdLMQpJbmRleDogU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVSZXNvbHZl VHJlZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVSZXNvbHZl VHJlZS5jcHAJKHJldmlzaW9uIDE1NDczOCkKKysrIFNvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxl UmVzb2x2ZVRyZWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yODcsMzAgKzI4Nyw2IEBAIHZvaWQg dXBkYXRlVGV4dFJlbmRlcmVyQWZ0ZXJDb250ZW50Q2hhbmcKICAgICB0ZXh0UmVuZGVyZXItPnNl dFRleHRXaXRoT2Zmc2V0KHRleHROb2RlLmRhdGFJbXBsKCksIG9mZnNldE9mUmVwbGFjZWREYXRh LCBsZW5ndGhPZlJlcGxhY2VkRGF0YSk7CiB9CiAKLQotc3RhdGljIHZvaWQgYXR0YWNoU2hhZG93 Um9vdChTaGFkb3dSb290KiBzaGFkb3dSb290LCBjb25zdCBBdHRhY2hDb250ZXh0JiBjb250ZXh0 KQotewotICAgIGlmIChzaGFkb3dSb290LT5hdHRhY2hlZCgpKQotICAgICAgICByZXR1cm47Ci0g ICAgU3R5bGVSZXNvbHZlciYgc3R5bGVSZXNvbHZlciA9IHNoYWRvd1Jvb3QtPmRvY3VtZW50KCkt PmVuc3VyZVN0eWxlUmVzb2x2ZXIoKTsKLSAgICBzdHlsZVJlc29sdmVyLnB1c2hQYXJlbnRTaGFk b3dSb290KHNoYWRvd1Jvb3QpOwotCi0gICAgU3R5bGU6OkF0dGFjaENvbnRleHQgY2hpbGRyZW5D b250ZXh0KGNvbnRleHQpOwotICAgIGNoaWxkcmVuQ29udGV4dC5yZXNvbHZlZFN0eWxlID0gMDsK LSAgICBmb3IgKE5vZGUqIGNoaWxkID0gc2hhZG93Um9vdC0+Zmlyc3RDaGlsZCgpOyBjaGlsZDsg Y2hpbGQgPSBjaGlsZC0+bmV4dFNpYmxpbmcoKSkgewotICAgICAgICBpZiAoY2hpbGQtPmlzVGV4 dE5vZGUoKSkgewotICAgICAgICAgICAgYXR0YWNoVGV4dFJlbmRlcmVyKCp0b1RleHQoY2hpbGQp KTsKLSAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICB9Ci0gICAgICAgIGlmIChjaGlsZC0+ aXNFbGVtZW50Tm9kZSgpKQotICAgICAgICAgICAgYXR0YWNoUmVuZGVyVHJlZSh0b0VsZW1lbnQo Y2hpbGQpLCBjaGlsZHJlbkNvbnRleHQpOwotICAgIH0KLSAgICBzdHlsZVJlc29sdmVyLnBvcFBh cmVudFNoYWRvd1Jvb3Qoc2hhZG93Um9vdCk7Ci0KLSAgICBzaGFkb3dSb290LT5jbGVhck5lZWRz U3R5bGVSZWNhbGMoKTsKLSAgICBzaGFkb3dSb290LT5zZXRBdHRhY2hlZCh0cnVlKTsKLX0KLQog I2lmbmRlZiBOREVCVUcKIHN0YXRpYyBib29sIGNoaWxkQXR0YWNoZWRBbGxvd2VkV2hlbkF0dGFj aGluZ0NoaWxkcmVuKENvbnRhaW5lck5vZGUqIG5vZGUpCiB7CkBAIC0zMjQsNyArMzAwLDcgQEAg c3RhdGljIGJvb2wgY2hpbGRBdHRhY2hlZEFsbG93ZWRXaGVuQXR0YQogfQogI2VuZGlmCiAKLXN0 YXRpYyB2b2lkIGF0dGFjaENoaWxkcmVuKEVsZW1lbnQqIGN1cnJlbnQsIGNvbnN0IEF0dGFjaENv bnRleHQmIGNvbnRleHQpCitzdGF0aWMgdm9pZCBhdHRhY2hDaGlsZHJlbihDb250YWluZXJOb2Rl KiBjdXJyZW50LCBjb25zdCBBdHRhY2hDb250ZXh0JiBjb250ZXh0KQogewogICAgIEF0dGFjaENv bnRleHQgY2hpbGRyZW5Db250ZXh0KGNvbnRleHQpOwogICAgIGNoaWxkcmVuQ29udGV4dC5yZXNv bHZlZFN0eWxlID0gMDsKQEAgLTM0Miw2ICszMTgsMjEgQEAgc3RhdGljIHZvaWQgYXR0YWNoQ2hp bGRyZW4oRWxlbWVudCogY3VycgogICAgIH0KIH0KIAorc3RhdGljIHZvaWQgYXR0YWNoU2hhZG93 Um9vdChTaGFkb3dSb290KiBzaGFkb3dSb290LCBjb25zdCBBdHRhY2hDb250ZXh0JiBjb250ZXh0 KQoreworICAgIGlmIChzaGFkb3dSb290LT5hdHRhY2hlZCgpKQorICAgICAgICByZXR1cm47Cisg ICAgU3R5bGVSZXNvbHZlciYgc3R5bGVSZXNvbHZlciA9IHNoYWRvd1Jvb3QtPmRvY3VtZW50KCkt PmVuc3VyZVN0eWxlUmVzb2x2ZXIoKTsKKyAgICBzdHlsZVJlc29sdmVyLnB1c2hQYXJlbnRTaGFk b3dSb290KHNoYWRvd1Jvb3QpOworCisgICAgYXR0YWNoQ2hpbGRyZW4oc2hhZG93Um9vdCwgY29u dGV4dCk7CisKKyAgICBzdHlsZVJlc29sdmVyLnBvcFBhcmVudFNoYWRvd1Jvb3Qoc2hhZG93Um9v dCk7CisKKyAgICBzaGFkb3dSb290LT5jbGVhck5lZWRzU3R5bGVSZWNhbGMoKTsKKyAgICBzaGFk b3dSb290LT5zZXRBdHRhY2hlZCh0cnVlKTsKK30KKwogdm9pZCBhdHRhY2hSZW5kZXJUcmVlKEVs ZW1lbnQqIGN1cnJlbnQsIGNvbnN0IEF0dGFjaENvbnRleHQmIGNvbnRleHQpCiB7CiAgICAgUG9z dEF0dGFjaENhbGxiYWNrRGlzYWJsZXIgY2FsbGJhY2tEaXNhYmxlcihjdXJyZW50KTsKQEAgLTM4 OCwyNSArMzc5LDcgQEAgdm9pZCBhdHRhY2hSZW5kZXJUcmVlKEVsZW1lbnQqIGN1cnJlbnQsIAog ICAgICAgICBjdXJyZW50LT5kaWRBdHRhY2hSZW5kZXJlcnMoKTsKIH0KIAotc3RhdGljIHZvaWQg ZGV0YWNoU2hhZG93Um9vdChTaGFkb3dSb290KiBzaGFkb3dSb290LCBjb25zdCBBdHRhY2hDb250 ZXh0JiBjb250ZXh0KQotewotICAgIGlmICghc2hhZG93Um9vdC0+YXR0YWNoZWQoKSkKLSAgICAg ICAgcmV0dXJuOwotICAgIFN0eWxlOjpBdHRhY2hDb250ZXh0IGNoaWxkcmVuQ29udGV4dChjb250 ZXh0KTsKLSAgICBjaGlsZHJlbkNvbnRleHQucmVzb2x2ZWRTdHlsZSA9IDA7Ci0gICAgZm9yIChO b2RlKiBjaGlsZCA9IHNoYWRvd1Jvb3QtPmZpcnN0Q2hpbGQoKTsgY2hpbGQ7IGNoaWxkID0gY2hp bGQtPm5leHRTaWJsaW5nKCkpIHsKLSAgICAgICAgaWYgKGNoaWxkLT5pc1RleHROb2RlKCkpIHsK LSAgICAgICAgICAgIFN0eWxlOjpkZXRhY2hUZXh0UmVuZGVyZXIoKnRvVGV4dChjaGlsZCkpOwot ICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgIH0KLSAgICAgICAgaWYgKGNoaWxkLT5pc0Vs ZW1lbnROb2RlKCkpCi0gICAgICAgICAgICBkZXRhY2hSZW5kZXJUcmVlKHRvRWxlbWVudChjaGls ZCksIGNvbnRleHQpOwotICAgIH0KLSAgICBzaGFkb3dSb290LT5jbGVhckNoaWxkTmVlZHNTdHls ZVJlY2FsYygpOwotICAgIHNoYWRvd1Jvb3QtPnNldEF0dGFjaGVkKGZhbHNlKTsKLX0KLQotc3Rh dGljIHZvaWQgZGV0YWNoQ2hpbGRyZW4oRWxlbWVudCogY3VycmVudCwgY29uc3QgQXR0YWNoQ29u dGV4dCYgY29udGV4dCkKK3N0YXRpYyB2b2lkIGRldGFjaENoaWxkcmVuKENvbnRhaW5lck5vZGUq IGN1cnJlbnQsIGNvbnN0IEF0dGFjaENvbnRleHQmIGNvbnRleHQpCiB7CiAgICAgQXR0YWNoQ29u dGV4dCBjaGlsZHJlbkNvbnRleHQoY29udGV4dCk7CiAgICAgY2hpbGRyZW5Db250ZXh0LnJlc29s dmVkU3R5bGUgPSAwOwpAQCAtNDIyLDYgKzM5NSwxNSBAQCBzdGF0aWMgdm9pZCBkZXRhY2hDaGls ZHJlbihFbGVtZW50KiBjdXJyCiAgICAgY3VycmVudC0+Y2xlYXJDaGlsZE5lZWRzU3R5bGVSZWNh bGMoKTsKIH0KIAorc3RhdGljIHZvaWQgZGV0YWNoU2hhZG93Um9vdChTaGFkb3dSb290KiBzaGFk b3dSb290LCBjb25zdCBBdHRhY2hDb250ZXh0JiBjb250ZXh0KQoreworICAgIGlmICghc2hhZG93 Um9vdC0+YXR0YWNoZWQoKSkKKyAgICAgICAgcmV0dXJuOworICAgIGRldGFjaENoaWxkcmVuKHNo YWRvd1Jvb3QsIGNvbnRleHQpOworCisgICAgc2hhZG93Um9vdC0+c2V0QXR0YWNoZWQoZmFsc2Up OworfQorCiB2b2lkIGRldGFjaFJlbmRlclRyZWUoRWxlbWVudCogY3VycmVudCwgY29uc3QgQXR0 YWNoQ29udGV4dCYgY29udGV4dCkKIHsKICAgICBXaWRnZXRIaWVyYXJjaHlVcGRhdGVzU3VzcGVu c2lvblNjb3BlIHN1c3BlbmRXaWRnZXRIaWVyYXJjaHlVcGRhdGVzOwo=