120413 2013-08-28 07:07:22 -0700 [curl] Use utf8 for headers in CurlDownload. 2013-09-12 11:28:29 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Curl P2 Normal --- 117300 1 tczene webkit-unassigned andersca bfulgham commit-queue galpeter ossy peavo oldest_to_newest 921983 0 tczene 2013-08-28 07:07:22 -0700 [curl] Use utf8 for headers in CurlDownload. 921987 1 209881 tczene 2013-08-28 07:10:24 -0700 Created attachment 209881 proposed patch 923697 2 andersca 2013-09-02 07:23:18 -0700 (In reply to comment #0) > [curl] Use utf8 for headers in CurlDownload. Why? 924500 3 galpeter 2013-09-04 10:31:34 -0700 (In reply to comment #2) > (In reply to comment #0) > > [curl] Use utf8 for headers in CurlDownload. > > Why? I think because the header can contain utf8 characters, like for example the name of the file can be in utf8 (in the content-disposition header). There is also a testcase for this: http/tests/download/literal-utf-8.html. 928388 4 209881 bfulgham 2013-09-12 11:04:58 -0700 Comment on attachment 209881 proposed patch Seems find, and unlikely to hurt any other port. r=me. 928403 5 209881 commit-queue 2013-09-12 11:28:27 -0700 Comment on attachment 209881 proposed patch Clearing flags on attachment: 209881 Committed r155634: <http://trac.webkit.org/changeset/155634> 928404 6 commit-queue 2013-09-12 11:28:29 -0700 All reviewed patches have been landed. Closing bug. 209881 2013-08-28 07:10:24 -0700 2013-09-12 11:28:27 -0700 proposed patch otodik text/plain 1309 tczene ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2YmIxMTRjLi42ZWQwN2VmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTMtMDgtMjggIFRhbWFzIEN6ZW5lICA8dGN6ZW5lQGluZi51LXN6ZWdlZC5odT4KKwor ICAgICAgICBbY3VybF0gVXNlIHV0ZjggZm9yIGhlYWRlcnMgaW4gQ3VybERvd25sb2FkLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwNDEzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9u ZXR3b3JrL2N1cmwvQ3VybERvd25sb2FkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkN1cmxEb3du bG9hZDo6aGVhZGVyQ2FsbGJhY2spOgorCiAyMDEzLTA4LTI4ICBBbnR0aSBLb2l2aXN0byAgPGFu dHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBEb24ndCB1c2UgTm9kZVJlbmRlcmluZ0NvbnRleHQg d2hlbiBhdHRhY2hpbmcgdGV4dCByZW5kZXJlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsRG93bmxvYWQuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxEb3dubG9hZC5jcHAKaW5kZXggNDI1ZTFhYi4uYWRj MDNmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1 cmxEb3dubG9hZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJs L0N1cmxEb3dubG9hZC5jcHAKQEAgLTQ2NCw3ICs0NjQsNyBAQCBzaXplX3QgQ3VybERvd25sb2Fk OjpoZWFkZXJDYWxsYmFjayhjaGFyKiBwdHIsIHNpemVfdCBzaXplLCBzaXplX3Qgbm1lbWIsIHZv aWQqCiAgICAgc2l6ZV90IHRvdGFsU2l6ZSA9IHNpemUgKiBubWVtYjsKICAgICBDdXJsRG93bmxv YWQqIGRvd25sb2FkID0gcmVpbnRlcnByZXRfY2FzdDxDdXJsRG93bmxvYWQqPihkYXRhKTsKIAot ICAgIFN0cmluZyBoZWFkZXIoc3RhdGljX2Nhc3Q8Y29uc3QgY2hhcio+KHB0ciksIHRvdGFsU2l6 ZSk7CisgICAgU3RyaW5nIGhlYWRlciA9IFN0cmluZzo6ZnJvbVVURjhXaXRoTGF0aW4xRmFsbGJh Y2soc3RhdGljX2Nhc3Q8Y29uc3QgY2hhcio+KHB0ciksIHRvdGFsU2l6ZSk7CiAKICAgICBpZiAo ZG93bmxvYWQpCiAgICAgICAgIGRvd25sb2FkLT5kaWRSZWNlaXZlSGVhZGVyKGhlYWRlcik7Cg==