120407 2013-08-28 06:19:56 -0700 Resolve unused parameter warning in WebKitAccessibleInterfaceText.cpp 2013-08-30 08:23:22 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 0 tczene webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni jdiggs mario webkit-bug-importer oldest_to_newest 921962 0 tczene 2013-08-28 06:19:56 -0700 Resolve unused parameter warning in WebKitAccessibleInterfaceText.cpp 921963 1 webkit-bug-importer 2013-08-28 06:20:37 -0700 <rdar://problem/14855742> 921966 2 209872 tczene 2013-08-28 06:21:56 -0700 Created attachment 209872 proposed patch 922054 3 209872 darin 2013-08-28 09:41:15 -0700 Comment on attachment 209872 proposed patch Since this function is local to this file, it doesn't make sense to pass and ignore an argument. We should just remove this argument from this function and all the call sites. I think it’s better style to just remove the argument name entirely rather than commenting it out, but it’s debatable I suppose. I also think the spacing inside the /* */ draws too much attention to the unused argument. 922853 4 210081 tczene 2013-08-30 02:12:11 -0700 Created attachment 210081 proposed patch I wouldn't really like to delete it, because the name can refer to its purpose. 922948 5 210081 darin 2013-08-30 08:00:53 -0700 Comment on attachment 210081 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=210081&action=review > Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:715 > +static VisibleSelection wordAtPositionForAtkBoundary(const AccessibilityObject* /*coreObject*/, const VisiblePosition& position, AtkTextBoundary boundaryType) You say “the name refers to its purpose”, but “core object” means nothing to me. Core of what? What object? It’s not adding anything. 922963 6 210081 commit-queue 2013-08-30 08:23:20 -0700 Comment on attachment 210081 proposed patch Clearing flags on attachment: 210081 Committed r154882: <http://trac.webkit.org/changeset/154882> 922964 7 commit-queue 2013-08-30 08:23:22 -0700 All reviewed patches have been landed. Closing bug. 209872 2013-08-28 06:21:56 -0700 2013-08-30 02:12:11 -0700 proposed patch elso text/plain 1492 tczene ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2YmIxMTRjLi42MzUxNmRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTMtMDgtMjggIFRhbWFzIEN6ZW5lICA8dGN6ZW5lQGluZi51LXN6ZWdlZC5odT4KKwor ICAgICAgICBSZXNvbHZlIHVudXNlZCBwYXJhbWV0ZXIgd2FybmluZyBpbiBXZWJLaXRBY2Nlc3Np YmxlSW50ZXJmYWNlVGV4dC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyMDQwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUludGVyZmFj ZVRleHQuY3BwOgorICAgICAgICAod29yZEF0UG9zaXRpb25Gb3JBdGtCb3VuZGFyeSk6CisKIDIw MTMtMDgtMjggIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIERv bid0IHVzZSBOb2RlUmVuZGVyaW5nQ29udGV4dCB3aGVuIGF0dGFjaGluZyB0ZXh0IHJlbmRlcmVy cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNj ZXNzaWJsZUludGVyZmFjZVRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9h dGsvV2ViS2l0QWNjZXNzaWJsZUludGVyZmFjZVRleHQuY3BwCmluZGV4IGYxMzVmZDQuLmUyY2Fk YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFj Y2Vzc2libGVJbnRlcmZhY2VUZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlSW50ZXJmYWNlVGV4dC5jcHAKQEAgLTcxMiw3ICs3MTIs NyBAQCBzdGF0aWMgVmlzaWJsZVBvc2l0aW9uIHByZXZpb3VzV29yZEVuZFBvc2l0aW9uKGNvbnN0 IFZpc2libGVQb3NpdGlvbiAmcG9zaXRpb24pCiAgICAgcmV0dXJuIHBvc2l0aW9uQXRTdGFydE9m Q3VycmVudFdvcmQ7CiB9CiAKLXN0YXRpYyBWaXNpYmxlU2VsZWN0aW9uIHdvcmRBdFBvc2l0aW9u Rm9yQXRrQm91bmRhcnkoY29uc3QgQWNjZXNzaWJpbGl0eU9iamVjdCogY29yZU9iamVjdCwgY29u c3QgVmlzaWJsZVBvc2l0aW9uJiBwb3NpdGlvbiwgQXRrVGV4dEJvdW5kYXJ5IGJvdW5kYXJ5VHlw ZSkKK3N0YXRpYyBWaXNpYmxlU2VsZWN0aW9uIHdvcmRBdFBvc2l0aW9uRm9yQXRrQm91bmRhcnko Y29uc3QgQWNjZXNzaWJpbGl0eU9iamVjdCogLyogY29yZU9iamVjdCAqLywgY29uc3QgVmlzaWJs ZVBvc2l0aW9uJiBwb3NpdGlvbiwgQXRrVGV4dEJvdW5kYXJ5IGJvdW5kYXJ5VHlwZSkKIHsKICAg ICBWaXNpYmxlUG9zaXRpb24gc3RhcnRQb3NpdGlvbjsKICAgICBWaXNpYmxlUG9zaXRpb24gZW5k UG9zaXRpb247Cg== 210081 2013-08-30 02:12:11 -0700 2013-08-30 08:23:19 -0700 proposed patch elso text/plain 1479 tczene ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5YTJmNDc0Li40MzE2YjJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTMtMDgtMzAgIFRhbWFzIEN6ZW5lICA8dGN6ZW5lQGluZi51LXN6ZWdlZC5odT4KKwor ICAgICAgICBSZXNvbHZlIHVudXNlZCBwYXJhbWV0ZXIgd2FybmluZyBpbiBGaW5kQ29udHJvbGxl ci5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy MDQwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog YWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUludGVyZmFjZVRleHQuY3BwOgorICAg ICAgICAod29yZEF0UG9zaXRpb25Gb3JBdGtCb3VuZGFyeSk6CisKIDIwMTMtMDgtMjkgIFJ5b3N1 a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5kdXBsaWNhdGUgdGhlIGNv ZGUgdG8gY29udmVydCBiZXR3ZWVuIFZpc2libGVQb3NpdGlvbiBhbmQgaW5kZXgKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRl cmZhY2VUZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFj Y2Vzc2libGVJbnRlcmZhY2VUZXh0LmNwcAppbmRleCBmMTM1ZmQ0Li5lMzIyNGUyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlSW50 ZXJmYWNlVGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2Vi S2l0QWNjZXNzaWJsZUludGVyZmFjZVRleHQuY3BwCkBAIC03MTIsNyArNzEyLDcgQEAgc3RhdGlj IFZpc2libGVQb3NpdGlvbiBwcmV2aW91c1dvcmRFbmRQb3NpdGlvbihjb25zdCBWaXNpYmxlUG9z aXRpb24gJnBvc2l0aW9uKQogICAgIHJldHVybiBwb3NpdGlvbkF0U3RhcnRPZkN1cnJlbnRXb3Jk OwogfQogCi1zdGF0aWMgVmlzaWJsZVNlbGVjdGlvbiB3b3JkQXRQb3NpdGlvbkZvckF0a0JvdW5k YXJ5KGNvbnN0IEFjY2Vzc2liaWxpdHlPYmplY3QqIGNvcmVPYmplY3QsIGNvbnN0IFZpc2libGVQ b3NpdGlvbiYgcG9zaXRpb24sIEF0a1RleHRCb3VuZGFyeSBib3VuZGFyeVR5cGUpCitzdGF0aWMg VmlzaWJsZVNlbGVjdGlvbiB3b3JkQXRQb3NpdGlvbkZvckF0a0JvdW5kYXJ5KGNvbnN0IEFjY2Vz c2liaWxpdHlPYmplY3QqIC8qY29yZU9iamVjdCovLCBjb25zdCBWaXNpYmxlUG9zaXRpb24mIHBv c2l0aW9uLCBBdGtUZXh0Qm91bmRhcnkgYm91bmRhcnlUeXBlKQogewogICAgIFZpc2libGVQb3Np dGlvbiBzdGFydFBvc2l0aW9uOwogICAgIFZpc2libGVQb3NpdGlvbiBlbmRQb3NpdGlvbjsK