120406 2013-08-28 06:17:43 -0700 [GTK] [WK2] TestWebKitWebView page-visibility fails 2013-08-29 10:21:16 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 117689 1 brian.holt brian.holt cgarcia commit-queue gustavo mario mrobinson oldest_to_newest 921961 0 brian.holt 2013-08-28 06:17:43 -0700 The unit test for page-visibility fails because the return value from JS is not a string. ERROR:../../Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp:366:char* jsValueToCString(JSGlobalContextRef, JSValueRef): assertion failed: (JSValueIsString(context, value)) 922038 1 209895 brian.holt 2013-08-28 09:16:39 -0700 Created attachment 209895 Patch 922039 2 commit-queue 2013-08-28 09:17:53 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 922041 3 brian.holt 2013-08-28 09:19:18 -0700 It looks like this test was missed when the prefixes were removed in https://bugs.webkit.org/show_bug.cgi?id=102340. The proposed patch fixes this specific issue, but there are still others preventing TestWebKitWebView from running. 922518 4 209895 gustavo 2013-08-29 10:07:10 -0700 Comment on attachment 209895 Patch Thanks! 922523 5 209895 commit-queue 2013-08-29 10:21:14 -0700 Comment on attachment 209895 Patch Clearing flags on attachment: 209895 Committed r154818: <http://trac.webkit.org/changeset/154818> 922524 6 commit-queue 2013-08-29 10:21:16 -0700 All reviewed patches have been landed. Closing bug. 209895 2013-08-28 09:16:39 -0700 2013-08-29 10:21:13 -0700 Patch bug-120406-20130828171721.patch text/plain 4608 brian.holt U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0NzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjQ5MjdkNWFhZWQ2M2Vj NmQxZjYyMmIwYzdlYTdlNWMwNDIyMGEzZS4uYmM1ODM4Y2I2Y2VlZWUxNGJlYThmNzgxNzJmMTQ0 NzIxMTRmZjY5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA4LTI4ICBCcmlh biBIb2x0ICA8YnJpYW4uaG9sdEBzYW1zdW5nLmNvbT4KKworICAgICAgICBbR1RLXSBbV0syXSBU ZXN0V2ViS2l0V2ViVmlldyBwYWdlLXZpc2liaWxpdHkgZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDQwNgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZWQgdGhlIHdlYmtpdCBwcmVmaXgg Zm9yIGRvY3VtZW50IHZpc2liaWxpdHkgcHJvcGVydGllcy4KKworICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvZ3RrL3Rlc3RzL1Rlc3RXZWJLaXRXZWJWaWV3LmNwcDoKKyAgICAgICAgKHRlc3RXZWJW aWV3UGFnZVZpc2liaWxpdHkpOgorCiAyMDEzLTA4LTI4ICDDgWJyYWjDoW0gR8OhYm9yICA8YWJy aG1AaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIEZpeCB1bnVzZWQgdmFyaWFibGUgd2Fybmlu Zy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rl c3RXZWJLaXRXZWJWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rl c3RzL1Rlc3RXZWJLaXRXZWJWaWV3LmNwcAppbmRleCA2ZmZlNTE0YzI3MTUzOWIxNjllNGNhMmQ1 ZTA5Yzg5MGUyNjQzMjQyLi4yOGEwOGYzMDIxMzM5Zjc4NTAyN2I4NzBmZTQ3NTlhNjM4ZjNmYWNh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0 V2ViS2l0V2ViVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv dGVzdHMvVGVzdFdlYktpdFdlYlZpZXcuY3BwCkBAIC0xMDkzLDkgKzEwOTMsOSBAQCBzdGF0aWMg dm9pZCB0ZXN0V2ViVmlld1BhZ2VWaXNpYmlsaXR5KFdlYlZpZXdUZXN0KiB0ZXN0LCBnY29uc3Rw b2ludGVyKQogICAgIHRlc3QtPmxvYWRIdG1sKCI8aHRtbD48dGl0bGU+PC90aXRsZT4iCiAgICAg ICAgICI8Ym9keT48cD5UZXN0IFdlYiBQYWdlIFZpc2liaWxpdHk8L3A+IgogICAgICAgICAiPHNj cmlwdD4iCi0gICAgICAgICJkb2N1bWVudC5hZGRFdmVudExpc3RlbmVyKFwid2Via2l0dmlzaWJp bGl0eWNoYW5nZVwiLCBvblZpc2liaWxpdHlDaGFuZ2UsIGZhbHNlKTsiCisgICAgICAgICJkb2N1 bWVudC5hZGRFdmVudExpc3RlbmVyKFwidmlzaWJpbGl0eWNoYW5nZVwiLCBvblZpc2liaWxpdHlD aGFuZ2UsIGZhbHNlKTsiCiAgICAgICAgICJmdW5jdGlvbiBvblZpc2liaWxpdHlDaGFuZ2UoKSB7 IgotICAgICAgICAiICAgIGRvY3VtZW50LnRpdGxlID0gZG9jdW1lbnQud2Via2l0VmlzaWJpbGl0 eVN0YXRlOyIKKyAgICAgICAgIiAgICBkb2N1bWVudC50aXRsZSA9IGRvY3VtZW50LnZpc2liaWxp dHlTdGF0ZTsiCiAgICAgICAgICJ9IgogICAgICAgICAiPC9zY3JpcHQ+IgogICAgICAgICAiPC9i b2R5PjwvaHRtbD4iLApAQCAtMTEwNSwxMyArMTEwNSwxMyBAQCBzdGF0aWMgdm9pZCB0ZXN0V2Vi Vmlld1BhZ2VWaXNpYmlsaXR5KFdlYlZpZXdUZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQogICAg IHRlc3QtPndhaXRVbnRpbExvYWRGaW5pc2hlZCgpOwogCiAgICAgR093blB0cjxHRXJyb3I+IGVy cm9yOwotICAgIFdlYktpdEphdmFzY3JpcHRSZXN1bHQqIGphdmFzY3JpcHRSZXN1bHQgPSB0ZXN0 LT5ydW5KYXZhU2NyaXB0QW5kV2FpdFVudGlsRmluaXNoZWQoImRvY3VtZW50LndlYmtpdFZpc2li aWxpdHlTdGF0ZTsiLCAmZXJyb3Iub3V0UHRyKCkpOworICAgIFdlYktpdEphdmFzY3JpcHRSZXN1 bHQqIGphdmFzY3JpcHRSZXN1bHQgPSB0ZXN0LT5ydW5KYXZhU2NyaXB0QW5kV2FpdFVudGlsRmlu aXNoZWQoImRvY3VtZW50LnZpc2liaWxpdHlTdGF0ZTsiLCAmZXJyb3Iub3V0UHRyKCkpOwogICAg IGdfYXNzZXJ0KGphdmFzY3JpcHRSZXN1bHQpOwogICAgIGdfYXNzZXJ0KCFlcnJvci5nZXQoKSk7 CiAgICAgR093blB0cjxjaGFyPiB2YWx1ZVN0cmluZyhXZWJWaWV3VGVzdDo6amF2YXNjcmlwdFJl c3VsdFRvQ1N0cmluZyhqYXZhc2NyaXB0UmVzdWx0KSk7CiAgICAgZ19hc3NlcnRfY21wc3RyKHZh bHVlU3RyaW5nLmdldCgpLCA9PSwgImhpZGRlbiIpOwogCi0gICAgamF2YXNjcmlwdFJlc3VsdCA9 IHRlc3QtPnJ1bkphdmFTY3JpcHRBbmRXYWl0VW50aWxGaW5pc2hlZCgiZG9jdW1lbnQud2Via2l0 SGlkZGVuOyIsICZlcnJvci5vdXRQdHIoKSk7CisgICAgamF2YXNjcmlwdFJlc3VsdCA9IHRlc3Qt PnJ1bkphdmFTY3JpcHRBbmRXYWl0VW50aWxGaW5pc2hlZCgiZG9jdW1lbnQuaGlkZGVuOyIsICZl cnJvci5vdXRQdHIoKSk7CiAgICAgZ19hc3NlcnQoamF2YXNjcmlwdFJlc3VsdCk7CiAgICAgZ19h c3NlcnQoIWVycm9yLmdldCgpKTsKICAgICBnX2Fzc2VydChXZWJWaWV3VGVzdDo6amF2YXNjcmlw dFJlc3VsdFRvQm9vbGVhbihqYXZhc2NyaXB0UmVzdWx0KSk7CkBAIC0xMTIwLDEzICsxMTIwLDEz IEBAIHN0YXRpYyB2b2lkIHRlc3RXZWJWaWV3UGFnZVZpc2liaWxpdHkoV2ViVmlld1Rlc3QqIHRl c3QsIGdjb25zdHBvaW50ZXIpCiAgICAgdGVzdC0+c2hvd0luV2luZG93KCk7CiAgICAgdGVzdC0+ d2FpdFVudGlsVGl0bGVDaGFuZ2VkKCk7CiAKLSAgICBqYXZhc2NyaXB0UmVzdWx0ID0gdGVzdC0+ cnVuSmF2YVNjcmlwdEFuZFdhaXRVbnRpbEZpbmlzaGVkKCJkb2N1bWVudC53ZWJraXRWaXNpYmls aXR5U3RhdGU7IiwgJmVycm9yLm91dFB0cigpKTsKKyAgICBqYXZhc2NyaXB0UmVzdWx0ID0gdGVz dC0+cnVuSmF2YVNjcmlwdEFuZFdhaXRVbnRpbEZpbmlzaGVkKCJkb2N1bWVudC52aXNpYmlsaXR5 U3RhdGU7IiwgJmVycm9yLm91dFB0cigpKTsKICAgICBnX2Fzc2VydChqYXZhc2NyaXB0UmVzdWx0 KTsKICAgICBnX2Fzc2VydCghZXJyb3IuZ2V0KCkpOwogICAgIHZhbHVlU3RyaW5nLnNldChXZWJW aWV3VGVzdDo6amF2YXNjcmlwdFJlc3VsdFRvQ1N0cmluZyhqYXZhc2NyaXB0UmVzdWx0KSk7CiAg ICAgZ19hc3NlcnRfY21wc3RyKHZhbHVlU3RyaW5nLmdldCgpLCA9PSwgInZpc2libGUiKTsKIAot ICAgIGphdmFzY3JpcHRSZXN1bHQgPSB0ZXN0LT5ydW5KYXZhU2NyaXB0QW5kV2FpdFVudGlsRmlu aXNoZWQoImRvY3VtZW50LndlYmtpdEhpZGRlbjsiLCAmZXJyb3Iub3V0UHRyKCkpOworICAgIGph dmFzY3JpcHRSZXN1bHQgPSB0ZXN0LT5ydW5KYXZhU2NyaXB0QW5kV2FpdFVudGlsRmluaXNoZWQo ImRvY3VtZW50LmhpZGRlbjsiLCAmZXJyb3Iub3V0UHRyKCkpOwogICAgIGdfYXNzZXJ0KGphdmFz Y3JpcHRSZXN1bHQpOwogICAgIGdfYXNzZXJ0KCFlcnJvci5nZXQoKSk7CiAgICAgZ19hc3NlcnQo IVdlYlZpZXdUZXN0OjpqYXZhc2NyaXB0UmVzdWx0VG9Cb29sZWFuKGphdmFzY3JpcHRSZXN1bHQp KTsKQEAgLTExMzUsMTMgKzExMzUsMTMgQEAgc3RhdGljIHZvaWQgdGVzdFdlYlZpZXdQYWdlVmlz aWJpbGl0eShXZWJWaWV3VGVzdCogdGVzdCwgZ2NvbnN0cG9pbnRlcikKICAgICBndGtfd2lkZ2V0 X2hpZGUoR1RLX1dJREdFVCh0ZXN0LT5tX3dlYlZpZXcpKTsKICAgICB0ZXN0LT53YWl0VW50aWxU aXRsZUNoYW5nZWQoKTsKIAotICAgIGphdmFzY3JpcHRSZXN1bHQgPSB0ZXN0LT5ydW5KYXZhU2Ny aXB0QW5kV2FpdFVudGlsRmluaXNoZWQoImRvY3VtZW50LndlYmtpdFZpc2liaWxpdHlTdGF0ZTsi LCAmZXJyb3Iub3V0UHRyKCkpOworICAgIGphdmFzY3JpcHRSZXN1bHQgPSB0ZXN0LT5ydW5KYXZh U2NyaXB0QW5kV2FpdFVudGlsRmluaXNoZWQoImRvY3VtZW50LnZpc2liaWxpdHlTdGF0ZTsiLCAm ZXJyb3Iub3V0UHRyKCkpOwogICAgIGdfYXNzZXJ0KGphdmFzY3JpcHRSZXN1bHQpOwogICAgIGdf YXNzZXJ0KCFlcnJvci5nZXQoKSk7CiAgICAgdmFsdWVTdHJpbmcuc2V0KFdlYlZpZXdUZXN0Ojpq YXZhc2NyaXB0UmVzdWx0VG9DU3RyaW5nKGphdmFzY3JpcHRSZXN1bHQpKTsKICAgICBnX2Fzc2Vy dF9jbXBzdHIodmFsdWVTdHJpbmcuZ2V0KCksID09LCAiaGlkZGVuIik7CiAKLSAgICBqYXZhc2Ny aXB0UmVzdWx0ID0gdGVzdC0+cnVuSmF2YVNjcmlwdEFuZFdhaXRVbnRpbEZpbmlzaGVkKCJkb2N1 bWVudC53ZWJraXRIaWRkZW47IiwgJmVycm9yLm91dFB0cigpKTsKKyAgICBqYXZhc2NyaXB0UmVz dWx0ID0gdGVzdC0+cnVuSmF2YVNjcmlwdEFuZFdhaXRVbnRpbEZpbmlzaGVkKCJkb2N1bWVudC5o aWRkZW47IiwgJmVycm9yLm91dFB0cigpKTsKICAgICBnX2Fzc2VydChqYXZhc2NyaXB0UmVzdWx0 KTsKICAgICBnX2Fzc2VydCghZXJyb3IuZ2V0KCkpOwogICAgIGdfYXNzZXJ0KFdlYlZpZXdUZXN0 OjpqYXZhc2NyaXB0UmVzdWx0VG9Cb29sZWFuKGphdmFzY3JpcHRSZXN1bHQpKTsK