120401 2013-08-28 03:53:12 -0700 [GTK][WTR] Several editing/selection tests are flaky as ClickCounter is not reset between test runs 2014-04-08 08:36:39 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 122551 Gtk, LayoutTestFailure P2 Normal --- 120458 1 spena spena ap cgarcia commit-queue eocanha gustavo mrobinson rego sam oldest_to_newest 921918 0 spena 2013-08-28 03:53:12 -0700 WebKitWebViewBase has a ClickCounter helper class to handle single-clicks, double-clicks, triple-clicks and so on: http://trac.webkit.org/browser/trunk/Source/WebCore/platform/gtk/GtkClickCounter.h WebKitTestRunner uses EventSenderProxy to create and dispatch GdkEvents with the mouse event. In TestController::resetStateToConsistentValues(), the EventSenderProxy is destroyed after every test run, which should clear existing click counts, previous click locations and other mouse event related state. However, since the internal ClickCounter is not cleared, and as it is used in webkitWebViewBaseButtonPressEvent to create NativeWebMouseEvent from the GdkEvents received, these new NativeWebMouseEvents carry the existing click count. The tests are simply flaky: when they are run in their own WebKitTestRunner, they will pass. This shouldn't affect the regular browsing behaviour, as the ClickCounter uses the event time and click location to tell whether a click is a different event or part of the previous one. However, I still think it should be fixed, as it can be misleading when analysing test results. I will now upload a patch that resets the click counter in the resetStateToConsistentValues, and also in the WEBKIT_LOAD_STARTED state. Let me know what you think. You can try this yourself by running Tools/Scripts/run-webkit-tests --repeat-each=2 --gtk -2 editing/selection/anchor-focus1.html \ editing/selection/anchor-focus2.html \ editing/selection/anchor-focus3.html \ editing/selection/block-with-positioned-lastchild.html \ editing/selection/caret-after-keypress.html \ editing/selection/crash-on-shift-click.html \ editing/selection/doubleclick-beside-cr-span.html \ editing/selection/doubleclick-crash.html \ editing/selection/doubleclick-inline-first-last-contenteditable.html \ editing/selection/doubleclick-whitespace.html \ editing/selection/drag-select-1.html \ editing/selection/drag-select-rapidly.html \ editing/selection/drag-start-event-client-x-y.html \ editing/selection/editable-links.html \ editing/selection/expanding-selections.html \ editing/selection/expanding-selections2.html \ editing/selection/fake-doubleclick.html \ editing/selection/fake-drag.html \ editing/selection/focus-and-display-none.html \ editing/selection/focus-crash.html \ editing/selection/hit-test-anonymous.html \ editing/selection/hit-test-on-text-with-line-height.html \ editing/selection/inline-closest-leaf-child.html \ editing/selection/last-empty-inline.html \ editing/selection/mixed-editability-1.html \ editing/selection/move-begin-end.html \ editing/selection/paragraph-granularity.html \ editing/selection/rtl-move-selection-right-left.html \ editing/selection/select-across-readonly-input-1.html \ editing/selection/select-across-readonly-input-2.html \ editing/selection/select-across-readonly-input-3.html \ editing/selection/select-across-readonly-input-4.html \ editing/selection/select-across-readonly-input-5.html \ editing/selection/select-all-iframe.html \ editing/selection/select-bidi-run.html \ editing/selection/select-from-textfield-outwards.html \ editing/selection/select-line-break-with-opposite-directionality.html \ editing/selection/select-out-of-editable.html \ editing/selection/select-out-of-floated-contenteditable.html \ editing/selection/select-out-of-floated-input.html \ editing/selection/select-out-of-floated-textarea.html \ editing/selection/selection-actions.html I took this list from http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20WK2%20%28Tests%29/builds/7907/steps/layout-test/logs/stdio. I removed editing/selection/empty-cell-right-click.html, which seems to cause a different issue and that I am investigating on its own. 921919 1 209863 spena 2013-08-28 04:10:35 -0700 Created attachment 209863 Patch 921920 2 commit-queue 2013-08-28 04:12:30 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 922061 3 209863 mrobinson 2013-08-28 09:47:52 -0700 Comment on attachment 209863 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209863&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1472 > + // Reset the click counter > + webkitWebViewBaseResetClickCounter(WEBKIT_WEB_VIEW_BASE(webView)); This is probably not the right time to do this. Just because a new load started doesn't mean the old page isn't active. Maybe a better time would be after the document changes. It might be hard to track this in the UI process, so perhaps it's better to wait for the first repaint that includes the new page. This should probably also be in WebKitWebViewBase. 922116 4 spena 2013-08-28 11:19:45 -0700 (In reply to comment #3) > (From update of attachment 209863 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=209863&action=review > > > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1472 > > + // Reset the click counter > > + webkitWebViewBaseResetClickCounter(WEBKIT_WEB_VIEW_BASE(webView)); > > This is probably not the right time to do this. Just because a new load started doesn't mean the old page isn't active. Maybe a better time would be after the document changes. It might be hard to track this in the UI process, so perhaps it's better to wait for the first repaint that includes the new page. This should probably also be in WebKitWebViewBase. As I explain in comment #0, that is probably the less important change: in the regular browsing, the ClickCounter is really unlikely to cause a wrong behaviour. And when WebKitTestRunner is used, webkitWebViewLoadChanged is never reached. So I wonder what's your opinion on the other changes in the patch: do you think that could be a good approach? (Of course, I will address your comment as well) 929617 5 211757 spena 2013-09-16 03:51:17 -0700 Created attachment 211757 Patch Removed the call to reset ClickCounter from the WebKitWebView 933572 6 rego 2013-09-26 10:17:37 -0700 *** Bug 121952 has been marked as a duplicate of this bug. *** 937549 7 spena 2013-10-08 09:34:27 -0700 OK: I've talked to Martin, and he agrees to have this split into two issues. We would file a new bug for the issue in the general case, and land this fix for the layout tests. 937582 8 211757 mrobinson 2013-10-08 10:30:34 -0700 Comment on attachment 211757 Patch Looks good to me, but I think a WK2 owner needs to verify the changes to platform independent code. 937903 9 spena 2013-10-09 06:38:00 -0700 (In reply to comment #8) > (From update of attachment 211757 [details]) > Looks good to me, but I think a WK2 owner needs to verify the changes to platform independent code. Sam, Alexey, could any of you take a look at the changes in Tools/WebKitTestRunner/PlatformWebView.h and Tools/WebKitTestRunner/TestController.cpp? Thanks! 938193 10 ap 2013-10-09 20:24:51 -0700 Could you please clarify why this is a responsibility of WKTR? On the face of it, it seems that the counter should be reset during regular page navigations, so the fix would be in WebKit2/gtk. 938235 11 spena 2013-10-10 00:51:41 -0700 (In reply to comment #10) > Could you please clarify why this is a responsibility of WKTR? On the face of it, it seems that the counter should be reset during regular page navigations, so the fix would be in WebKit2/gtk. You are right: the proper fix would be in WebKit2/GTK (we filed bug #122551 about it), but I thought of this as a partial fix that would get the layout tests working properly again. Fixing it in WebKit2/GTK was the first approach I tried -unsuccessfully-, but I am not sure where exactly it makes sense to proceed and reset it (see also Martin's comment #3). I don't mind trying again, but would appreciate some suggestions about where/when to handle this and reset the counter. 938376 12 211757 ap 2013-10-10 09:26:19 -0700 Comment on attachment 211757 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211757&action=review I'm OK with landing this change. > Tools/WebKitTestRunner/TestController.cpp:635 > +#if PLATFORM(GTK) > + m_mainWebView->resetStateToConsistentValues(); > +#endif Perhaps this should be named less generally if we don't expect more code in the reset function - and we don't. I'd just call this resetGtkClickCounter(), and add a FIXME pointing to bug 122551. 998368 13 mrobinson 2014-04-07 19:01:51 -0700 We need to get the tests running, so let's just land this and figure out a better way to fix it later. 998369 14 211757 mrobinson 2014-04-07 19:02:10 -0700 Comment on attachment 211757 Patch This also needs to unskip the tests. 998452 15 ap 2014-04-07 23:21:53 -0700 Why is this needed, given that bug 122551 is already fixed? That bug was supposed to fix this for real, as opposed to this workaround. 998510 16 spena 2014-04-08 02:28:42 -0700 I will try to talk to Quique, who fixed bug #122551, and see if this patch is still needed. 998545 17 spena 2014-04-08 06:23:48 -0700 I have just talked to Quique and he showed me https://bugs.webkit.org/show_bug.cgi?id=122551#c7. According to that comment, his patch in bug #122551 addressed this problem in the proper way, so the patch here shouldn't be needed any more. I will still try to see if the patch here makes any difference: if it doesn't, we can clear the flags and close it. 998571 18 mrobinson 2014-04-08 08:27:23 -0700 It look like the patch for 122551 did not actually unskip the tests. *** This bug has been marked as a duplicate of bug 122551 *** 998577 19 211757 spena 2014-04-08 08:36:39 -0700 Comment on attachment 211757 Patch Clearing the flags. 209863 2013-08-28 04:10:35 -0700 2013-09-16 03:51:11 -0700 Patch bug-120401-20130828121011.patch text/plain 9241 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0NzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjgyZDEzMjU0MzhiNzRh MjZiZWUzNGY4MTM1NTc5NTBiMWQzNGM3Yy4uZjllMTcwMjIxYjY5NDU5OTQ2ZDk4ZTIxNjAyOWYy MDAzMWJiZGJhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQwIEBACisyMDEzLTA4LTI4ICBTaW1v biBQZW5hICA8c2ltb24ucGVuYUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbR1RLXVtXVFJdIFNl dmVyYWwgZWRpdGluZy9zZWxlY3Rpb24gdGVzdHMgYXJlIGZsYWt5IGFzIENsaWNrQ291bnRlciBp cyBub3QgcmVzZXQgYmV0d2VlbiB0ZXN0IHJ1bnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDQwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEluIEdUSywgRXZlbnRTZW5kZXJQcm94eSBjcmVhdGVzIGZh a2UgR2RrRXZlbnRzIHRvIHNpbXVsYXRlCisgICAgICAgIHNpbmdsZSwgZG91YmxlIG9yIHRyaXBs ZSBjbGlja3MuIFRoaXMgZXZlbnRzIGFyZSBsYXRlciBjb252ZXJ0ZWQKKyAgICAgICAgaW50byBO YXRpdmVXZWJNb3VzZUV2ZW50cyBpbiBXZWJLaXRXZWJWaWV3QmFzZSwgdXNpbmcgYQorICAgICAg ICBDbGlja0NvdW50ZXIuCisKKyAgICAgICAgV2hpbGUgYWxsIHRoZSBlbGVtZW50cyB0aGF0IGtl ZXAgdGhlIHN0YXRlIHJlZ2FyZGluZworICAgICAgICBFdmVudFNlbmRlclByb3h5IGFyZSBjbGVh cmVkIGluCisgICAgICAgIFRlc3RDb250cm9sbGVyOjpyZXNldFN0YXRlVG9Db25zaXN0ZW50VmFs dWVzLCB0aGUgQ2xpY2tDb3VudGVyCisgICAgICAgIG9iamVjdCBvZiB0aGUgV2ViS2l0V2ViVmll d0Jhc2UgaXMgbm90IHJlc2V0LCB3aGljaCBsZWFkcyB0byBzb21lCisgICAgICAgIHRlc3RzIGJl aW5nIGZsYWt5LCBhcyB0aGVpciBtb3VzZSBldmVudHMgYXJlIGluY29ycmVjdGx5IHRyZWF0ZWQs CisgICAgICAgIGhhdmluZyB0aGUgd3JvbmcgbnVtYmVyIG9mIGNsaWNrcy4KKworICAgICAgICBB ZGQgYSBtZXRob2QgdG8gcmVzZXQgdGhlIGNsaWNrIGNvdW50ZXIgdG8gdGhlIFdlYktpdFdlYlZp ZXdCYXNlLAorICAgICAgICBhcyB3ZWxsIGFzIHByaXZhdGUgQVBJIHRvIHJlc2V0IHRoZSBXS1Zp ZXcgc3RhdGUgdG8gYSBjb25zaXN0ZW50CisgICAgICAgIHZhbHVlLgorCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9DL2d0ay9XS1ZpZXcuY3BwOgorICAgICAgICAoV0tWaWV3UmVzZXRTdGF0ZVRv Q29uc2lzdGVudFZhbHVlcyk6IEFkZGVkIG1ldGhvZCB0aGF0IGNhbGxzCisgICAgICAgIHdlYmtp dFdlYlZpZXdCYXNlUmVzZXRDbGlja0NvdW50ZXIuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9D L2d0ay9XS1ZpZXdQcml2YXRlLmg6IEV4cG9ydCBhIHByaXZhdGUgbWV0aG9kCisgICAgICAgIGFs bG93aW5nIHRvIHJlc2V0IHRoZSBzdGF0ZS4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRXZWJWaWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdFdlYlZpZXdMb2FkQ2hhbmdlZCk6IFJl c2V0IHRoZSBjbGljayBjb3VudGVyIHdoZW4gd2Ugc3RhcnQKKyAgICAgICAgbG9hZGluZy4KKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHA6CisgICAgICAg ICh3ZWJraXRXZWJWaWV3QmFzZVJlc2V0Q2xpY2tDb3VudGVyKTogSW1wbGVtZW50IGEgcHJpdmF0 ZSBtZXRob2QgdGhhdAorICAgICAgICByZXNldHMgdGhlIGNsaWNrIGNvdW50ZXIuCisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlLmg6IERlY2xhcmUg YSBwcml2YXRlCisgICAgICAgIG1ldGhvZCB0byByZXNldCB0aGUgY2xpY2sgY291bnRlci4KKwog MjAxMy0wOC0yOCAgQWxleGFuZHJlIEFicmV1ICA8YWxleGFuZHJlLmFicmV1QGNhbm9uaWNhbC5j b20+CiAKICAgICAgICAgQWRkIGEgJ2lzTWFpbkZyYW1lJyBwYXJhbWV0ZXIgdG8gUVdlYk5hdmln YXRpb25SZXF1ZXN0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9D L2d0ay9XS1ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL2d0ay9XS1Zp ZXcuY3BwCmluZGV4IDNlNjlhOTkwOGVjZGM0NmZmYzk5ZjQ4ZjhmZWU0NGYxY2YyMDk4NWEuLjQ4 NWQ2NWMyZWVmZTYwYjBiYWZhZDg3MWVkOTI1OGY4YTNlNDNhOWMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9ndGsvV0tWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL0MvZ3RrL1dLVmlldy5jcHAKQEAgLTQ5LDMgKzQ5LDggQEAgdm9p ZCBXS1ZpZXdTZXRGb2N1cyhXS1ZpZXdSZWYgdmlld1JlZiwgYm9vbCBmb2N1c2VkKQogewogICAg IHdlYmtpdFdlYlZpZXdCYXNlU2V0Rm9jdXModG9JbXBsKHZpZXdSZWYpLCBmb2N1c2VkKTsKIH0K Kwordm9pZCBXS1ZpZXdSZXNldFN0YXRlVG9Db25zaXN0ZW50VmFsdWVzKFdLVmlld1JlZiB2aWV3 UmVmKQoreworICAgIHdlYmtpdFdlYlZpZXdCYXNlUmVzZXRDbGlja0NvdW50ZXIodG9JbXBsKHZp ZXdSZWYpKTsKK30KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9n dGsvV0tWaWV3UHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL2d0ay9X S1ZpZXdQcml2YXRlLmgKaW5kZXggMmMxYjJkMWYwZTI0Y2JiNjAzMGM4ZDBkYWRmNmM0MzUxYmZl OWM0OS4uOGQ1N2M1ZmQ4MjNlOTdmOTAxNzZiMjBjNGM4ZmQ3NzI1YTJlZTBkNCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL2d0ay9XS1ZpZXdQcml2YXRlLmgKKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL2d0ay9XS1ZpZXdQcml2YXRlLmgKQEAg LTM0LDYgKzM0LDggQEAgZXh0ZXJuICJDIiB7CiAKIFdLX0VYUE9SVCB2b2lkIFdLVmlld1NldEZv Y3VzKFdLVmlld1JlZiB2aWV3UmVmLCBib29sIGZvY3VzZWQpOwogCitXS19FWFBPUlQgdm9pZCBX S1ZpZXdSZXNldFN0YXRlVG9Db25zaXN0ZW50VmFsdWVzKFdLVmlld1JlZiB2aWV3UmVmKTsKKwog I2lmZGVmIF9fY3BsdXNwbHVzCiB9CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAKaW5kZXggNzJmZTY2YTQyZWFkMjJmYWYy ZDlhNDg1YTk5MTIyNTMyNjIyZmVkMi4uNDBiZTAyNmQzM2RhM2NlMjY0YjZlODRkNzlkOWFkN2Ix NmExNDk5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2Vi S2l0V2ViVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2Vi S2l0V2ViVmlldy5jcHAKQEAgLTE0NjcsNiArMTQ2Nyw5IEBAIHZvaWQgd2Via2l0V2ViVmlld0xv YWRDaGFuZ2VkKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIFdlYktpdExvYWRFdmVudCBsb2FkRXZl bnQpCiAgICAgICAgIHByaXYtPmxvYWRpbmdSZXNvdXJjZXNNYXAuY2xlYXIoKTsKICAgICAgICAg cHJpdi0+bWFpblJlc291cmNlID0gMDsKICAgICAgICAgcHJpdi0+d2FpdGluZ0Zvck1haW5SZXNv dXJjZSA9IGZhbHNlOworCisgICAgICAgIC8vIFJlc2V0IHRoZSBjbGljayBjb3VudGVyCisgICAg ICAgIHdlYmtpdFdlYlZpZXdCYXNlUmVzZXRDbGlja0NvdW50ZXIoV0VCS0lUX1dFQl9WSUVXX0JB U0Uod2ViVmlldykpOwogICAgIH0gZWxzZSBpZiAobG9hZEV2ZW50ID09IFdFQktJVF9MT0FEX0NP TU1JVFRFRCkgewogICAgICAgICBXZWJLaXRGYXZpY29uRGF0YWJhc2UqIGRhdGFiYXNlID0gd2Vi a2l0X3dlYl9jb250ZXh0X2dldF9mYXZpY29uX2RhdGFiYXNlKHByaXYtPmNvbnRleHQpOwogICAg ICAgICBHT3duUHRyPGNoYXI+IGZhdmljb25VUkkod2Via2l0X2Zhdmljb25fZGF0YWJhc2VfZ2V0 X2Zhdmljb25fdXJpKGRhdGFiYXNlLCBwcml2LT5hY3RpdmVVUkkuZGF0YSgpKSk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5j cHAKaW5kZXggYTQxNDkyMGIxMDE2NjNkYWQyYmM5ODBjNTgzODQ1NDVjOTgwMDM5Yi4uYjkyODVj YTQ4YmEwYmI1ZWZlNjIzM2E1NzQ0OTY4M2ZhZmRmZjk2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcApAQCAtMTEw MywzICsxMTAzLDggQEAgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZVVwZGF0ZVRleHRJbnB1dFN0YXRl KFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJraXRXZWJWaWV3QmFzZSkKIHsKICAgICB3ZWJraXRXZWJW aWV3QmFzZS0+cHJpdi0+aW5wdXRNZXRob2RGaWx0ZXIuc2V0Q3Vyc29yUmVjdCh3ZWJraXRXZWJW aWV3QmFzZS0+cHJpdi0+cGFnZVByb3h5LT5lZGl0b3JTdGF0ZSgpLmN1cnNvclJlY3QpOwogfQor Cit2b2lkIHdlYmtpdFdlYlZpZXdCYXNlUmVzZXRDbGlja0NvdW50ZXIoV2ViS2l0V2ViVmlld0Jh c2UqIHdlYmtpdFdlYlZpZXdCYXNlKQoreworICAgIHdlYmtpdFdlYlZpZXdCYXNlLT5wcml2LT5j bGlja0NvdW50ZXIucmVzZXQoKTsKK30KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlUHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlLmgKaW5kZXggZTMwZmQ5 NDllY2I5ZmFjMTRiNGZiZmQzYWM5NTRhODA1YWYwMGFiNS4uNzQwYWU3NWM2MmMxMTVjNTkyZGVi MGJjYWViYTE0OTk1MWU0MDY3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlLmgKQEAgLTY5LDUgKzY5 LDYgQEAgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZUhhbmRsZURvd25sb2FkUmVxdWVzdChXZWJLaXRX ZWJWaWV3QmFzZSosIFdlYktpdDo6RG93bmxvYWQKIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VBZGRB dXRoZW50aWNhdGlvbkRpYWxvZyhXZWJLaXRXZWJWaWV3QmFzZSosIEd0a1dpZGdldCogYXV0aERp YWxvZyk7CiB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlQ2FuY2VsQXV0aGVudGljYXRpb25EaWFsb2co V2ViS2l0V2ViVmlld0Jhc2UqKTsKIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VBZGRXZWJJbnNwZWN0 b3IoV2ViS2l0V2ViVmlld0Jhc2UqLCBHdGtXaWRnZXQqIGluc3BlY3Rvcik7Cit2b2lkIHdlYmtp dFdlYlZpZXdCYXNlUmVzZXRDbGlja0NvdW50ZXIoV2ViS2l0V2ViVmlld0Jhc2UqKTsKIAogI2Vu ZGlmIC8vIFdlYktpdFdlYlZpZXdCYXNlUHJpdmF0ZV9oCmRpZmYgLS1naXQgYS9Ub29scy9DaGFu Z2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWIyMGI0ZDIwNDE2ODk0ODIwODhhYzQwNTU2 MzBmZTE3Y2EyZTRhNC4uZDM2ODA2MGI1NjA4YzA0NjE3OGYzMTQ2YzM4ZTBjMTJlM2Y5MjBmNyAx MDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDM1IEBACisyMDEzLTA4LTI4ICBTaW1vbiBQZW5hICA8c2ltb24ucGVuYUBzYW1zdW5nLmNv bT4KKworICAgICAgICBbR1RLXVtXVFJdIFNldmVyYWwgZWRpdGluZy9zZWxlY3Rpb24gdGVzdHMg YXJlIGZsYWt5IGFzIENsaWNrQ291bnRlciBpcyBub3QgcmVzZXQgYmV0d2VlbiB0ZXN0IHJ1bnMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDQwMQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIEdUSywg RXZlbnRTZW5kZXJQcm94eSBjcmVhdGVzIGZha2UgR2RrRXZlbnRzIHRvIHNpbXVsYXRlCisgICAg ICAgIHNpbmdsZSwgZG91YmxlIG9yIHRyaXBsZSBjbGlja3MuIFRoaXMgZXZlbnRzIGFyZSBsYXRl ciBjb252ZXJ0ZWQKKyAgICAgICAgaW50byBOYXRpdmVXZWJNb3VzZUV2ZW50cyBpbiBXZWJLaXRX ZWJWaWV3QmFzZSwgdXNpbmcgYQorICAgICAgICBDbGlja0NvdW50ZXIuCisKKyAgICAgICAgV2hp bGUgYWxsIHRoZSBlbGVtZW50cyB0aGF0IGtlZXAgdGhlIHN0YXRlIHJlZ2FyZGluZworICAgICAg ICBFdmVudFNlbmRlclByb3h5IGFyZSBjbGVhcmVkIGluCisgICAgICAgIFRlc3RDb250cm9sbGVy OjpyZXNldFN0YXRlVG9Db25zaXN0ZW50VmFsdWVzLCB0aGUgQ2xpY2tDb3VudGVyCisgICAgICAg IG9iamVjdCBvZiB0aGUgV2ViS2l0V2ViVmlld0Jhc2UgaXMgbm90IHJlc2V0LCB3aGljaCBsZWFk cyB0byBzb21lCisgICAgICAgIHRlc3RzIGJlaW5nIGZsYWt5LCBhcyB0aGVpciBtb3VzZSBldmVu dHMgYXJlIGluY29ycmVjdGx5IHRyZWF0ZWQsCisgICAgICAgIGhhdmluZyB0aGUgd3JvbmcgbnVt YmVyIG9mIGNsaWNrcy4KKworICAgICAgICBEZWNsYXJlIGEgR1RLLXNwZWNpZmljIG1ldGhvZCB0 aGF0IHJlc2V0cyB0aGUgUGxhdGZvcm1XZWJWaWV3CisgICAgICAgIHN0YXRlIHRvIGEgY29uc2lz dGVudCB2YWx1ZSwgYW5kIGNhbGwgaXQgZnJvbSB0aGUgVGVzdENvbnRyb2xsZXIKKyAgICAgICAg d2hlbiBkb2luZyB0aGUgZ2VuZXJpYyByZXNldC4gSW1wbGVtZW50IHRoYXQgbWV0aG9kIGJ5IGNh bGxpbmcgdGhlCisgICAgICAgIHByaXZhdGUgZ3RrIEMgQVBJLgorCisgICAgICAgICogV2ViS2l0 VGVzdFJ1bm5lci9QbGF0Zm9ybVdlYlZpZXcuaDogQ29uZGl0aW9uYWxseSBkZWNsYXJlIHRoZSBy ZXNldCBtZXRob2QuCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5j cHA6CisgICAgICAgIChXVFI6OlRlc3RDb250cm9sbGVyOjpyZXNldFN0YXRlVG9Db25zaXN0ZW50 VmFsdWVzKTogQ2FsbAorICAgICAgICByZXNldFN0YXRlIGZvciB0aGUgbWFpbldlYlZpZXcuCisg ICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9ndGsvUGxhdGZvcm1XZWJWaWV3R3RrLmNwcDoKKyAg ICAgICAgKFdUUjo6UGxhdGZvcm1XZWJWaWV3OjpyZXNldFN0YXRlVG9Db25zaXN0ZW50VmFsdWVz KTogSW1wbGVtZW50CisgICAgICAgIHRoZSBtZXRob2QgYnkgY2FsbGluZyB0aGUgcHJpdmF0ZSBD IEFQSS4KKwogMjAxMy0wOC0yNyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4K IAogICAgICAgICBbV0syXSBSZW1vdmUgVVNFX1dFQlBST0NFU1NfRVZFTlRfU0lNVUxBVElPTgpk aWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9QbGF0Zm9ybVdlYlZpZXcuaCBiL1Rv b2xzL1dlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1XZWJWaWV3LmgKaW5kZXggOThkODgyNzEwZGUy NDViM2I5MGY2ZjYyYTc2MjM3NDlmNzI4NTA0ZS4uYTZmNDA2Y2FmMjRkZmFmZGYzYjIyOTZkNmQx NWJiYzNjYTVjMDFhYyAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9QbGF0Zm9y bVdlYlZpZXcuaAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1BsYXRmb3JtV2ViVmlldy5o CkBAIC03Nyw2ICs3NywxMCBAQCBwdWJsaWM6CiAgICAgdm9pZCByZXNpemVUbyh1bnNpZ25lZCB3 aWR0aCwgdW5zaWduZWQgaGVpZ2h0KTsKICAgICB2b2lkIGZvY3VzKCk7CiAKKyNpZiBQTEFURk9S TShHVEspCisgICAgdm9pZCByZXNldFN0YXRlVG9Db25zaXN0ZW50VmFsdWVzKCk7CisjZW5kaWYK KwogI2lmIFBMQVRGT1JNKFFUKQogICAgIGJvb2wgc2VuZEV2ZW50KFFFdmVudCopOwogICAgIHZv aWQgcG9zdEV2ZW50KFFFdmVudCopOwpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5l ci9UZXN0Q29udHJvbGxlci5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9s bGVyLmNwcAppbmRleCBkNjkxYWNkMDUyMjY0Yjk4OTkwYzllNGVmODFlZDQ4ZWJjYWE2OTIxLi5i OTAxNDExZjMyZWUwZTMxZWY4OTczNmVjZGQ0NTFhNzhjY2U2ZTZkIDEwMDY0NAotLS0gYS9Ub29s cy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAorKysgYi9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcApAQCAtNjMwLDYgKzYzMCwxMCBAQCBib29sIFRl c3RDb250cm9sbGVyOjpyZXNldFN0YXRlVG9Db25zaXN0ZW50VmFsdWVzKCkKICAgICAvLyBSZXNl dCBtYWluIHBhZ2UgYmFjayB0byBhYm91dDpibGFuawogICAgIG1fZG9uZVJlc2V0dGluZyA9IGZh bHNlOwogCisjaWYgUExBVEZPUk0oR1RLKQorICAgIG1fbWFpbldlYlZpZXctPnJlc2V0U3RhdGVU b0NvbnNpc3RlbnRWYWx1ZXMoKTsKKyNlbmRpZgorCiAgICAgV0tQYWdlTG9hZFVSTChtX21haW5X ZWJWaWV3LT5wYWdlKCksIGJsYW5rVVJMKCkpOwogICAgIHJ1blVudGlsKG1fZG9uZVJlc2V0dGlu ZywgU2hvcnRUaW1lb3V0KTsKICAgICByZXR1cm4gbV9kb25lUmVzZXR0aW5nOwpkaWZmIC0tZ2l0 IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9ndGsvUGxhdGZvcm1XZWJWaWV3R3RrLmNwcCBiL1Rv b2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL1BsYXRmb3JtV2ViVmlld0d0ay5jcHAKaW5kZXggZmQ2 Zjg0NjZiNDk2YTE3YWQ4NWY0ZDFmZDUzOWIwMjhlOWE0NjNkZC4uMTkyODZkNjExZmZmNGU1NWVj NTAwYjg5MTM1N2QxMDg2ZGQzMzAxYyAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5l ci9ndGsvUGxhdGZvcm1XZWJWaWV3R3RrLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVy L2d0ay9QbGF0Zm9ybVdlYlZpZXdHdGsuY3BwCkBAIC0xMjUsNSArMTI1LDEwIEBAIHZvaWQgUGxh dGZvcm1XZWJWaWV3OjpkaWRJbml0aWFsaXplQ2xpZW50cygpCiB7CiB9CiAKK3ZvaWQgUGxhdGZv cm1XZWJWaWV3OjpyZXNldFN0YXRlVG9Db25zaXN0ZW50VmFsdWVzKCkKK3sKKyAgICBXS1ZpZXdS ZXNldFN0YXRlVG9Db25zaXN0ZW50VmFsdWVzKG1fdmlldyk7Cit9CisKIH0gLy8gbmFtZXNwYWNl IFdUUgogCg== 211757 2013-09-16 03:51:17 -0700 2014-04-08 08:36:38 -0700 Patch bug-120401-20130916115052.patch text/plain 8285 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1ODQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODJmZjI0YjBjMzc0YWE0 MTcxN2I1Y2UzNWFlMTZmMWI2ZTAwZDhjZi4uMWY4MGI5MTk0ODAxNDhmNWQwNDI5ODNlN2MxMjUx MTkyZTEzZGNlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM3IEBACisyMDEzLTA4LTI4ICBTaW1v biBQZW5hICA8c2ltb24ucGVuYUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbR1RLXVtXVFJdIFNl dmVyYWwgZWRpdGluZy9zZWxlY3Rpb24gdGVzdHMgYXJlIGZsYWt5IGFzIENsaWNrQ291bnRlciBp cyBub3QgcmVzZXQgYmV0d2VlbiB0ZXN0IHJ1bnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDQwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEluIEdUSywgRXZlbnRTZW5kZXJQcm94eSBjcmVhdGVzIGZh a2UgR2RrRXZlbnRzIHRvIHNpbXVsYXRlCisgICAgICAgIHNpbmdsZSwgZG91YmxlIG9yIHRyaXBs ZSBjbGlja3MuIFRoaXMgZXZlbnRzIGFyZSBsYXRlciBjb252ZXJ0ZWQKKyAgICAgICAgaW50byBO YXRpdmVXZWJNb3VzZUV2ZW50cyBpbiBXZWJLaXRXZWJWaWV3QmFzZSwgdXNpbmcgYQorICAgICAg ICBDbGlja0NvdW50ZXIuCisKKyAgICAgICAgV2hpbGUgYWxsIHRoZSBlbGVtZW50cyB0aGF0IGtl ZXAgdGhlIHN0YXRlIHJlZ2FyZGluZworICAgICAgICBFdmVudFNlbmRlclByb3h5IGFyZSBjbGVh cmVkIGluCisgICAgICAgIFRlc3RDb250cm9sbGVyOjpyZXNldFN0YXRlVG9Db25zaXN0ZW50VmFs dWVzLCB0aGUgQ2xpY2tDb3VudGVyCisgICAgICAgIG9iamVjdCBvZiB0aGUgV2ViS2l0V2ViVmll d0Jhc2UgaXMgbm90IHJlc2V0LCB3aGljaCBsZWFkcyB0byBzb21lCisgICAgICAgIHRlc3RzIGJl aW5nIGZsYWt5LCBhcyB0aGVpciBtb3VzZSBldmVudHMgYXJlIGluY29ycmVjdGx5IHRyZWF0ZWQs CisgICAgICAgIGhhdmluZyB0aGUgd3JvbmcgbnVtYmVyIG9mIGNsaWNrcy4KKworICAgICAgICBB ZGQgYSBtZXRob2QgdG8gcmVzZXQgdGhlIGNsaWNrIGNvdW50ZXIgdG8gdGhlIFdlYktpdFdlYlZp ZXdCYXNlLAorICAgICAgICBhcyB3ZWxsIGFzIHByaXZhdGUgQVBJIHRvIHJlc2V0IHRoZSBXS1Zp ZXcgc3RhdGUgdG8gYSBjb25zaXN0ZW50CisgICAgICAgIHZhbHVlLgorCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9DL2d0ay9XS1ZpZXcuY3BwOgorICAgICAgICAoV0tWaWV3UmVzZXRTdGF0ZVRv Q29uc2lzdGVudFZhbHVlcyk6IEFkZGVkIG1ldGhvZCB0aGF0IGNhbGxzCisgICAgICAgIHdlYmtp dFdlYlZpZXdCYXNlUmVzZXRDbGlja0NvdW50ZXIuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9D L2d0ay9XS1ZpZXdQcml2YXRlLmg6IEV4cG9ydCBhIHByaXZhdGUgbWV0aG9kCisgICAgICAgIGFs bG93aW5nIHRvIHJlc2V0IHRoZSBzdGF0ZS4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRXZWJWaWV3QmFzZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZVJlc2V0Q2xp Y2tDb3VudGVyKTogSW1wbGVtZW50IGEgcHJpdmF0ZSBtZXRob2QgdGhhdAorICAgICAgICByZXNl dHMgdGhlIGNsaWNrIGNvdW50ZXIuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0 V2ViVmlld0Jhc2VQcml2YXRlLmg6IERlY2xhcmUgYSBwcml2YXRlCisgICAgICAgIG1ldGhvZCB0 byByZXNldCB0aGUgY2xpY2sgY291bnRlci4KKwogMjAxMy0wOS0xNiAgV29qY2llY2ggQmllbGF3 c2tpICA8dy5iaWVsYXdza2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW1dLVFJdIFdlYktpdFRl c3RSdW5uZXIncyBldmVudFNlbmRlci5jb250ZXh0Q2xpY2soKSByZXR1cm5zIG9iamVjdHMgd2l0 aG91dCBpbXBsZW1lbnRlZCBjbGljaygpIG1ldGhvZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQy9ndGsvV0tWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvQy9ndGsvV0tWaWV3LmNwcAppbmRleCAzZTY5YTk5MDhlY2RjNDZmZmM5OWY0OGY4 ZmVlNDRmMWNmMjA5ODVhLi40ODVkNjVjMmVlZmU2MGIwYmFmYWQ4NzFlZDkyNThmOGEzZTQzYTlj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvZ3RrL1dLVmlldy5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL2d0ay9XS1ZpZXcuY3BwCkBA IC00OSwzICs0OSw4IEBAIHZvaWQgV0tWaWV3U2V0Rm9jdXMoV0tWaWV3UmVmIHZpZXdSZWYsIGJv b2wgZm9jdXNlZCkKIHsKICAgICB3ZWJraXRXZWJWaWV3QmFzZVNldEZvY3VzKHRvSW1wbCh2aWV3 UmVmKSwgZm9jdXNlZCk7CiB9CisKK3ZvaWQgV0tWaWV3UmVzZXRTdGF0ZVRvQ29uc2lzdGVudFZh bHVlcyhXS1ZpZXdSZWYgdmlld1JlZikKK3sKKyAgICB3ZWJraXRXZWJWaWV3QmFzZVJlc2V0Q2xp Y2tDb3VudGVyKHRvSW1wbCh2aWV3UmVmKSk7Cit9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL0MvZ3RrL1dLVmlld1ByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvQy9ndGsvV0tWaWV3UHJpdmF0ZS5oCmluZGV4IDJjMWIyZDFmMGUyNGNiYjYw MzBjOGQwZGFkZjZjNDM1MWJmZTljNDkuLjhkNTdjNWZkODIzZTk3ZjkwMTc2YjIwYzRjOGZkNzcy NWEyZWUwZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9ndGsv V0tWaWV3UHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9ndGsv V0tWaWV3UHJpdmF0ZS5oCkBAIC0zNCw2ICszNCw4IEBAIGV4dGVybiAiQyIgewogCiBXS19FWFBP UlQgdm9pZCBXS1ZpZXdTZXRGb2N1cyhXS1ZpZXdSZWYgdmlld1JlZiwgYm9vbCBmb2N1c2VkKTsK IAorV0tfRVhQT1JUIHZvaWQgV0tWaWV3UmVzZXRTdGF0ZVRvQ29uc2lzdGVudFZhbHVlcyhXS1Zp ZXdSZWYgdmlld1JlZik7CisKICNpZmRlZiBfX2NwbHVzcGx1cwogfQogI2VuZGlmCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5j cHAKaW5kZXggNGYwZjFlNTEyYmU2YmMwNzQwN2MyOGVmMGM1ZWQ2NjIzYzMwYWY0MC4uMzllODM0 ODE1MTIwYTc4NzJiMWZiZmQwM2I0M2YyZjEyYzgzMWYxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcApAQCAtMTEx MiwzICsxMTEyLDggQEAgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZVVwZGF0ZVRleHRJbnB1dFN0YXRl KFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJraXRXZWJWaWV3QmFzZSkKIHsKICAgICB3ZWJraXRXZWJW aWV3QmFzZS0+cHJpdi0+aW5wdXRNZXRob2RGaWx0ZXIuc2V0Q3Vyc29yUmVjdCh3ZWJraXRXZWJW aWV3QmFzZS0+cHJpdi0+cGFnZVByb3h5LT5lZGl0b3JTdGF0ZSgpLmN1cnNvclJlY3QpOwogfQor Cit2b2lkIHdlYmtpdFdlYlZpZXdCYXNlUmVzZXRDbGlja0NvdW50ZXIoV2ViS2l0V2ViVmlld0Jh c2UqIHdlYmtpdFdlYlZpZXdCYXNlKQoreworICAgIHdlYmtpdFdlYlZpZXdCYXNlLT5wcml2LT5j bGlja0NvdW50ZXIucmVzZXQoKTsKK30KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlUHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlLmgKaW5kZXggZjliOGJm YTMxY2I2NjNkMzY4MzgwMzJmZTM4YWRiYWFlMTU3NjQ1MC4uNmY1ODhjMTlkZGMyMTE3MjA4MmM2 ZmZmNWM5MDkwZTQxMjBkY2U3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlLmgKQEAgLTcwLDUgKzcw LDYgQEAgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZUhhbmRsZURvd25sb2FkUmVxdWVzdChXZWJLaXRX ZWJWaWV3QmFzZSosIFdlYktpdDo6RG93bmxvYWQKIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VBZGRB dXRoZW50aWNhdGlvbkRpYWxvZyhXZWJLaXRXZWJWaWV3QmFzZSosIEd0a1dpZGdldCogYXV0aERp YWxvZyk7CiB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlQ2FuY2VsQXV0aGVudGljYXRpb25EaWFsb2co V2ViS2l0V2ViVmlld0Jhc2UqKTsKIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VBZGRXZWJJbnNwZWN0 b3IoV2ViS2l0V2ViVmlld0Jhc2UqLCBHdGtXaWRnZXQqIGluc3BlY3Rvcik7Cit2b2lkIHdlYmtp dFdlYlZpZXdCYXNlUmVzZXRDbGlja0NvdW50ZXIoV2ViS2l0V2ViVmlld0Jhc2UqKTsKIAogI2Vu ZGlmIC8vIFdlYktpdFdlYlZpZXdCYXNlUHJpdmF0ZV9oCmRpZmYgLS1naXQgYS9Ub29scy9DaGFu Z2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWRlNGU3N2YyYjlmNDFjNzYwZGE3MDIwZDg4 NTU4NzgxNDc1MzZiNC4uYTY1ZDBmZjMwMzkxODMyMGM4NzEyM2U3NjY5YjFiZTRkMzk1NjdjYyAx MDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDM1IEBACisyMDEzLTA4LTI4ICBTaW1vbiBQZW5hICA8c2ltb24ucGVuYUBzYW1zdW5nLmNv bT4KKworICAgICAgICBbR1RLXVtXVFJdIFNldmVyYWwgZWRpdGluZy9zZWxlY3Rpb24gdGVzdHMg YXJlIGZsYWt5IGFzIENsaWNrQ291bnRlciBpcyBub3QgcmVzZXQgYmV0d2VlbiB0ZXN0IHJ1bnMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMDQwMQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIEdUSywg RXZlbnRTZW5kZXJQcm94eSBjcmVhdGVzIGZha2UgR2RrRXZlbnRzIHRvIHNpbXVsYXRlCisgICAg ICAgIHNpbmdsZSwgZG91YmxlIG9yIHRyaXBsZSBjbGlja3MuIFRoaXMgZXZlbnRzIGFyZSBsYXRl ciBjb252ZXJ0ZWQKKyAgICAgICAgaW50byBOYXRpdmVXZWJNb3VzZUV2ZW50cyBpbiBXZWJLaXRX ZWJWaWV3QmFzZSwgdXNpbmcgYQorICAgICAgICBDbGlja0NvdW50ZXIuCisKKyAgICAgICAgV2hp bGUgYWxsIHRoZSBlbGVtZW50cyB0aGF0IGtlZXAgdGhlIHN0YXRlIHJlZ2FyZGluZworICAgICAg ICBFdmVudFNlbmRlclByb3h5IGFyZSBjbGVhcmVkIGluCisgICAgICAgIFRlc3RDb250cm9sbGVy OjpyZXNldFN0YXRlVG9Db25zaXN0ZW50VmFsdWVzLCB0aGUgQ2xpY2tDb3VudGVyCisgICAgICAg IG9iamVjdCBvZiB0aGUgV2ViS2l0V2ViVmlld0Jhc2UgaXMgbm90IHJlc2V0LCB3aGljaCBsZWFk cyB0byBzb21lCisgICAgICAgIHRlc3RzIGJlaW5nIGZsYWt5LCBhcyB0aGVpciBtb3VzZSBldmVu dHMgYXJlIGluY29ycmVjdGx5IHRyZWF0ZWQsCisgICAgICAgIGhhdmluZyB0aGUgd3JvbmcgbnVt YmVyIG9mIGNsaWNrcy4KKworICAgICAgICBEZWNsYXJlIGEgR1RLLXNwZWNpZmljIG1ldGhvZCB0 aGF0IHJlc2V0cyB0aGUgUGxhdGZvcm1XZWJWaWV3CisgICAgICAgIHN0YXRlIHRvIGEgY29uc2lz dGVudCB2YWx1ZSwgYW5kIGNhbGwgaXQgZnJvbSB0aGUgVGVzdENvbnRyb2xsZXIKKyAgICAgICAg d2hlbiBkb2luZyB0aGUgZ2VuZXJpYyByZXNldC4gSW1wbGVtZW50IHRoYXQgbWV0aG9kIGJ5IGNh bGxpbmcgdGhlCisgICAgICAgIHByaXZhdGUgZ3RrIEMgQVBJLgorCisgICAgICAgICogV2ViS2l0 VGVzdFJ1bm5lci9QbGF0Zm9ybVdlYlZpZXcuaDogQ29uZGl0aW9uYWxseSBkZWNsYXJlIHRoZSBy ZXNldCBtZXRob2QuCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5j cHA6CisgICAgICAgIChXVFI6OlRlc3RDb250cm9sbGVyOjpyZXNldFN0YXRlVG9Db25zaXN0ZW50 VmFsdWVzKTogQ2FsbAorICAgICAgICByZXNldFN0YXRlIGZvciB0aGUgbWFpbldlYlZpZXcuCisg ICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9ndGsvUGxhdGZvcm1XZWJWaWV3R3RrLmNwcDoKKyAg ICAgICAgKFdUUjo6UGxhdGZvcm1XZWJWaWV3OjpyZXNldFN0YXRlVG9Db25zaXN0ZW50VmFsdWVz KTogSW1wbGVtZW50CisgICAgICAgIHRoZSBtZXRob2QgYnkgY2FsbGluZyB0aGUgcHJpdmF0ZSBD IEFQSS4KKwogMjAxMy0wOS0xNiAgV29qY2llY2ggQmllbGF3c2tpICA8dy5iaWVsYXdza2lAc2Ft c3VuZy5jb20+CiAKICAgICAgICAgW1dLVFJdIFdlYktpdFRlc3RSdW5uZXIncyBldmVudFNlbmRl ci5jb250ZXh0Q2xpY2soKSByZXR1cm5zIG9iamVjdHMgd2l0aG91dCBpbXBsZW1lbnRlZCBjbGlj aygpIG1ldGhvZC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1X ZWJWaWV3LmggYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1BsYXRmb3JtV2ViVmlldy5oCmluZGV4 IGUyY2FiZmEyOWRiZmJmMzhjMGMwOThmMzM3ZmY1Mzk1MmE0YmYxOTEuLjYwY2ZiZjBkODgxMGZi YWFmMzcxZjZkOTkyNjg1NjI2MTQ1ZDc1YTEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvUGxhdGZvcm1XZWJWaWV3LmgKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9QbGF0 Zm9ybVdlYlZpZXcuaApAQCAtNzcsNiArNzcsMTAgQEAgcHVibGljOgogICAgIHZvaWQgcmVzaXpl VG8odW5zaWduZWQgd2lkdGgsIHVuc2lnbmVkIGhlaWdodCk7CiAgICAgdm9pZCBmb2N1cygpOwog CisjaWYgUExBVEZPUk0oR1RLKQorICAgIHZvaWQgcmVzZXRTdGF0ZVRvQ29uc2lzdGVudFZhbHVl cygpOworI2VuZGlmCisKICNpZiBQTEFURk9STShRVCkKICAgICBib29sIHNlbmRFdmVudChRRXZl bnQqKTsKICAgICB2b2lkIHBvc3RFdmVudChRRXZlbnQqKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5l ci9UZXN0Q29udHJvbGxlci5jcHAKaW5kZXggZDY5MWFjZDA1MjI2NGI5ODk5MGM5ZTRlZjgxZWQ0 OGViY2FhNjkyMS4uYjkwMTQxMWYzMmVlMGUzMWVmODk3MzZlY2RkNDUxYTc4Y2NlNmU2ZCAxMDA2 NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKKysrIGIv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKQEAgLTYzMCw2ICs2MzAs MTAgQEAgYm9vbCBUZXN0Q29udHJvbGxlcjo6cmVzZXRTdGF0ZVRvQ29uc2lzdGVudFZhbHVlcygp CiAgICAgLy8gUmVzZXQgbWFpbiBwYWdlIGJhY2sgdG8gYWJvdXQ6YmxhbmsKICAgICBtX2RvbmVS ZXNldHRpbmcgPSBmYWxzZTsKIAorI2lmIFBMQVRGT1JNKEdUSykKKyAgICBtX21haW5XZWJWaWV3 LT5yZXNldFN0YXRlVG9Db25zaXN0ZW50VmFsdWVzKCk7CisjZW5kaWYKKwogICAgIFdLUGFnZUxv YWRVUkwobV9tYWluV2ViVmlldy0+cGFnZSgpLCBibGFua1VSTCgpKTsKICAgICBydW5VbnRpbCht X2RvbmVSZXNldHRpbmcsIFNob3J0VGltZW91dCk7CiAgICAgcmV0dXJuIG1fZG9uZVJlc2V0dGlu ZzsKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL1BsYXRmb3JtV2ViVmll d0d0ay5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2d0ay9QbGF0Zm9ybVdlYlZpZXdHdGsu Y3BwCmluZGV4IGZkNmY4NDY2YjQ5NmExN2FkODVmNGQxZmQ1MzliMDI4ZTlhNDYzZGQuLjE5Mjg2 ZDYxMWZmZjRlNTVlYzUwMGI4OTEzNTdkMTA4NmRkMzMwMWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvZ3RrL1BsYXRmb3JtV2ViVmlld0d0ay5jcHAKKysrIGIvVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9ndGsvUGxhdGZvcm1XZWJWaWV3R3RrLmNwcApAQCAtMTI1LDUgKzEyNSwx MCBAQCB2b2lkIFBsYXRmb3JtV2ViVmlldzo6ZGlkSW5pdGlhbGl6ZUNsaWVudHMoKQogewogfQog Cit2b2lkIFBsYXRmb3JtV2ViVmlldzo6cmVzZXRTdGF0ZVRvQ29uc2lzdGVudFZhbHVlcygpCit7 CisgICAgV0tWaWV3UmVzZXRTdGF0ZVRvQ29uc2lzdGVudFZhbHVlcyhtX3ZpZXcpOworfQorCiB9 IC8vIG5hbWVzcGFjZSBXVFIKIAo=