120396 2013-08-28 01:40:12 -0700 Fix unused variable warning on WK2 in PageOverlay.h 2013-08-28 05:51:14 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abrhm webkit-unassigned commit-queue galpeter ossy oldest_to_newest 921868 0 209854 abrhm 2013-08-28 01:40:12 -0700 Created attachment 209854 proposed patch Fix unused variable warning on WK2 in PageOverlay.h file after r153404. 921869 1 commit-queue 2013-08-28 01:42:04 -0700 Attachment 209854 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebPage/PageOverlay.h']" exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 921872 2 209856 abrhm 2013-08-28 01:45:05 -0700 Created attachment 209856 proposed patch v2 921952 3 209856 commit-queue 2013-08-28 05:51:13 -0700 Comment on attachment 209856 proposed patch v2 Clearing flags on attachment: 209856 Committed r154737: <http://trac.webkit.org/changeset/154737> 921953 4 commit-queue 2013-08-28 05:51:14 -0700 All reviewed patches have been landed. Closing bug. 209854 2013-08-28 01:40:12 -0700 2013-08-28 01:41:29 -0700 proposed patch patch39.patch text/plain 2193 abrhm ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2ODJkMTMyLi4wNzZjZjVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkg QEAKKzIwMTMtMDgtMjggIMOBYnJhaMOhbSBHw6Fib3IgIDxhYnJobUBpbmYudS1zemVnZWQuaHU+ CisKKyAgICAgICAgRml4IHVudXNlZCB2YXJpYWJsZSB3YXJuaW5nLgorICAgICAgICBOZWVkIHRo ZSBidWcgVVJMIChPT1BTISkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRml4IHVudXNlZCB2YXJpYWJsZSBjb21waWxlciB3YXJuaW5nIGluIFBhZ2VP dmVybGF5LmgKKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9QYWdlT3ZlcmxheS5oOgor ICAgICAgICAoV2ViS2l0OjpQYWdlT3ZlcmxheTo6Q2xpZW50Ojpjb3B5QWNjZXNzaWJpbGl0eUF0 dHJpYnV0ZVZhbHVlKToKKyAgICAgICAgKFdlYktpdDo6UGFnZU92ZXJsYXk6OkNsaWVudDo6Y29w eUFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVOYW1lcyk6CisKKzIwMTMtMDgtMjggIMOBYnJhaMOhbSBH w6Fib3IgIDxhYnJobUBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgRml4IHVudXNlZCB2YXJp YWJsZSB3YXJuaW5nLgorICAgICAgICBOZWVkIHRoZSBidWcgVVJMIChPT1BTISkuCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHVudXNlZCB2YXJp YWJsZSBjb21waWxlciB3YXJuaW5nIGluIFBhZ2VPdmVybGF5LmgKKworICAgICAgICAqIFdlYlBy b2Nlc3MvV2ViUGFnZS9QYWdlT3ZlcmxheS5oOgorICAgICAgICAoV2ViS2l0OjpQYWdlT3Zlcmxh eTo6Q2xpZW50Ojpjb3B5QWNjZXNzaWJpbGl0eUF0dHJpYnV0ZVZhbHVlKToKKyAgICAgICAgKFdl YktpdDo6UGFnZU92ZXJsYXk6OkNsaWVudDo6Y29weUFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVOYW1l cyk6CisKIDIwMTMtMDgtMjggIEFsZXhhbmRyZSBBYnJldSAgPGFsZXhhbmRyZS5hYnJldUBjYW5v bmljYWwuY29tPgogCiAgICAgICAgIEFkZCBhICdpc01haW5GcmFtZScgcGFyYW1ldGVyIHRvIFFX ZWJOYXZpZ2F0aW9uUmVxdWVzdC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9QYWdlT3ZlcmxheS5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL1BhZ2VPdmVybGF5LmgKaW5kZXggNTQyNDFmZC4uODk2ZjEyNiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1BhZ2VPdmVybGF5LmgKKysrIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1BhZ2VPdmVybGF5LmgKQEAgLTU1LDggKzU1LDgg QEAgcHVibGljOgogICAgICAgICB2aXJ0dWFsIHZvaWQgZHJhd1JlY3QoUGFnZU92ZXJsYXkqLCBX ZWJDb3JlOjpHcmFwaGljc0NvbnRleHQmLCBjb25zdCBXZWJDb3JlOjpJbnRSZWN0JiBkaXJ0eVJl Y3QpID0gMDsKICAgICAgICAgdmlydHVhbCBib29sIG1vdXNlRXZlbnQoUGFnZU92ZXJsYXkqLCBj b25zdCBXZWJNb3VzZUV2ZW50JikgPSAwOwogCi0gICAgICAgIHZpcnR1YWwgV0tUeXBlUmVmIGNv cHlBY2Nlc3NpYmlsaXR5QXR0cmlidXRlVmFsdWUoUGFnZU92ZXJsYXkqLCBXS1N0cmluZ1JlZiBh dHRyaWJ1dGUsIFdLVHlwZVJlZiBwYXJhbWV0ZXIpIHsgcmV0dXJuIDA7IH0KLSAgICAgICAgdmly dHVhbCBXS0FycmF5UmVmIGNvcHlBY2Nlc3NpYmlsaXR5QXR0cmlidXRlTmFtZXMoUGFnZU92ZXJs YXkqLCBib29sIHBhcmFtZXRlcml6ZWROYW1lcykgeyByZXR1cm4gMDsgfQorICAgICAgICB2aXJ0 dWFsIFdLVHlwZVJlZiBjb3B5QWNjZXNzaWJpbGl0eUF0dHJpYnV0ZVZhbHVlKFBhZ2VPdmVybGF5 KiwgV0tTdHJpbmdSZWYgLyogYXR0cmlidXRlICovLCBXS1R5cGVSZWYgLyogcGFyYW1ldGVyICov KSB7IHJldHVybiAwOyB9CisgICAgICAgIHZpcnR1YWwgV0tBcnJheVJlZiBjb3B5QWNjZXNzaWJp bGl0eUF0dHJpYnV0ZU5hbWVzKFBhZ2VPdmVybGF5KiwgYm9vbCAvKiBwYXJhbWV0ZXJpemVkTmFt ZXMgKi8pIHsgcmV0dXJuIDA7IH0KICAgICB9OwogCiAgICAgc3RhdGljIFBhc3NSZWZQdHI8UGFn ZU92ZXJsYXk+IGNyZWF0ZShDbGllbnQqKTsK 209856 2013-08-28 01:45:05 -0700 2013-08-28 05:51:12 -0700 proposed patch v2 patch39.patch text/plain 1787 abrhm ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2ODJkMTMyLi5kNjUyOGVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDgtMjggIMOBYnJhaMOhbSBHw6Fib3IgIDxhYnJobUBpbmYudS1zemVnZWQuaHU+ CisKKyAgICAgICAgRml4IHVudXNlZCB2YXJpYWJsZSB3YXJuaW5nLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIwMzk2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHVudXNlZCB2YXJpYWJsZSBjb21w aWxlciB3YXJuaW5nIGluIFBhZ2VPdmVybGF5LmgKKworICAgICAgICAqIFdlYlByb2Nlc3MvV2Vi UGFnZS9QYWdlT3ZlcmxheS5oOgorICAgICAgICAoV2ViS2l0OjpQYWdlT3ZlcmxheTo6Q2xpZW50 Ojpjb3B5QWNjZXNzaWJpbGl0eUF0dHJpYnV0ZVZhbHVlKToKKyAgICAgICAgKFdlYktpdDo6UGFn ZU92ZXJsYXk6OkNsaWVudDo6Y29weUFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVOYW1lcyk6CisKKwog MjAxMy0wOC0yOCAgQWxleGFuZHJlIEFicmV1ICA8YWxleGFuZHJlLmFicmV1QGNhbm9uaWNhbC5j b20+CiAKICAgICAgICAgQWRkIGEgJ2lzTWFpbkZyYW1lJyBwYXJhbWV0ZXIgdG8gUVdlYk5hdmln YXRpb25SZXF1ZXN0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL1BhZ2VPdmVybGF5LmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvUGFn ZU92ZXJsYXkuaAppbmRleCA1NDI0MWZkLi44OTZmMTI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvUGFnZU92ZXJsYXkuaAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvUGFnZU92ZXJsYXkuaApAQCAtNTUsOCArNTUsOCBAQCBwdWJs aWM6CiAgICAgICAgIHZpcnR1YWwgdm9pZCBkcmF3UmVjdChQYWdlT3ZlcmxheSosIFdlYkNvcmU6 OkdyYXBoaWNzQ29udGV4dCYsIGNvbnN0IFdlYkNvcmU6OkludFJlY3QmIGRpcnR5UmVjdCkgPSAw OwogICAgICAgICB2aXJ0dWFsIGJvb2wgbW91c2VFdmVudChQYWdlT3ZlcmxheSosIGNvbnN0IFdl Yk1vdXNlRXZlbnQmKSA9IDA7CiAKLSAgICAgICAgdmlydHVhbCBXS1R5cGVSZWYgY29weUFjY2Vz c2liaWxpdHlBdHRyaWJ1dGVWYWx1ZShQYWdlT3ZlcmxheSosIFdLU3RyaW5nUmVmIGF0dHJpYnV0 ZSwgV0tUeXBlUmVmIHBhcmFtZXRlcikgeyByZXR1cm4gMDsgfQotICAgICAgICB2aXJ0dWFsIFdL QXJyYXlSZWYgY29weUFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVOYW1lcyhQYWdlT3ZlcmxheSosIGJv b2wgcGFyYW1ldGVyaXplZE5hbWVzKSB7IHJldHVybiAwOyB9CisgICAgICAgIHZpcnR1YWwgV0tU eXBlUmVmIGNvcHlBY2Nlc3NpYmlsaXR5QXR0cmlidXRlVmFsdWUoUGFnZU92ZXJsYXkqLCBXS1N0 cmluZ1JlZiAvKiBhdHRyaWJ1dGUgKi8sIFdLVHlwZVJlZiAvKiBwYXJhbWV0ZXIgKi8pIHsgcmV0 dXJuIDA7IH0KKyAgICAgICAgdmlydHVhbCBXS0FycmF5UmVmIGNvcHlBY2Nlc3NpYmlsaXR5QXR0 cmlidXRlTmFtZXMoUGFnZU92ZXJsYXkqLCBib29sIC8qIHBhcmFtZXRlcml6ZWROYW1lcyAqLykg eyByZXR1cm4gMDsgfQogICAgIH07CiAKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxQYWdlT3Zlcmxh eT4gY3JlYXRlKENsaWVudCopOwo=