120390 2013-08-27 20:01:16 -0700 Fix the indentation of SpaceSplitString 2013-08-27 20:09:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue esprehn+autocc kangil.han oldest_to_newest 921799 0 benjamin 2013-08-27 20:01:16 -0700 Fix the indentation of SpaceSplitString 921800 1 209838 benjamin 2013-08-27 20:01:47 -0700 Created attachment 209838 Patch 921803 2 209838 benjamin 2013-08-27 20:09:28 -0700 Comment on attachment 209838 Patch Clearing flags on attachment: 209838 Committed r154719: <http://trac.webkit.org/changeset/154719> 921804 3 benjamin 2013-08-27 20:09:30 -0700 All reviewed patches have been landed. Closing bug. 209838 2013-08-27 20:01:47 -0700 2013-08-27 20:09:27 -0700 Patch bug-120390-20130827200146.patch text/plain 7315 benjamin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDcxOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDEzLTA4LTI3ICBCZW5qYW1p biBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBGaXggdGhlIGluZGVu dGF0aW9uIG9mIFNwYWNlU3BsaXRTdHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyMDM5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogZG9tL1NwYWNlU3BsaXRTdHJpbmcuaDoKKyAgICAgICAgKFdl YkNvcmU6OlNwYWNlU3BsaXRTdHJpbmdEYXRhOjpjb250YWlucyk6CisgICAgICAgIChXZWJDb3Jl OjpTcGFjZVNwbGl0U3RyaW5nRGF0YTo6aXNVbmlxdWUpOgorICAgICAgICAoV2ViQ29yZTo6U3Bh Y2VTcGxpdFN0cmluZ0RhdGE6OnNpemUpOgorICAgICAgICAoV2ViQ29yZTo6U3BhY2VTcGxpdFN0 cmluZ0RhdGE6Om9wZXJhdG9yW10pOgorICAgICAgICAoV2ViQ29yZTo6U3BhY2VTcGxpdFN0cmlu Zzo6U3BhY2VTcGxpdFN0cmluZyk6CisgICAgICAgIChXZWJDb3JlOjpTcGFjZVNwbGl0U3RyaW5n OjpvcGVyYXRvciE9KToKKyAgICAgICAgKFdlYkNvcmU6OlNwYWNlU3BsaXRTdHJpbmc6OmNsZWFy KToKKyAgICAgICAgKFdlYkNvcmU6OlNwYWNlU3BsaXRTdHJpbmc6OmNvbnRhaW5zKToKKyAgICAg ICAgKFdlYkNvcmU6OlNwYWNlU3BsaXRTdHJpbmc6OmNvbnRhaW5zQWxsKToKKyAgICAgICAgKFdl YkNvcmU6OlNwYWNlU3BsaXRTdHJpbmc6OnNpemUpOgorICAgICAgICAoV2ViQ29yZTo6U3BhY2VT cGxpdFN0cmluZzo6aXNOdWxsKToKKyAgICAgICAgKFdlYkNvcmU6OlNwYWNlU3BsaXRTdHJpbmc6 Om9wZXJhdG9yW10pOgorICAgICAgICAoV2ViQ29yZTo6U3BhY2VTcGxpdFN0cmluZzo6c3BhY2VT cGxpdFN0cmluZ0NvbnRhaW5zVmFsdWUpOgorICAgICAgICAoV2ViQ29yZTo6U3BhY2VTcGxpdFN0 cmluZzo6ZW5zdXJlVW5pcXVlKToKKwogMjAxMy0wOC0yNyAgQW5kcmVhcyBLbGluZyAgPGFrbGlu Z0BhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBpdCBsZXNzIGF3a3dhcmQgdG8gY2hlY2sgaWYg YSBGcmFtZSBpcyB0aGUgbWFpbiBGcmFtZS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9TcGFj ZVNwbGl0U3RyaW5nLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL1NwYWNlU3Bs aXRTdHJpbmcuaAkocmV2aXNpb24gMTU0NzE0KQorKysgU291cmNlL1dlYkNvcmUvZG9tL1NwYWNl U3BsaXRTdHJpbmcuaAkod29ya2luZyBjb3B5KQpAQCAtMjcsNzkgKzI3LDc5IEBACiAKIG5hbWVz cGFjZSBXZWJDb3JlIHsKIAotICAgIGNsYXNzIFNwYWNlU3BsaXRTdHJpbmdEYXRhIDogcHVibGlj IFJlZkNvdW50ZWQ8U3BhY2VTcGxpdFN0cmluZ0RhdGE+IHsKLSAgICBwdWJsaWM6Ci0gICAgICAg IHN0YXRpYyBQYXNzUmVmUHRyPFNwYWNlU3BsaXRTdHJpbmdEYXRhPiBjcmVhdGUoY29uc3QgQXRv bWljU3RyaW5nJik7Ci0gICAgICAgIHN0YXRpYyBQYXNzUmVmUHRyPFNwYWNlU3BsaXRTdHJpbmdE YXRhPiBjcmVhdGVVbmlxdWUoY29uc3QgU3BhY2VTcGxpdFN0cmluZ0RhdGEmKTsKLQotICAgICAg ICB+U3BhY2VTcGxpdFN0cmluZ0RhdGEoKTsKLQotICAgICAgICBib29sIGNvbnRhaW5zKGNvbnN0 IEF0b21pY1N0cmluZyYgc3RyaW5nKQotICAgICAgICB7Ci0gICAgICAgICAgICBzaXplX3Qgc2l6 ZSA9IG1fdmVjdG9yLnNpemUoKTsKLSAgICAgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwg c2l6ZTsgKytpKSB7Ci0gICAgICAgICAgICAgICAgaWYgKG1fdmVjdG9yW2ldID09IHN0cmluZykK LSAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgICAgICAgICB9Ci0gICAgICAg ICAgICByZXR1cm4gZmFsc2U7CitjbGFzcyBTcGFjZVNwbGl0U3RyaW5nRGF0YSA6IHB1YmxpYyBS ZWZDb3VudGVkPFNwYWNlU3BsaXRTdHJpbmdEYXRhPiB7CitwdWJsaWM6CisgICAgc3RhdGljIFBh c3NSZWZQdHI8U3BhY2VTcGxpdFN0cmluZ0RhdGE+IGNyZWF0ZShjb25zdCBBdG9taWNTdHJpbmcm KTsKKyAgICBzdGF0aWMgUGFzc1JlZlB0cjxTcGFjZVNwbGl0U3RyaW5nRGF0YT4gY3JlYXRlVW5p cXVlKGNvbnN0IFNwYWNlU3BsaXRTdHJpbmdEYXRhJik7CisKKyAgICB+U3BhY2VTcGxpdFN0cmlu Z0RhdGEoKTsKKworICAgIGJvb2wgY29udGFpbnMoY29uc3QgQXRvbWljU3RyaW5nJiBzdHJpbmcp CisgICAgeworICAgICAgICBzaXplX3Qgc2l6ZSA9IG1fdmVjdG9yLnNpemUoKTsKKyAgICAgICAg Zm9yIChzaXplX3QgaSA9IDA7IGkgPCBzaXplOyArK2kpIHsKKyAgICAgICAgICAgIGlmIChtX3Zl Y3RvcltpXSA9PSBzdHJpbmcpCisgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAg IH0KKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KIAotICAgICAgICBib29sIGNvbnRhaW5z QWxsKFNwYWNlU3BsaXRTdHJpbmdEYXRhJik7CisgICAgYm9vbCBjb250YWluc0FsbChTcGFjZVNw bGl0U3RyaW5nRGF0YSYpOwogCi0gICAgICAgIHZvaWQgYWRkKGNvbnN0IEF0b21pY1N0cmluZyYp OwotICAgICAgICB2b2lkIHJlbW92ZSh1bnNpZ25lZCBpbmRleCk7CisgICAgdm9pZCBhZGQoY29u c3QgQXRvbWljU3RyaW5nJik7CisgICAgdm9pZCByZW1vdmUodW5zaWduZWQgaW5kZXgpOwogCi0g ICAgICAgIGJvb2wgaXNVbmlxdWUoKSBjb25zdCB7IHJldHVybiBtX2tleVN0cmluZy5pc051bGwo KTsgfSAKLSAgICAgICAgc2l6ZV90IHNpemUoKSBjb25zdCB7IHJldHVybiBtX3ZlY3Rvci5zaXpl KCk7IH0KLSAgICAgICAgY29uc3QgQXRvbWljU3RyaW5nJiBvcGVyYXRvcltdKHNpemVfdCBpKSB7 IEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKGkgPCBzaXplKCkpOyByZXR1cm4gbV92 ZWN0b3JbaV07IH0KLQotICAgIHByaXZhdGU6Ci0gICAgICAgIGV4cGxpY2l0IFNwYWNlU3BsaXRT dHJpbmdEYXRhKGNvbnN0IEF0b21pY1N0cmluZyYpOwotICAgICAgICBleHBsaWNpdCBTcGFjZVNw bGl0U3RyaW5nRGF0YShjb25zdCBTcGFjZVNwbGl0U3RyaW5nRGF0YSYpOwotCi0gICAgICAgIHZv aWQgY3JlYXRlVmVjdG9yKGNvbnN0IFN0cmluZyYpOwotICAgICAgICB0ZW1wbGF0ZSA8dHlwZW5h bWUgQ2hhcmFjdGVyVHlwZT4KLSAgICAgICAgaW5saW5lIHZvaWQgY3JlYXRlVmVjdG9yKGNvbnN0 IENoYXJhY3RlclR5cGUqLCB1bnNpZ25lZCk7Ci0KLSAgICAgICAgQXRvbWljU3RyaW5nIG1fa2V5 U3RyaW5nOwotICAgICAgICBWZWN0b3I8QXRvbWljU3RyaW5nLCA0PiBtX3ZlY3RvcjsKLSAgICB9 OwotCi0gICAgY2xhc3MgU3BhY2VTcGxpdFN0cmluZyB7Ci0gICAgcHVibGljOgotICAgICAgICBT cGFjZVNwbGl0U3RyaW5nKCkgeyB9Ci0gICAgICAgIFNwYWNlU3BsaXRTdHJpbmcoY29uc3QgQXRv bWljU3RyaW5nJiBzdHJpbmcsIGJvb2wgc2hvdWxkRm9sZENhc2UpIHsgc2V0KHN0cmluZywgc2hv dWxkRm9sZENhc2UpOyB9Ci0KLSAgICAgICAgYm9vbCBvcGVyYXRvciE9KGNvbnN0IFNwYWNlU3Bs aXRTdHJpbmcmIG90aGVyKSBjb25zdCB7IHJldHVybiBtX2RhdGEgIT0gb3RoZXIubV9kYXRhOyB9 Ci0KLSAgICAgICAgdm9pZCBzZXQoY29uc3QgQXRvbWljU3RyaW5nJiwgYm9vbCBzaG91bGRGb2xk Q2FzZSk7Ci0gICAgICAgIHZvaWQgY2xlYXIoKSB7IG1fZGF0YS5jbGVhcigpOyB9Ci0KLSAgICAg ICAgYm9vbCBjb250YWlucyhjb25zdCBBdG9taWNTdHJpbmcmIHN0cmluZykgY29uc3QgeyByZXR1 cm4gbV9kYXRhICYmIG1fZGF0YS0+Y29udGFpbnMoc3RyaW5nKTsgfQotICAgICAgICBib29sIGNv bnRhaW5zQWxsKGNvbnN0IFNwYWNlU3BsaXRTdHJpbmcmIG5hbWVzKSBjb25zdCB7IHJldHVybiAh bmFtZXMubV9kYXRhIHx8IChtX2RhdGEgJiYgbV9kYXRhLT5jb250YWluc0FsbCgqbmFtZXMubV9k YXRhKSk7IH0KLSAgICAgICAgdm9pZCBhZGQoY29uc3QgQXRvbWljU3RyaW5nJik7Ci0gICAgICAg IGJvb2wgcmVtb3ZlKGNvbnN0IEF0b21pY1N0cmluZyYpOwotCi0gICAgICAgIHNpemVfdCBzaXpl KCkgY29uc3QgeyByZXR1cm4gbV9kYXRhID8gbV9kYXRhLT5zaXplKCkgOiAwOyB9Ci0gICAgICAg IGJvb2wgaXNOdWxsKCkgY29uc3QgeyByZXR1cm4gIW1fZGF0YTsgfQotICAgICAgICBjb25zdCBB dG9taWNTdHJpbmcmIG9wZXJhdG9yW10oc2l6ZV90IGkpIGNvbnN0IHsgQVNTRVJUX1dJVEhfU0VD VVJJVFlfSU1QTElDQVRJT04oaSA8IHNpemUoKSk7IHJldHVybiAoKm1fZGF0YSlbaV07IH0KLQot ICAgICAgICBzdGF0aWMgYm9vbCBzcGFjZVNwbGl0U3RyaW5nQ29udGFpbnNWYWx1ZShjb25zdCBT dHJpbmcmIHNwYWNlU3BsaXRTdHJpbmcsIGNvbnN0IGNoYXIqIHZhbHVlLCB1bnNpZ25lZCBsZW5n dGgsIGJvb2wgc2hvdWxkRm9sZENhc2UpOwotICAgICAgICB0ZW1wbGF0ZTxzaXplX3QgbGVuZ3Ro PgotICAgICAgICBzdGF0aWMgYm9vbCBzcGFjZVNwbGl0U3RyaW5nQ29udGFpbnNWYWx1ZShjb25z dCBTdHJpbmcmIHNwYWNlU3BsaXRTdHJpbmcsIGNvbnN0IGNoYXIgKCZ2YWx1ZSlbbGVuZ3RoXSwg Ym9vbCBzaG91bGRGb2xkQ2FzZSkKLSAgICAgICAgewotICAgICAgICAgICAgcmV0dXJuIHNwYWNl U3BsaXRTdHJpbmdDb250YWluc1ZhbHVlKHNwYWNlU3BsaXRTdHJpbmcsIHZhbHVlLCBsZW5ndGgg LSAxLCBzaG91bGRGb2xkQ2FzZSk7Ci0gICAgICAgIH0KLQotICAgIHByaXZhdGU6Ci0gICAgICAg IHZvaWQgZW5zdXJlVW5pcXVlKCkKLSAgICAgICAgewotICAgICAgICAgICAgaWYgKG1fZGF0YSAm JiAhbV9kYXRhLT5pc1VuaXF1ZSgpKQotICAgICAgICAgICAgICAgIG1fZGF0YSA9IFNwYWNlU3Bs aXRTdHJpbmdEYXRhOjpjcmVhdGVVbmlxdWUoKm1fZGF0YSk7Ci0gICAgICAgIH0KKyAgICBib29s IGlzVW5pcXVlKCkgY29uc3QgeyByZXR1cm4gbV9rZXlTdHJpbmcuaXNOdWxsKCk7IH0gCisgICAg c2l6ZV90IHNpemUoKSBjb25zdCB7IHJldHVybiBtX3ZlY3Rvci5zaXplKCk7IH0KKyAgICBjb25z dCBBdG9taWNTdHJpbmcmIG9wZXJhdG9yW10oc2l6ZV90IGkpIHsgQVNTRVJUX1dJVEhfU0VDVVJJ VFlfSU1QTElDQVRJT04oaSA8IHNpemUoKSk7IHJldHVybiBtX3ZlY3RvcltpXTsgfQorCitwcml2 YXRlOgorICAgIGV4cGxpY2l0IFNwYWNlU3BsaXRTdHJpbmdEYXRhKGNvbnN0IEF0b21pY1N0cmlu ZyYpOworICAgIGV4cGxpY2l0IFNwYWNlU3BsaXRTdHJpbmdEYXRhKGNvbnN0IFNwYWNlU3BsaXRT dHJpbmdEYXRhJik7CisKKyAgICB2b2lkIGNyZWF0ZVZlY3Rvcihjb25zdCBTdHJpbmcmKTsKKyAg ICB0ZW1wbGF0ZSA8dHlwZW5hbWUgQ2hhcmFjdGVyVHlwZT4KKyAgICBpbmxpbmUgdm9pZCBjcmVh dGVWZWN0b3IoY29uc3QgQ2hhcmFjdGVyVHlwZSosIHVuc2lnbmVkKTsKKworICAgIEF0b21pY1N0 cmluZyBtX2tleVN0cmluZzsKKyAgICBWZWN0b3I8QXRvbWljU3RyaW5nLCA0PiBtX3ZlY3RvcjsK K307CisKK2NsYXNzIFNwYWNlU3BsaXRTdHJpbmcgeworcHVibGljOgorICAgIFNwYWNlU3BsaXRT dHJpbmcoKSB7IH0KKyAgICBTcGFjZVNwbGl0U3RyaW5nKGNvbnN0IEF0b21pY1N0cmluZyYgc3Ry aW5nLCBib29sIHNob3VsZEZvbGRDYXNlKSB7IHNldChzdHJpbmcsIHNob3VsZEZvbGRDYXNlKTsg fQorCisgICAgYm9vbCBvcGVyYXRvciE9KGNvbnN0IFNwYWNlU3BsaXRTdHJpbmcmIG90aGVyKSBj b25zdCB7IHJldHVybiBtX2RhdGEgIT0gb3RoZXIubV9kYXRhOyB9CisKKyAgICB2b2lkIHNldChj b25zdCBBdG9taWNTdHJpbmcmLCBib29sIHNob3VsZEZvbGRDYXNlKTsKKyAgICB2b2lkIGNsZWFy KCkgeyBtX2RhdGEuY2xlYXIoKTsgfQorCisgICAgYm9vbCBjb250YWlucyhjb25zdCBBdG9taWNT dHJpbmcmIHN0cmluZykgY29uc3QgeyByZXR1cm4gbV9kYXRhICYmIG1fZGF0YS0+Y29udGFpbnMo c3RyaW5nKTsgfQorICAgIGJvb2wgY29udGFpbnNBbGwoY29uc3QgU3BhY2VTcGxpdFN0cmluZyYg bmFtZXMpIGNvbnN0IHsgcmV0dXJuICFuYW1lcy5tX2RhdGEgfHwgKG1fZGF0YSAmJiBtX2RhdGEt PmNvbnRhaW5zQWxsKCpuYW1lcy5tX2RhdGEpKTsgfQorICAgIHZvaWQgYWRkKGNvbnN0IEF0b21p Y1N0cmluZyYpOworICAgIGJvb2wgcmVtb3ZlKGNvbnN0IEF0b21pY1N0cmluZyYpOworCisgICAg c2l6ZV90IHNpemUoKSBjb25zdCB7IHJldHVybiBtX2RhdGEgPyBtX2RhdGEtPnNpemUoKSA6IDA7 IH0KKyAgICBib29sIGlzTnVsbCgpIGNvbnN0IHsgcmV0dXJuICFtX2RhdGE7IH0KKyAgICBjb25z dCBBdG9taWNTdHJpbmcmIG9wZXJhdG9yW10oc2l6ZV90IGkpIGNvbnN0IHsgQVNTRVJUX1dJVEhf U0VDVVJJVFlfSU1QTElDQVRJT04oaSA8IHNpemUoKSk7IHJldHVybiAoKm1fZGF0YSlbaV07IH0K KworICAgIHN0YXRpYyBib29sIHNwYWNlU3BsaXRTdHJpbmdDb250YWluc1ZhbHVlKGNvbnN0IFN0 cmluZyYgc3BhY2VTcGxpdFN0cmluZywgY29uc3QgY2hhciogdmFsdWUsIHVuc2lnbmVkIGxlbmd0 aCwgYm9vbCBzaG91bGRGb2xkQ2FzZSk7CisgICAgdGVtcGxhdGU8c2l6ZV90IGxlbmd0aD4KKyAg ICBzdGF0aWMgYm9vbCBzcGFjZVNwbGl0U3RyaW5nQ29udGFpbnNWYWx1ZShjb25zdCBTdHJpbmcm IHNwYWNlU3BsaXRTdHJpbmcsIGNvbnN0IGNoYXIgKCZ2YWx1ZSlbbGVuZ3RoXSwgYm9vbCBzaG91 bGRGb2xkQ2FzZSkKKyAgICB7CisgICAgICAgIHJldHVybiBzcGFjZVNwbGl0U3RyaW5nQ29udGFp bnNWYWx1ZShzcGFjZVNwbGl0U3RyaW5nLCB2YWx1ZSwgbGVuZ3RoIC0gMSwgc2hvdWxkRm9sZENh c2UpOworICAgIH0KKworcHJpdmF0ZToKKyAgICB2b2lkIGVuc3VyZVVuaXF1ZSgpCisgICAgewor ICAgICAgICBpZiAobV9kYXRhICYmICFtX2RhdGEtPmlzVW5pcXVlKCkpCisgICAgICAgICAgICBt X2RhdGEgPSBTcGFjZVNwbGl0U3RyaW5nRGF0YTo6Y3JlYXRlVW5pcXVlKCptX2RhdGEpOworICAg IH0KIAotICAgICAgICBSZWZQdHI8U3BhY2VTcGxpdFN0cmluZ0RhdGE+IG1fZGF0YTsKLSAgICB9 OworICAgIFJlZlB0cjxTcGFjZVNwbGl0U3RyaW5nRGF0YT4gbV9kYXRhOworfTsKIAogfSAvLyBu YW1lc3BhY2UgV2ViQ29yZQogCg==