120376 2013-08-27 14:18:32 -0700 Stop using deleteAllValues in CClass 2013-08-28 02:59:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 120398 1 andersca andersca abrhm allan.jensen hausmann kadam ossy zarvai oldest_to_newest 921667 0 andersca 2013-08-27 14:18:32 -0700 Stop using deleteAllValues in CClass 921668 1 209801 andersca 2013-08-27 14:21:13 -0700 Created attachment 209801 Patch 921669 2 209801 kling 2013-08-27 14:22:36 -0700 Comment on attachment 209801 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209801&action=review k > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). OOPS 921670 3 andersca 2013-08-27 14:25:58 -0700 Committed r154708: <http://trac.webkit.org/changeset/154708> 921684 4 209801 darin 2013-08-27 14:59:11 -0700 Comment on attachment 209801 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209801&action=review > Source/WebCore/bridge/c/c_class.cpp:101 > + OwnPtr<Field> field = adoptPtr(new CField(ident)); > + m_fields.set(name.impl(), field.release()); This would read better without the local variable and without the release(). 921855 5 ossy 2013-08-27 23:57:47 -0700 (In reply to comment #3) > Committed r154708: <http://trac.webkit.org/changeset/154708> It broke all plugin tests on GTK and Qt WK1: - http://build.webkit.org/builders/Qt%20Linux%20Release/builds/62478 - http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20WK1/builds/3852 209801 2013-08-27 14:21:13 -0700 2013-08-27 14:59:11 -0700 Patch bug-120376-20130827142112.patch text/plain 4525 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU0NzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWM2NzNiMDZmZmYxMDE5 ZTk3MDIyZTk4NDc3ZjRlZmI3NGFiMTUwZi4uZTAwNzliZTFmMTlmZjVkZDdlMzBlMzY3NjVmMTA4 ODNjZDNmNzQ3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA4LTI3ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgU3RvcCB1c2luZyBk ZWxldGVBbGxWYWx1ZXMgaW4gQ0NsYXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjAzNzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICAqIGJyaWRn ZS9jL2NfY2xhc3MuY3BwOgorICAgICAgICAoSlNDOjpCaW5kaW5nczo6Q0NsYXNzOjpDQ2xhc3Mp OgorICAgICAgICAoSlNDOjpCaW5kaW5nczo6Q0NsYXNzOjp+Q0NsYXNzKToKKyAgICAgICAgKEpT Qzo6QmluZGluZ3M6OkNDbGFzczo6bWV0aG9kTmFtZWQpOgorICAgICAgICAoSlNDOjpCaW5kaW5n czo6Q0NsYXNzOjpmaWVsZE5hbWVkKToKKyAgICAgICAgKiBicmlkZ2UvYy9jX2NsYXNzLmg6Cisg ICAgICAgICogYnJpZGdlL2pzYy9CcmlkZ2VKU0MuaDoKKwogMjAxMy0wOC0yNyAgUm9iZXJ0IEhv Z2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgY2VsbCB3aWR0aCAvIG9mZnNldFRv cCBpbmNvcnJlY3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JyaWRnZS9jL2NfY2xhc3Mu Y3BwIGIvU291cmNlL1dlYkNvcmUvYnJpZGdlL2MvY19jbGFzcy5jcHAKaW5kZXggNDY0ZDg4MmUx NTZjZTFjNTIxOWIxMmUyMDUxMjI2MDYxNjFhNmVlYS4uNzJiZjJjZDkxMTc5MWY4OGU1ODAwODk3 OGEwZDY3ZTBiNjE0Mjc2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYnJpZGdlL2MvY19j bGFzcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYnJpZGdlL2MvY19jbGFzcy5jcHAKQEAgLTQx LDE2ICs0MSwxMyBAQCBuYW1lc3BhY2UgSlNDIHsgbmFtZXNwYWNlIEJpbmRpbmdzIHsKIAogQ0Ns YXNzOjpDQ2xhc3MoTlBDbGFzcyogYUNsYXNzKQogewotICAgIF9pc2EgPSBhQ2xhc3M7CisgICAg bV9pc2EgPSBhQ2xhc3M7CiB9CiAKIENDbGFzczo6fkNDbGFzcygpCiB7Ci0gICAgZGVsZXRlQWxs VmFsdWVzKF9tZXRob2RzKTsKLSAgICBfbWV0aG9kcy5jbGVhcigpOwotCi0gICAgZGVsZXRlQWxs VmFsdWVzKF9maWVsZHMpOwotICAgIF9maWVsZHMuY2xlYXIoKTsKKyAgICBtX21ldGhvZHMuY2xl YXIoKTsKKyAgICBtX2ZpZWxkcy5jbGVhcigpOwogfQogCiB0eXBlZGVmIEhhc2hNYXA8TlBDbGFz cyosIENDbGFzcyo+IENsYXNzZXNCeUlzQU1hcDsKQEAgLTc0LDE2ICs3MSwxNiBAQCBNZXRob2Qq IENDbGFzczo6bWV0aG9kTmFtZWQoUHJvcGVydHlOYW1lIHByb3BlcnR5TmFtZSwgSW5zdGFuY2Uq IGluc3RhbmNlKSBjb25zdAogewogICAgIFN0cmluZyBuYW1lKHByb3BlcnR5TmFtZS5wdWJsaWNO YW1lKCkpOwogICAgIAotICAgIGlmIChNZXRob2QqIG1ldGhvZCA9IF9tZXRob2RzLmdldChuYW1l LmltcGwoKSkpCisgICAgaWYgKE1ldGhvZCogbWV0aG9kID0gbV9tZXRob2RzLmdldChuYW1lLmlt cGwoKSkpCiAgICAgICAgIHJldHVybiBtZXRob2Q7CiAKICAgICBOUElkZW50aWZpZXIgaWRlbnQg PSBfTlBOX0dldFN0cmluZ0lkZW50aWZpZXIobmFtZS5hc2NpaSgpLmRhdGEoKSk7CiAgICAgY29u c3QgQ0luc3RhbmNlKiBpbnN0ID0gc3RhdGljX2Nhc3Q8Y29uc3QgQ0luc3RhbmNlKj4oaW5zdGFu Y2UpOwogICAgIE5QT2JqZWN0KiBvYmogPSBpbnN0LT5nZXRPYmplY3QoKTsKLSAgICBpZiAoX2lz YS0+aGFzTWV0aG9kICYmIF9pc2EtPmhhc01ldGhvZChvYmosIGlkZW50KSl7Ci0gICAgICAgIE1l dGhvZCogbWV0aG9kID0gbmV3IENNZXRob2QoaWRlbnQpOyAvLyBkZWxldGVkIGluIHRoZSBDQ2xh c3MgZGVzdHJ1Y3RvcgotICAgICAgICBfbWV0aG9kcy5zZXQobmFtZS5pbXBsKCksIG1ldGhvZCk7 Ci0gICAgICAgIHJldHVybiBtZXRob2Q7CisgICAgaWYgKG1faXNhLT5oYXNNZXRob2QgJiYgbV9p c2EtPmhhc01ldGhvZChvYmosIGlkZW50KSkgeworICAgICAgICBPd25QdHI8TWV0aG9kPiBtZXRo b2QgPSBhZG9wdFB0cihuZXcgQ01ldGhvZChpZGVudCkpOworICAgICAgICBtX21ldGhvZHMuc2V0 KG5hbWUuaW1wbCgpLCBtZXRob2QucmVsZWFzZSgpKTsKKyAgICAgICAgcmV0dXJuIG1ldGhvZC5n ZXQoKTsKICAgICB9CiAgICAgCiAgICAgcmV0dXJuIDA7CkBAIC05MywxOCArOTAsMTggQEAgRmll bGQqIENDbGFzczo6ZmllbGROYW1lZChQcm9wZXJ0eU5hbWUgcHJvcGVydHlOYW1lLCBJbnN0YW5j ZSogaW5zdGFuY2UpIGNvbnN0CiB7CiAgICAgU3RyaW5nIG5hbWUocHJvcGVydHlOYW1lLnB1Ymxp Y05hbWUoKSk7CiAgICAgCi0gICAgRmllbGQqIGFGaWVsZCA9IF9maWVsZHMuZ2V0KG5hbWUuaW1w bCgpKTsKLSAgICBpZiAoYUZpZWxkKQotICAgICAgICByZXR1cm4gYUZpZWxkOwotICAgIAorICAg IGlmIChGaWVsZCogZmllbGQgPSBtX2ZpZWxkcy5nZXQobmFtZS5pbXBsKCkpKQorICAgICAgICBy ZXR1cm4gZmllbGQ7CisKICAgICBOUElkZW50aWZpZXIgaWRlbnQgPSBfTlBOX0dldFN0cmluZ0lk ZW50aWZpZXIobmFtZS5hc2NpaSgpLmRhdGEoKSk7CiAgICAgY29uc3QgQ0luc3RhbmNlKiBpbnN0 ID0gc3RhdGljX2Nhc3Q8Y29uc3QgQ0luc3RhbmNlKj4oaW5zdGFuY2UpOwogICAgIE5QT2JqZWN0 KiBvYmogPSBpbnN0LT5nZXRPYmplY3QoKTsKLSAgICBpZiAoX2lzYS0+aGFzUHJvcGVydHkgJiYg X2lzYS0+aGFzUHJvcGVydHkob2JqLCBpZGVudCkpewotICAgICAgICBhRmllbGQgPSBuZXcgQ0Zp ZWxkKGlkZW50KTsgLy8gZGVsZXRlZCBpbiB0aGUgQ0NsYXNzIGRlc3RydWN0b3IKLSAgICAgICAg X2ZpZWxkcy5zZXQobmFtZS5pbXBsKCksIGFGaWVsZCk7CisgICAgaWYgKG1faXNhLT5oYXNQcm9w ZXJ0eSAmJiBtX2lzYS0+aGFzUHJvcGVydHkob2JqLCBpZGVudCkpIHsKKyAgICAgICAgT3duUHRy PEZpZWxkPiBmaWVsZCA9IGFkb3B0UHRyKG5ldyBDRmllbGQoaWRlbnQpKTsKKyAgICAgICAgbV9m aWVsZHMuc2V0KG5hbWUuaW1wbCgpLCBmaWVsZC5yZWxlYXNlKCkpOwogICAgIH0KLSAgICByZXR1 cm4gYUZpZWxkOworCisgICAgcmV0dXJuIDA7CiB9CiAKIH0gfSAvLyBuYW1lc3BhY2UgSlNDOjpC aW5kaW5ncwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYnJpZGdlL2MvY19jbGFzcy5oIGIv U291cmNlL1dlYkNvcmUvYnJpZGdlL2MvY19jbGFzcy5oCmluZGV4IGY2NzM5OWZlNTk3NzZlNjNj Y2IxODZhYzkyY2JiNjcyZjFkY2YwYWMuLjM0Y2FkNWZiMjRiY2U4MzEzOTk1ZWUyYjNjNDAyZGUw MzQ3NzdmN2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JyaWRnZS9jL2NfY2xhc3MuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9icmlkZ2UvYy9jX2NsYXNzLmgKQEAgLTQ3LDkgKzQ3LDkgQEAg cHVibGljOgogICAgIHZpcnR1YWwgRmllbGQqIGZpZWxkTmFtZWQoUHJvcGVydHlOYW1lLCBJbnN0 YW5jZSopIGNvbnN0OwogCiBwcml2YXRlOgotICAgIE5QQ2xhc3MqIF9pc2E7Ci0gICAgbXV0YWJs ZSBNZXRob2RNYXAgX21ldGhvZHM7Ci0gICAgbXV0YWJsZSBGaWVsZE1hcCBfZmllbGRzOworICAg IE5QQ2xhc3MqIG1faXNhOworICAgIG11dGFibGUgSGFzaE1hcDxSZWZQdHI8U3RyaW5nSW1wbD4s IE93blB0cjxNZXRob2Q+PiBtX21ldGhvZHM7CisgICAgbXV0YWJsZSBIYXNoTWFwPFJlZlB0cjxT dHJpbmdJbXBsPiwgT3duUHRyPEZpZWxkPj4gbV9maWVsZHM7CiB9OwogCiB9IC8vIG5hbWVzcGFj ZSBCaW5kaW5ncwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYnJpZGdlL2pzYy9CcmlkZ2VK U0MuaCBiL1NvdXJjZS9XZWJDb3JlL2JyaWRnZS9qc2MvQnJpZGdlSlNDLmgKaW5kZXggNDc1NTM5 YzdmMzYzZmNmYTFmZTVhNGQyYWQ0MjAzMTU1YzM0ZjY5YS4uYTJlZjg3ODk2ZjhlYWUzOTZlOGE5 M2I3MGUwMTRmMjIyYzA2YjU5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYnJpZGdlL2pz Yy9CcmlkZ2VKU0MuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9icmlkZ2UvanNjL0JyaWRnZUpTQy5o CkBAIC0xMzQsOSArMTM0LDYgQEAgcHJvdGVjdGVkOgogCiBjb25zdCBjaGFyKiBzaWduYXR1cmVG b3JQYXJhbWV0ZXJzKGNvbnN0IEFyZ0xpc3QmKTsKIAotdHlwZWRlZiBIYXNoTWFwPFJlZlB0cjxT dHJpbmdJbXBsPiwgTWV0aG9kKj4gTWV0aG9kTWFwOwotdHlwZWRlZiBIYXNoTWFwPFJlZlB0cjxT dHJpbmdJbXBsPiwgRmllbGQqPiBGaWVsZE1hcDsKLQogfSAvLyBuYW1lc3BhY2UgQmluZGluZ3MK IAogfSAvLyBuYW1lc3BhY2UgSlNDCg==