120370 2013-08-27 11:45:39 -0700 AppleWin port should delete sem lock files in /dev/shm during cleanup tasks for NRWT 2013-08-27 12:41:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned bfulgham commit-queue dpranke glenn lforschler roger_fong oldest_to_newest 921606 0 roger_fong 2013-08-27 11:45:39 -0700 With our current version of cygwin and python there is a bug where the sem lock files do not get removed from /dev/shm. /dev/shm eventually fills up with tons of sem lock files and we issues where we get "OSError raised: [Errno 17] File exists" due to file collisions. However, installing other versions of cygwin/python would lead to tons of other issues which we've previously discovered so we just need to work around this issue here. 921610 1 209789 roger_fong 2013-08-27 11:55:19 -0700 Created attachment 209789 patch 921611 2 roger_fong 2013-08-27 11:55:39 -0700 tested this fix locally on a bot that had this issue, and it did the trick 921612 3 209789 bfulgham 2013-08-27 11:58:11 -0700 Comment on attachment 209789 patch This looks great! Does this cleanup code get called at startup of the test harness, or only when ending tests? If it doesn't, maybe we could add a belt-and-suspenders step to kill any locks when the test rig is first started? 921618 4 dpranke 2013-08-27 12:14:58 -0700 cleanup_test_run() does not get called at startup. setup_test_run() (right above in the code) does :). 921626 5 roger_fong 2013-08-27 12:36:08 -0700 (In reply to comment #4) > cleanup_test_run() does not get called at startup. setup_test_run() (right above in the code) does :). O cool, I'll move it there. Thanks! 921627 6 roger_fong 2013-08-27 12:41:39 -0700 <rdar://problem/14621844> Committed: http://trac.webkit.org/changeset/154704 209789 2013-08-27 11:55:19 -0700 2013-08-27 11:58:10 -0700 patch patch.patch text/plain 1516 roger_fong SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1NDY1MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEzLTA4LTI2ICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+ CisKKyAgICAgICAgTlJXVCBvbiBBcHBsZVdpbiBwb3J0IHNob3VsZCBkZWxldGUgc2VtYXBob3Jl IGxvY2sgZmlsZXMgZHVyaW5nIGNsZWFudXAgdGFza3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjAzNzAuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5 OgorICAgICAgICAoV2luUG9ydC5kZWxldGVfc2VtX2xvY2tzKToKKwogMjAxMy0wOC0yNiAgQWxl eGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJLaXRUZXN0UnVu bmVyIG5lZWRzIHRvIHByb3RlY3QgdGhlIHVzZXIncyBwYXN0ZWJvYXJkIGNvbnRlbnRzIHdoaWxl IHJ1bm5pbmcKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93aW4ucHkKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3dpbi5weQkocmV2aXNpb24gMTU0 NjUzKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3dpbi5weQkod29ya2luZyBjb3B5 KQpAQCAtMjA4LDYgKzIwOCw5IEBACiAgICAgICAgIGZvciBrZXkgaW4gc2VsZi5wcmV2aW91c19k ZWJ1Z2dlcl92YWx1ZXM6CiAgICAgICAgICAgICBzZWxmLndyaXRlX3JlZ2lzdHJ5X3N0cmluZyhr ZXksIHNlbGYucHJldmlvdXNfZGVidWdnZXJfdmFsdWVzW2tleV0pCiAKKyAgICBkZWYgZGVsZXRl X3NlbV9sb2NrcyhzZWxmKToKKyAgICAgICAgb3Muc3lzdGVtKCJybSAtcmYgL2Rldi9zaG0vc2Vt LioiKQorCiAgICAgZGVmIHNldHVwX3Rlc3RfcnVuKHNlbGYpOgogICAgICAgICBhdGV4aXQucmVn aXN0ZXIoc2VsZi5yZXN0b3JlX2NyYXNoX2xvZ19zYXZpbmcpCiAgICAgICAgIHNlbGYuc2V0dXBf Y3Jhc2hfbG9nX3NhdmluZygpCkBAIC0yMTUsNiArMjE4LDcgQEAKIAogICAgIGRlZiBjbGVhbl91 cF90ZXN0X3J1bihzZWxmKToKICAgICAgICAgc2VsZi5yZXN0b3JlX2NyYXNoX2xvZ19zYXZpbmco KQorICAgICAgICBzZWxmLmRlbGV0ZV9zZW1fbG9ja3MoKQogICAgICAgICBzdXBlcihXaW5Qb3J0 LCBzZWxmKS5jbGVhbl91cF90ZXN0X3J1bigpCiAKICAgICBkZWYgX2dldF9jcmFzaF9sb2coc2Vs ZiwgbmFtZSwgcGlkLCBzdGRvdXQsIHN0ZGVyciwgbmV3ZXJfdGhhbiwgdGltZV9mbj1Ob25lLCBz bGVlcF9mbj1Ob25lLCB3YWl0X2Zvcl9sb2c9VHJ1ZSk6Cg==