120368 2013-08-27 10:04:41 -0700 Better mutation and event assertions for descendant iterators 2013-09-05 16:25:52 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned commit-queue darin esprehn+autocc kangil.han kling oldest_to_newest 921575 0 koivisto 2013-08-27 10:04:41 -0700 Safer, more convenient. 921580 1 209784 koivisto 2013-08-27 10:15:28 -0700 Created attachment 209784 patch 925273 2 koivisto 2013-09-05 16:25:52 -0700 This was http://trac.webkit.org/changeset/154700 209784 2013-08-27 10:15:28 -0700 2013-08-27 11:11:05 -0700 patch iterator-assertions.patch text/plain 6757 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDY5NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDEzLTA4LTI3ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBCZXR0ZXIgbXV0YXRpb24gYW5k IGV2ZW50IGFzc2VydGlvbnMgZm9yIGRlc2NlbmRhbnQgaXRlcmF0b3JzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjAzNjgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbXV0YXRpb24gYXNzZXJ0aW9u cyB0byBhbGwgZnVuY3Rpb25zLgorICAgICAgICBEcm9wIHRoZSBuby1ldmVudC1kaXNwYXRjaCBh c3NlcnRpb24gd2hlbiB0aGUgaXRlcmF0b3IgcmVhY2hlcyB0aGUgZW5kLiBUaGlzIHJlZHVjZXMg bmVlZCBmb3IgaXRlcmF0b3Igc2NvcGluZworICAgICAgICBqdXN0IHRvIGF2b2lkIGFzc2VydGlv bnMuCisKKyAgICAgICAgKiBkb20vQ2hpbGRJdGVyYXRvci5oOgorICAgICAgICAoV2ViQ29yZTo6 Ojpkb21UcmVlSGFzTXV0YXRlZCk6CisgICAgICAgIChXZWJDb3JlOjo6Om9wZXJhdG9yKToKKyAg ICAgICAgKFdlYkNvcmU6Oj0pOgorICAgICAgICAqIGRvbS9EZXNjZW5kYW50SXRlcmF0b3IuaDoK KyAgICAgICAgKFdlYkNvcmU6Ojo6ZG9tVHJlZUhhc011dGF0ZWQpOgorICAgICAgICAoV2ViQ29y ZTo6OjpvcGVyYXRvcik6CisgICAgICAgIChXZWJDb3JlOjo9KToKKyAgICAgICAgKiBkb20vRG9j dW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmNoaWxkcmVuQ2hhbmdlZCk6 CisgICAgICAgIAorICAgICAgICAgICAgTWFrZSBpZGlvbWF0aWMuCisKIDIwMTMtMDgtMjcgIEJy ZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbmRvd3NdIENv cnJlY3QgbWV0aG9kIGNhbGwgZm9yIGNoYXJhY3RlcmlzdGljIHVwZGF0ZS4KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2RvbS9DaGlsZEl0ZXJhdG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvZG9tL0NoaWxkSXRlcmF0b3IuaAkocmV2aXNpb24gMTU0Njc4KQorKysgU291cmNlL1dlYkNv cmUvZG9tL0NoaWxkSXRlcmF0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtNDAsMTMgKzQwLDE1IEBA IHB1YmxpYzoKICAgICBDaGlsZEl0ZXJhdG9yKCk7CiAgICAgQ2hpbGRJdGVyYXRvcihFbGVtZW50 VHlwZSogY3VycmVudCk7CiAgICAgQ2hpbGRJdGVyYXRvciYgb3BlcmF0b3IrKygpOwotICAgIEVs ZW1lbnRUeXBlJiBvcGVyYXRvciooKSB7IHJldHVybiAqbV9jdXJyZW50OyB9Ci0gICAgRWxlbWVu dFR5cGUqIG9wZXJhdG9yLT4oKSB7IHJldHVybiBtX2N1cnJlbnQ7IH0KKyAgICBFbGVtZW50VHlw ZSYgb3BlcmF0b3IqKCk7CisgICAgRWxlbWVudFR5cGUqIG9wZXJhdG9yLT4oKTsKICAgICBib29s IG9wZXJhdG9yIT0oY29uc3QgQ2hpbGRJdGVyYXRvciYgb3RoZXIpIGNvbnN0OwogCiBwcml2YXRl OgogICAgIEVsZW1lbnRUeXBlKiBtX2N1cnJlbnQ7CisKICNpZm5kZWYgTkRFQlVHCisgICAgYm9v bCBkb21UcmVlSGFzTXV0YXRlZCgpIGNvbnN0OwogICAgIE93blB0cjxOb0V2ZW50RGlzcGF0Y2hB c3NlcnRpb24+IG1fbm9FdmVudERpc3BhdGNoQXNzZXJ0aW9uOwogICAgIHVpbnQ2NF90IG1faW5p dGlhbERPTVRyZWVWZXJzaW9uOwogI2VuZGlmCkBAIC04NywxOCArODksNDggQEAgaW5saW5lIENo aWxkSXRlcmF0b3I8RWxlbWVudFR5cGU+OjpDaGlsZAogewogfQogCisjaWZuZGVmIE5ERUJVRwor dGVtcGxhdGUgPHR5cGVuYW1lIEVsZW1lbnRUeXBlPgoraW5saW5lIGJvb2wgQ2hpbGRJdGVyYXRv cjxFbGVtZW50VHlwZT46OmRvbVRyZWVIYXNNdXRhdGVkKCkgY29uc3QKK3sKKyAgICByZXR1cm4g bV9pbml0aWFsRE9NVHJlZVZlcnNpb24gJiYgbV9jdXJyZW50ICYmIG1fY3VycmVudC0+ZG9jdW1l bnQoKS0+ZG9tVHJlZVZlcnNpb24oKSAhPSBtX2luaXRpYWxET01UcmVlVmVyc2lvbjsKK30KKyNl bmRpZgorCiB0ZW1wbGF0ZSA8dHlwZW5hbWUgRWxlbWVudFR5cGU+CiBpbmxpbmUgQ2hpbGRJdGVy YXRvcjxFbGVtZW50VHlwZT4mIENoaWxkSXRlcmF0b3I8RWxlbWVudFR5cGU+OjpvcGVyYXRvcisr KCkKIHsKICAgICBBU1NFUlQobV9jdXJyZW50KTsKLSAgICBBU1NFUlQobV9jdXJyZW50LT5kb2N1 bWVudCgpLT5kb21UcmVlVmVyc2lvbigpID09IG1faW5pdGlhbERPTVRyZWVWZXJzaW9uKTsKKyAg ICBBU1NFUlQoIWRvbVRyZWVIYXNNdXRhdGVkKCkpOwogICAgIG1fY3VycmVudCA9IFRyYXZlcnNh bDxFbGVtZW50VHlwZT46Om5leHRTaWJsaW5nKG1fY3VycmVudCk7CisjaWZuZGVmIE5ERUJVRwor ICAgIC8vIERyb3AgdGhlIGFzc2VydGlvbiB3aGVuIHRoZSBpdGVyYXRvciByZWFjaGVzIHRoZSBl bmQuCisgICAgaWYgKCFtX2N1cnJlbnQpCisgICAgICAgIG1fbm9FdmVudERpc3BhdGNoQXNzZXJ0 aW9uID0gbnVsbHB0cjsKKyNlbmRpZgogICAgIHJldHVybiAqdGhpczsKIH0KIAogdGVtcGxhdGUg PHR5cGVuYW1lIEVsZW1lbnRUeXBlPgoraW5saW5lIEVsZW1lbnRUeXBlJiBDaGlsZEl0ZXJhdG9y PEVsZW1lbnRUeXBlPjo6b3BlcmF0b3IqKCkKK3sKKyAgICBBU1NFUlQobV9jdXJyZW50KTsKKyAg ICBBU1NFUlQoIWRvbVRyZWVIYXNNdXRhdGVkKCkpOworICAgIHJldHVybiAqbV9jdXJyZW50Owor fQorCit0ZW1wbGF0ZSA8dHlwZW5hbWUgRWxlbWVudFR5cGU+CitpbmxpbmUgRWxlbWVudFR5cGUq IENoaWxkSXRlcmF0b3I8RWxlbWVudFR5cGU+OjpvcGVyYXRvci0+KCkKK3sKKyAgICBBU1NFUlQo bV9jdXJyZW50KTsKKyAgICBBU1NFUlQoIWRvbVRyZWVIYXNNdXRhdGVkKCkpOworICAgIHJldHVy biBtX2N1cnJlbnQ7Cit9CisKK3RlbXBsYXRlIDx0eXBlbmFtZSBFbGVtZW50VHlwZT4KIGlubGlu ZSBib29sIENoaWxkSXRlcmF0b3I8RWxlbWVudFR5cGU+OjpvcGVyYXRvciE9KGNvbnN0IENoaWxk SXRlcmF0b3ImIG90aGVyKSBjb25zdAogeworICAgIEFTU0VSVCghZG9tVHJlZUhhc011dGF0ZWQo KSk7CiAgICAgcmV0dXJuIG1fY3VycmVudCAhPSBvdGhlci5tX2N1cnJlbnQ7CiB9CiAKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2RvbS9EZXNjZW5kYW50SXRlcmF0b3IuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9kb20vRGVzY2VuZGFudEl0ZXJhdG9yLmgJKHJldmlzaW9uIDE1NDY4MikK KysrIFNvdXJjZS9XZWJDb3JlL2RvbS9EZXNjZW5kYW50SXRlcmF0b3IuaAkod29ya2luZyBjb3B5 KQpAQCAtNDAsMTQgKzQwLDE2IEBAIHB1YmxpYzoKICAgICBEZXNjZW5kYW50SXRlcmF0b3IoY29u c3QgTm9kZSogcm9vdCk7CiAgICAgRGVzY2VuZGFudEl0ZXJhdG9yKGNvbnN0IE5vZGUqIHJvb3Qs IEVsZW1lbnRUeXBlKiBjdXJyZW50KTsKICAgICBEZXNjZW5kYW50SXRlcmF0b3ImIG9wZXJhdG9y KysoKTsKLSAgICBFbGVtZW50VHlwZSYgb3BlcmF0b3IqKCkgeyByZXR1cm4gKm1fY3VycmVudDsg fQotICAgIEVsZW1lbnRUeXBlKiBvcGVyYXRvci0+KCkgeyByZXR1cm4gbV9jdXJyZW50OyB9Cisg ICAgRWxlbWVudFR5cGUmIG9wZXJhdG9yKigpOworICAgIEVsZW1lbnRUeXBlKiBvcGVyYXRvci0+ KCk7CiAgICAgYm9vbCBvcGVyYXRvciE9KGNvbnN0IERlc2NlbmRhbnRJdGVyYXRvciYgb3RoZXIp IGNvbnN0OwogCiBwcml2YXRlOgogICAgIGNvbnN0IE5vZGUqIG1fcm9vdDsKICAgICBFbGVtZW50 VHlwZSogbV9jdXJyZW50OworCiAjaWZuZGVmIE5ERUJVRworICAgIGJvb2wgZG9tVHJlZUhhc011 dGF0ZWQoKSBjb25zdDsKICAgICBPd25QdHI8Tm9FdmVudERpc3BhdGNoQXNzZXJ0aW9uPiBtX25v RXZlbnREaXNwYXRjaEFzc2VydGlvbjsKICAgICB1aW50NjRfdCBtX2luaXRpYWxET01UcmVlVmVy c2lvbjsKICNlbmRpZgpAQCAtODUsMjQgKzg3LDU0IEBAIGlubGluZSBEZXNjZW5kYW50SXRlcmF0 b3I8RWxlbWVudFR5cGU+OjoKICAgICAsIG1fY3VycmVudChjdXJyZW50KQogI2lmbmRlZiBOREVC VUcKICAgICAsIG1fbm9FdmVudERpc3BhdGNoQXNzZXJ0aW9uKGFkb3B0UHRyKG5ldyBOb0V2ZW50 RGlzcGF0Y2hBc3NlcnRpb24pKQotICAgICwgbV9pbml0aWFsRE9NVHJlZVZlcnNpb24obV9jdXJy ZW50ID8gbV9jdXJyZW50LT5kb2N1bWVudCgpLT5kb21UcmVlVmVyc2lvbigpIDogMCkKKyAgICAs IG1faW5pdGlhbERPTVRyZWVWZXJzaW9uKHJvb3QtPmRvY3VtZW50KCktPmRvbVRyZWVWZXJzaW9u KCkpCiAjZW5kaWYKIHsKIH0KIAorI2lmbmRlZiBOREVCVUcKK3RlbXBsYXRlIDx0eXBlbmFtZSBF bGVtZW50VHlwZT4KK2lubGluZSBib29sIERlc2NlbmRhbnRJdGVyYXRvcjxFbGVtZW50VHlwZT46 OmRvbVRyZWVIYXNNdXRhdGVkKCkgY29uc3QKK3sKKyAgICByZXR1cm4gbV9yb290LT5kb2N1bWVu dCgpLT5kb21UcmVlVmVyc2lvbigpICE9IG1faW5pdGlhbERPTVRyZWVWZXJzaW9uOworfQorI2Vu ZGlmCisKIHRlbXBsYXRlIDx0eXBlbmFtZSBFbGVtZW50VHlwZT4KIGlubGluZSBEZXNjZW5kYW50 SXRlcmF0b3I8RWxlbWVudFR5cGU+JiBEZXNjZW5kYW50SXRlcmF0b3I8RWxlbWVudFR5cGU+Ojpv cGVyYXRvcisrKCkKIHsKICAgICBBU1NFUlQobV9jdXJyZW50KTsKLSAgICBBU1NFUlQobV9jdXJy ZW50LT5kb2N1bWVudCgpLT5kb21UcmVlVmVyc2lvbigpID09IG1faW5pdGlhbERPTVRyZWVWZXJz aW9uKTsKKyAgICBBU1NFUlQoIWRvbVRyZWVIYXNNdXRhdGVkKCkpOwogICAgIG1fY3VycmVudCA9 IFRyYXZlcnNhbDxFbGVtZW50VHlwZT46Om5leHQobV9jdXJyZW50LCBtX3Jvb3QpOworI2lmbmRl ZiBOREVCVUcKKyAgICAvLyBEcm9wIHRoZSBhc3NlcnRpb24gd2hlbiB0aGUgaXRlcmF0b3IgcmVh Y2hlcyB0aGUgZW5kLgorICAgIGlmICghbV9jdXJyZW50KQorICAgICAgICBtX25vRXZlbnREaXNw YXRjaEFzc2VydGlvbiA9IG51bGxwdHI7CisjZW5kaWYKICAgICByZXR1cm4gKnRoaXM7CiB9CiAK IHRlbXBsYXRlIDx0eXBlbmFtZSBFbGVtZW50VHlwZT4KK2lubGluZSBFbGVtZW50VHlwZSYgRGVz Y2VuZGFudEl0ZXJhdG9yPEVsZW1lbnRUeXBlPjo6b3BlcmF0b3IqKCkKK3sKKyAgICBBU1NFUlQo bV9jdXJyZW50KTsKKyAgICBBU1NFUlQoIWRvbVRyZWVIYXNNdXRhdGVkKCkpOworICAgIHJldHVy biAqbV9jdXJyZW50OworfQorCit0ZW1wbGF0ZSA8dHlwZW5hbWUgRWxlbWVudFR5cGU+Citpbmxp bmUgRWxlbWVudFR5cGUqIERlc2NlbmRhbnRJdGVyYXRvcjxFbGVtZW50VHlwZT46Om9wZXJhdG9y LT4oKQoreworICAgIEFTU0VSVChtX2N1cnJlbnQpOworICAgIEFTU0VSVCghZG9tVHJlZUhhc011 dGF0ZWQoKSk7CisgICAgcmV0dXJuIG1fY3VycmVudDsKK30KKwordGVtcGxhdGUgPHR5cGVuYW1l IEVsZW1lbnRUeXBlPgogaW5saW5lIGJvb2wgRGVzY2VuZGFudEl0ZXJhdG9yPEVsZW1lbnRUeXBl Pjo6b3BlcmF0b3IhPShjb25zdCBEZXNjZW5kYW50SXRlcmF0b3ImIG90aGVyKSBjb25zdAogewog ICAgIEFTU0VSVChtX3Jvb3QgPT0gb3RoZXIubV9yb290KTsKKyAgICBBU1NFUlQoIWRvbVRyZWVI YXNNdXRhdGVkKCkpOwogICAgIHJldHVybiBtX2N1cnJlbnQgIT0gb3RoZXIubV9jdXJyZW50Owog fQogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDE1NDY3OSkKKysrIFNv dXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc3Niw4ICs3 NzYsMTIgQEAgYm9vbCBEb2N1bWVudDo6aGFzTWFuaWZlc3QoKSBjb25zdAogdm9pZCBEb2N1bWVu dDo6Y2hpbGRyZW5DaGFuZ2VkKGJvb2wgY2hhbmdlZEJ5UGFyc2VyLCBOb2RlKiBiZWZvcmVDaGFu Z2UsIE5vZGUqIGFmdGVyQ2hhbmdlLCBpbnQgY2hpbGRDb3VudERlbHRhKQogewogICAgIENvbnRh aW5lck5vZGU6OmNoaWxkcmVuQ2hhbmdlZChjaGFuZ2VkQnlQYXJzZXIsIGJlZm9yZUNoYW5nZSwg YWZ0ZXJDaGFuZ2UsIGNoaWxkQ291bnREZWx0YSk7Ci0gICAgCi0gICAgRWxlbWVudCogbmV3RG9j dW1lbnRFbGVtZW50ID0gJiplbGVtZW50Q2hpbGRyZW4odGhpcykuYmVnaW4oKTsKKworICAgIEVs ZW1lbnQqIG5ld0RvY3VtZW50RWxlbWVudCA9IDA7CisgICAgYXV0byBmaXJzdEVsZW1lbnRDaGls ZCA9IGVsZW1lbnRDaGlsZHJlbih0aGlzKS5iZWdpbigpOworICAgIGlmIChmaXJzdEVsZW1lbnRD aGlsZCAhPSBlbGVtZW50Q2hpbGRyZW4odGhpcykuZW5kKCkpCisgICAgICAgIG5ld0RvY3VtZW50 RWxlbWVudCA9ICYqZmlyc3RFbGVtZW50Q2hpbGQ7CisKICAgICBpZiAobmV3RG9jdW1lbnRFbGVt ZW50ID09IG1fZG9jdW1lbnRFbGVtZW50KQogICAgICAgICByZXR1cm47CiAgICAgbV9kb2N1bWVu dEVsZW1lbnQgPSBuZXdEb2N1bWVudEVsZW1lbnQ7Cg==